From e3a320eec0becc3fc1373c819cbb98447a853843 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Magnus=20Gro=C3=9F?= Date: Wed, 26 Oct 2022 23:27:46 +0200 Subject: [PATCH] Continue parsing cmdline arguments in the desktop file In a56904e40d24412b23e5b4748b5cfe9c1deb5933 the desktop file was patched to use "wezterm start" instead of "wezterm". As an unneeded addendum that patch also included the unnecessary addition of ending command-line parsing by passing the "--" option at the end. As it turns out, some consumers of wezterm's desktop file want wezterm to parse command line flags. For example KDE's kio passes the whole cmdline via the "-e" flag, because it is widely used for most terminal emulators as the primary mean of passing the cmdline. To solve this we remove the unneeded "--" again, because we now also support the "-e" option. After all, all trailing arguments will automatically be parsed by wezterm as the cmdline of the program to run. The only sideeffect of this change is that we now cannot longer start programs that share a name with a "wezterm start" option, for example if the user has installed an executable at /usr/bin/--always-new-process then this edge case will not work anymore. Given that this would be an extremely unlikely scenario, it makes more sense to improve compatibility by supporting the usecase of passing the cmdline with the "-e" flag. refs: #2622 refs: #2271 refs: https://bugs.kde.org/show_bug.cgi?id=459616 --- assets/wezterm.desktop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/wezterm.desktop b/assets/wezterm.desktop index 751588740..6ad25398d 100644 --- a/assets/wezterm.desktop +++ b/assets/wezterm.desktop @@ -5,7 +5,7 @@ Keywords=shell;prompt;command;commandline;cmd; Icon=org.wezfurlong.wezterm StartupWMClass=org.wezfurlong.wezterm TryExec=wezterm -Exec=wezterm start --cwd . -- +Exec=wezterm start --cwd . Type=Application Categories=System;TerminalEmulator;Utility; Terminal=false