From e41c4405c73484093364be91ccef512317230111 Mon Sep 17 00:00:00 2001 From: Wez Furlong Date: Sat, 20 May 2023 19:54:24 -0700 Subject: [PATCH] palette: avoid spurious warning when opening command palette If you haven't registered an augment-command-palette event, you'd see: ``` 16:29:02.641 WARN wezterm_gui::termwindow::palette > augment-command-palette: error converting Lua nil to Rust Type (Cannot convert `Null` to `Vec`) ``` refs: https://github.com/wez/wezterm/issues/3595 --- wezterm-gui/src/termwindow/palette.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/wezterm-gui/src/termwindow/palette.rs b/wezterm-gui/src/termwindow/palette.rs index 3d57466b1..b656440d4 100644 --- a/wezterm-gui/src/termwindow/palette.rs +++ b/wezterm-gui/src/termwindow/palette.rs @@ -104,7 +104,9 @@ fn build_commands( ("augment-command-palette".to_string(), (gui_window, pane)), )?; - entries = from_lua_value_dynamic(result)?; + if !matches!(&result, mlua::Value::Nil) { + entries = from_lua_value_dynamic(result)?; + } } Ok(entries)