mirror of
https://github.com/wez/wezterm.git
synced 2024-11-22 22:42:48 +03:00
53febb14ff
e6421d1b72 removed this bit from the
example:
```
-
- // Note that we're waiting until after we've read the output
- // to call `wait` on the process.
- // On macOS Catalina, waiting on the process seems to prevent
- // its output from making it into the pty.
- println!("child status: {:?}", child.wait().unwrap());
```
This commit revisits that and puts in place a differently horrible
solution for macos.
The issue is that if we don't put in a short sleep on macos, then
for a short lived process like `whoami` in this example, we end up
reading output like this:
```
; cargo run --example whoami
Compiling portable-pty v0.8.0 (/Users/wez/wez-personal/wezterm/pty)
Finished dev [unoptimized + debuginfo] target(s) in 0.60s
Running `/Users/wez/wez-personal/wezterm/target/debug/examples/whoami`
child status: ExitStatus { code: 0, signal: None }
output: \r\n^D\u{8}\u{8}wez\r\n%
```
where the EOT that we send on Drop somehow gets *prepended* to the output
that we read from the pty with a couple of BELs thrown in.
I'm not sure WTF is happening on macOS for that to occur; feels like
some kind of race wrt. process startup and initializing the pty in the
system.
The reader has to be started before we close it as well, otherwise
the same issue can occur.
95 lines
3.5 KiB
Rust
95 lines
3.5 KiB
Rust
//! This is a conceptually simple example that spawns the `whoami` program
|
|
//! to print your username. It is made more complex because there are multiple
|
|
//! pipes involved and it is easy to get blocked/deadlocked if care and attention
|
|
//! is not paid to those pipes!
|
|
use portable_pty::{CommandBuilder, NativePtySystem, PtySize, PtySystem};
|
|
use std::sync::mpsc::channel;
|
|
|
|
fn main() {
|
|
let pty_system = NativePtySystem::default();
|
|
|
|
let pair = pty_system
|
|
.openpty(PtySize {
|
|
rows: 24,
|
|
cols: 80,
|
|
pixel_width: 0,
|
|
pixel_height: 0,
|
|
})
|
|
.unwrap();
|
|
|
|
let cmd = CommandBuilder::new("whoami");
|
|
let mut child = pair.slave.spawn_command(cmd).unwrap();
|
|
|
|
// Release any handles owned by the slave: we don't need it now
|
|
// that we've spawned the child.
|
|
drop(pair.slave);
|
|
|
|
// Read the output in another thread.
|
|
// This is important because it is easy to encounter a situation
|
|
// where read/write buffers fill and block either your process
|
|
// or the spawned process.
|
|
let (tx, rx) = channel();
|
|
let mut reader = pair.master.try_clone_reader().unwrap();
|
|
std::thread::spawn(move || {
|
|
// Consume the output from the child
|
|
let mut s = String::new();
|
|
reader.read_to_string(&mut s).unwrap();
|
|
tx.send(s).unwrap();
|
|
});
|
|
|
|
{
|
|
// Obtain the writer.
|
|
// When the writer is dropped, EOF will be sent to
|
|
// the program that was spawned.
|
|
// It is important to take the writer even if you don't
|
|
// send anything to its stdin so that EOF can be
|
|
// generated, otherwise you risk deadlocking yourself.
|
|
let mut writer = pair.master.take_writer().unwrap();
|
|
|
|
if cfg!(target_os = "macos") {
|
|
// macOS quirk: the child and reader must be started and
|
|
// allowed a brief grace period to run before we allow
|
|
// the writer to drop. Otherwise, the data we send to
|
|
// the kernel to trigger EOF is interleaved with the
|
|
// data read by the reader! WTF!?
|
|
// This appears to be a race condition for very short
|
|
// lived processes on macOS.
|
|
// I'd love to find a more deterministic solution to
|
|
// this than sleeping.
|
|
std::thread::sleep(std::time::Duration::from_millis(20));
|
|
}
|
|
|
|
// This example doesn't need to write anything, but if you
|
|
// want to send data to the child, you'd set `to_write` to
|
|
// that data and do it like this:
|
|
let to_write = "";
|
|
if !to_write.is_empty() {
|
|
// To avoid deadlock, wrt. reading and waiting, we send
|
|
// data to the stdin of the child in a different thread.
|
|
std::thread::spawn(move || {
|
|
writer.write_all(to_write.as_bytes()).unwrap();
|
|
});
|
|
}
|
|
}
|
|
|
|
// Wait for the child to complete
|
|
println!("child status: {:?}", child.wait().unwrap());
|
|
|
|
// Take care to drop the master after our processes are
|
|
// done, as some platforms get unhappy if it is dropped
|
|
// sooner than that.
|
|
drop(pair.master);
|
|
|
|
// Now wait for the output to be read by our reader thread
|
|
let output = rx.recv().unwrap();
|
|
|
|
// We print with escapes escaped because the windows conpty
|
|
// implementation synthesizes title change escape sequences
|
|
// in the output stream and it can be confusing to see those
|
|
// printed out raw in another terminal.
|
|
print!("output: ");
|
|
for c in output.escape_debug() {
|
|
print!("{}", c);
|
|
}
|
|
}
|