yonaskolb/XcodeGen
1
1
Fork 0
mirror of https://github.com/yonaskolb/XcodeGen.git synced 2024-11-28 02:33:06 +03:00
Code Issues Projects Releases Wiki Activity

escape target name in auto generated PRODUCT_BUNDLE_IDENTIFIER

Browse Source
This commit is contained in:
Yonas Kolb 2017-09-25 21:08:15 +02:00
parent a70c4c1821
commit 1c578d1a66
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Sources/XcodeGenKit/PBXProjGenerator.swift
View File

@ -181,7 +181,9 @@ public class PBXProjGenerator {
}
if let bundleIdPrefix = spec.options.bundleIdPrefix, !spec.targetHasBuildSetting("PRODUCT_BUNDLE_IDENTIFIER", basePath: basePath, target: target, config: config) {
buildSettings["PRODUCT_BUNDLE_IDENTIFIER"] = bundleIdPrefix + "." + target.name
let characterSet = CharacterSet.alphanumerics.union(CharacterSet(charactersIn: "-.")).inverted
let escapedTargetName = target.name.replacingOccurrences(of: "_", with: "-").components(separatedBy: characterSet).joined(separator: "")
buildSettings["PRODUCT_BUNDLE_IDENTIFIER"] = bundleIdPrefix + "." + escapedTargetName
}
// set Carthage search paths

6
docs/ProjectSpec.md
View File

@ -50,7 +50,7 @@ This merging behaviour can be overriden on a value basis. If you wish to replace
```yaml
include:
include:
- base.yml
name: CustomSpec
targets:
@ -59,11 +59,11 @@ targets:
- my_new_sources
```
Note that target names can also be changed by adding a `name` property to a target.
Note that target names can also be changed by adding a `name` property to a target.
### Options
- ⚪️ **carthageBuildPath**: `String` - The path to the carthage build directory. Defaults to `Carthage/Build`. This is used when specifying target carthage dependencies
- ⚪️ **bundleIdPrefix**: `String` - If this is specified then any target that doesn't have an `PRODUCT_BUNDLE_IDENTIFIER` (via all levels of build settings) will get an autogenerated one by combining `bundleIdPrefix` and the target name: `bundleIdPrefix.name`
- ⚪️ **bundleIdPrefix**: `String` - If this is specified then any target that doesn't have an `PRODUCT_BUNDLE_IDENTIFIER` (via all levels of build settings) will get an autogenerated one by combining `bundleIdPrefix` and the target name: `bundleIdPrefix.name`. The target name will be stripped of all characters that aren't alphanumerics, hyphens, or periods. Underscores will be replace with hyphens.
### Configs
Each config maps to a build type of either `debug` or `release` which will then apply default build settings. Any value other than `debug` or `release` (for example "none"), will mean no default build settings will be applied.