yonaskolb/XcodeGen
1
1
Fork 0
mirror of https://github.com/yonaskolb/XcodeGen.git synced 2024-12-11 07:16:40 +03:00
Code Issues Projects Releases Wiki Activity

Merge pull request #744 from ikesyo/avoid-adding-unnecessary-path-to-FRAMEWORK_SEARCH_PATHS

Browse Source 
Don't add framework dependency's directory to FRAMEWORK_SEARCH_PATHS if it is implicit
This commit is contained in:
Yonas Kolb 2020-01-12 21:45:39 +11:00 committed by GitHub
commit 308b351a7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -8,6 +8,7 @@
#### Fixed
- Fixed resolving a relative path for `projectReference.path` [#740](https://github.com/yonaskolb/XcodeGen/pull/740) @kateinoigakukun
- Don't add framework dependency's directory to `FRAMEWORK_SEARCH_PATHS` if it is implicit [#744](https://github.com/yonaskolb/XcodeGen/pull/744) @ikesyo @yutailang0119
#### Internal
- Update to SwiftCLI 6.0 and use the new property wrappers [#749](https://github.com/yonaskolb/XcodeGen/pull/749) @yonaskolb

6
Sources/XcodeGenKit/PBXProjGenerator.swift
View File

@ -534,8 +534,10 @@ public class PBXProjGenerator {
}
case .framework:
let buildPath = Path(dependency.reference).parent().string.quoted
frameworkBuildPaths.insert(buildPath)
if !dependency.implicit {
let buildPath = Path(dependency.reference).parent().string.quoted
frameworkBuildPaths.insert(buildPath)
}
let fileReference: PBXFileElement
if dependency.implicit {