mirror of
https://github.com/yonaskolb/XcodeGen.git
synced 2024-10-27 06:21:28 +03:00
e7f753785e
* Fix recursive include path when relativePath is not set If relativePath is not set on a particular include, the first level of include will currently work, but starting at the second level of iteration, the computed include path will fail as relativePath will be appended over and over onto the filePath. We're fixing that recursion problem here and adding the corresponding tests to make sure it doesn't happen again. * Include projectRoot in include paths The projectRoot setting (when specified) is currently ignored when computing the include paths. We're fixing that in that commit. * Use memoization during recursive SpecFiles creation SpecFile objects are created by recursive through includes. On a large project with programatically generated SpecFile, it is not rare to have hundreds of SpecFiles, creating a large web of include dependencies. In such a case, it is not rare either for a particular SpecFile to be included by multiple other SpecFiles. When that happens, XcodeGen currently creates a SpecFile object every time a SpecFile gets included, which can lead to an exponential growth of includes. I have seen hundreds of files being turned into hundred of thousands of SpecFile object creations, which leads to an impractical XcodeGen run of tens of minutes. This change adds memoization during SpecFile recursion, in order to reuse the previously created SpecFiles, if available, instead of re-creating them. * Update CHANGELOG.md Add the following changes to the changelog: * b97bdc4 - Use memoization during recursive SpecFiles creation * a6b96ad - Include projectRoot in include paths * 557b074 - Fix recursive include path when relativePath is not set |
||
---|---|---|
.. | ||
CarthageProject | ||
duplicated_include | ||
legacy_paths_test | ||
paths_test | ||
scheme_test | ||
SPM | ||
TestProject | ||
include_test.json | ||
include_test.yml | ||
included_addtional.yml | ||
included.yml | ||
legacy_paths_test.yml | ||
paths_test.yml | ||
settings_test.yml | ||
test.xcconfig | ||
variables_test.yml | ||
yaml.yml |