From 40588ed753efaa9bc089bf6807860a7ddb1d5d46 Mon Sep 17 00:00:00 2001
From: Oleg Shparber <oleg@zealdocs.org>
Date: Sat, 29 Apr 2023 00:24:55 -0400
Subject: [PATCH] ci(github): refactor artifact publishing check

---
 .github/workflows/build-check.yml | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml
index 0ab1873..0923b27 100644
--- a/.github/workflows/build-check.yml
+++ b/.github/workflows/build-check.yml
@@ -84,7 +84,8 @@ jobs:
               qt_modules: "qtwebengine",
               qt_version: "5.15.2",
               configurePreset: "ninja-multi-vcpkg",
-              buildPreset: "ninja-multi-vcpkg-release"
+              buildPreset: "ninja-multi-vcpkg-release",
+              publishArtifacts: false
             }
           - {
               name: "Windows Server 2019 / Qt 5 / Portable",
@@ -92,7 +93,8 @@ jobs:
               qt_modules: "qtwebengine",
               qt_version: "5.15.2",
               configurePreset: ninja-multi-vcpkg-portable,
-              buildPreset: ninja-multi-vcpkg-portable-release
+              buildPreset: ninja-multi-vcpkg-portable-release,
+              publishArtifacts: false
             }
           - {
               name: "Windows Server 2022 / Qt 6",
@@ -100,7 +102,8 @@ jobs:
               qt_modules: "qtwebengine qtwebchannel qtpositioning",
               qt_version: "6.5.0",
               configurePreset: ninja-multi-vcpkg,
-              buildPreset: ninja-multi-vcpkg-release
+              buildPreset: ninja-multi-vcpkg-release,
+              publishArtifacts: true
             }
           - {
               name: "Windows Server 2022 / Qt 6 / Portable",
@@ -108,7 +111,8 @@ jobs:
               qt_modules: "qtwebengine qtwebchannel qtpositioning",
               qt_version: "6.5.0",
               configurePreset: ninja-multi-vcpkg-portable,
-              buildPreset: ninja-multi-vcpkg-portable-release
+              buildPreset: ninja-multi-vcpkg-portable-release,
+              publishArtifacts: true
             }
 
     env:
@@ -152,8 +156,8 @@ jobs:
         run: cmake --build build/${{ matrix.config.configurePreset }} --config RelWithDebInfo --target install
 
       - name: Upload Artifacts
+        if: matrix.config.publishArtifacts
         uses: actions/upload-artifact@v3
-        if: matrix.config.os == 'windows-2022'
         with:
           name: zeal-${{ env.ZEAL_VERSION }}${{ matrix.config.configurePreset == 'ninja-multi-vcpkg-portable' &&  '-portable' || '' }}-windows-x64
           path: |
@@ -195,8 +199,8 @@ jobs:
 
       # TODO: Enable for releases.
       - name: Upload AppImage.zsync
-        uses: actions/upload-artifact@v3
         if: github.event_name == 'create' && github.event.ref_type == 'tag' && startsWith(github.ref, 'v')
+        uses: actions/upload-artifact@v3
         with:
           name: zeal-dev-x86_64.AppImage.zsync
           path: zeal-*.AppImage.zsync