From 62b772089c321dadfcdc85939b61520cfaeb2290 Mon Sep 17 00:00:00 2001 From: Oleg Shparber Date: Sat, 26 Jan 2019 22:45:24 -0500 Subject: [PATCH] refactor(registry,util): use default contructors instead of empty --- src/libs/registry/docsetmetadata.cpp | 4 ---- src/libs/registry/docsetmetadata.h | 2 +- src/libs/registry/searchquery.cpp | 4 ---- src/libs/registry/searchquery.h | 2 +- src/libs/util/plist.cpp | 5 ----- src/libs/util/plist.h | 2 +- 6 files changed, 3 insertions(+), 16 deletions(-) diff --git a/src/libs/registry/docsetmetadata.cpp b/src/libs/registry/docsetmetadata.cpp index 14864be..abab9f9 100644 --- a/src/libs/registry/docsetmetadata.cpp +++ b/src/libs/registry/docsetmetadata.cpp @@ -32,10 +32,6 @@ using namespace Zeal::Registry; -DocsetMetadata::DocsetMetadata() -{ -} - DocsetMetadata::DocsetMetadata(const QJsonObject &jsonObject) { m_name = jsonObject[QStringLiteral("name")].toString(); diff --git a/src/libs/registry/docsetmetadata.h b/src/libs/registry/docsetmetadata.h index 13405df..e4240c9 100644 --- a/src/libs/registry/docsetmetadata.h +++ b/src/libs/registry/docsetmetadata.h @@ -35,7 +35,7 @@ namespace Registry { class DocsetMetadata { public: - explicit DocsetMetadata(); + explicit DocsetMetadata() = default; explicit DocsetMetadata(const QJsonObject &jsonObject); void save(const QString &path, const QString &version); diff --git a/src/libs/registry/searchquery.cpp b/src/libs/registry/searchquery.cpp index f02ab48..7aa338a 100644 --- a/src/libs/registry/searchquery.cpp +++ b/src/libs/registry/searchquery.cpp @@ -32,10 +32,6 @@ const char prefixSeparator = ':'; const char keywordSeparator = ','; } -SearchQuery::SearchQuery() -{ -} - SearchQuery::SearchQuery(QString query, const QStringList &keywords) : m_query(std::move(query)) { diff --git a/src/libs/registry/searchquery.h b/src/libs/registry/searchquery.h index 0ecea93..2a9e377 100644 --- a/src/libs/registry/searchquery.h +++ b/src/libs/registry/searchquery.h @@ -35,7 +35,7 @@ namespace Registry { class SearchQuery { public: - explicit SearchQuery(); + explicit SearchQuery() = default; explicit SearchQuery(QString query, const QStringList &keywords = QStringList()); /// Creates a search query from a string. Single separator will be diff --git a/src/libs/util/plist.cpp b/src/libs/util/plist.cpp index e2c6a34..fb58be2 100644 --- a/src/libs/util/plist.cpp +++ b/src/libs/util/plist.cpp @@ -27,11 +27,6 @@ using namespace Zeal::Util; -Plist::Plist() : - QHash() -{ -} - bool Plist::read(const QString &fileName) { QScopedPointer file(new QFile(fileName)); diff --git a/src/libs/util/plist.h b/src/libs/util/plist.h index f827a2c..a37e5ab 100644 --- a/src/libs/util/plist.h +++ b/src/libs/util/plist.h @@ -32,7 +32,7 @@ namespace Util { class Plist : public QHash { public: - Plist(); + Plist() = default; bool read(const QString &fileName); bool hasError() const;