Commit Graph

1914 Commits

Author SHA1 Message Date
Oleg Shparber
9bee1f07e8 ci(appveyor): enable push to AppVeyor artifacts 2019-03-03 18:11:13 -05:00
Oleg Shparber
3cdb0dacc9 ci(appveyor): only deploy to BinTray from the stable branch 2019-03-03 18:10:36 -05:00
Oleg Shparber
d261423f70 ci(appveyor): do not package artifacts for pull request builds 2019-03-03 14:59:20 -05:00
Oleg Shparber
7d72dfa343 refactor(browser): disable copying and mark classes final 2019-02-10 14:54:50 -05:00
Oleg Shparber
ebc4bc8207 refactor(registry): disable copying and mark classes final 2019-02-10 14:53:14 -05:00
Oleg Shparber
949d16fb14 refactor(core): disable copying and mark classes final 2019-02-10 14:52:47 -05:00
Oleg Shparber
021b55ad73 refactor(registry,ui): limit Registry::ListModel to one instance 2019-02-09 14:48:13 -05:00
Oleg Shparber
4fd2723b15 fix(registry,ui): add SearchModel::clone() instead of copy constructor
Classes derived from QObject should never have be copied.
2019-01-27 16:02:13 -05:00
Oleg Shparber
e7ddfaf303 refactor(browser,ui): move saveHistory(), restoreHistory() into WebControl 2019-01-27 01:48:46 -05:00
Oleg Shparber
7faa77d0bf
refactor(browser,ui): move webview related classes into new library (#1074)
Also rename WebViewTab to WebControl.
2019-01-27 01:32:54 -05:00
Oleg Shparber
ab0d979c07 fix(registry,ui): fix some potential container detachments in range loops
More information:
https://github.com/KDE/clazy/blob/master/docs/checks/README-range-loop.md
2019-01-27 00:34:53 -05:00
Oleg Shparber
0be8a77db5 fix(ui): do not call QList::first() on a temporary value 2019-01-27 00:04:27 -05:00
Oleg Shparber
15c490ebaf fix(ui): disable copy assignment for MainWindow::TabState 2019-01-27 00:04:27 -05:00
Oleg Shparber
738843b689 refactor(core): remove unnecessary constant reference parameters 2019-01-27 00:04:27 -05:00
Oleg Shparber
9fe642db01 fix(ui): fix missing constant references 2019-01-27 00:04:27 -05:00
Oleg Shparber
aa5d4a19df refactor(ui): do not check for nullptr before delete 2019-01-27 00:04:27 -05:00
Oleg Shparber
abca9115c6 refactor(ui): remove unused variable 2019-01-27 00:04:27 -05:00
Oleg Shparber
355f87954f refactor(ui): do not use 0 as a null pointer 2019-01-27 00:04:27 -05:00
Oleg Shparber
558ea65521 refactor(registry): use brace initializer where possible 2019-01-27 00:04:27 -05:00
Oleg Shparber
62b772089c refactor(registry,util): use default contructors instead of empty 2019-01-27 00:04:27 -05:00
Oleg Shparber
e114a7fc3c refactor(app,core,ui): pass context object when connecting to a lambda
More information:
https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-3arg-lambda.md
2019-01-27 00:02:36 -05:00
Oleg Shparber
4c58e67980 refactor(core,registry,ui,util): avoid else-blocks after returns 2019-01-27 00:02:36 -05:00
Oleg Shparber
f02e904916 refactor(core,registry,ui): use auto for improved readability 2019-01-27 00:02:36 -05:00
Gianluca Recchia
b4bf14485b fix(registry): avoid unnecessary object copying (#1068)
Qt containers return a deep copy when used in a loop with a call to a
member function such as QMap::keys() or QMap::values(const Key& key).
Using iterators or assigning the return value to a const object avoids
the copy, thanks to the implicit sharing feature of Qt.

Further, when arguments in a constructor are to be passed to a member's
constructor, taking the argument by value and then moving it can be
beneficial when the argument is an rvalue as it will avoid the call to a
copy constructor.
2019-01-26 23:57:19 -05:00
Oleg Shparber
b4e26c48f3
refactor(ui): make ui/widgets a separate library (#1072) 2019-01-26 18:24:15 -05:00
Oleg Shparber
8512e40406 refactor(ui): use focus proxy instead of setFocus() call 2019-01-22 23:46:12 -05:00
Gianluca Recchia
999edbd448 refactor(ui): s/Q_OS_OSX/Q_OS_MACOS (#1065)
According to the Qt docs, the Q_OS_OSX macro is deprecated and
Q_OS_MACOS should be used instead.

See https://doc.qt.io/qt-5/qtglobal.html#Q_OS_OSX
2019-01-12 22:59:22 -05:00
Valentin Brandl
a64dadc3cf feat(ui): trim feed URL before trying to resolve it (#1037) 2018-11-23 20:46:37 -05:00
Oleg Shparber
10628488be feat(ui): add keyboard accelerators for the Preferences->Network tab 2018-11-07 00:14:18 -05:00
Oleg Shparber
2fe4122d9e ci(appveyor): package artifacts in after_build
`before_package` is too late, and artifacts cannot be detected then.
2018-11-06 22:06:22 -05:00
Oleg Shparber
646e1892fc ci(appveyor): invoke MSBuild directly
AppVeyor ignores `build:` when `build_script:` is present.
2018-11-06 00:29:32 -05:00
Oleg Shparber
4d019fff1f feat(core,ui): add support for SOCKS5 proxies (fixes #893) 2018-11-06 00:09:28 -05:00
Oleg Shparber
7fe9e726f5 ci(appveyor): install libsqlite3-dev dependency 2018-10-30 00:03:04 -04:00
Oleg Shparber
7eda7f2142 chore(cmake): require C++14 support 2018-10-23 23:57:44 -04:00
Oleg Shparber
c8f69cdfd0 fix(ui): resolve keyboard accelerator conflict in settings (fixes #1017) 2018-10-23 23:47:32 -04:00
Oleg Shparber
0a33df25b1 fix(registry,ui,util): order docsets case-insensitively (fixes #244) 2018-10-23 23:38:01 -04:00
Oleg Shparber
d34d7b50e0 fix(core): fix docset storage not created in portable build
Regression from b7d7e0a6a9.
2018-10-20 19:32:55 -04:00
Oleg Shparber
25a2227809 refactor(app,ui): remove code for Qt below version 5.7 2018-10-19 01:39:06 -04:00
Oleg Shparber
660298c7f5 chore(cmake,doc): bump required Qt version to 5.9.5 2018-10-19 01:33:12 -04:00
Oleg Shparber
4f9e482e2a chore(ci): remove integration with Shippable 2018-10-19 01:27:06 -04:00
Oleg Shparber
977712b5ca chore(ci): add .appveyor.yml 2018-10-19 01:15:50 -04:00
Oleg Shparber
ea1d77349b chore(git): update .gitignore 2018-10-19 01:15:24 -04:00
Oleg Shparber
69a5aeba33 chore: add .editorconfig 2018-10-19 01:09:41 -04:00
Oleg Shparber
b7d7e0a6a9 fix(core): use relative storage path in portable build by default 2018-10-19 01:09:41 -04:00
Guillermo Bonvehí
241b6955de feat(ui): add shortcuts for zooming webview content (fixes #767) (#1012) 2018-10-19 01:07:41 -04:00
Oleg Shparber
d9bb3c5901 docs: update AppVeyor badge in the README
The project was moved to the team account.
2018-10-12 08:18:32 -04:00
Karthik Nishanth
eed785ceb5 chore(ui): remove a completed TODO comment (#1004)
QAction::triggered has the prototype triggered(bool checked=false), and
QAbstractButton::animateClick has the prototype animateClick(int msec=100).

In this case, we don't set the QAction checkable boolean and its by default, false.
An implicit conversion of false to int occurs here.

Actual signal to slot connection is also confirmed using GammaRay
2018-10-09 23:06:41 -04:00
Karthik Nishanth
8bfacd75c4 feat(registry,ui): respect per docset JavaScript enablement (fixes #999) (#1003) 2018-10-07 13:05:24 -04:00
Oleg Shparber
b7d528bd6e chore(github): add CODEOWNERS file 2018-10-07 00:39:58 -04:00
Oleg Shparber
3bdb8ee0fd chore(release): 0.6.1 2018-09-28 01:26:37 -04:00