From 01ddf840f5516d90980288c24abb8b3e6e445744 Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Fri, 2 Feb 2024 16:42:43 +0100 Subject: [PATCH] completions: do not render empty multi-line documentation (#7279) I ran into this a lot with Go code: the documentation would be empty so we'd display a big box with nothing in it. I think it's better if we only display the box if we have documentation. Release Notes: - Fixed documentation box in showing up when using auto-complete even if documentation was empty. ## Before ![screenshot-2024-02-02-14 00 18@2x](https://github.com/zed-industries/zed/assets/1185253/e4915d51-a573-41f4-aa5d-21de6d1b0ff1) ## After ![screenshot-2024-02-02-14 01 58@2x](https://github.com/zed-industries/zed/assets/1185253/74b244af-3fc7-45e9-8cb3-7264e34b7ab7) --- crates/editor/src/editor.rs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 86090b0f05..b244ba6d12 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -857,9 +857,15 @@ impl CompletionsMenu { Some(Documentation::MultiLinePlainText(text)) => { Some(div().child(SharedString::from(text.clone()))) } - Some(Documentation::MultiLineMarkdown(parsed)) => Some(div().child( - render_parsed_markdown("completions_markdown", parsed, &style, workspace, cx), - )), + Some(Documentation::MultiLineMarkdown(parsed)) if !parsed.text.is_empty() => { + Some(div().child(render_parsed_markdown( + "completions_markdown", + parsed, + &style, + workspace, + cx, + ))) + } _ => None, }; multiline_docs.map(|div| {