zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-11-08 07:35:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Make App a user property in Mixpanel

Browse Source 
Currently, we cannot take advantage of Mixpanel's virtual session end events because they are associated with users, not events; this change moves the property onto users.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
This commit is contained in:
Joseph T Lyons 2022-11-04 14:16:12 -04:00
parent 18ff459014
commit 474a5dd4f2
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crates/client/src/telemetry.rs
View File

@ -32,7 +32,6 @@ pub struct Telemetry {
struct TelemetryState { struct TelemetryState {
metrics_id: Option<Arc<str>>, metrics_id: Option<Arc<str>>,
device_id: Option<Arc<str>>, device_id: Option<Arc<str>>,
app: &'static str,
app_version: Option<Arc<str>>, app_version: Option<Arc<str>>,
release_channel: Option<&'static str>, release_channel: Option<&'static str>,
os_version: Option<Arc<str>>, os_version: Option<Arc<str>>,
@ -80,8 +79,6 @@ struct MixpanelEventProperties {
app_version: Option<Arc<str>>, app_version: Option<Arc<str>>,
#[serde(rename = "Signed In")] #[serde(rename = "Signed In")]
signed_in: bool, signed_in: bool,
#[serde(rename = "App")]
app: &'static str,
} }
#[derive(Serialize)] #[derive(Serialize)]
@ -120,7 +117,6 @@ impl Telemetry {
state: Mutex::new(TelemetryState { state: Mutex::new(TelemetryState {
os_version: platform.os_version().ok().map(|v| v.to_string().into()), os_version: platform.os_version().ok().map(|v| v.to_string().into()),
os_name: platform.os_name().into(), os_name: platform.os_name().into(),
app: "Zed",
app_version: platform.app_version().ok().map(|v| v.to_string().into()), app_version: platform.app_version().ok().map(|v| v.to_string().into()),
release_channel, release_channel,
device_id: None, device_id: None,
@ -205,7 +201,11 @@ impl Telemetry {
let json_bytes = serde_json::to_vec(&[MixpanelEngageRequest { let json_bytes = serde_json::to_vec(&[MixpanelEngageRequest {
token, token,
distinct_id: device_id, distinct_id: device_id,
set: json!({ "Staff": is_staff, "ID": metrics_id }), set: json!({
"Staff": is_staff,
"ID": metrics_id,
"App": true
}),
}])?; }])?;
let request = Request::post(MIXPANEL_ENGAGE_URL) let request = Request::post(MIXPANEL_ENGAGE_URL)
.header("Content-Type", "application/json") .header("Content-Type", "application/json")
@ -241,7 +241,6 @@ impl Telemetry {
release_channel: state.release_channel, release_channel: state.release_channel,
app_version: state.app_version.clone(), app_version: state.app_version.clone(),
signed_in: state.metrics_id.is_some(), signed_in: state.metrics_id.is_some(),
app: state.app,
}, },
}; };
state.queue.push(event); state.queue.push(event);