zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-11-09 21:26:14 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix panic in completions menu (#3778)

Browse Source 
We were shifting all the positions while keeping the original string,
which caused problems later when combining highlighted ranges with
matched indices.

Release Notes:

- N/A
This commit is contained in:
Antonio Scandurra 2023-12-22 12:27:52 +01:00 committed by GitHub
commit 62aea418de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/editor2/src/editor.rs
View File

@ -1350,15 +1350,15 @@ impl CompletionsMenu {
completion.sort_key(),
)
});
drop(completions);
for mat in &mut matches {
let completions = self.completions.read();
let filter_start = completions[mat.candidate_id].label.filter_range.start;
let completion = &completions[mat.candidate_id];
mat.string = completion.label.text.clone();
for position in &mut mat.positions {
*position += filter_start;
*position += completion.label.filter_range.start;
}
}
drop(completions);
self.matches = matches.into();
self.selected_item = 0;