diff --git a/crates/gpui/src/platform.rs b/crates/gpui/src/platform.rs index 7007061cbb..09edfdb848 100644 --- a/crates/gpui/src/platform.rs +++ b/crates/gpui/src/platform.rs @@ -412,7 +412,6 @@ pub trait PlatformDispatcher: Send + Sync { pub(crate) trait PlatformTextSystem: Send + Sync { fn add_fonts(&self, fonts: Vec>) -> Result<()>; fn all_font_names(&self) -> Vec; - fn all_font_families(&self) -> Vec; fn font_id(&self, descriptor: &Font) -> Result; fn font_metrics(&self, font_id: FontId) -> FontMetrics; fn typographic_bounds(&self, font_id: FontId, glyph_id: GlyphId) -> Result>; diff --git a/crates/gpui/src/platform/linux/text_system.rs b/crates/gpui/src/platform/linux/text_system.rs index f297e050e2..65cc512d19 100644 --- a/crates/gpui/src/platform/linux/text_system.rs +++ b/crates/gpui/src/platform/linux/text_system.rs @@ -77,17 +77,6 @@ impl PlatformTextSystem for CosmicTextSystem { result } - fn all_font_families(&self) -> Vec { - self.0 - .read() - .font_system - .db() - .faces() - // todo(linux) this will list the same font family multiple times - .filter_map(|face| face.families.first().map(|family| family.0.clone())) - .collect_vec() - } - fn font_id(&self, font: &Font) -> Result { // todo(linux): Do we need to use CosmicText's Font APIs? Can we consolidate this to use font_kit? let mut state = self.0.write(); diff --git a/crates/gpui/src/platform/mac/text_system.rs b/crates/gpui/src/platform/mac/text_system.rs index 2967e2f56e..aba1e8edf9 100644 --- a/crates/gpui/src/platform/mac/text_system.rs +++ b/crates/gpui/src/platform/mac/text_system.rs @@ -5,7 +5,7 @@ use crate::{ }; use anyhow::anyhow; use cocoa::appkit::{CGFloat, CGPoint}; -use collections::{BTreeSet, HashMap}; +use collections::HashMap; use core_foundation::{ attributed_string::CFMutableAttributedString, base::{CFRange, TCFType}, @@ -93,26 +93,18 @@ impl PlatformTextSystem for MacTextSystem { } fn all_font_names(&self) -> Vec { + let mut names = Vec::new(); let collection = core_text::font_collection::create_for_all_families(); let Some(descriptors) = collection.get_descriptors() else { - return Vec::new(); + return names; }; - let mut names = BTreeSet::new(); for descriptor in descriptors.into_iter() { names.extend(lenient_font_attributes::family_name(&descriptor)); } if let Ok(fonts_in_memory) = self.0.read().memory_source.all_families() { names.extend(fonts_in_memory); } - names.into_iter().collect() - } - - fn all_font_families(&self) -> Vec { - self.0 - .read() - .system_source - .all_families() - .expect("core text should never return an error") + names } fn font_id(&self, font: &Font) -> Result { diff --git a/crates/gpui/src/platform/windows/direct_write.rs b/crates/gpui/src/platform/windows/direct_write.rs index afceca2ffa..5c33393795 100644 --- a/crates/gpui/src/platform/windows/direct_write.rs +++ b/crates/gpui/src/platform/windows/direct_write.rs @@ -177,10 +177,6 @@ impl PlatformTextSystem for DirectWriteTextSystem { self.0.read().all_font_names() } - fn all_font_families(&self) -> Vec { - self.0.read().all_font_families() - } - fn font_id(&self, font: &Font) -> Result { let lock = self.0.upgradable_read(); if let Some(font_id) = lock.font_selections.get(font) { @@ -962,10 +958,6 @@ impl DirectWriteState { )); result } - - fn all_font_families(&self) -> Vec { - get_font_names_from_collection(&self.system_font_collection, &self.components.locale) - } } impl Drop for DirectWriteState { diff --git a/crates/gpui/src/text_system.rs b/crates/gpui/src/text_system.rs index 67f8ac783b..fa564f8097 100644 --- a/crates/gpui/src/text_system.rs +++ b/crates/gpui/src/text_system.rs @@ -17,7 +17,7 @@ use crate::{ StrikethroughStyle, UnderlineStyle, }; use anyhow::anyhow; -use collections::{BTreeSet, FxHashMap}; +use collections::FxHashMap; use core::fmt; use derive_more::Deref; use itertools::Itertools; @@ -78,18 +78,15 @@ impl TextSystem { /// Get a list of all available font names from the operating system. pub fn all_font_names(&self) -> Vec { - let mut names: BTreeSet<_> = self - .platform_text_system - .all_font_names() - .into_iter() - .collect(); - names.extend(self.platform_text_system.all_font_families()); + let mut names = self.platform_text_system.all_font_names(); names.extend( self.fallback_font_stack .iter() .map(|font| font.family.to_string()), ); - names.into_iter().collect() + names.sort(); + names.dedup(); + names } /// Add a font's data to the text system.