vim: Fix >... (#15404)

Co-Authored-By: @Alextopher

Release Notes:

- vim: Fixed a hang when repeating an aborted operation
([#15399](https://github.com/zed-industries/zed/issues/15399)).
This commit is contained in:
Conrad Irwin 2024-07-29 09:22:25 -06:00 committed by GitHub
parent f58ef9b82b
commit 6db33b83d8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 24 additions and 18 deletions

View File

@ -1448,3 +1448,15 @@ async fn test_visual_indent_count(cx: &mut gpui::TestAppContext) {
cx.simulate_keystrokes("shift-v 2 <");
cx.assert_state(" ˇhi", Mode::Normal);
}
#[gpui::test]
async fn test_record_replay_recursion(cx: &mut gpui::TestAppContext) {
let mut cx = NeovimBackedTestContext::new(cx).await;
cx.set_shared_state("ˇhello world").await;
cx.simulate_shared_keystrokes(">").await;
cx.simulate_shared_keystrokes(".").await;
cx.simulate_shared_keystrokes(".").await;
cx.simulate_shared_keystrokes(".").await;
cx.shared_state().await.assert_eq("ˇhello world"); // takes a _long_ time
}

View File

@ -189,25 +189,13 @@ fn observe_keystrokes(keystroke_event: &KeystrokeEvent, cx: &mut WindowContext)
return;
}
Vim::update(cx, |vim, cx| match vim.active_operator() {
Some(
Operator::FindForward { .. }
| Operator::FindBackward { .. }
| Operator::Replace
| Operator::Digraph { .. }
| Operator::AddSurrounds { .. }
| Operator::ChangeSurrounds { .. }
| Operator::DeleteSurrounds
| Operator::Mark
| Operator::Jump { .. }
| Operator::Register
| Operator::RecordRegister
| Operator::ReplayRegister,
) => {}
Some(_) => {
vim.clear_operator(cx);
Vim::update(cx, |vim, cx| {
if let Some(operator) = vim.active_operator() {
if !operator.is_waiting(vim.state().mode) {
vim.clear_operator(cx);
vim.stop_recording_immediately(Box::new(ClearOperators))
}
}
_ => {}
});
}

View File

@ -0,0 +1,6 @@
{"Put":{"state":"ˇhello world"}}
{"Key":">"}
{"Key":"."}
{"Key":"."}
{"Key":"."}
{"Get":{"state":"ˇhello world","mode":"Normal"}}