From 84b34677e246647812aa4aa994ebb966b881f32d Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Wed, 17 Jul 2024 15:35:09 -0400 Subject: [PATCH] Exclude dev extensions from auto-updates (#14680) This PR makes it so dev extensions that are installed are excluded when checking for extension updates. We don't want to accidentally clobber dev extensions if the upstream extension is deemed more "up-to-date". Release Notes: - Changed dev extensions to be excluded from extension auto-updates. --- crates/extension/src/extension_store.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/extension/src/extension_store.rs b/crates/extension/src/extension_store.rs index 1330b7ae6d..7e08c8d327 100644 --- a/crates/extension/src/extension_store.rs +++ b/crates/extension/src/extension_store.rs @@ -456,9 +456,9 @@ impl ExtensionStore { let extension_ids = self .extension_index .extensions - .keys() - .map(|id| id.as_ref()) - .filter(|id| extension_settings.should_auto_update(id)) + .iter() + .filter(|(id, entry)| !entry.dev && extension_settings.should_auto_update(id)) + .map(|(id, _)| id.as_ref()) .collect::>() .join(","); let task = self.fetch_extensions_from_api(