mirror of
https://github.com/zed-industries/zed.git
synced 2024-09-19 02:17:35 +03:00
lsp: Check if "Goto Definition" supported before request (#15111)
This is related to #15023 where we have the running Rubocop LSP that provides diagnostics and formatting capabilities. Rubocop LSP sends its capabilities back to Zed without support for "textDocument/definition" request, Zed actually does not check that and sends a request to Rubocop that results in the server error "Unsupported method: textDocument/definition". The fix here is related to https://github.com/zed-industries/zed/pull/14666 Release Notes: - N/A
This commit is contained in:
parent
740c444089
commit
9c9a0bd24f
@ -786,6 +786,7 @@ mod tests {
|
|||||||
let mut cx = EditorLspTestContext::new_rust(
|
let mut cx = EditorLspTestContext::new_rust(
|
||||||
lsp::ServerCapabilities {
|
lsp::ServerCapabilities {
|
||||||
hover_provider: Some(lsp::HoverProviderCapability::Simple(true)),
|
hover_provider: Some(lsp::HoverProviderCapability::Simple(true)),
|
||||||
|
definition_provider: Some(lsp::OneOf::Left(true)),
|
||||||
..Default::default()
|
..Default::default()
|
||||||
},
|
},
|
||||||
cx,
|
cx,
|
||||||
|
@ -427,6 +427,13 @@ impl LspCommand for GetDefinition {
|
|||||||
type LspRequest = lsp::request::GotoDefinition;
|
type LspRequest = lsp::request::GotoDefinition;
|
||||||
type ProtoRequest = proto::GetDefinition;
|
type ProtoRequest = proto::GetDefinition;
|
||||||
|
|
||||||
|
fn check_capabilities(&self, capabilities: AdapterServerCapabilities) -> bool {
|
||||||
|
capabilities
|
||||||
|
.server_capabilities
|
||||||
|
.definition_provider
|
||||||
|
.is_some()
|
||||||
|
}
|
||||||
|
|
||||||
fn to_lsp(
|
fn to_lsp(
|
||||||
&self,
|
&self,
|
||||||
path: &Path,
|
path: &Path,
|
||||||
|
Loading…
Reference in New Issue
Block a user