zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-11-08 07:35:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

repl: Simplify error output formatting (#15088)

Browse Source 
Release Notes:

- N/A
This commit is contained in:
Kyle Kelley 2024-07-24 08:38:04 -07:00 committed by GitHub
parent c6d6c44810
commit 9e528dbb16
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
crates/repl/src/outputs.rs
View File

@ -281,14 +281,14 @@ impl ErrorView {
fn render(&self, cx: &ViewContext<ExecutionView>) -> Option<AnyElement> {
let theme = cx.theme();
let colors = cx.theme().colors();
let padding = cx.line_height() / 2.;
Some(
v_flex()
.w_full()
.bg(colors.background)
.py(cx.line_height() / 2.)
.border_l_1()
.px(padding)
.py(padding)
.border_1()
.border_color(theme.status().error_border)
.child(
h_flex()
@ -429,13 +429,17 @@ impl ExecutionView {
self.outputs.push(output);
}
// Comments from @rgbkrk, reach out with questions
// There are other payloads that could be handled here, such as updating the input.
// Below are the other payloads that _could_ be handled, but are not required for Zed.
// Set next input adds text to the next cell. Not required to support.
// However, this could be implemented by adding text to the buffer.
// Trigger in python using `get_ipython().set_next_input("text")`
//
// runtimelib::Payload::SetNextInput { text, replace } => {},
// Not likely to be used in the context of Zed, where someone could just open the buffer themselves
// Python users can trigger this with the `%edit` magic command
// runtimelib::Payload::EditMagic { filename, line_number } => {},
// Ask the user if they want to exit the kernel. Not required to support.