zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-12-29 07:32:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

Avoid async fs call before checking if operation is applicable

Browse Source 
This way, the executor isn't influenced by operations that aren't applicable.
This commit is contained in:
Max Brunsfeld 2023-04-05 18:11:33 -07:00
parent 1064b14779
commit bf3b8adf35
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
crates/collab/src/tests/randomized_integration_tests.rs
View File

@ -735,11 +735,13 @@ async fn apply_client_operation(
is_dir,
content,
} => {
client
if !client
.fs
.metadata(&path.parent().unwrap())
.await?
.ok_or(TestError::Inapplicable)?;
.directories()
.contains(&path.parent().unwrap().to_owned())
{
return Err(TestError::Inapplicable);
}
if is_dir {
log::info!("{}: creating dir at {:?}", client.username, path);
@ -761,13 +763,8 @@ async fn apply_client_operation(
repo_path,
contents,
} => {
if !client
.fs
.metadata(&repo_path)
.await?
.map_or(false, |m| m.is_dir)
{
Err(TestError::Inapplicable)?;
if !client.fs.directories().contains(&repo_path) {
return Err(TestError::Inapplicable);
}
log::info!(