zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-12-26 19:05:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

Don't update active completion for editors that are not focused (#9904)

Browse Source 
Release Notes:

- N/A
This commit is contained in:
Antonio Scandurra 2024-03-28 10:51:55 +01:00 committed by GitHub
parent eaec04632a
commit c33ee52046
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/copilot_ui/src/copilot_completion_provider.rs
View File

@ -764,6 +764,7 @@ mod tests {
multibuffer multibuffer
}); });
let editor = cx.add_window(|cx| Editor::for_multibuffer(multibuffer, None, cx)); let editor = cx.add_window(|cx| Editor::for_multibuffer(multibuffer, None, cx));
editor.update(cx, |editor, cx| editor.focus(cx)).unwrap();
let copilot_provider = cx.new_model(|_| CopilotCompletionProvider::new(copilot)); let copilot_provider = cx.new_model(|_| CopilotCompletionProvider::new(copilot));
editor editor
.update(cx, |editor, cx| { .update(cx, |editor, cx| {

2
crates/editor/src/editor.rs
View File

@ -1676,7 +1676,9 @@ impl Editor {
) { ) {
self.inline_completion_provider = Some(RegisteredInlineCompletionProvider { self.inline_completion_provider = Some(RegisteredInlineCompletionProvider {
_subscription: cx.observe(&provider, |this, _, cx| { _subscription: cx.observe(&provider, |this, _, cx| {
if this.focus_handle.is_focused(cx) {
this.update_visible_inline_completion(cx); this.update_visible_inline_completion(cx);
}
}), }),
provider: Arc::new(provider), provider: Arc::new(provider),
}); });