mirror of
https://github.com/zed-industries/zed.git
synced 2024-12-27 16:04:57 +03:00
Fix code that identifies language via extension
This commit is contained in:
parent
c96b03ae55
commit
c523ccc4c7
@ -45,7 +45,7 @@ use syntax_map::SyntaxSnapshot;
|
||||
use theme::{SyntaxTheme, Theme};
|
||||
use tree_sitter::{self, Query};
|
||||
use unicase::UniCase;
|
||||
use util::http::HttpClient;
|
||||
use util::{http::HttpClient, paths::PathExt};
|
||||
use util::{merge_json_value_into, post_inc, ResultExt, TryFutureExt as _, UnwrapFuture};
|
||||
|
||||
#[cfg(any(test, feature = "test-support"))]
|
||||
@ -777,7 +777,7 @@ impl LanguageRegistry {
|
||||
) -> UnwrapFuture<oneshot::Receiver<Result<Arc<Language>>>> {
|
||||
let path = path.as_ref();
|
||||
let filename = path.file_name().and_then(|name| name.to_str());
|
||||
let extension = path.extension().and_then(|name| name.to_str());
|
||||
let extension = path.extension_or_hidden_file_name();
|
||||
let path_suffixes = [extension, filename];
|
||||
self.get_or_load_language(|config| {
|
||||
let path_matches = config
|
||||
|
@ -33,6 +33,7 @@ pub mod legacy {
|
||||
pub trait PathExt {
|
||||
fn compact(&self) -> PathBuf;
|
||||
fn icon_suffix(&self) -> Option<&str>;
|
||||
fn extension_or_hidden_file_name(&self) -> Option<&str>;
|
||||
}
|
||||
|
||||
impl<T: AsRef<Path>> PathExt for T {
|
||||
@ -60,6 +61,7 @@ impl<T: AsRef<Path>> PathExt for T {
|
||||
}
|
||||
}
|
||||
|
||||
/// Returns a suffix of the path that is used to determine which file icon to use
|
||||
fn icon_suffix(&self) -> Option<&str> {
|
||||
let file_name = self.as_ref().file_name()?.to_str()?;
|
||||
|
||||
@ -69,8 +71,16 @@ impl<T: AsRef<Path>> PathExt for T {
|
||||
|
||||
self.as_ref()
|
||||
.extension()
|
||||
.map(|extension| extension.to_str())
|
||||
.flatten()
|
||||
.and_then(|extension| extension.to_str())
|
||||
}
|
||||
|
||||
/// Returns a file's extension or, if the file is hidden, its name without the leading dot
|
||||
fn extension_or_hidden_file_name(&self) -> Option<&str> {
|
||||
if let Some(extension) = self.as_ref().extension() {
|
||||
return extension.to_str();
|
||||
}
|
||||
|
||||
self.as_ref().file_name()?.to_str()?.split('.').last()
|
||||
}
|
||||
}
|
||||
|
||||
@ -315,4 +325,27 @@ mod tests {
|
||||
let path = Path::new("/a/b/c/.eslintrc.js");
|
||||
assert_eq!(path.icon_suffix(), Some("eslintrc.js"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_extension_or_hidden_file_name() {
|
||||
// No dots in name
|
||||
let path = Path::new("/a/b/c/file_name.rs");
|
||||
assert_eq!(path.extension_or_hidden_file_name(), Some("rs"));
|
||||
|
||||
// Single dot in name
|
||||
let path = Path::new("/a/b/c/file.name.rs");
|
||||
assert_eq!(path.extension_or_hidden_file_name(), Some("rs"));
|
||||
|
||||
// Multiple dots in name
|
||||
let path = Path::new("/a/b/c/long.file.name.rs");
|
||||
assert_eq!(path.extension_or_hidden_file_name(), Some("rs"));
|
||||
|
||||
// Hidden file, no extension
|
||||
let path = Path::new("/a/b/c/.gitignore");
|
||||
assert_eq!(path.extension_or_hidden_file_name(), Some("gitignore"));
|
||||
|
||||
// Hidden file, with extension
|
||||
let path = Path::new("/a/b/c/.eslintrc.js");
|
||||
assert_eq!(path.extension_or_hidden_file_name(), Some("js"));
|
||||
}
|
||||
}
|
||||
|
@ -1,5 +1,5 @@
|
||||
name = "Shell Script"
|
||||
path_suffixes = ["sh", "bash", "bashrc", "bash_profile", "bash_aliases", "bash_logout", "profile", "zsh", "zshrc", "zshenv", "zsh_profile", "zsh_aliases", "zsh_histfile", "zlogin"]
|
||||
path_suffixes = ["sh", "bash", "bashrc", "bash_profile", "bash_aliases", "bash_logout", "profile", "zsh", "zshrc", "zshenv", "zsh_profile", "zsh_aliases", "zsh_histfile", "zlogin", "zprofile"]
|
||||
line_comment = "# "
|
||||
first_line_pattern = "^#!.*\\b(?:ba|z)?sh\\b"
|
||||
brackets = [
|
||||
|
Loading…
Reference in New Issue
Block a user