zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-11-08 07:35:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ensure the outer ListItem element has a unique ID (#3644)

Browse Source 
This PR fixes an issue where the outer `ListItem` element was using a
static ID instead of the one provided to the component.

Now that active states are fixed, this meant that any time there were
sibling list items they would share active states if one of them was
clicked.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2023-12-13 21:14:21 -05:00 committed by GitHub
parent 474f09ca3f
commit ceede28fab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/ui2/src/components/list/list_item.rs
View File

@ -128,7 +128,7 @@ impl RenderOnce for ListItem {
fn render(self, cx: &mut WindowContext) -> Self::Rendered {
h_stack()
.id("item_container")
.id(self.id)
.w_full()
.relative()
// When an item is inset draw the indent spacing outside of the item
@ -151,7 +151,7 @@ impl RenderOnce for ListItem {
})
.child(
h_stack()
.id(self.id)
.id("inner_list_item")
.w_full()
.relative()
.gap_1()

4
crates/ui2/src/components/stories/list_item.rs
View File

@ -17,7 +17,7 @@ impl Render for ListItemStory {
.child(ListItem::new("hello_world").child("Hello, world!"))
.child(Story::label("Inset"))
.child(
ListItem::new("hello_world")
ListItem::new("inset_list_item")
.inset(true)
.start_slot(
IconElement::new(Icon::Bell)
@ -59,7 +59,7 @@ impl Render for ListItemStory {
)
.child(Story::label("With end hover slot"))
.child(
ListItem::new("with_left_avatar")
ListItem::new("with_end_hover_slot")
.child("Hello, world!")
.end_slot(
h_stack()