zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-09-19 10:29:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Do not render a signature popover when its location is before the visible range (#14307)

Browse Source 
Follow-up of https://github.com/zed-industries/zed/pull/12909

Release Notes:

- N/A
This commit is contained in:
Kirill Bulatov 2024-07-12 11:31:52 +03:00 committed by GitHub
parent 8abc000553
commit ea26a01f5f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
crates/editor/src/element.rs
View File

@ -2642,28 +2642,30 @@ impl EditorElement {
hitbox: &Hitbox,
content_origin: gpui::Point<Pixels>,
scroll_pixel_position: gpui::Point<Pixels>,
display_point: Option<DisplayPoint>,
newest_selection_head: Option<DisplayPoint>,
start_row: DisplayRow,
line_layouts: &[LineWithInvisibles],
line_height: Pixels,
em_width: Pixels,
cx: &mut WindowContext,
) {
let Some(display_point) = display_point else {
let Some(newest_selection_head) = newest_selection_head else {
return;
};
let Some(cursor_row_layout) =
line_layouts.get(display_point.row().minus(start_row) as usize)
let selection_row = newest_selection_head.row();
if selection_row < start_row {
return;
}
let Some(cursor_row_layout) = line_layouts.get(selection_row.minus(start_row) as usize)
else {
return;
};
let start_x = cursor_row_layout.x_for_index(display_point.column() as usize)
let start_x = cursor_row_layout.x_for_index(newest_selection_head.column() as usize)
- scroll_pixel_position.x
+ content_origin.x;
let start_y =
display_point.row().as_f32() * line_height + content_origin.y - scroll_pixel_position.y;
selection_row.as_f32() * line_height + content_origin.y - scroll_pixel_position.y;
let max_size = size(
(120. * em_width) // Default size