zed-industries/zed
1
1
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-09-18 18:08:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2435 from zed-industries/use-json-post-request-for-update-requests

Browse Source 
Use json_post() request for update requests
This commit is contained in:
Joseph T. Lyons 2023-05-02 23:42:25 -04:00 committed by GitHub
commit f576586cd7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/auto_update/src/auto_update.rs
View File

@ -273,7 +273,7 @@ impl AutoUpdater {
telemetry,
})?);
let mut response = client.get(&release.url, request_body, true).await?;
let mut response = client.post_json(&release.url, request_body, true).await?;
smol::io::copy(response.body_mut(), &mut dmg_file).await?;
log::info!("downloaded update. path:{:?}", dmg_path);

6
crates/client/src/telemetry.rs
View File

@ -270,7 +270,7 @@ impl Telemetry {
}])?;
this.http_client
.post_json(MIXPANEL_ENGAGE_URL, json_bytes.into())
.post_json(MIXPANEL_ENGAGE_URL, json_bytes.into(), false)
.await?;
anyhow::Ok(())
}
@ -404,7 +404,7 @@ impl Telemetry {
json_bytes.clear();
serde_json::to_writer(&mut json_bytes, &events)?;
this.http_client
.post_json(MIXPANEL_EVENTS_URL, json_bytes.into())
.post_json(MIXPANEL_EVENTS_URL, json_bytes.into(), false)
.await?;
anyhow::Ok(())
}
@ -454,7 +454,7 @@ impl Telemetry {
}
this.http_client
.post_json(CLICKHOUSE_EVENTS_URL.as_str(), json_bytes.into())
.post_json(CLICKHOUSE_EVENTS_URL.as_str(), json_bytes.into(), false)
.await?;
anyhow::Ok(())
}

6
crates/util/src/http.rs
View File

@ -40,8 +40,14 @@ pub trait HttpClient: Send + Sync {
&'a self,
uri: &str,
body: AsyncBody,
follow_redirects: bool,
) -> BoxFuture<'a, Result<Response<AsyncBody>, Error>> {
let request = isahc::Request::builder()
.redirect_policy(if follow_redirects {
RedirectPolicy::Follow
} else {
RedirectPolicy::None
})
.method(Method::POST)
.uri(uri)
.header("Content-Type", "application/json")