Conrad Irwin
844d161c40
Allow adding write access to guests
2024-01-08 22:02:56 -07:00
Marshall Bowers
4afa5fb23e
Add stories for collab notifications ( #3967 )
...
This PR adds some basic stories for collab notifications to make them
easier to work on:
<img width="1076" alt="Screenshot 2024-01-08 at 9 43 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4a0adcfa-1134-49c2-b589-74ac1d52af4c ">
I factored out a `CollabNotification` component that defines the general
structure for one of these notifications, and this is the component that
we use in the stories, with representative values passed to it to
simulate the different instances of the notification.
We can't use the actual notification components in the stories due to
their data dependencies.
Release Notes:
- N/A
2024-01-08 21:54:59 -05:00
Marshall Bowers
80f204fabb
Style the chat panel message input ( #3956 )
...
This PR styles the message input in the chat panel.
<img width="242" alt="Screenshot 2024-01-08 at 4 28 33 PM"
src="https://github.com/zed-industries/zed/assets/1486634/48e83692-878e-4891-8e40-8738cdeb23a8 ">
Release Notes:
- Improved the styling of the message editor in the chat panel.
2024-01-08 16:45:18 -05:00
Marshall Bowers
667d90180d
Improve chat panel empty states ( #3955 )
...
This PR improves the empty states for the chat panel:
- The signed-out state has been updated to match our other signed-out
panel states.
- A new state has been added to account for the case where a user is
signed in but doesn't have an active chat.
Release Notes:
- Improved the design of empty states in the chat panel.
2024-01-08 15:56:52 -05:00
Piotr Osiewicz
e4b1c76895
Display setting documentation in settings.json ( #3936 )
...
Let this screenshot of settings.json speak for itself:
![image](https://github.com/zed-industries/zed/assets/24362066/fca60383-1788-43f9-803b-00f083394c8a )
Release Notes:
- Added code completion & on-hover documentation to Zed's settings.json
file.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
2024-01-08 19:30:18 +01:00
Marshall Bowers
5e401e4550
Fix layout shift when renaming a channel ( #3946 )
...
This PR fixes the layout shift that would occur in the channel list when
opening a rename editor for a channel.
Release Notes:
- Fixed layout shift when opening a rename editor for a channel.
2024-01-08 13:28:21 -05:00
Marshall Bowers
72de75dd45
Adjust spacing of extra call participant count indicator ( #3945 )
...
This PR adjusts the spacing of the indicator showing the number of extra
call participants that appears after the facepile:
<img width="242" alt="Screenshot 2024-01-08 at 1 09 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/6d9cbefa-3b4e-4501-ab11-51026dfb5b6c ">
Release Notes:
- Added more space between the call participant facepile and the number
indicating additional call participants.
2024-01-08 13:24:56 -05:00
Marshall Bowers
fd2abb7ba1
Adjust thickness of tree branches
2024-01-08 12:32:01 -05:00
Marshall Bowers
04f01ab408
Overdraw the tree branch to avoid gaps
2024-01-08 12:01:13 -05:00
Piotr Osiewicz
d475f1373a
gpui: Further docs refinement & moved some reexports into 'private' module ( #3935 )
...
This commit mostly fixes invalid URLs in docstrings. It also
encapsulates crates we reexport (serde stuff + linkme) into a public
module named "private" in order to reduce the API surfaced through docs.
Moreover, I fixed up a bunch of crates that were pulling serde_json in
through gpui explicitly instead of using Cargo manifest.
Release Notes:
- N/A
2024-01-07 14:14:21 +01:00
Joseph T. Lyons
520c433af5
Fix tests
2024-01-06 16:10:40 -05:00
Joseph T. Lyons
ea1770254d
Merge branch 'main' into instrument-welcome-screen
2024-01-06 15:23:06 -05:00
Joseph T. Lyons
cdd5cb16ed
WIP
2024-01-06 14:41:35 -05:00
Kirill Bulatov
d86ccb1afc
Reduce the height of the collaborators' color ribbon
2024-01-06 12:54:54 +02:00
Kirill Bulatov
ae14f7bd92
Add space between menus and player stack
2024-01-06 12:07:48 +02:00
Kirill Bulatov
ee336cb87f
Add spaces between leave call and call status icons, and call status icons and user menu
2024-01-06 11:56:01 +02:00
Kirill Bulatov
e549ef0ee9
Restore tooltipts for all collab buttons
2024-01-06 01:50:59 +02:00
Marshall Bowers
be98ff408e
Iterate on design of channel management modal ( #3923 )
...
This PR refines the design of the channel management modal:
#### Before
<img width="585" alt="Screenshot 2024-01-05 at 4 17 32 PM"
src="https://github.com/zed-industries/zed/assets/1486634/a6d96674-b688-4549-8fb8-0a7b2c7c88be ">
#### After
<img width="589" alt="Screenshot 2024-01-05 at 4 15 20 PM"
src="https://github.com/zed-industries/zed/assets/1486634/31ae8dc1-a129-4a15-963e-9779b9b79bd9 ">
Release Notes:
- Improved the look of the channel management modal.
2024-01-05 16:22:43 -05:00
Marshall Bowers
6cb8b86aeb
Tidy up styling of connection status in the title bar ( #3922 )
...
This PR tidies up the styling of the connection status indicators in the
title bar.
Removed some debug styles and tweaked the styling to match the rest of
the title bar overall.
Release Notes:
- Improved the connection status indicators in the title bar.
2024-01-05 15:36:30 -05:00
Conrad Irwin
3c0052850c
Merge branch 'main' into channel-guests
2024-01-05 10:05:59 -07:00
Nate Butler
a205b2dbf3
Update call controls & Add tinted buttons ( #3886 )
...
This PR introduces Tinted button styles and the `selected_style` field
on buttons to allow replicating the previous design of titlebar call
controls. It also updates the styles of the titlebar controls.
### Creating a tinted button:
```
Button::new("accept-cta", "Accept")
.style(ButtonStyle::Tinted(TintColor::Accent))
.on_click(...)
```
Ths button will always be tinted blue.
### Creating a button that becomes tinted when selected::
```rust
IconButton::new("screen-share", Icon::Screen)
.style(ButtonStyle::Subtle)
.selected(is_screen_sharing)
.selected_style(ButtonStyle::Tinted(TintColor::Accent))
.on_click(...),
```
This button will be flat/subtle by default, but be tinted blue when it
is `selected`.
Note: There appears to be some issue where `is_deafened` isn't
activating correctly, making the speaker icon not toggle when selected.
Release Notes:
- Restore call control styles to a similar look to Zed 1.
2024-01-05 11:28:18 -05:00
Nate Butler
6c4350933f
Update titlebar call status icons
2024-01-05 11:20:24 -05:00
Marshall Bowers
c8dcc80a1f
Respect the setting to show/hide the assistant and chat panels ( #3909 )
...
This PR makes it so we respect the setting to show/hide the assistant
and chat panels.
Resolves https://github.com/zed-industries/community/issues/2370 .
Release Notes:
- Fixed an issue where the settings to show/hide certain panels were not
respected.
2024-01-05 11:17:29 -05:00
Marshall Bowers
3f06a05060
Iterate on collab panel filter input style ( #3900 )
...
This PR takes another pass at the collab panel filter input to improve
its styling.
Release Notes:
- Improved the look of the filter input in the collab panel.
2024-01-04 18:08:28 -05:00
Conrad Irwin
be426e67cc
Tidy up guest count
2024-01-04 12:22:45 -07:00
Piotr Osiewicz
5a43cbacbe
channels: Move name of the channel to the same line as the hash icon.
2024-01-04 12:11:23 +01:00
Nate Butler
77647fa088
Use theme colors for muted/speaking indicators
2024-01-03 23:19:47 -05:00
Conrad Irwin
1930258d39
Show guests in fewer places
2024-01-03 19:31:43 -07:00
Conrad Irwin
9fe17a1d1d
Prevent guests from screen-sharing, unmuting or screen sharing
2024-01-03 19:31:43 -07:00
Conrad Irwin
84171787a5
Track read_only per project and buffer
...
This uses a new enum to avoid confusing booleans
2024-01-03 19:31:43 -07:00
Marshall Bowers
2ec58c0438
Follow the project host when clicking their name in the title bar ( #3868 )
...
This PR adds back the ability to follow the project host when clicking
on their name in the title bar.
Release Notes:
- Added back following the project host when clicking their name in the
title bar.
2024-01-03 17:48:46 -05:00
Max Brunsfeld
a8061232a5
cargo fmt
2024-01-03 13:13:50 -08:00
Max Brunsfeld
83f4c61657
Remove 2 suffix from gpui_macros, fix compile errors in tests
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 13:12:21 -08:00
Max Brunsfeld
f5ba22659b
Remove 2 suffix from gpui
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:59:39 -08:00
Max Brunsfeld
dfcb17fe74
Remove 2 suffix for theme
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:41:01 -08:00
Max Brunsfeld
4305c5fdbe
Remove 2 suffix for ui, storybook, text
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:33:51 -08:00
Max Brunsfeld
0cf65223ce
Remove 2 suffix for collab, rope, settings, menu
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:29:16 -08:00
Max Brunsfeld
5ddd298b4d
Remove 2 suffix for fs, db, semantic_index, prettier
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:09:42 -08:00
Max Brunsfeld
53bdf6beb3
Remove 2 suffix for client, call, channel
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:02:14 -08:00
Max Brunsfeld
9f99e58834
Remove 2 suffix for lsp, language, fuzzy
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:58:02 -08:00
Max Brunsfeld
c5a1950522
Remove 2 suffix for project
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:53:34 -08:00
Max Brunsfeld
4ddb26204f
Remove 2 suffix for ai, zed_actions, install_ci, feature_flags
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:48:46 -08:00
Max Brunsfeld
789ce8dd75
Remove 2 suffix for workspace
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:08:51 -08:00
Max Brunsfeld
588976d27a
Remove 2 suffix for editor
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 10:58:57 -08:00
Max Brunsfeld
bcad3a5847
Remove 2 suffix for picker, feedback
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 10:55:34 -08:00
Max Brunsfeld
0ac8aae17b
Remove 2 suffix for language_tools, search, terminal_view, auto_update
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 10:52:40 -08:00
Max Brunsfeld
292b3397ab
Remove 2 suffix for language selector, project panel, recent_projects, copilot_button, breadcrumbs, activity_indicator
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 10:47:33 -08:00
Max Brunsfeld
37e6533b28
Remove 2 suffix for project_symbols, theme_selector
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 10:38:23 -08:00
Max Brunsfeld
2b8822fd08
Remove 2 suffix for welcome, vcs_menu, quick_action_bar, collab_ui
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 10:30:52 -08:00
Kirill Bulatov
a5c615ceb4
Pass a new query parameter into the search
2023-11-17 21:40:56 +02:00
Max Brunsfeld
2dd32dbe87
Allow language injection in markdown code blocks in channel notes
2023-11-03 15:53:54 -07:00
Mikayla Maki
f67f42779b
Rename IIFE to maybe ( #3165 )
...
Too good of an idea to forget
Release Notes:
- N/A
2023-10-25 17:09:12 +02:00
Mikayla
26a3d41dc7
Change from try (reserved keyword) to maybe
2023-10-25 07:10:21 -07:00
Max Brunsfeld
32367eba14
Set up UI to allow dragging a channel to the root
2023-10-25 15:39:02 +02:00
Max Brunsfeld
42259a4007
Fix channel dragging
...
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Joseph <joseph@zed.dev>
2023-10-25 09:41:16 +02:00
Conrad Irwin
70eeefa1f8
Fix channel collapsing
2023-10-25 09:27:17 +02:00
Max Brunsfeld
5c03b6a610
Remove logic for multiple channel parents
...
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Kyle <kyle@zed.dev>
Co-authored-by: Joseph <joseph@zed.dev>
2023-10-24 17:29:23 +02:00
Conrad Irwin
ea4e67fb76
Merge branch 'main' into guest-exp
2023-10-23 17:47:21 +02:00
Max Brunsfeld
4d491ca3a1
Tweak styling of notifications
...
Co-authored-by: Piotr <piotr@zed.dev>
2023-10-23 14:58:03 +02:00
Max Brunsfeld
2f0eaafc39
Format timestamps more tersely in the notification panel
...
Co-authored-by: Piotr <piotr@zed.dev>
2023-10-23 14:34:38 +02:00
Max Brunsfeld
8766e5f0d0
Avoid flickering toast when mentioned in already-visible chat channel
...
Co-authored-by: Piotr <piotr@zed.dev>
2023-10-23 13:48:49 +02:00
Piotr Osiewicz
812ff9a97d
Account for markdown styling in mentions offset calculation.
...
This also means that we can support smart punctuation.
Co-authored-by: Max <max@zed.dev>
2023-10-23 12:50:57 +02:00
Max Brunsfeld
763b13e700
Avoid duplicate acks for messages with mentions
2023-10-22 18:00:02 +02:00
Max Brunsfeld
59adcc1744
Load more notifications when scrolling down
2023-10-22 17:10:21 +02:00
Max Brunsfeld
23400a5a70
Start styling notification panel
2023-10-22 16:03:33 +02:00
Max Brunsfeld
234ccbe51f
Merge branch 'main' into notifications
2023-10-22 12:25:30 +02:00
Max Brunsfeld
4a0358a513
Mark contact acceptance notifications as read automatically
2023-10-22 12:22:47 +02:00
Max Brunsfeld
fce09e8c92
Mark chat mention notifications as read when viewing the message
2023-10-22 11:57:10 +02:00
Piotr Osiewicz
fc37abc356
vcs_menu: Query branches on open instead of per keystroke ( #3144 )
...
Release Notes:
- Improved performance of branch picker by querying branches on menu
open instead of querying once per each keystroke. (fixes
zed-industries/community#2161 )
2023-10-21 14:01:01 +02:00
Conrad Irwin
31872227f1
Remove screen sharing indicator
...
This is now redundant given macOS has the same icon, and it panics when
you click on it :D.
2023-10-20 13:04:45 -06:00
Piotr Osiewicz
6844bb6510
Highlight mentions in the Saved chat messages
2023-10-20 15:30:36 +02:00
Conrad Irwin
e03e5364d2
Wire through LiveKit permissions
2023-10-19 23:23:33 -06:00
Max Brunsfeld
44cb55fbe9
Fix scrolling to messages on clicking of notifications
2023-10-19 14:04:34 -07:00
Max Brunsfeld
5b90507310
Navigate to chat messages when clicking them in the notification panel
2023-10-19 12:31:45 -07:00
Conrad Irwin
0eff7c6ca9
Add read-only channel notes support
...
Fix some bugs where ChannelNotes and ChannelChat had old cached channel
instances
2023-10-19 13:20:49 -06:00
Conrad Irwin
3853009d92
Refactor to avoid some (mostly hypothetical) races
...
Tidy up added code to reduce duplicity of X and X_internals.
2023-10-18 21:42:10 -06:00
Max Brunsfeld
b07f9fe3b5
Merge branch 'main' into notifications
2023-10-18 17:20:04 -07:00
Max Brunsfeld
d05404a4df
Persist chat mentions
2023-10-18 16:56:03 -07:00
Mikayla
0ce1ec5d15
Restrict DAG-related functionality, but retain infrastructure for implementing symlinks
2023-10-18 05:28:05 -07:00
Conrad Irwin
70aed4a605
Sync Role as part of channels
...
Begin to fix guest notifications
2023-10-17 22:48:44 -06:00
Max Brunsfeld
821419ee5b
Add a unit test for the mention-searching logic in MessageEditor
2023-10-17 20:15:49 -07:00
Max Brunsfeld
ee87ac2f9b
Start work on chat mentions
2023-10-17 17:59:42 -07:00
Max Brunsfeld
660021f5e5
Fix more issues with the channels panel
...
* Put the newest notifications at the top
* Have at most 1 notification toast, which is non-interactive,
but focuses the notification panel on click, and auto-dismisses
on a timer.
2023-10-17 15:43:06 -07:00
Conrad Irwin
1c5e07f4a2
update sidebar for public channels
2023-10-17 13:30:09 -06:00
Max Brunsfeld
52834dbf21
Add notifications integration test
2023-10-17 11:21:38 -07:00
Max Brunsfeld
f2d36a47ae
Generalize notifications' actor id to entity id
...
This way, we can retrieve channel invite notifications when
responding to the invites.
2023-10-17 10:34:50 -07:00
Max Brunsfeld
f225039d36
Display invite response buttons inline in notification panel
2023-10-17 09:12:55 -07:00
Conrad Irwin
9cc55f895c
Merge branch 'main' into guests
2023-10-17 09:54:17 -06:00
Conrad Irwin
851701cb6f
Fix get_most_public_ancestor
2023-10-17 09:41:34 -06:00
Mikayla
162f625716
Adjust chat permisisons to allow deletion for channel admins
2023-10-17 02:16:17 -07:00
Conrad Irwin
4e7b35c917
Make joining a channel as a guest always succeed
2023-10-16 15:14:13 -06:00
Max Brunsfeld
c66385f0f9
Add an empty state to the notification panel
2023-10-16 12:54:44 -07:00
Max Brunsfeld
cb7b011d6b
Avoid creating duplicate invite notifications
2023-10-13 16:57:28 -07:00
Max Brunsfeld
83fb8d20b7
Remove contact notifications when cancelling a contact request
2023-10-13 16:09:46 -07:00
Conrad Irwin
f6f9b5c8cb
Wire through public access toggle
2023-10-13 16:59:30 -06:00
Max Brunsfeld
8db86dcebf
Connect notification panel to notification toasts
2023-10-13 11:21:45 -07:00
Max Brunsfeld
3241128840
Make notification db representation more flexible
2023-10-12 17:42:32 -07:00
Max Brunsfeld
d1756b621f
Start work on notification panel
2023-10-12 17:41:09 -07:00
Max Brunsfeld
85fe11ff11
Replace disconnected channel notes views when re-opening the notes
2023-10-12 12:38:23 -07:00
Conrad Irwin
540436a1f9
Push role refactoring through RPC/client
2023-10-12 13:05:54 -06:00