Marshall Bowers
b136d21ebf
Make tab close button square ( #4052 )
...
This PR makes the close button for tabs square.
`IconButton` now accepts a `shape`, and using `IconButtonShape::Square`
will ensure the `IconButton` is square with respect to its contained
icon.
#### Before
<img width="119" alt="Screenshot 2024-01-15 at 10 32 40 AM"
src="https://github.com/zed-industries/zed/assets/1486634/dc806b9b-411f-4cd9-8c10-676d2cbd298b ">
#### After
<img width="116" alt="Screenshot 2024-01-15 at 10 32 24 AM"
src="https://github.com/zed-industries/zed/assets/1486634/8b4ef43c-14b6-449f-a235-5d7affd82c4e ">
Release Notes:
- Changed the tab close button to be square.
2024-01-15 10:43:03 -05:00
Antonio Scandurra
4ff514ca7e
Merge remote-tracking branch 'origin/main' into cache
...
# Conflicts:
# crates/gpui/src/elements/div.rs
2024-01-15 11:37:46 +01:00
Conrad Irwin
29ce109211
chat panel ++ ( #4044 )
...
- Update chat panel with current channel
- Open chat panel for guests
- Open chat when joining a channel with guests
- Some tweaks for chat panels
- Don't lose focus on default panel state
- Make chat prettier (to my eyes at least)
- Fix multiple mentions in one message
- Show a border when scrolled in chat
- Fix re-docking chat panel
- Move settings subscription to dock
[[PR Description]]
Release Notes:
- Opens chat by default when joining a public channel
- Improves chat panel UI
2024-01-14 13:54:10 -07:00
Conrad Irwin
b34c78016f
Fix tests for TestPanel
2024-01-14 12:26:54 -07:00
Conrad Irwin
898645681f
Move settings subscription to dock
...
Reduces likelihood of panels being unable to move themselves
2024-01-13 22:41:26 -07:00
Mikayla
bfb59f1598
Remove last stale code
2024-01-12 20:59:19 -08:00
Antonio Scandurra
94293b3bf9
Merge remote-tracking branch 'origin/main' into cache
...
# Conflicts:
# crates/gpui/src/window.rs
2024-01-12 14:31:13 +01:00
Max Brunsfeld
258c2fdad4
Fix routing of leader updates from unshared projects
...
Previously, leader updates in unshared projects would be sent to
all followers regardless of project, as if they were not scoped
to any project.
2024-01-11 13:47:31 -08:00
Conrad Irwin
43183538a7
Stop following when project is unshared ( #4010 )
...
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.
[[PR Description]]
Release Notes:
- Fixed an edge-case where following didn't handle unshare correctly
2024-01-11 11:26:56 -07:00
Kirill Bulatov
2e36b0b72a
Do not split on only external directories being drag and dropped
2024-01-11 15:09:43 +02:00
Conrad Irwin
f418bd907d
Stop following when project is unshared
...
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.
2024-01-10 23:09:09 -07:00
Mikayla
a5ca58354d
Fix first few asserts
2024-01-10 18:26:01 -08:00
Antonio Scandurra
1c260e6dfd
Merge remote-tracking branch 'origin/main' into cache
...
# Conflicts:
# crates/copilot/src/sign_in.rs
# crates/gpui/src/window.rs
# crates/workspace/src/pane_group.rs
2024-01-10 22:58:52 +01:00
Conrad Irwin
5dff458014
Ensure focus_in and focus_out fire on window activation ( #3993 )
...
Also:
- Rename cx.on_blur to cx.on_focus_lost
- Fix a bug where notify calls in focus handlers were ignored
- Fix a bug where vim would get stuck in the wrong mode when switching
windows
Release Notes:
- (preview only) vim: fix switching between multiple windows
2024-01-10 10:00:07 -07:00
Antonio Scandurra
2923b71f83
Replace WindowContext::notify
with WindowContext::refresh
2024-01-10 17:27:02 +01:00
Conrad Irwin
5d3f5611e5
guest promotion ( #3969 )
...
Release Notes:
- Adds the ability to promote read-only guests to read-write
participants in calls
2024-01-09 22:21:13 -07:00
Conrad Irwin
1bf33b4b61
Ensure focus_in and focus_out fire on window activation
...
Also:
- Rename cx.on_blur to cx.on_focus_lost
- Fix a bug where notify calls in focus handlers were ignored
- Fix a bug where vim would get stuck in the wrong mode when switching
windows
2024-01-09 20:55:00 -07:00
Mikayla Maki
45baad2825
Remove or fix stale todos ( #3990 )
...
The software equivalent of dusting
Release Notes:
-
2024-01-09 18:37:35 -08:00
Mikayla
e786e22121
And a few more todos
2024-01-09 16:41:17 -08:00
Mikayla
9ce7ef8949
Remove the last of the major todos
2024-01-09 16:14:54 -08:00
Conrad Irwin
276bfa0fab
Merge branch 'main' into guest-promotion
2024-01-09 16:28:42 -07:00
Kirill Bulatov
8b71b1d07b
Do not dismiss buffer search when any modal is present
...
Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
2024-01-09 23:29:05 +02:00
Marshall Bowers
fa53353c57
Rename IconElement
to just Icon
( #3974 )
...
This PR renames the `IconElement` component to just `Icon`.
This better matches the rest of our components, as `IconElement` was the
only one using this naming convention.
The `Icon` enum has been renamed to `IconName` to free up the name.
I was trying to come up with a way that would allow rendering an
`Icon::Zed` directly (and thus make the `IconElement` a hidden part of
the API), but I couldn't come up with a way to do this cleanly.
Release Notes:
- N/A
2024-01-09 10:11:20 -05:00
Kirill Bulatov
625c9d8980
Remove some todo!'s
2024-01-09 11:36:36 +02:00
Conrad Irwin
844d161c40
Allow adding write access to guests
2024-01-08 22:02:56 -07:00
Mikayla
51caa74349
Restore the active pane magnification feature
2024-01-08 15:48:31 -08:00
Conrad Irwin
c951b4c5fa
Fix prevention of cross-channel joins ( #3949 )
...
Co-Authored-By: Max <max@zed.dev>
[[PR Description]]
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/ <public_issue_number_if_exists>)).
2024-01-08 14:17:44 -07:00
Conrad Irwin
ed76315387
Fix prevention of cross-channel joins
...
Co-Authored-By: Max <max@zed.dev>
2024-01-08 13:47:27 -07:00
Piotr Osiewicz
e4b1c76895
Display setting documentation in settings.json ( #3936 )
...
Let this screenshot of settings.json speak for itself:
![image](https://github.com/zed-industries/zed/assets/24362066/fca60383-1788-43f9-803b-00f083394c8a )
Release Notes:
- Added code completion & on-hover documentation to Zed's settings.json
file.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
2024-01-08 19:30:18 +01:00
Antonio Scandurra
84c36066bc
Start on caching views
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2024-01-08 19:07:20 +01:00
Piotr Osiewicz
97aed8a4d7
Restore ability to reset pane split size by double clicking drag handle. ( #3937 )
...
Release notes
- Fixed double clicking on pane drag handle not resetting pane's split
size.
- Fixed pane group sizes not being serialized.
2024-01-08 16:48:17 +01:00
Piotr Osiewicz
53564fb269
Bring back zed.rs tests ( #3907 )
...
At present 3 tests still fail; 2 are related to keymap issues that (I
believe) @maxbrunsfeld is working on. The other one
(`test_open_paths_action`) I'll look into. edit: done
This PR also fixes workspace unregistration, as we've put the code to do
that behind `debug_assert`
(https://github.com/zed-industries/zed/pull/3907/files#diff-041673bbd1947a35d45945636c0055429dfc8b5985faf93f8a8a960c9ad31e28L649 ).
Release Notes:
- N/A
2024-01-08 12:29:54 +01:00
Kirill Bulatov
419b4d029c
External file drag and drop ( #3933 )
...
Deals with https://github.com/zed-industries/community/issues/1317
Deals with https://github.com/zed-industries/community/issues/486
Reworks pane drag and drop code to support
* dropping external files into main pane (supports splits same as tabs
and project entries drop) — this will open the file dropped
* dropping external files, tabs and project entries drop into the
terminal — this will add file abs path into the terminal
Release Notes:
- Added a way to drag and drop external files into Zed main & terminal
panes; support tabs and project entries drop into terminal pane
2024-01-07 13:37:49 +02:00
Joseph T. Lyons
5344296c9a
Remove immediate flush mode
...
Allow flush method to be called publicly. This is a better, simpler solution, that allows for better control over flushing.
2024-01-06 20:27:30 -05:00
Kirill Bulatov
4f88a50aad
On external file drop, add visible project entries for directories only
2024-01-07 03:11:28 +02:00
Kirill Bulatov
518868a12f
Implement terminal pane drag and drop overrides
2024-01-07 02:21:43 +02:00
Kirill Bulatov
c4e306162c
Implement external file drop in pane
2024-01-07 01:18:02 +02:00
Kirill Bulatov
8ff05c6a72
Prepare for external file drop in pane
2024-01-07 01:17:49 +02:00
Joseph T. Lyons
cdd5cb16ed
WIP
2024-01-06 14:41:35 -05:00
Kirill Bulatov
669293e749
Screenshare item background is now of editor background's color
2024-01-06 02:01:12 +02:00
Conrad Irwin
204ef451d0
Merge branch 'main' into following-tests
2024-01-05 16:14:12 -07:00
Conrad Irwin
f239a8292e
More following tests
2024-01-05 16:13:40 -07:00
Conrad Irwin
81d707adbc
Port 1.00 following tests
...
Co-Authored-By: Max <max@zed.dev>
2024-01-05 15:55:33 -07:00
Piotr Osiewicz
254a52d0a1
gpui: Remove dependency on sqlez ( #3871 )
...
This removes one of the path dependencies in gpui that's only really
needed by `workspace` (which can work around lack of these
implementations by itself). In theory it should also improve build
scheduling (as gpui doesn't have to wait for main dependency of sqlez -
libsqlite3 - to finish it's 25 seconds-long build in release), though in
practice I didn't notice a substantial improvement.
Moreover `sqlez` was unused by `settings` too, so that's removed
as well.
Release Notes:
- N/A
2024-01-05 19:36:55 +01:00
Conrad Irwin
1a993ca496
Read-only access for channel guests ( #3841 )
2024-01-05 11:21:18 -07:00
Conrad Irwin
c066480e31
Fix dock right click labels ( #3626 )
...
Release Notes:
- N/A
2024-01-05 10:08:58 -07:00
Conrad Irwin
3c0052850c
Merge branch 'main' into channel-guests
2024-01-05 10:05:59 -07:00
Conrad Irwin
df0076a4eb
Better TestWindow support ( #3876 )
...
Adding guest roles led us down a rabbit hole where we'd have liked to
rely on a
side-effect of activating a window in tests; but the test window didn't
implement that.
Looking into that, I realized our TestWindow wasn't doing a great job of
emulating the MacWindow, so this makes the two more similar.
2024-01-05 09:59:48 -07:00
Conrad Irwin
fa73cf3983
Correct dock menu names
2024-01-05 09:58:07 -07:00
Kirill Bulatov
bf11a04410
Remove extra dbg!'s
2024-01-05 17:48:07 +02:00
Kirill Bulatov
92d6a8c253
Return back git status colors for tab labels ( #3906 )
2024-01-05 13:52:51 +02:00
Kirill Bulatov
3070a6ef26
Return back git status colors for tab labels
2024-01-05 12:38:42 +02:00
Antonio Scandurra
3e6b4a1298
Don't shift pane content when following someone ( #3905 )
...
Release Notes:
- Fixed a bug that would shrink the pane when following someone.
2024-01-05 11:01:23 +01:00
Antonio Scandurra
cf03ea2da9
Don't shift pane content when following someone
2024-01-05 10:55:33 +01:00
Conrad Irwin
fff415e3e9
Improve deactivate simulation
2024-01-04 22:06:52 -07:00
Kirill Bulatov
4dbec66cdd
Return back old project search behavior as default.
...
Add a `workspace::DeploySearch` action and use it as a default for "cmd-shift-f" binding.
This action opens existing search tab if it exists, or creates a new one otherwise.
`workspace::NewSearch` action is still available and always opens an existing search tab.
2024-01-04 21:17:24 +02:00
Conrad Irwin
9d146a2a6f
Fix vim tests
2024-01-04 08:59:31 -07:00
Antonio Scandurra
f6af7ab27c
Fix quitting Zed when project was unshared
2024-01-04 15:00:36 +01:00
Joseph T. Lyons
2972ee8ced
Move telemetry settings check into telemetry module
2024-01-04 01:13:21 -05:00
Max Brunsfeld
28c39aae17
Start work on read-only project access for channel guests
...
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 19:30:32 -07:00
Max Brunsfeld
f5ba22659b
Remove 2 suffix from gpui
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:59:39 -08:00
Max Brunsfeld
dfcb17fe74
Remove 2 suffix for theme
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:41:01 -08:00
Max Brunsfeld
4305c5fdbe
Remove 2 suffix for ui, storybook, text
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:33:51 -08:00
Max Brunsfeld
0cf65223ce
Remove 2 suffix for collab, rope, settings, menu
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:29:16 -08:00
Max Brunsfeld
5ddd298b4d
Remove 2 suffix for fs, db, semantic_index, prettier
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:09:42 -08:00
Max Brunsfeld
53bdf6beb3
Remove 2 suffix for client, call, channel
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:02:14 -08:00
Max Brunsfeld
9f99e58834
Remove 2 suffix for lsp, language, fuzzy
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:58:02 -08:00
Max Brunsfeld
c5a1950522
Remove 2 suffix for project
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:53:34 -08:00
Max Brunsfeld
4ddb26204f
Remove 2 suffix for ai, zed_actions, install_ci, feature_flags
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:48:46 -08:00
Max Brunsfeld
789ce8dd75
Remove 2 suffix for workspace
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 11:08:51 -08:00
Joseph T. Lyons
b1870af386
Add project open event
...
Give the caller of report_app_event() the choice of whether to immediately flush the queue or not.
2023-12-22 20:23:55 -05:00
Kirill Bulatov
27d6432c84
Rework the way project panel auto reveals entries
...
* gitignored entries are never auto revealed
* `project_panel::auto_reveal_entries = true` settings entry was added,
setting it to `false` will disable the auto reveal
* `pane::RevealInProjectPanel` action was added that activates the project panel and reveals the entry it got triggered on (including the gitignored ones)
2023-12-12 11:38:51 +02:00
Kirill Bulatov
f0ca7141b8
Ignore excluded files on worktree entry refresh
2023-12-05 12:30:29 +02:00
Kirill Bulatov
1f6c69c7dc
Allow opening buffers without a project entry
2023-12-05 12:30:29 +02:00
Conrad Irwin
f3d142b7e9
remove zed1 notification mess
2023-11-27 16:27:02 -07:00
Conrad Irwin
039c933d8e
gpui2: Notifications
2023-11-26 22:28:53 -07:00
Conrad Irwin
4f859e0253
link to channel notes ( #3167 )
...
Release Notes:
- Add links to channel notes
2023-10-25 15:53:34 +02:00
Conrad Irwin
1411b98a5d
link to channel notes
2023-10-24 19:48:31 +02:00
Conrad Irwin
fd8e6110b1
Fix panic by disallowing multiple room joins
2023-10-20 14:34:25 -06:00
Conrad Irwin
9cc55f895c
Merge branch 'main' into guests
2023-10-17 09:54:17 -06:00
Conrad Irwin
6ffbc3a0f5
Allow pasting ZED urls in the command palette in development
2023-10-16 20:03:44 -06:00
Kirill Bulatov
ce6b31d938
Make NodeRuntime non-static for prettier runner
2023-10-11 12:56:29 +03:00
Max Brunsfeld
96d60eff23
Fix inclusion of spurious views from other projects in FollowResponse
2023-10-10 15:40:40 -07:00
Conrad Irwin
d4ef764305
Merge branch 'main' into links
2023-10-09 20:08:48 -06:00
Conrad Irwin
8922437fcd
code review
2023-10-09 19:06:55 -06:00
Max Brunsfeld
90b54a45e8
Log a warning when leader activates an unknown view
2023-10-09 14:29:45 -07:00
Max Brunsfeld
ca735ad70f
Ensure there's only one leader per pane
2023-10-09 13:32:38 -07:00
Conrad Irwin
abfb4490d5
Focus the currently active project if there is one
...
(also consider your own projects in "most_active_projects")
2023-10-09 12:05:26 -06:00
Conrad Irwin
5dbda70235
Fix ./script/bundle to allow passing key
2023-10-09 08:59:25 -06:00
Conrad Irwin
f6bc229d1d
More progress and some debug logs to remove
2023-10-06 16:48:29 -06:00
Conrad Irwin
63a230f92e
Make joining on boot work
2023-10-06 16:11:45 -06:00
Max Brunsfeld
f8ca86c6a7
Remove workspace -> channel dependency
2023-10-06 14:19:25 -07:00
Conrad Irwin
b58c42cd53
TEMP
2023-10-06 13:47:35 -06:00
Max Brunsfeld
8fafae2cfa
Fix panic when immediately closing a window while opening paths
2023-10-05 16:21:14 -07:00
Conrad Irwin
13192fa03c
Code to allow opening zed:/channel/1234
...
Refactored a bit how url arguments are handled to avoid adding too much
extra complexity to main.
2023-10-05 14:57:45 -07:00
Max Brunsfeld
438dd42f7d
Fix bugs in handling mutual following
...
* Propagate all of leader's views to a new follower, even if those views
were originally created by that follower.
* Propagate active view changes to followers, even if the active view is
following that follower.
* Avoid redundant active view updates on the client.
2023-10-05 13:28:46 -07:00
Max Brunsfeld
95342c8c33
Merge branch 'main' into channel-changes
2023-10-03 17:52:28 -07:00
Max Brunsfeld
af09861f5c
Specify uuid crate in the root Cargo.toml
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2023-10-03 17:39:24 -07:00
Conrad Irwin
528fa5c57b
Refactor to remove toggle_follow
2023-10-02 16:51:02 -06:00
Conrad Irwin
27d784b23e
Fix bug in following
...
Prior to this change you could only follow across workspaces when you
were heading to the first window.
2023-10-02 16:29:42 -06:00