eaec04632a
Fix #8994 and #9844 Release notes: * Fixed the `t` object in Vim mode not working correctly when cursor was on a tag. #9844 and #8994 This mr fixes the above two problems, for #9844, because our previous logic is to only think that the minimum html tag containing the current cursor is qualified, but the approach of nvim is to get the tag after the current cursor first, followed by the tag around the current cursor, so I modified the corresponding condition For #8994, the situation is a bit more complicated, in our previous implementation, we could only get the range of the object by a `cursor position`, but there are two possible cases for the html tag: When the current cursor length is 1, nvim will return the first tag after the current cursor, as described above When the current cursor length is greater than 1, nvim will return just the smallest tag that can cover the current selection So we may need to pass the current selection to the inside of the method, and the point alone is not enough to support us in calculating these conditions |
||
|---|---|---|
| .. | ||
| src | ||
| test_data | ||
| Cargo.toml | ||
| LICENSE-GPL | ||
| README.md | ||
This contains the code for Zed's Vim emulation mode.
Vim mode in Zed is supposed to primarily "do what you expect": it mostly tries to copy vim exactly, but will use Zed-specific functionality when available to make things smoother. This means Zed will never be 100% vim compatible, but should be 100% vim familiar!
The backlog is maintained in the #vim channel notes.
Testing against Neovim
If you are making a change to make Zed's behaviour more closely match vim/nvim, you can create a test using the NeovimBackedTestContext.
For example, the following test checks that Zed and Neovim have the same behaviour when running * in visual mode:
#[gpui::test]
async fn test_visual_star_hash(cx: &mut gpui::TestAppContext) {
let mut cx = NeovimBackedTestContext::new(cx).await;
cx.set_shared_state("ˇa.c. abcd a.c. abcd").await;
cx.simulate_shared_keystrokes(["v", "3", "l", "*"]).await;
cx.assert_shared_state("a.c. abcd ˇa.c. abcd").await;
}
To keep CI runs fast, by default the neovim tests use a cached JSON file that records what neovim did (see crates/vim/test_data), but while developing this test you'll need to run it with the neovim flag enabled:
cargo test -p vim --features neovim test_visual_star_hash
This will run your keystrokes against a headless neovim and cache the results in the test_data directory.
Testing zed-only behaviour
Zed does more than vim/neovim in their default modes. The VimTestContext can be used instead. This lets you test integration with the language server and other parts of zed's UI that don't have a NeoVim equivalent.