cargo: Don't strip release binary (#1916)

* cargo: Don't strip release binary

because the lack of debug symbols makes the panic backtrace completely
useless. It will show a long list of unknown locations then.

Except for a minor space saving of 3-4 MB, debug symbols don't have any
negative side-effects for our application that we're aware of.

* changelog: Add PR #1916

Don't strip debug symbols from release binaries so the backtraces
contain the function names involved.

* cargo: Explicitly keep debug symbols

and add a comment explaining why.
This commit is contained in:
har7an 2022-11-09 08:40:02 +00:00 committed by GitHub
parent 48bc2281c7
commit 5975af6e42
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions

View File

@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* debugging: Improve error logging in server (https://github.com/zellij-org/zellij/pull/1881)
* docs: add kanagawa theme (https://github.com/zellij-org/zellij/pull/1913)
* fix: use 'temp_dir' instead of hard-coded '/tmp/' (https://github.com/zellij-org/zellij/pull/1898)
* debugging: Don't strip debug symbols from release binaries (https://github.com/zellij-org/zellij/pull/1916)
## [0.32.0] - 2022-10-25

View File

@ -45,7 +45,8 @@ members = [
[profile.release]
lto = true
strip = true
# Keep debug symbols so we see function names in backtraces
strip = false
[package.metadata.deb]
depends = "$auto"