From 0c570a52f56e61505d0eb1893b4bc19df651f611 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Tue, 29 Jun 2021 23:46:00 -0700 Subject: [PATCH 01/18] feat: Add logger to Zellij We add log4rs create for logging across Zellij. Additionally, we capture `stderr` output from plugins and log it the same log file as other Zellij logs. --- Cargo.lock | 301 +++++++++++++++++++++----- Cargo.toml | 1 + default-plugins/strider/src/main.rs | 3 + src/main.rs | 3 + zellij-server/Cargo.toml | 5 + zellij-server/src/decorating_pipe.rs | 94 ++++++++ zellij-server/src/lib.rs | 3 + zellij-server/src/wasm_vm.rs | 9 +- zellij-tile/Cargo.toml | 1 + zellij-utils/Cargo.toml | 3 + zellij-utils/assets/config/log4rs.yml | 42 ++++ zellij-utils/src/logging.rs | 10 +- 12 files changed, 416 insertions(+), 59 deletions(-) create mode 100644 zellij-server/src/decorating_pipe.rs create mode 100644 zellij-utils/assets/config/log4rs.yml diff --git a/Cargo.lock b/Cargo.lock index a2c525d65..1a51077b7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -17,6 +17,15 @@ version = "1.0.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "f26201604c87b1e01bd3d98f8d5d9a8fcbb815e8cedb41ffccbeb4bf593a35fe" +[[package]] +name = "aho-corasick" +version = "0.7.18" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "1e37cfd5e7657ada45f742d6e99ca5788580b5c529dc78faf11ece6dc702656f" +dependencies = [ + "memchr", +] + [[package]] name = "ansi_term" version = "0.11.0" @@ -35,6 +44,18 @@ dependencies = [ "winapi", ] +[[package]] +name = "anyhow" +version = "1.0.41" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "15af2628f6890fe2609a3b91bef4c83450512802e59489f9c1cb1fa5df064a61" + +[[package]] +name = "arc-swap" +version = "0.4.8" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "dabe5a181f83789739c194cbe5a897dde195078fac08568d09221fd6137a7ba8" + [[package]] name = "arrayvec" version = "0.5.2" @@ -216,7 +237,7 @@ dependencies = [ "cfg-if 1.0.0", "libc", "miniz_oxide", - "object 0.25.2", + "object 0.25.3", "rustc-demangle", ] @@ -297,6 +318,19 @@ version = "1.0.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd" +[[package]] +name = "chrono" +version = "0.4.19" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "670ad68c9088c2a963aaa298cb369688cf3f9465ce5e2d4ca10e6e0098a1ce73" +dependencies = [ + "libc", + "num-integer", + "num-traits", + "time", + "winapi", +] + [[package]] name = "clap" version = "2.33.3" @@ -582,6 +616,17 @@ dependencies = [ "syn", ] +[[package]] +name = "derivative" +version = "2.2.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "fcc3dd5e9e9c0b295d6e1e4d811fb6f157d5ffd784b8d202fc62eac8035a770b" +dependencies = [ + "proc-macro2", + "quote", + "syn", +] + [[package]] name = "directories-next" version = "2.0.0" @@ -644,9 +689,9 @@ dependencies = [ [[package]] name = "erased-serde" -version = "0.3.15" +version = "0.3.16" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e5b36e6f2295f393f44894c6031f67df4d185b984cd54d08f768ce678007efcd" +checksum = "3de9ad4541d99dc22b59134e7ff8dc3d6c988c89ecd7324bf10a8362b07a2afa" dependencies = [ "serde", ] @@ -866,9 +911,9 @@ dependencies = [ [[package]] name = "hashbrown" -version = "0.9.1" +version = "0.11.2" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "d7afe4a420e3fe79967a00898cc1f4db7c8a49a9333a29f8a4bd76a253d5cd04" +checksum = "ab5ef0d4909ef3724cc8cce6ccc8572c5c817592e9285f5464f8e86f8bd3726e" [[package]] name = "heck" @@ -881,13 +926,19 @@ dependencies = [ [[package]] name = "hermit-abi" -version = "0.1.18" +version = "0.1.19" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "322f4de77956e22ed0e5032c359a0f1273f1f7f0d79bfa3b8ffbc730d7fbcc5c" +checksum = "62b467343b94ba476dcb2500d242dadbb39557df889310ac77c5d99100aaac33" dependencies = [ "libc", ] +[[package]] +name = "humantime" +version = "2.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9a3a5bfb195931eeb336b2a7b4d761daec841b97f947d34394601737a7bba5e4" + [[package]] name = "ident_case" version = "1.0.1" @@ -896,9 +947,9 @@ checksum = "b9e0384b61958566e926dc50660321d12159025e767c18e043daf26b70104c39" [[package]] name = "indexmap" -version = "1.6.2" +version = "1.7.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "824845a0bf897a9042383849b02c1bc219c2383772efcd5c6f9766fa4b81aef3" +checksum = "bc633605454125dec4b66843673f01c7df2b89479b32e0ed634e43a91cff62a5" dependencies = [ "autocfg", "hashbrown", @@ -1013,9 +1064,9 @@ checksum = "3576a87f2ba00f6f106fdfcd16db1d698d648a26ad8e0573cad8537c3c362d2a" [[package]] name = "libc" -version = "0.2.95" +version = "0.2.97" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "789da6d93f1b866ffe175afc5322a4d76c038605a1c3319bb57b06967ca98a36" +checksum = "12b8adadd720df158f4d70dfe7ccc6adb0472d7c55ca83445f6a5ab3e36f8fb6" [[package]] name = "libloading" @@ -1084,9 +1135,43 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "51b9bbe6c47d51fc3e1a9b945965946b4c44142ab8792c50835a980d362c2710" dependencies = [ "cfg-if 1.0.0", + "serde", "value-bag", ] +[[package]] +name = "log-mdc" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "a94d21414c1f4a51209ad204c1776a3d0765002c76c6abcb602a6f09f1e881c7" + +[[package]] +name = "log4rs" +version = "1.0.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "d1572a880d1115ff867396eee7ae2bc924554225e67a0d3c85c745b3e60ca211" +dependencies = [ + "anyhow", + "arc-swap", + "chrono", + "derivative", + "fnv", + "humantime", + "libc", + "log", + "log-mdc", + "parking_lot 0.11.1", + "regex", + "serde", + "serde-value", + "serde_json", + "serde_yaml", + "thiserror", + "thread-id", + "typemap", + "winapi", +] + [[package]] name = "mach" version = "0.3.2" @@ -1132,9 +1217,9 @@ dependencies = [ [[package]] name = "mio" -version = "0.7.11" +version = "0.7.13" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "cf80d3e903b34e0bd7282b218398aec54e082c840d9baf8339e0080a0c542956" +checksum = "8c2bdb6314ec10835cd3293dd268473a835c02b7b352e788be788b3c6ca6bb16" dependencies = [ "libc", "log", @@ -1188,6 +1273,25 @@ dependencies = [ "winapi", ] +[[package]] +name = "num-integer" +version = "0.1.44" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "d2cc698a63b549a70bc047073d2949cce27cd1c7b0a4a862d08a8031bc2801db" +dependencies = [ + "autocfg", + "num-traits", +] + +[[package]] +name = "num-traits" +version = "0.2.14" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9a64b1ec5cda2586e284722486d802acf1f7dbdc623e2bfc57e65ca1cd099290" +dependencies = [ + "autocfg", +] + [[package]] name = "num_cpus" version = "1.13.0" @@ -1216,24 +1320,24 @@ dependencies = [ [[package]] name = "object" -version = "0.25.2" +version = "0.25.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f8bc1d42047cf336f0f939c99e97183cf31551bf0f2865a2ec9c8d91fd4ffb5e" +checksum = "a38f2be3697a57b4060074ff41b44c16870d916ad7877c17696e063257482bc7" dependencies = [ "memchr", ] [[package]] name = "once_cell" -version = "1.7.2" +version = "1.8.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "af8b08b04175473088b46763e51ee54da5f9a164bc162f615b91bc179dbf15a3" +checksum = "692fcb63b64b1758029e0a96ee63e049ce8c5948587f2f7208df04625e5f6b56" [[package]] name = "openssl-sys" -version = "0.9.63" +version = "0.9.65" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b6b0d6fb7d80f877617dfcb014e605e2b5ab2fb0afdf27935219bb6bd984cb98" +checksum = "7a7907e3bfa08bb85105209cdfcb6c63d109f8f6c1ed6ca318fff5c1853fbc1d" dependencies = [ "autocfg", "cc", @@ -1242,6 +1346,15 @@ dependencies = [ "vcpkg", ] +[[package]] +name = "ordered-float" +version = "2.5.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f100fcfb41e5385e0991f74981732049f9b896821542a219420491046baafdc2" +dependencies = [ + "num-traits", +] + [[package]] name = "parking" version = "2.0.0" @@ -1292,16 +1405,16 @@ dependencies = [ "cfg-if 1.0.0", "instant", "libc", - "redox_syscall 0.2.8", + "redox_syscall 0.2.9", "smallvec", "winapi", ] [[package]] name = "pin-project-lite" -version = "0.2.6" +version = "0.2.7" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "dc0e1f259c92177c30a4c9d177246edd0a3568b25756a977d0632cf8fa37e905" +checksum = "8d31d11c69a6b52a174b42bdc0c30e5e11670f90788b2c471c31c1d17d449443" [[package]] name = "pin-utils" @@ -1317,14 +1430,14 @@ checksum = "3831453b3449ceb48b6d9c7ad7c96d5ea673e9b470a1dc578c2ce6521230884c" [[package]] name = "polling" -version = "2.0.3" +version = "2.1.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "4fc12d774e799ee9ebae13f4076ca003b40d18a11ac0f3641e6f899618580b7b" +checksum = "92341d779fa34ea8437ef4d82d440d5e1ce3f3ff7f824aa64424cd481f9a1f25" dependencies = [ "cfg-if 1.0.0", "libc", "log", - "wepoll-sys", + "wepoll-ffi", "winapi", ] @@ -1423,24 +1536,24 @@ dependencies = [ [[package]] name = "rand" -version = "0.8.3" +version = "0.8.4" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "0ef9e7e66b4468674bfcb0c81af8b7fa0bb154fa9f28eb840da5c447baeb8d7e" +checksum = "2e7573632e6454cf6b99d7aac4ccca54be06da05aca2ef7423d22d27d4d4bcd8" dependencies = [ "libc", "rand_chacha", - "rand_core 0.6.2", + "rand_core 0.6.3", "rand_hc", ] [[package]] name = "rand_chacha" -version = "0.3.0" +version = "0.3.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e12735cf05c9e10bf21534da50a147b924d555dc7a547c42e6bb2d5b6017ae0d" +checksum = "e6c10a63a0fa32252be49d21e7709d4d4baf8d231c2dbce1eaa8141b9b127d88" dependencies = [ "ppv-lite86", - "rand_core 0.6.2", + "rand_core 0.6.3", ] [[package]] @@ -1460,20 +1573,20 @@ checksum = "9c33a3c44ca05fa6f1807d8e6743f3824e8509beca625669633be0acbdf509dc" [[package]] name = "rand_core" -version = "0.6.2" +version = "0.6.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "34cf66eb183df1c5876e2dcf6b13d57340741e8dc255b48e40a26de954d06ae7" +checksum = "d34f1408f55294453790c48b2f1ebbb1c5b4b7563eb1f418bcfcfdbb06ebb4e7" dependencies = [ "getrandom", ] [[package]] name = "rand_hc" -version = "0.3.0" +version = "0.3.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "3190ef7066a446f2e7f42e239d161e905420ccab01eb967c9eb27d21b2322a73" +checksum = "d51e9f596de227fda2ea6c84607f5558e196eeaf43c986b724ba4fb8fdf497e7" dependencies = [ - "rand_core 0.6.2", + "rand_core 0.6.3", ] [[package]] @@ -1518,9 +1631,9 @@ checksum = "41cc0f7e4d5d4544e8861606a285bb08d3e70712ccc7d2b84d7c0ccfaf4b05ce" [[package]] name = "redox_syscall" -version = "0.2.8" +version = "0.2.9" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "742739e41cd49414de871ea5e549afb7e2a3ac77b589bcbebe8c82fab37147fc" +checksum = "5ab49abadf3f9e1c4bc499e8845e152ad87d2ad2d30371841171169e9d75feee" dependencies = [ "bitflags", ] @@ -1531,7 +1644,7 @@ version = "0.1.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "8440d8acb4fd3d277125b4bd01a6f38aee8d814b3b5fc09b3f2b825d37d3fe8f" dependencies = [ - "redox_syscall 0.2.8", + "redox_syscall 0.2.9", ] [[package]] @@ -1541,7 +1654,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "528532f3d801c87aec9def2add9ca802fe569e44a544afe633765267840abe64" dependencies = [ "getrandom", - "redox_syscall 0.2.8", + "redox_syscall 0.2.9", ] [[package]] @@ -1555,6 +1668,23 @@ dependencies = [ "smallvec", ] +[[package]] +name = "regex" +version = "1.5.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "d07a8629359eb56f1e2fb1652bb04212c072a87ba68546a04065d525673ac461" +dependencies = [ + "aho-corasick", + "memchr", + "regex-syntax", +] + +[[package]] +name = "regex-syntax" +version = "0.6.25" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f497285884f3fcff424ffc933e56d7cbca511def0c9831a7f9b5f6153e3cc89b" + [[package]] name = "region" version = "2.2.0" @@ -1578,9 +1708,9 @@ dependencies = [ [[package]] name = "rustc-demangle" -version = "0.1.19" +version = "0.1.20" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "410f7acf3cb3a44527c5d9546bad4bf4e6c460915d5f9f2fc524498bfe8f70ce" +checksum = "dead70b0b5e03e9c814bcb6b01e03e68f7c57a80aa48c72ec92152ab3e818d49" [[package]] name = "rustc-hash" @@ -1609,6 +1739,16 @@ dependencies = [ "serde_derive", ] +[[package]] +name = "serde-value" +version = "0.7.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f3a1a3341211875ef120e117ea7fd5228530ae7e7036a779fdc9117be6b3282c" +dependencies = [ + "ordered-float", + "serde", +] + [[package]] name = "serde_bytes" version = "0.11.5" @@ -1821,9 +1961,9 @@ dependencies = [ [[package]] name = "syn" -version = "1.0.72" +version = "1.0.73" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "a1e8cdbefb79a9a5a65e0db8b47b723ee907b7c7f8496c76a1770b5c310bab82" +checksum = "f71489ff30030d2ae598524f61326b902466f72a0fb1a8564c001cc63425bcc7" dependencies = [ "proc-macro2", "quote", @@ -1854,8 +1994,8 @@ checksum = "dac1c663cfc93810f88aed9b8941d48cabf856a1b111c29a40439018d870eb22" dependencies = [ "cfg-if 1.0.0", "libc", - "rand 0.8.3", - "redox_syscall 0.2.8", + "rand 0.8.4", + "redox_syscall 0.2.9", "remove_dir_all", "winapi", ] @@ -1889,7 +2029,7 @@ checksum = "077185e2eac69c3f8379a4298e1e07cd36beb962290d4a51199acf0fdc10607e" dependencies = [ "libc", "numtoa", - "redox_syscall 0.2.8", + "redox_syscall 0.2.9", "redox_termios", ] @@ -1922,6 +2062,17 @@ dependencies = [ "syn", ] +[[package]] +name = "thread-id" +version = "3.3.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "c7fbf4c9d56b320106cd64fd024dadfa0be7cb4706725fc44a7d7ce952d820c1" +dependencies = [ + "libc", + "redox_syscall 0.1.57", + "winapi", +] + [[package]] name = "time" version = "0.1.43" @@ -1965,6 +2116,21 @@ dependencies = [ "lazy_static", ] +[[package]] +name = "traitobject" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "efd1f82c56340fdf16f2a953d7bda4f8fdffba13d93b00844c25572110b26079" + +[[package]] +name = "typemap" +version = "0.3.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "653be63c80a3296da5551e1bfd2cca35227e13cdd08c6668903ae2f4f77aa1f6" +dependencies = [ + "unsafe-any", +] + [[package]] name = "typetag" version = "0.1.7" @@ -2007,6 +2173,15 @@ version = "0.2.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "8ccb82d61f80a663efe1f787a51b16b5a51e3314d6ac365b08639f52387b33f3" +[[package]] +name = "unsafe-any" +version = "0.4.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f30360d7979f5e9c6e6cea48af192ea8fab4afb3cf72597154b8f08935bc9c7f" +dependencies = [ + "traitobject", +] + [[package]] name = "utf8parse" version = "0.1.1" @@ -2037,9 +2212,9 @@ dependencies = [ [[package]] name = "vcpkg" -version = "0.2.13" +version = "0.2.15" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "025ce40a007e1907e58d5bc1a594def78e5573bb0b1160bc389634e8f12e4faa" +checksum = "accd4ea62f7bb7a82fe23066fb0957d48ef677f6eeb8215f372f52e48bb32426" [[package]] name = "vec_map" @@ -2102,6 +2277,8 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d54ee1d4ed486f78874278e63e4069fc1ab9f6a18ca492076ffb90c5eb2997fd" dependencies = [ "cfg-if 1.0.0", + "serde", + "serde_json", "wasm-bindgen-macro", ] @@ -2363,18 +2540,18 @@ checksum = "87cc2fe6350834b4e528ba0901e7aa405d78b89dc1fa3145359eb4de0e323fcf" [[package]] name = "wast" -version = "35.0.2" +version = "36.0.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "2ef140f1b49946586078353a453a1d28ba90adfc54dde75710bc1931de204d68" +checksum = "8b5d7ba374a364571da1cb0a379a3dc302582a2d9937a183bfe35b68ad5bb9c4" dependencies = [ "leb128", ] [[package]] name = "wat" -version = "1.0.37" +version = "1.0.38" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8ec280a739b69173e0ffd12c1658507996836ba4e992ed9bc1e5385a0bd72a02" +checksum = "16383df7f0e3901484c2dda6294ed6895caa3627ce4f6584141dcf30a33a23e6" dependencies = [ "wast", ] @@ -2390,10 +2567,10 @@ dependencies = [ ] [[package]] -name = "wepoll-sys" -version = "3.0.1" +name = "wepoll-ffi" +version = "0.1.2" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "0fcb14dea929042224824779fbc82d9fab8d2e6d3cbc0ac404de8edf489e77ff" +checksum = "d743fdedc5c64377b5fc2bc036b01c7fd642205a0d96356034ae3404d49eb7fb" dependencies = [ "cc", ] @@ -2444,8 +2621,9 @@ name = "zellij" version = "0.14.0" dependencies = [ "insta", + "log", "names", - "rand 0.8.3", + "rand 0.8.4", "ssh2", "zellij-client", "zellij-server", @@ -2469,8 +2647,13 @@ dependencies = [ "cassowary", "daemonize", "insta", + "log", + "serde", + "serde_derive", "serde_json", + "typetag", "unicode-width", + "wasm-bindgen", "wasmer", "wasmer-wasi", "zellij-utils", @@ -2480,6 +2663,7 @@ dependencies = [ name = "zellij-tile" version = "0.14.0" dependencies = [ + "log", "serde", "serde_json", "strum", @@ -2506,6 +2690,8 @@ dependencies = [ "interprocess", "lazy_static", "libc", + "log", + "log4rs", "nix", "once_cell", "serde", @@ -2516,6 +2702,7 @@ dependencies = [ "strum", "tempfile", "termion", + "typetag", "vte 0.10.1", "zellij-tile", ] diff --git a/Cargo.toml b/Cargo.toml index 165254525..b14e70959 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -17,6 +17,7 @@ names = "0.11.0" zellij-client = { path = "zellij-client/", version = "0.14.0" } zellij-server = { path = "zellij-server/", version = "0.14.0" } zellij-utils = { path = "zellij-utils/", version = "0.14.0" } +log = "0.4.14" [dev-dependencies] insta = { version = "1.6.0", features = ["backtrace"] } diff --git a/default-plugins/strider/src/main.rs b/default-plugins/strider/src/main.rs index 8edc1e197..d73f674ff 100644 --- a/default-plugins/strider/src/main.rs +++ b/default-plugins/strider/src/main.rs @@ -9,11 +9,14 @@ register_plugin!(State); impl ZellijPlugin for State { fn load(&mut self) { + dbg!("hello from load"); refresh_directory(self); subscribe(&[EventType::KeyPress]); } fn update(&mut self, event: Event) { + dbg!("hello from update"); + if let Event::KeyPress(key) = event { match key { Key::Up | Key::Char('k') => { diff --git a/src/main.rs b/src/main.rs index 6bcfa8723..67b9419b3 100644 --- a/src/main.rs +++ b/src/main.rs @@ -4,6 +4,7 @@ mod sessions; mod tests; use crate::install::populate_data_dir; +use log::info; use sessions::{assert_session, assert_session_ne, get_active_session, list_sessions}; use std::convert::TryFrom; use std::process; @@ -21,6 +22,8 @@ use zellij_utils::{ }; pub fn main() { + configure_logger(); + info!("Hello Zellij!"); let opts = CliArgs::from_args(); if let Some(Command::Sessions(Sessions::ListSessions)) = opts.command { diff --git a/zellij-server/Cargo.toml b/zellij-server/Cargo.toml index 1a99bb40d..d06745de3 100644 --- a/zellij-server/Cargo.toml +++ b/zellij-server/Cargo.toml @@ -16,8 +16,13 @@ serde_json = "1.0" unicode-width = "0.1.8" wasmer = "1.0.0" wasmer-wasi = "1.0.0" +wasm-bindgen = { version = "0.2", features = ["serde-serialize"] } cassowary = "0.3.0" zellij-utils = { path = "../zellij-utils/", version = "0.14.0" } +log = "0.4.14" +serde_derive = "1.0.80" +serde = "1.0.126" +typetag = "0.1.7" [dev-dependencies] insta = "1.6.0" diff --git a/zellij-server/src/decorating_pipe.rs b/zellij-server/src/decorating_pipe.rs new file mode 100644 index 000000000..4b95c57b8 --- /dev/null +++ b/zellij-server/src/decorating_pipe.rs @@ -0,0 +1,94 @@ +use std::{ + collections::VecDeque, + io::{Read, Seek, Write}, +}; + +use log::info; +use serde::{Deserialize, Serialize}; +use wasmer_wasi::{WasiFile, WasiFsError}; + +#[derive(Debug, Serialize, Deserialize)] +pub struct DecoratingPipe { + buffer: VecDeque, + plugin_name: String, +} + +impl DecoratingPipe { + pub fn new(plugin_name: &str) -> DecoratingPipe { + info!("Creating decorating pipe!"); + dbg!("Creating the decorating pipe :)"); + DecoratingPipe { + buffer: VecDeque::new(), + plugin_name: String::from(plugin_name), + } + } +} + +impl Read for DecoratingPipe { + fn read(&mut self, buf: &mut [u8]) -> std::io::Result { + let amt = std::cmp::min(buf.len(), self.buffer.len()); + for (i, byte) in self.buffer.drain(..amt).enumerate() { + buf[i] = byte; + } + Ok(amt) + } +} + +// TODO: do this better. We're not sure about byte boundaries and endl stuff but, we do expect +// to get the valid thing eventually +impl Write for DecoratingPipe { + fn write(&mut self, buf: &[u8]) -> std::io::Result { + self.buffer.extend(buf); + let current_chunk = std::str::from_utf8(buf).unwrap(); + for c in current_chunk.chars() { + if c == '\n' { + info!( + "{}: {}", + self.plugin_name, + std::str::from_utf8(&self.buffer.make_contiguous().split_last().unwrap().1) + .unwrap() + ); + self.buffer.clear(); + } + } + Ok(buf.len()) + } + fn flush(&mut self) -> std::io::Result<()> { + Ok(()) + } +} + +impl Seek for DecoratingPipe { + fn seek(&mut self, _pos: std::io::SeekFrom) -> std::io::Result { + Err(std::io::Error::new( + std::io::ErrorKind::Other, + "can not seek in a pipe", + )) + } +} + +#[typetag::serde] +impl WasiFile for DecoratingPipe { + fn last_accessed(&self) -> u64 { + 0 + } + fn last_modified(&self) -> u64 { + 0 + } + fn created_time(&self) -> u64 { + 0 + } + fn size(&self) -> u64 { + self.buffer.len() as u64 + } + fn set_len(&mut self, len: u64) -> Result<(), WasiFsError> { + self.buffer.resize(len as usize, 0); + Ok(()) + } + fn unlink(&mut self) -> Result<(), WasiFsError> { + Ok(()) + } + fn bytes_available(&self) -> Result { + Ok(self.buffer.len()) + } +} diff --git a/zellij-server/src/lib.rs b/zellij-server/src/lib.rs index 27872b64e..9ea35e23f 100644 --- a/zellij-server/src/lib.rs +++ b/zellij-server/src/lib.rs @@ -2,6 +2,7 @@ pub mod os_input_output; pub mod panes; pub mod tab; +mod decorating_pipe; mod pty; mod route; mod screen; @@ -9,6 +10,7 @@ mod thread_bus; mod ui; mod wasm_vm; +use log::info; use zellij_utils::zellij_tile; use std::path::PathBuf; @@ -108,6 +110,7 @@ pub(crate) enum SessionState { } pub fn start_server(os_input: Box, socket_path: PathBuf) { + info!("starts server"); #[cfg(not(any(feature = "test", test)))] daemonize::Daemonize::new() .working_directory(std::env::current_dir().unwrap()) diff --git a/zellij-server/src/wasm_vm.rs b/zellij-server/src/wasm_vm.rs index 62198d685..14823e527 100644 --- a/zellij-server/src/wasm_vm.rs +++ b/zellij-server/src/wasm_vm.rs @@ -1,5 +1,8 @@ +use log::info; +use serde::{de::DeserializeOwned, Serialize}; use std::collections::{HashMap, HashSet}; use std::fs; +use std::io::{Read, Write}; use std::path::PathBuf; use std::process; use std::str::FromStr; @@ -9,7 +12,6 @@ use std::time::{Duration, Instant}; use zellij_utils::{serde, zellij_tile}; -use serde::{de::DeserializeOwned, Serialize}; use wasmer::{ imports, ChainableNamedResolver, Function, ImportObject, Instance, Module, Store, Value, WasmerEnv, @@ -18,6 +20,7 @@ use wasmer_wasi::{Pipe, WasiEnv, WasiState}; use zellij_tile::data::{Event, EventType, PluginIds}; use crate::{ + decorating_pipe::DecoratingPipe, panes::PaneId, pty::PtyInstruction, screen::ScreenInstruction, @@ -56,6 +59,7 @@ pub(crate) struct PluginEnv { // Thread main -------------------------------------------------------------------------------------------------------- pub(crate) fn wasm_thread_main(bus: Bus, store: Store, data_dir: PathBuf) { + info!("Wasm create thread :))"); let mut plugin_id = 0; let mut plugin_map = HashMap::new(); loop { @@ -74,6 +78,8 @@ pub(crate) fn wasm_thread_main(bus: Bus, store: Store, data_d let output = Pipe::new(); let input = Pipe::new(); + let stderr = + DecoratingPipe::new(path.as_path().file_name().unwrap().to_str().unwrap()); let mut wasi_env = WasiState::new("Zellij") .env("CLICOLOR_FORCE", "1") .preopen(|p| { @@ -86,6 +92,7 @@ pub(crate) fn wasm_thread_main(bus: Bus, store: Store, data_d .unwrap() .stdin(Box::new(input)) .stdout(Box::new(output)) + .stderr(Box::new(stderr)) .finalize() .unwrap(); diff --git a/zellij-tile/Cargo.toml b/zellij-tile/Cargo.toml index 93bc3a617..a2aaab1ff 100644 --- a/zellij-tile/Cargo.toml +++ b/zellij-tile/Cargo.toml @@ -11,3 +11,4 @@ serde = { version = "1.0", features = ["derive"] } serde_json = "1.0" strum = "0.20.0" strum_macros = "0.20.0" +log = "0.4.14" diff --git a/zellij-utils/Cargo.toml b/zellij-utils/Cargo.toml index 16aab07d6..42a74d540 100644 --- a/zellij-utils/Cargo.toml +++ b/zellij-utils/Cargo.toml @@ -28,6 +28,9 @@ strum = "0.20.0" termion = "1.5.0" vte = "0.10.1" zellij-tile = { path = "../zellij-tile/", version = "0.14.0" } +log = "0.4.14" +typetag = "0.1.7" +log4rs = "1.0.0" [dependencies.async-std] version = "1.3.0" diff --git a/zellij-utils/assets/config/log4rs.yml b/zellij-utils/assets/config/log4rs.yml new file mode 100644 index 000000000..a10aec55b --- /dev/null +++ b/zellij-utils/assets/config/log4rs.yml @@ -0,0 +1,42 @@ +# Scan this file for changes every 30 seconds +refresh_rate: 30 seconds + +appenders: + # An appender named "stdout" that writes to stdout + stderr: + kind: console + target: stderr + + logFile: + kind: file + path: "zellij.log" + append: false + encoder: + pattern: "{h(|{M}| {d} {l} [{T}] [{f}:{L}]: {m})} {n}" + + logPlugin: + kind: file + path: "zellij.log" + encoder: + pattern: "{m} {n}" + + # An appender named "requests" that writes to a file with a custom pattern encoder + requests: + kind: file + path: "requests.log" + encoder: + pattern: "{d} - {m}{n}" + +# Set the default logging level to "warn" and attach the "stdout" appender to the root +root: + level: info + appenders: + - logFile + +loggers: + # Raise the maximum log level for events sent to the "app::backend::db" logger to "info" + zellij_server::decorating_pipe: + level: trace + appenders: + - logPlugin + additive: false diff --git a/zellij-utils/src/logging.rs b/zellij-utils/src/logging.rs index 6d415e38f..eb7361422 100644 --- a/zellij-utils/src/logging.rs +++ b/zellij-utils/src/logging.rs @@ -1,15 +1,23 @@ //! Zellij logging utility functions. use std::{ - fs, + fs::{self, OpenOptions}, io::{self, prelude::*}, os::unix::io::RawFd, path::{Path, PathBuf}, + thread, }; +use log::info; + use crate::consts::{ZELLIJ_TMP_LOG_DIR, ZELLIJ_TMP_LOG_FILE}; use crate::shared::set_permissions; +pub fn configure_logger() { + log4rs::init_file("zellij-utils/assets/config/log4rs.yml", Default::default()).unwrap(); + info!("Zellij logger initialized"); +} + pub fn atomic_create_file(file_name: &Path) -> io::Result<()> { let _ = fs::OpenOptions::new() .append(true) From 13dd44557449919ca434ca2c919dc4b8e4d09bf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Tue, 6 Jul 2021 23:41:37 -0700 Subject: [PATCH 02/18] Some progress on decorating pipe. Add some logic to handle endl in plugin messages. Basic logging from plugins works now. --- default-plugins/status-bar/src/main.rs | 1 + default-plugins/strider/src/main.rs | 1 + zellij-server/src/decorating_pipe.rs | 72 +++++++++++++++++++++----- zellij-tile/src/lib.rs | 1 + 4 files changed, 61 insertions(+), 14 deletions(-) diff --git a/default-plugins/status-bar/src/main.rs b/default-plugins/status-bar/src/main.rs index 83eb50c9a..e9e60fc39 100644 --- a/default-plugins/status-bar/src/main.rs +++ b/default-plugins/status-bar/src/main.rs @@ -133,6 +133,7 @@ fn color_elements(palette: Palette) -> ColoredElements { impl ZellijPlugin for State { fn load(&mut self) { + dbg!("hello from load"); set_selectable(false); set_invisible_borders(true); set_fixed_height(2); diff --git a/default-plugins/strider/src/main.rs b/default-plugins/strider/src/main.rs index d73f674ff..7d80f014a 100644 --- a/default-plugins/strider/src/main.rs +++ b/default-plugins/strider/src/main.rs @@ -10,6 +10,7 @@ register_plugin!(State); impl ZellijPlugin for State { fn load(&mut self) { dbg!("hello from load"); + dbg!("hello from load2?"); refresh_directory(self); subscribe(&[EventType::KeyPress]); } diff --git a/zellij-server/src/decorating_pipe.rs b/zellij-server/src/decorating_pipe.rs index 4b95c57b8..fb02ce6a2 100644 --- a/zellij-server/src/decorating_pipe.rs +++ b/zellij-server/src/decorating_pipe.rs @@ -3,9 +3,10 @@ use std::{ io::{Read, Seek, Write}, }; -use log::info; +use log::{error, info}; use serde::{Deserialize, Serialize}; use wasmer_wasi::{WasiFile, WasiFsError}; +use zellij_utils::logging::debug_log_to_file; #[derive(Debug, Serialize, Deserialize)] pub struct DecoratingPipe { @@ -16,7 +17,7 @@ pub struct DecoratingPipe { impl DecoratingPipe { pub fn new(plugin_name: &str) -> DecoratingPipe { info!("Creating decorating pipe!"); - dbg!("Creating the decorating pipe :)"); + debug_log_to_file("Creating decorating pipe!".to_string()).expect("xd"); DecoratingPipe { buffer: VecDeque::new(), plugin_name: String::from(plugin_name), @@ -39,21 +40,64 @@ impl Read for DecoratingPipe { impl Write for DecoratingPipe { fn write(&mut self, buf: &[u8]) -> std::io::Result { self.buffer.extend(buf); - let current_chunk = std::str::from_utf8(buf).unwrap(); - for c in current_chunk.chars() { - if c == '\n' { - info!( - "{}: {}", - self.plugin_name, - std::str::from_utf8(&self.buffer.make_contiguous().split_last().unwrap().1) - .unwrap() - ); - self.buffer.clear(); - } - } + + debug_log_to_file(format!( + "Write called for {}, currentChunk: {}", + self.plugin_name, + std::str::from_utf8(buf).unwrap() + )) + .expect("xd2"); + Ok(buf.len()) } + + // When we flush, check if current buffer is valid utf8 string, split by '\n' and truncate buffer in the process. + // We assume that, eventually, flush will be called on valid string boundary (i.e. std::str::from_utf8(..).is_ok() returns true at some point). + // Above assumption might not be true, in which case we'll have to think about it. Also, at some point we might actually require some synchronization + // between write and flush (i.e. concurrent writes and flushes?). Make it simple for now. fn flush(&mut self) -> std::io::Result<()> { + debug_log_to_file(format!( + "Flush called for {}, buffer: {:?}", + self.plugin_name, self.buffer + )) + .expect("xd3"); + + self.buffer.make_contiguous(); + + if let Ok(converted_string) = std::str::from_utf8(self.buffer.as_slices().0) { + if converted_string.contains('\n') { + let mut consumed_bytes = 0; + let mut split_msg = converted_string.split('\n').peekable(); + debug_log_to_file(format!( + "Back: {}, len: {}, convertedString: {}", + split_msg.clone().collect::(), + split_msg.clone().count(), + converted_string + )) + .expect("xD"); + while let Some(msg) = split_msg.next() { + if split_msg.peek().is_none() { + // Log last chunk iff the last char is endline. Otherwise do not do it. + if converted_string.chars().last().unwrap() == '\n' && !msg.is_empty() { + info!("special case: {}: {}", self.plugin_name, msg); + consumed_bytes += msg.len() + 1; + } + } else { + info!("normal case: {}: {}", self.plugin_name, msg); + consumed_bytes += msg.len() + 1; + } + } + drop(self.buffer.drain(..consumed_bytes)); + debug_log_to_file(format!( + "Consumed: {} bytes, buffer: {:?}", + consumed_bytes, self.buffer + )) + .expect("xd4"); + } + } else { + error!("Buffer conversion didn't work. This is unexpected"); + } + Ok(()) } } diff --git a/zellij-tile/src/lib.rs b/zellij-tile/src/lib.rs index af7d8ca12..176a94972 100644 --- a/zellij-tile/src/lib.rs +++ b/zellij-tile/src/lib.rs @@ -19,6 +19,7 @@ macro_rules! register_plugin { } fn main() { + dbg!("hello from plugin main :)"); STATE.with(|state| { state.borrow_mut().load(); }); From 46cac59d4cc10b3f48c9995d857b7fe54fdb6e1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Wed, 7 Jul 2021 22:54:38 -0700 Subject: [PATCH 03/18] Add unit tests for decorating pipe and clean it up a bit --- zellij-server/src/decorating_pipe.rs | 129 ++++++++++++++++++--------- 1 file changed, 89 insertions(+), 40 deletions(-) diff --git a/zellij-server/src/decorating_pipe.rs b/zellij-server/src/decorating_pipe.rs index fb02ce6a2..49517629a 100644 --- a/zellij-server/src/decorating_pipe.rs +++ b/zellij-server/src/decorating_pipe.rs @@ -6,7 +6,6 @@ use std::{ use log::{error, info}; use serde::{Deserialize, Serialize}; use wasmer_wasi::{WasiFile, WasiFsError}; -use zellij_utils::logging::debug_log_to_file; #[derive(Debug, Serialize, Deserialize)] pub struct DecoratingPipe { @@ -17,7 +16,6 @@ pub struct DecoratingPipe { impl DecoratingPipe { pub fn new(plugin_name: &str) -> DecoratingPipe { info!("Creating decorating pipe!"); - debug_log_to_file("Creating decorating pipe!".to_string()).expect("xd"); DecoratingPipe { buffer: VecDeque::new(), plugin_name: String::from(plugin_name), @@ -35,64 +33,37 @@ impl Read for DecoratingPipe { } } -// TODO: do this better. We're not sure about byte boundaries and endl stuff but, we do expect -// to get the valid thing eventually impl Write for DecoratingPipe { fn write(&mut self, buf: &[u8]) -> std::io::Result { self.buffer.extend(buf); - debug_log_to_file(format!( - "Write called for {}, currentChunk: {}", - self.plugin_name, - std::str::from_utf8(buf).unwrap() - )) - .expect("xd2"); - Ok(buf.len()) } // When we flush, check if current buffer is valid utf8 string, split by '\n' and truncate buffer in the process. - // We assume that, eventually, flush will be called on valid string boundary (i.e. std::str::from_utf8(..).is_ok() returns true at some point). - // Above assumption might not be true, in which case we'll have to think about it. Also, at some point we might actually require some synchronization - // between write and flush (i.e. concurrent writes and flushes?). Make it simple for now. + // We assume that eventually, flush will be called on valid string boundary (i.e. std::str::from_utf8(..).is_ok() returns true at some point). + // Above assumption might not be true, in which case we'll have to think about it. Make it simple for now. fn flush(&mut self) -> std::io::Result<()> { - debug_log_to_file(format!( - "Flush called for {}, buffer: {:?}", - self.plugin_name, self.buffer - )) - .expect("xd3"); - self.buffer.make_contiguous(); - if let Ok(converted_string) = std::str::from_utf8(self.buffer.as_slices().0) { - if converted_string.contains('\n') { + if let Ok(converted_buffer) = std::str::from_utf8(self.buffer.as_slices().0) { + if converted_buffer.contains('\n') { let mut consumed_bytes = 0; - let mut split_msg = converted_string.split('\n').peekable(); - debug_log_to_file(format!( - "Back: {}, len: {}, convertedString: {}", - split_msg.clone().collect::(), - split_msg.clone().count(), - converted_string - )) - .expect("xD"); - while let Some(msg) = split_msg.next() { - if split_msg.peek().is_none() { + let mut split_converted_buffer = converted_buffer.split('\n').peekable(); + + while let Some(msg) = split_converted_buffer.next() { + if split_converted_buffer.peek().is_none() { // Log last chunk iff the last char is endline. Otherwise do not do it. - if converted_string.chars().last().unwrap() == '\n' && !msg.is_empty() { - info!("special case: {}: {}", self.plugin_name, msg); + if converted_buffer.chars().last().unwrap() == '\n' && !msg.is_empty() { + info!("{}: {}", self.plugin_name, msg); consumed_bytes += msg.len() + 1; } } else { - info!("normal case: {}: {}", self.plugin_name, msg); + info!("{}: {}", self.plugin_name, msg); consumed_bytes += msg.len() + 1; } } drop(self.buffer.drain(..consumed_bytes)); - debug_log_to_file(format!( - "Consumed: {} bytes, buffer: {:?}", - consumed_bytes, self.buffer - )) - .expect("xd4"); } } else { error!("Buffer conversion didn't work. This is unexpected"); @@ -136,3 +107,81 @@ impl WasiFile for DecoratingPipe { Ok(self.buffer.len()) } } + +// Unit tests +#[cfg(test)] +mod decorating_pipe_test { + + use super::*; + + #[test] + fn write_without_endl_does_not_consume_buffer_after_flush() { + let mut pipe = DecoratingPipe::new("TestPipe"); + + let test_buffer = "Testing write".as_bytes(); + + pipe.write(test_buffer).expect("Err write"); + pipe.flush().expect("Err flush"); + + assert_eq!(pipe.buffer.len(), test_buffer.len()); + } + + #[test] + fn write_with_single_endl_at_the_end_consumes_whole_buffer_after_flush() { + let mut pipe = DecoratingPipe::new("TestPipe"); + + let test_buffer = "Testing write \n".as_bytes(); + + pipe.write(test_buffer).expect("Err write"); + pipe.flush().expect("Err flush"); + + assert_eq!(pipe.buffer.len(), 0); + } + + #[test] + fn write_with_endl_in_the_middle_consumes_buffer_up_to_endl_after_flush() { + let mut pipe = DecoratingPipe::new("TestPipe"); + + let test_buffer = "Testing write \n".as_bytes(); + let test_buffer2 = "And the rest".as_bytes(); + + pipe.write( + [ + test_buffer, + test_buffer, + test_buffer, + test_buffer, + test_buffer2, + ] + .concat() + .as_slice(), + ) + .expect("Err write"); + pipe.flush().expect("Err flush"); + + assert_eq!(pipe.buffer.len(), test_buffer2.len()); + } + + #[test] + fn write_with_many_endl_consumes_whole_buffer_after_flush() { + let mut pipe = DecoratingPipe::new("TestPipe"); + + let test_buffer = "Testing write \n".as_bytes(); + + pipe.write( + [ + test_buffer, + test_buffer, + test_buffer, + test_buffer, + test_buffer, + ] + .concat() + .as_slice(), + ) + .expect("Err write"); + pipe.flush().expect("Err flush"); + + assert_eq!(pipe.buffer.len(), 0); + } +} From 21b88281ce6d70d2473fdbf02b6642d67bba8a0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Wed, 7 Jul 2021 23:14:50 -0700 Subject: [PATCH 04/18] Add test case for malformed input and detect too long messages --- zellij-server/src/decorating_pipe.rs | 33 ++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/zellij-server/src/decorating_pipe.rs b/zellij-server/src/decorating_pipe.rs index 49517629a..0d5d2f518 100644 --- a/zellij-server/src/decorating_pipe.rs +++ b/zellij-server/src/decorating_pipe.rs @@ -7,6 +7,8 @@ use log::{error, info}; use serde::{Deserialize, Serialize}; use wasmer_wasi::{WasiFile, WasiFsError}; +// 16kB log buffer +const ZELLIJ_MAX_PIPE_BUFFER_SIZE: usize = 16_384; #[derive(Debug, Serialize, Deserialize)] pub struct DecoratingPipe { buffer: VecDeque, @@ -37,6 +39,19 @@ impl Write for DecoratingPipe { fn write(&mut self, buf: &[u8]) -> std::io::Result { self.buffer.extend(buf); + if self.buffer.len() > ZELLIJ_MAX_PIPE_BUFFER_SIZE { + let error_msg = + "Exceeded log buffer size. Make sure that your plugin calls flush on stderr on \ + valid UTF-8 symbol boundary. Aditionally, make sure that your log message contains \ + endline \\n symbol."; + error!("{}: {}", self.plugin_name, error_msg); + self.buffer.clear(); + return Err(std::io::Error::new( + std::io::ErrorKind::InvalidData, + error_msg, + )); + } + Ok(buf.len()) } @@ -184,4 +199,22 @@ mod decorating_pipe_test { assert_eq!(pipe.buffer.len(), 0); } + + #[test] + fn write_with_incorrect_byte_boundary_does_not_crash() { + let mut pipe = DecoratingPipe::new("TestPipe"); + + let test_buffer = "😱".as_bytes(); + + // make sure it's not valid utf-8 string if we drop last symbol + assert!(std::str::from_utf8(&test_buffer[..test_buffer.len() - 1]).is_err()); + + pipe.write(&test_buffer[..test_buffer.len() - 1]) + .expect("Err write"); + pipe.flush().expect("Err flush"); + + assert_eq!(pipe.buffer.len(), test_buffer.len() - 1); + + println!("len: {}, buf: {:?}", test_buffer.len(), test_buffer); + } } From ba21b86435a390342893dc0e43a69532fc39bb77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Wed, 7 Jul 2021 23:27:07 -0700 Subject: [PATCH 05/18] Cleanup log config file a bit, make format verbose so everyone can understand it without looking into log4rs docs --- zellij-utils/assets/config/log4rs.yml | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/zellij-utils/assets/config/log4rs.yml b/zellij-utils/assets/config/log4rs.yml index a10aec55b..01934f40c 100644 --- a/zellij-utils/assets/config/log4rs.yml +++ b/zellij-utils/assets/config/log4rs.yml @@ -7,34 +7,37 @@ appenders: kind: console target: stderr + # default zellij appender, should be used across most of the codebase. logFile: kind: file path: "zellij.log" append: false encoder: - pattern: "{h(|{M}| {d} {l} [{T}] [{f}:{L}]: {m})} {n}" + # {n} means platform dependent newline + pattern: "|{module}| {date} {highlight({level})} [{thread}] [{file}:{line}]: {message} {n}" + # plugin appender. To be used in decorating_pipe to forward stderr output from plugins. logPlugin: kind: file path: "zellij.log" encoder: - pattern: "{m} {n}" + # {n} means platform dependent newline + pattern: "{message} {n}" - # An appender named "requests" that writes to a file with a custom pattern encoder - requests: - kind: file - path: "requests.log" - encoder: - pattern: "{d} - {m}{n}" - -# Set the default logging level to "warn" and attach the "stdout" appender to the root +# Set the default logging level to "info" and log it to zellij.log file root: level: info appenders: - logFile loggers: - # Raise the maximum log level for events sent to the "app::backend::db" logger to "info" + # decrease verbosity for this module because it has a lot of useless info logs + wasmer_compiler_cranelift: + level: warn + appenders: + - logFile + + # For decorating_pipe, we use custom format as we use logging macros to forward stderr output from plugins zellij_server::decorating_pipe: level: trace appenders: From 13b5d1e58fce574240bebec8721460f7b8636f5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Thu, 8 Jul 2021 21:43:19 -0700 Subject: [PATCH 06/18] Add padding to logger --- zellij-server/src/decorating_pipe.rs | 6 +++--- zellij-utils/assets/config/log4rs.yml | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/zellij-server/src/decorating_pipe.rs b/zellij-server/src/decorating_pipe.rs index 0d5d2f518..7f68f50ce 100644 --- a/zellij-server/src/decorating_pipe.rs +++ b/zellij-server/src/decorating_pipe.rs @@ -17,7 +17,7 @@ pub struct DecoratingPipe { impl DecoratingPipe { pub fn new(plugin_name: &str) -> DecoratingPipe { - info!("Creating decorating pipe!"); + info!("Creating decorating pipe for plugin: {}!", plugin_name); DecoratingPipe { buffer: VecDeque::new(), plugin_name: String::from(plugin_name), @@ -70,11 +70,11 @@ impl Write for DecoratingPipe { if split_converted_buffer.peek().is_none() { // Log last chunk iff the last char is endline. Otherwise do not do it. if converted_buffer.chars().last().unwrap() == '\n' && !msg.is_empty() { - info!("{}: {}", self.plugin_name, msg); + info!("|{:<25}| {}", self.plugin_name, msg); consumed_bytes += msg.len() + 1; } } else { - info!("{}: {}", self.plugin_name, msg); + info!("|{:<25}| {}", self.plugin_name, msg); consumed_bytes += msg.len() + 1; } } diff --git a/zellij-utils/assets/config/log4rs.yml b/zellij-utils/assets/config/log4rs.yml index 01934f40c..5a60b973d 100644 --- a/zellij-utils/assets/config/log4rs.yml +++ b/zellij-utils/assets/config/log4rs.yml @@ -2,7 +2,7 @@ refresh_rate: 30 seconds appenders: - # An appender named "stdout" that writes to stdout + # An appender named "stderr" that writes to stderr stderr: kind: console target: stderr @@ -14,7 +14,8 @@ appenders: append: false encoder: # {n} means platform dependent newline - pattern: "|{module}| {date} {highlight({level})} [{thread}] [{file}:{line}]: {message} {n}" + # module is padded to *at least* 25 bytes and thread is padded to be between 10 and 15 bytes. + pattern: "|{module:<25}| {date} {highlight({level})} [{thread:<10.15}] [{file}:{line}]: {message} {n}" # plugin appender. To be used in decorating_pipe to forward stderr output from plugins. logPlugin: From a076d9ef1437f21b67ca525d4f8bddbca7c14f73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Thu, 8 Jul 2021 21:49:56 -0700 Subject: [PATCH 07/18] Cleanup --- .gitignore | 3 ++- Cargo.lock | 5 ----- zellij-server/Cargo.toml | 1 - zellij-server/src/wasm_vm.rs | 5 ++--- zellij-tile/Cargo.toml | 3 +-- zellij-utils/Cargo.toml | 1 - zellij-utils/src/logging.rs | 3 +-- 7 files changed, 6 insertions(+), 15 deletions(-) diff --git a/.gitignore b/.gitignore index 433d02d7a..21a50829e 100644 --- a/.gitignore +++ b/.gitignore @@ -4,4 +4,5 @@ .vim .DS_Store /assets/man/zellij.1 -**/target \ No newline at end of file +**/target +zellij.log \ No newline at end of file diff --git a/Cargo.lock b/Cargo.lock index 1a51077b7..a55e40da4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2277,8 +2277,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d54ee1d4ed486f78874278e63e4069fc1ab9f6a18ca492076ffb90c5eb2997fd" dependencies = [ "cfg-if 1.0.0", - "serde", - "serde_json", "wasm-bindgen-macro", ] @@ -2653,7 +2651,6 @@ dependencies = [ "serde_json", "typetag", "unicode-width", - "wasm-bindgen", "wasmer", "wasmer-wasi", "zellij-utils", @@ -2663,7 +2660,6 @@ dependencies = [ name = "zellij-tile" version = "0.14.0" dependencies = [ - "log", "serde", "serde_json", "strum", @@ -2702,7 +2698,6 @@ dependencies = [ "strum", "tempfile", "termion", - "typetag", "vte 0.10.1", "zellij-tile", ] diff --git a/zellij-server/Cargo.toml b/zellij-server/Cargo.toml index d06745de3..442360d98 100644 --- a/zellij-server/Cargo.toml +++ b/zellij-server/Cargo.toml @@ -16,7 +16,6 @@ serde_json = "1.0" unicode-width = "0.1.8" wasmer = "1.0.0" wasmer-wasi = "1.0.0" -wasm-bindgen = { version = "0.2", features = ["serde-serialize"] } cassowary = "0.3.0" zellij-utils = { path = "../zellij-utils/", version = "0.14.0" } log = "0.4.14" diff --git a/zellij-server/src/wasm_vm.rs b/zellij-server/src/wasm_vm.rs index 14823e527..0f6761696 100644 --- a/zellij-server/src/wasm_vm.rs +++ b/zellij-server/src/wasm_vm.rs @@ -1,8 +1,6 @@ use log::info; -use serde::{de::DeserializeOwned, Serialize}; use std::collections::{HashMap, HashSet}; use std::fs; -use std::io::{Read, Write}; use std::path::PathBuf; use std::process; use std::str::FromStr; @@ -10,8 +8,9 @@ use std::sync::{mpsc::Sender, Arc, Mutex}; use std::thread; use std::time::{Duration, Instant}; -use zellij_utils::{serde, zellij_tile}; +use zellij_utils::zellij_tile; +use serde::{de::DeserializeOwned, Serialize}; use wasmer::{ imports, ChainableNamedResolver, Function, ImportObject, Instance, Module, Store, Value, WasmerEnv, diff --git a/zellij-tile/Cargo.toml b/zellij-tile/Cargo.toml index a2aaab1ff..f4c733671 100644 --- a/zellij-tile/Cargo.toml +++ b/zellij-tile/Cargo.toml @@ -10,5 +10,4 @@ license = "MIT" serde = { version = "1.0", features = ["derive"] } serde_json = "1.0" strum = "0.20.0" -strum_macros = "0.20.0" -log = "0.4.14" +strum_macros = "0.20.0" \ No newline at end of file diff --git a/zellij-utils/Cargo.toml b/zellij-utils/Cargo.toml index 42a74d540..bf7c60af5 100644 --- a/zellij-utils/Cargo.toml +++ b/zellij-utils/Cargo.toml @@ -29,7 +29,6 @@ termion = "1.5.0" vte = "0.10.1" zellij-tile = { path = "../zellij-tile/", version = "0.14.0" } log = "0.4.14" -typetag = "0.1.7" log4rs = "1.0.0" [dependencies.async-std] diff --git a/zellij-utils/src/logging.rs b/zellij-utils/src/logging.rs index eb7361422..52e91497f 100644 --- a/zellij-utils/src/logging.rs +++ b/zellij-utils/src/logging.rs @@ -1,11 +1,10 @@ //! Zellij logging utility functions. use std::{ - fs::{self, OpenOptions}, + fs, io::{self, prelude::*}, os::unix::io::RawFd, path::{Path, PathBuf}, - thread, }; use log::info; From 8d864e1fbf7408a840e2ac0ff3933f9d82fa1772 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Thu, 8 Jul 2021 21:53:22 -0700 Subject: [PATCH 08/18] remove one more crate from zellij-server --- Cargo.lock | 1 - zellij-server/Cargo.toml | 1 - 2 files changed, 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index a55e40da4..aa63b3f17 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2647,7 +2647,6 @@ dependencies = [ "insta", "log", "serde", - "serde_derive", "serde_json", "typetag", "unicode-width", diff --git a/zellij-server/Cargo.toml b/zellij-server/Cargo.toml index 442360d98..9cec6b8a0 100644 --- a/zellij-server/Cargo.toml +++ b/zellij-server/Cargo.toml @@ -19,7 +19,6 @@ wasmer-wasi = "1.0.0" cassowary = "0.3.0" zellij-utils = { path = "../zellij-utils/", version = "0.14.0" } log = "0.4.14" -serde_derive = "1.0.80" serde = "1.0.126" typetag = "0.1.7" From 3b78d7d0a4781ca541b4e307afe37f4a0c4d4640 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Thu, 8 Jul 2021 22:01:03 -0700 Subject: [PATCH 09/18] More cleanup, remove serde from zellij-server --- Cargo.lock | 1 - zellij-server/Cargo.toml | 1 - zellij-server/src/decorating_pipe.rs | 5 ++++- zellij-server/src/wasm_vm.rs | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index aa63b3f17..6d23cea31 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2646,7 +2646,6 @@ dependencies = [ "daemonize", "insta", "log", - "serde", "serde_json", "typetag", "unicode-width", diff --git a/zellij-server/Cargo.toml b/zellij-server/Cargo.toml index 9cec6b8a0..1a671c3df 100644 --- a/zellij-server/Cargo.toml +++ b/zellij-server/Cargo.toml @@ -19,7 +19,6 @@ wasmer-wasi = "1.0.0" cassowary = "0.3.0" zellij-utils = { path = "../zellij-utils/", version = "0.14.0" } log = "0.4.14" -serde = "1.0.126" typetag = "0.1.7" [dev-dependencies] diff --git a/zellij-server/src/decorating_pipe.rs b/zellij-server/src/decorating_pipe.rs index 7f68f50ce..650391396 100644 --- a/zellij-server/src/decorating_pipe.rs +++ b/zellij-server/src/decorating_pipe.rs @@ -4,12 +4,15 @@ use std::{ }; use log::{error, info}; -use serde::{Deserialize, Serialize}; use wasmer_wasi::{WasiFile, WasiFsError}; +use zellij_utils::serde; + +use serde::{Deserialize, Serialize}; // 16kB log buffer const ZELLIJ_MAX_PIPE_BUFFER_SIZE: usize = 16_384; #[derive(Debug, Serialize, Deserialize)] +#[serde(crate = "self::serde")] pub struct DecoratingPipe { buffer: VecDeque, plugin_name: String, diff --git a/zellij-server/src/wasm_vm.rs b/zellij-server/src/wasm_vm.rs index 0f6761696..fe8f5be77 100644 --- a/zellij-server/src/wasm_vm.rs +++ b/zellij-server/src/wasm_vm.rs @@ -8,7 +8,7 @@ use std::sync::{mpsc::Sender, Arc, Mutex}; use std::thread; use std::time::{Duration, Instant}; -use zellij_utils::zellij_tile; +use zellij_utils::{serde, zellij_tile}; use serde::{de::DeserializeOwned, Serialize}; use wasmer::{ From 383446d025bc8fd8bcc87289daac3c61a117bd86 Mon Sep 17 00:00:00 2001 From: qepasa Date: Fri, 9 Jul 2021 07:56:20 +0200 Subject: [PATCH 10/18] Update Cargo.toml --- Cargo.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index b6ac222dc..a0fd188e4 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -14,7 +14,6 @@ resolver = "2" [dependencies] names = "0.11.0" - zellij-client = { path = "zellij-client/", version = "0.15.0" } zellij-server = { path = "zellij-server/", version = "0.15.0" } zellij-utils = { path = "zellij-utils/", version = "0.15.0" } From a38c176646fcbe8f10d71c32e955674ffd7b669d Mon Sep 17 00:00:00 2001 From: qepasa Date: Fri, 9 Jul 2021 07:56:54 +0200 Subject: [PATCH 11/18] Update Cargo.toml --- zellij-utils/Cargo.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/zellij-utils/Cargo.toml b/zellij-utils/Cargo.toml index 9520753b0..b3f14886f 100644 --- a/zellij-utils/Cargo.toml +++ b/zellij-utils/Cargo.toml @@ -31,7 +31,6 @@ zellij-tile = { path = "../zellij-tile/", version = "0.15.0" } log = "0.4.14" log4rs = "1.0.0" - [dependencies.async-std] version = "1.3.0" features = ["unstable"] From b15cfba6e1c6227395a4f8cd2a625bd75659092e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Tue, 13 Jul 2021 23:22:11 -0700 Subject: [PATCH 12/18] Apply code review suggestions. Rename decorating_pipe to logging_pipe. Add plugin_id to plugin log. Move logger init from file to in-code initialization and change logging file to zellij directory. Change format of timestamp. --- .gitignore | 3 +- Cargo.lock | 82 ++++++++++--------- default-plugins/status-bar/src/main.rs | 1 - default-plugins/strider/src/main.rs | 4 - src/main.rs | 2 +- zellij-client/Cargo.toml | 1 + zellij-client/src/lib.rs | 2 + zellij-server/Cargo.toml | 1 + zellij-server/src/lib.rs | 2 +- .../{decorating_pipe.rs => logging_pipe.rs} | 61 +++++++++----- zellij-server/src/wasm_vm.rs | 10 ++- zellij-tile/src/lib.rs | 1 - zellij-utils/assets/config/log4rs.yml | 46 ----------- zellij-utils/src/logging.rs | 50 ++++++++++- 14 files changed, 143 insertions(+), 123 deletions(-) rename zellij-server/src/{decorating_pipe.rs => logging_pipe.rs} (81%) delete mode 100644 zellij-utils/assets/config/log4rs.yml diff --git a/.gitignore b/.gitignore index 21a50829e..433d02d7a 100644 --- a/.gitignore +++ b/.gitignore @@ -4,5 +4,4 @@ .vim .DS_Store /assets/man/zellij.1 -**/target -zellij.log \ No newline at end of file +**/target \ No newline at end of file diff --git a/Cargo.lock b/Cargo.lock index ead56047d..f06e05c15 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -46,9 +46,9 @@ dependencies = [ [[package]] name = "anyhow" -version = "1.0.41" +version = "1.0.42" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "15af2628f6890fe2609a3b91bef4c83450512802e59489f9c1cb1fa5df064a61" +checksum = "595d3cfa7a60d4555cb5067b99f07142a08ea778de5cf993f7b75c7d8fabc486" [[package]] name = "arc-swap" @@ -105,12 +105,11 @@ dependencies = [ [[package]] name = "async-io" -version = "1.4.1" +version = "1.6.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "4bbfd5cf2794b1e908ea8457e6c45f8f8f1f6ec5f74617bf4662623f47503c3b" +checksum = "a811e6a479f2439f0c04038796b5cfb3d2ad56c230e0f2d3f7b04d68cfee607b" dependencies = [ "concurrent-queue", - "fastrand", "futures-lite", "libc", "log", @@ -211,12 +210,12 @@ checksum = "065374052e7df7ee4047b1160cca5e1467a12351a40b3da123c870ba0b8eda2a" [[package]] name = "atty" -version = "0.2.11" +version = "0.2.14" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "9a7d5b8723950951411ee34d271d99dddcc2035a16ab25310ea2c8cfd4369652" +checksum = "d9b39be18770d11421cdb1b9947a45dd3f37e93092cbf377614828a319d5fee8" dependencies = [ + "hermit-abi", "libc", - "termion", "winapi", ] @@ -308,9 +307,9 @@ checksum = "df8670b8c7b9dae1793364eafadf7239c40d669904660c5960d74cfd80b46a53" [[package]] name = "cc" -version = "1.0.68" +version = "1.0.69" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "4a72c244c1ff497a746a7e1fb3d14bd08420ecda70c8f25c7112f2781652d787" +checksum = "e70cc2f62c6ce1868963827bd677764c62d07c3d9a3e1fb1177ee1a9ab199eb2" [[package]] name = "cfg-if" @@ -589,9 +588,9 @@ dependencies = [ [[package]] name = "darling" -version = "0.12.4" +version = "0.13.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5f2c43f534ea4b0b049015d00269734195e6d3f0f6635cb692251aca6f9f8b3c" +checksum = "757c0ded2af11d8e739c4daea1ac623dd1624b06c844cf3f5a39f1bdbd99bb12" dependencies = [ "darling_core", "darling_macro", @@ -599,9 +598,9 @@ dependencies = [ [[package]] name = "darling_core" -version = "0.12.4" +version = "0.13.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8e91455b86830a1c21799d94524df0845183fa55bafd9aa137b01c7d1065fa36" +checksum = "2c34d8efb62d0c2d7f60ece80f75e5c63c1588ba68032740494b0b9a996466e3" dependencies = [ "fnv", "ident_case", @@ -613,9 +612,9 @@ dependencies = [ [[package]] name = "darling_macro" -version = "0.12.4" +version = "0.13.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "29b5acf0dea37a7f66f7b25d2c5e93fd46f8f6968b1a5d7a3e02e97768afc95a" +checksum = "ade7bff147130fe5e6d39f089c6bd49ec0250f35d70b2eebf72afdfc919f15cc" dependencies = [ "darling_core", "quote", @@ -674,18 +673,18 @@ checksum = "a357d28ed41a50f9c765dbfe56cbc04a64e53e5fc58ba79fbc34c10ef3df831f" [[package]] name = "enumset" -version = "1.0.6" +version = "1.0.7" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "fbd795df6708a599abf1ee10eacc72efd052b7a5f70fdf0715e4d5151a6db9c3" +checksum = "7e76129da36102af021b8e5000dab2c1c30dbef85c1e482beeff8da5dde0e0b0" dependencies = [ "enumset_derive", ] [[package]] name = "enumset_derive" -version = "0.5.4" +version = "0.5.5" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e19c52f9ec503c8a68dc04daf71a04b07e690c32ab1a8b68e33897f255269d47" +checksum = "6451128aa6655d880755345d085494cf7561a6bee7c8dc821e5d77e6d267ecd4" dependencies = [ "darling", "proc-macro2", @@ -980,9 +979,9 @@ dependencies = [ [[package]] name = "instant" -version = "0.1.9" +version = "0.1.10" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "61124eeebbd69b8190558df225adf7e4caafce0d743919e5d6b19652314ec5ec" +checksum = "bee0328b1209d157ef001c94dd85b4f8f64139adb0eac2659f4b08382b2f474d" dependencies = [ "cfg-if 1.0.0", ] @@ -1070,9 +1069,9 @@ checksum = "3576a87f2ba00f6f106fdfcd16db1d698d648a26ad8e0573cad8537c3c362d2a" [[package]] name = "libc" -version = "0.2.97" +version = "0.2.98" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "12b8adadd720df158f4d70dfe7ccc6adb0472d7c55ca83445f6a5ab3e36f8fb6" +checksum = "320cfe77175da3a483efed4bc0adc1968ca050b098ce4f2f1c13a56626128790" [[package]] name = "libloading" @@ -1354,9 +1353,9 @@ dependencies = [ [[package]] name = "ordered-float" -version = "2.5.1" +version = "2.7.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f100fcfb41e5385e0991f74981732049f9b896821542a219420491046baafdc2" +checksum = "039f02eb0f69271f26abe3202189275d7aa2258b903cb0281b5de710a2570ff3" dependencies = [ "num-traits", ] @@ -1925,9 +1924,9 @@ checksum = "73473c0e59e6d5812c5dfe2a064a6444949f089e20eec9a2e5506596494e4623" [[package]] name = "structopt" -version = "0.3.21" +version = "0.3.22" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5277acd7ee46e63e5168a80734c9f6ee81b1367a7d8772a2d765df2a3705d28c" +checksum = "69b041cdcb67226aca307e6e7be44c8806423d83e018bd662360a93dabce4d71" dependencies = [ "clap", "lazy_static", @@ -1936,9 +1935,9 @@ dependencies = [ [[package]] name = "structopt-derive" -version = "0.4.14" +version = "0.4.15" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5ba9cdfda491b814720b6b06e0cac513d922fc407582032e8706e9f137976f90" +checksum = "7813934aecf5f51a54775e00068c237de98489463968231a51746bbbc03f9c10" dependencies = [ "heck", "proc-macro-error", @@ -2050,18 +2049,18 @@ dependencies = [ [[package]] name = "thiserror" -version = "1.0.25" +version = "1.0.26" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "fa6f76457f59514c7eeb4e59d891395fab0b2fd1d40723ae737d64153392e9c6" +checksum = "93119e4feac1cbe6c798c34d3a53ea0026b0b1de6a120deef895137c0529bfe2" dependencies = [ "thiserror-impl", ] [[package]] name = "thiserror-impl" -version = "1.0.25" +version = "1.0.26" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8a36768c0fbf1bb15eca10defa29526bda730a2376c2ab4393ccfa16fb1a318d" +checksum = "060d69a0afe7796bf42e9e2ff91f5ee691fb15c53d38b4b62a9a53eb23164745" dependencies = [ "proc-macro2", "quote", @@ -2081,11 +2080,12 @@ dependencies = [ [[package]] name = "time" -version = "0.1.43" +version = "0.1.44" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "ca8a50ef2360fbd1eeb0ecd46795a87a19024eb4b53c5dc916ca1fd95fe62438" +checksum = "6db9e6914ab8b1ae1c260a4ae7a49b6c5611b40328a735b21862567685e73255" dependencies = [ "libc", + "wasi", "winapi", ] @@ -2163,9 +2163,9 @@ dependencies = [ [[package]] name = "unicode-segmentation" -version = "1.7.1" +version = "1.8.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bb0d2e7be6ae3a5fa87eed5fb451aff96f2573d2694942e40543ae0bbe19c796" +checksum = "8895849a949e7845e06bd6dc1aa51731a103c42707010a5b591c0038fb73385b" [[package]] name = "unicode-width" @@ -2272,9 +2272,9 @@ checksum = "9d5b2c62b4012a3e1eca5a7e077d13b3bf498c4073e33ccd58626607748ceeca" [[package]] name = "wasi" -version = "0.10.2+wasi-snapshot-preview1" +version = "0.10.0+wasi-snapshot-preview1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "fd6fbd9a79829dd1ad0cc20627bf1ed606756a7f77edff7b66b7064f9cb327c6" +checksum = "1a143597ca7c7793eff794def352d41792a93c481eb1042423ff7ff72ba2c31f" [[package]] name = "wasm-bindgen" @@ -2639,6 +2639,7 @@ name = "zellij-client" version = "0.15.0" dependencies = [ "insta", + "log", "mio", "termbg", "zellij-utils", @@ -2652,6 +2653,7 @@ dependencies = [ "async-trait", "base64", "cassowary", + "chrono", "daemonize", "insta", "log", diff --git a/default-plugins/status-bar/src/main.rs b/default-plugins/status-bar/src/main.rs index e9e60fc39..83eb50c9a 100644 --- a/default-plugins/status-bar/src/main.rs +++ b/default-plugins/status-bar/src/main.rs @@ -133,7 +133,6 @@ fn color_elements(palette: Palette) -> ColoredElements { impl ZellijPlugin for State { fn load(&mut self) { - dbg!("hello from load"); set_selectable(false); set_invisible_borders(true); set_fixed_height(2); diff --git a/default-plugins/strider/src/main.rs b/default-plugins/strider/src/main.rs index 7d80f014a..8edc1e197 100644 --- a/default-plugins/strider/src/main.rs +++ b/default-plugins/strider/src/main.rs @@ -9,15 +9,11 @@ register_plugin!(State); impl ZellijPlugin for State { fn load(&mut self) { - dbg!("hello from load"); - dbg!("hello from load2?"); refresh_directory(self); subscribe(&[EventType::KeyPress]); } fn update(&mut self, event: Event) { - dbg!("hello from update"); - if let Event::KeyPress(key) = event { match key { Key::Up | Key::Char('k') => { diff --git a/src/main.rs b/src/main.rs index 7d6865fd3..1fa3343b3 100644 --- a/src/main.rs +++ b/src/main.rs @@ -21,7 +21,7 @@ use zellij_utils::{ pub fn main() { configure_logger(); - info!("Hello Zellij!"); + info!("Starting Zellij!"); let opts = CliArgs::from_args(); if let Some(Command::Sessions(Sessions::ListSessions)) = opts.command { diff --git a/zellij-client/Cargo.toml b/zellij-client/Cargo.toml index 5a2e314a3..64241f585 100644 --- a/zellij-client/Cargo.toml +++ b/zellij-client/Cargo.toml @@ -12,6 +12,7 @@ license = "MIT" mio = "0.7.11" termbg = "0.2.3" zellij-utils = { path = "../zellij-utils/", version = "0.15.0" } +log = "0.4.14" [dev-dependencies] insta = "1.6.0" diff --git a/zellij-client/src/lib.rs b/zellij-client/src/lib.rs index 90732024d..d456103aa 100644 --- a/zellij-client/src/lib.rs +++ b/zellij-client/src/lib.rs @@ -3,6 +3,7 @@ pub mod os_input_output; mod command_is_executing; mod input_handler; +use log::info; use std::env::current_exe; use std::io::{self, Write}; use std::path::Path; @@ -291,6 +292,7 @@ pub fn start_client( ); os_input.disable_mouse(); + info!("{}", exit_msg); os_input.unset_raw_mode(0); let mut stdout = os_input.get_stdout_writer(); let _ = stdout.write(goodbye_message.as_bytes()).unwrap(); diff --git a/zellij-server/Cargo.toml b/zellij-server/Cargo.toml index 598d8aa3d..81616d060 100644 --- a/zellij-server/Cargo.toml +++ b/zellij-server/Cargo.toml @@ -21,6 +21,7 @@ cassowary = "0.3.0" zellij-utils = { path = "../zellij-utils/", version = "0.15.0" } log = "0.4.14" typetag = "0.1.7" +chrono = "0.4.19" [dev-dependencies] insta = "1.6.0" diff --git a/zellij-server/src/lib.rs b/zellij-server/src/lib.rs index 8dc5509b4..853f35a04 100644 --- a/zellij-server/src/lib.rs +++ b/zellij-server/src/lib.rs @@ -2,7 +2,7 @@ pub mod os_input_output; pub mod panes; pub mod tab; -mod decorating_pipe; +mod logging_pipe; mod pty; mod route; mod screen; diff --git a/zellij-server/src/decorating_pipe.rs b/zellij-server/src/logging_pipe.rs similarity index 81% rename from zellij-server/src/decorating_pipe.rs rename to zellij-server/src/logging_pipe.rs index 650391396..e1d7acc5b 100644 --- a/zellij-server/src/decorating_pipe.rs +++ b/zellij-server/src/logging_pipe.rs @@ -3,32 +3,51 @@ use std::{ io::{Read, Seek, Write}, }; -use log::{error, info}; +use log::{debug, error, info}; use wasmer_wasi::{WasiFile, WasiFsError}; use zellij_utils::serde; +use chrono::prelude::*; use serde::{Deserialize, Serialize}; // 16kB log buffer const ZELLIJ_MAX_PIPE_BUFFER_SIZE: usize = 16_384; #[derive(Debug, Serialize, Deserialize)] #[serde(crate = "self::serde")] -pub struct DecoratingPipe { +pub struct LoggingPipe { buffer: VecDeque, plugin_name: String, + plugin_id: u32, } -impl DecoratingPipe { - pub fn new(plugin_name: &str) -> DecoratingPipe { - info!("Creating decorating pipe for plugin: {}!", plugin_name); - DecoratingPipe { +impl LoggingPipe { + pub fn new(plugin_name: &str, plugin_id: u32) -> LoggingPipe { + info!( + "|{:<25.25}| {} [{:<10.15}] Creating decorating pipe for plugin: {}!", + plugin_name, + Local::now().format("%Y-%m-%d %H:%M:%S.%3f"), + format!("id: {}", plugin_id), + plugin_name + ); + LoggingPipe { buffer: VecDeque::new(), plugin_name: String::from(plugin_name), + plugin_id, } } + + fn log_message(&self, message: &str) { + debug!( + "|{:<25.25}| {} [{:<10.15}] {}", + self.plugin_name, + Local::now().format("%Y-%m-%d %H:%M:%S.%3f"), + format!("id: {}", self.plugin_id), + message + ); + } } -impl Read for DecoratingPipe { +impl Read for LoggingPipe { fn read(&mut self, buf: &mut [u8]) -> std::io::Result { let amt = std::cmp::min(buf.len(), self.buffer.len()); for (i, byte) in self.buffer.drain(..amt).enumerate() { @@ -38,11 +57,9 @@ impl Read for DecoratingPipe { } } -impl Write for DecoratingPipe { +impl Write for LoggingPipe { fn write(&mut self, buf: &[u8]) -> std::io::Result { - self.buffer.extend(buf); - - if self.buffer.len() > ZELLIJ_MAX_PIPE_BUFFER_SIZE { + if self.buffer.len() + buf.len() > ZELLIJ_MAX_PIPE_BUFFER_SIZE { let error_msg = "Exceeded log buffer size. Make sure that your plugin calls flush on stderr on \ valid UTF-8 symbol boundary. Aditionally, make sure that your log message contains \ @@ -55,6 +72,8 @@ impl Write for DecoratingPipe { )); } + self.buffer.extend(buf); + Ok(buf.len()) } @@ -73,11 +92,11 @@ impl Write for DecoratingPipe { if split_converted_buffer.peek().is_none() { // Log last chunk iff the last char is endline. Otherwise do not do it. if converted_buffer.chars().last().unwrap() == '\n' && !msg.is_empty() { - info!("|{:<25}| {}", self.plugin_name, msg); + self.log_message(msg); consumed_bytes += msg.len() + 1; } } else { - info!("|{:<25}| {}", self.plugin_name, msg); + self.log_message(msg); consumed_bytes += msg.len() + 1; } } @@ -91,7 +110,7 @@ impl Write for DecoratingPipe { } } -impl Seek for DecoratingPipe { +impl Seek for LoggingPipe { fn seek(&mut self, _pos: std::io::SeekFrom) -> std::io::Result { Err(std::io::Error::new( std::io::ErrorKind::Other, @@ -101,7 +120,7 @@ impl Seek for DecoratingPipe { } #[typetag::serde] -impl WasiFile for DecoratingPipe { +impl WasiFile for LoggingPipe { fn last_accessed(&self) -> u64 { 0 } @@ -128,13 +147,13 @@ impl WasiFile for DecoratingPipe { // Unit tests #[cfg(test)] -mod decorating_pipe_test { +mod logging_pipe_test { use super::*; #[test] fn write_without_endl_does_not_consume_buffer_after_flush() { - let mut pipe = DecoratingPipe::new("TestPipe"); + let mut pipe = LoggingPipe::new("TestPipe", 0); let test_buffer = "Testing write".as_bytes(); @@ -146,7 +165,7 @@ mod decorating_pipe_test { #[test] fn write_with_single_endl_at_the_end_consumes_whole_buffer_after_flush() { - let mut pipe = DecoratingPipe::new("TestPipe"); + let mut pipe = LoggingPipe::new("TestPipe", 0); let test_buffer = "Testing write \n".as_bytes(); @@ -158,7 +177,7 @@ mod decorating_pipe_test { #[test] fn write_with_endl_in_the_middle_consumes_buffer_up_to_endl_after_flush() { - let mut pipe = DecoratingPipe::new("TestPipe"); + let mut pipe = LoggingPipe::new("TestPipe", 0); let test_buffer = "Testing write \n".as_bytes(); let test_buffer2 = "And the rest".as_bytes(); @@ -182,7 +201,7 @@ mod decorating_pipe_test { #[test] fn write_with_many_endl_consumes_whole_buffer_after_flush() { - let mut pipe = DecoratingPipe::new("TestPipe"); + let mut pipe = LoggingPipe::new("TestPipe", 0); let test_buffer = "Testing write \n".as_bytes(); @@ -205,7 +224,7 @@ mod decorating_pipe_test { #[test] fn write_with_incorrect_byte_boundary_does_not_crash() { - let mut pipe = DecoratingPipe::new("TestPipe"); + let mut pipe = LoggingPipe::new("TestPipe", 0); let test_buffer = "😱".as_bytes(); diff --git a/zellij-server/src/wasm_vm.rs b/zellij-server/src/wasm_vm.rs index eed7e9356..f3e4a115b 100644 --- a/zellij-server/src/wasm_vm.rs +++ b/zellij-server/src/wasm_vm.rs @@ -17,7 +17,7 @@ use wasmer_wasi::{Pipe, WasiEnv, WasiState}; use zellij_tile::data::{Event, EventType, PluginIds}; use crate::{ - decorating_pipe::DecoratingPipe, + logging_pipe::LoggingPipe, panes::PaneId, pty::PtyInstruction, screen::ScreenInstruction, @@ -57,7 +57,7 @@ pub(crate) struct PluginEnv { // Thread main -------------------------------------------------------------------------------------------------------- pub(crate) fn wasm_thread_main(bus: Bus, store: Store, data_dir: PathBuf) { - info!("Wasm create thread :))"); + info!("Wasm main thread starts"); let mut plugin_id = 0; let mut plugin_map = HashMap::new(); loop { @@ -76,8 +76,10 @@ pub(crate) fn wasm_thread_main(bus: Bus, store: Store, data_d let output = Pipe::new(); let input = Pipe::new(); - let stderr = - DecoratingPipe::new(path.as_path().file_name().unwrap().to_str().unwrap()); + let stderr = LoggingPipe::new( + path.as_path().file_name().unwrap().to_str().unwrap(), + plugin_id, + ); let mut wasi_env = WasiState::new("Zellij") .env("CLICOLOR_FORCE", "1") .preopen(|p| { diff --git a/zellij-tile/src/lib.rs b/zellij-tile/src/lib.rs index 176a94972..af7d8ca12 100644 --- a/zellij-tile/src/lib.rs +++ b/zellij-tile/src/lib.rs @@ -19,7 +19,6 @@ macro_rules! register_plugin { } fn main() { - dbg!("hello from plugin main :)"); STATE.with(|state| { state.borrow_mut().load(); }); diff --git a/zellij-utils/assets/config/log4rs.yml b/zellij-utils/assets/config/log4rs.yml deleted file mode 100644 index 5a60b973d..000000000 --- a/zellij-utils/assets/config/log4rs.yml +++ /dev/null @@ -1,46 +0,0 @@ -# Scan this file for changes every 30 seconds -refresh_rate: 30 seconds - -appenders: - # An appender named "stderr" that writes to stderr - stderr: - kind: console - target: stderr - - # default zellij appender, should be used across most of the codebase. - logFile: - kind: file - path: "zellij.log" - append: false - encoder: - # {n} means platform dependent newline - # module is padded to *at least* 25 bytes and thread is padded to be between 10 and 15 bytes. - pattern: "|{module:<25}| {date} {highlight({level})} [{thread:<10.15}] [{file}:{line}]: {message} {n}" - - # plugin appender. To be used in decorating_pipe to forward stderr output from plugins. - logPlugin: - kind: file - path: "zellij.log" - encoder: - # {n} means platform dependent newline - pattern: "{message} {n}" - -# Set the default logging level to "info" and log it to zellij.log file -root: - level: info - appenders: - - logFile - -loggers: - # decrease verbosity for this module because it has a lot of useless info logs - wasmer_compiler_cranelift: - level: warn - appenders: - - logFile - - # For decorating_pipe, we use custom format as we use logging macros to forward stderr output from plugins - zellij_server::decorating_pipe: - level: trace - appenders: - - logPlugin - additive: false diff --git a/zellij-utils/src/logging.rs b/zellij-utils/src/logging.rs index 52e91497f..d7f35344d 100644 --- a/zellij-utils/src/logging.rs +++ b/zellij-utils/src/logging.rs @@ -7,13 +7,59 @@ use std::{ path::{Path, PathBuf}, }; -use log::info; +use log::{info, LevelFilter}; + +use log4rs::append::file::FileAppender; +use log4rs::config::{Appender, Config, Logger, Root}; +use log4rs::encode::pattern::PatternEncoder; use crate::consts::{ZELLIJ_TMP_LOG_DIR, ZELLIJ_TMP_LOG_FILE}; use crate::shared::set_permissions; pub fn configure_logger() { - log4rs::init_file("zellij-utils/assets/config/log4rs.yml", Default::default()).unwrap(); + // {n} means platform dependent newline + // module is padded to exactly 25 bytes and thread is padded to be between 10 and 15 bytes. + let file_pattern = "{highlight({level:<6})} |{module:<25.25}| {date(%Y-%m-%d %H:%M:%S.%3f)} [{thread:<10.15}] [{file}:{line}]: {message} {n}"; + + // default zellij appender, should be used across most of the codebase. + let log_file = FileAppender::builder() + .encoder(Box::new(PatternEncoder::new(file_pattern))) + .append(true) + .build(ZELLIJ_TMP_LOG_DIR.join("zellij.log")) + .unwrap(); + + // plugin appender. To be used in loggin_pipe to forward stderr output from plugins. We do some formatting + // in logging_pipe to print plugin name as 'module' and plugin_id instead of thread. + let log_plugin = FileAppender::builder() + .encoder(Box::new(PatternEncoder::new( + "{highlight({level:<6})} {message} {n}", + ))) + .append(true) + .build(ZELLIJ_TMP_LOG_DIR.join("zellij.log")) + .unwrap(); + + // Set the default logging level to "info" and log it to zellij.log file + // Decrease verbosity for `wasmer_compiler_cranelift` module because it has a lot of useless info logs + // For `zellij_server::logging_pipe`, we use custom format as we use logging macros to forward stderr output from plugins + let config = Config::builder() + .appender(Appender::builder().build("logFile", Box::new(log_file))) + .appender(Appender::builder().build("logPlugin", Box::new(log_plugin))) + .logger( + Logger::builder() + .appender("logFile") + .build("wasmer_compiler_cranelift", LevelFilter::Warn), + ) + .logger( + Logger::builder() + .appender("logPlugin") + .additive(false) + .build("zellij_server::logging_pipe", LevelFilter::Trace), + ) + .build(Root::builder().appender("logFile").build(LevelFilter::Info)) + .unwrap(); + + let _ = log4rs::init_config(config).unwrap(); + info!("Zellij logger initialized"); } From 9044dbcec361ab921d618965f547437da4097bc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Tue, 13 Jul 2021 23:31:16 -0700 Subject: [PATCH 13/18] small touchups --- zellij-server/src/lib.rs | 1 - zellij-tile/Cargo.toml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/zellij-server/src/lib.rs b/zellij-server/src/lib.rs index 853f35a04..b8cbbc5dc 100644 --- a/zellij-server/src/lib.rs +++ b/zellij-server/src/lib.rs @@ -117,7 +117,6 @@ pub(crate) enum SessionState { pub fn start_server(os_input: Box, socket_path: PathBuf) { info!("starts server"); - #[cfg(not(any(feature = "test", test)))] daemonize::Daemonize::new() .working_directory(std::env::current_dir().unwrap()) .umask(0o077) diff --git a/zellij-tile/Cargo.toml b/zellij-tile/Cargo.toml index 3ae62576f..b0c18ff29 100644 --- a/zellij-tile/Cargo.toml +++ b/zellij-tile/Cargo.toml @@ -10,4 +10,4 @@ license = "MIT" serde = { version = "1.0", features = ["derive"] } serde_json = "1.0" strum = "0.20.0" -strum_macros = "0.20.0" \ No newline at end of file +strum_macros = "0.20.0" From 3326f521efd33cdfbe9df3d6f44ddd9042897943 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Tue, 13 Jul 2021 23:46:36 -0700 Subject: [PATCH 14/18] Fix clippy --- zellij-server/src/logging_pipe.rs | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/zellij-server/src/logging_pipe.rs b/zellij-server/src/logging_pipe.rs index e1d7acc5b..eecfa2d3c 100644 --- a/zellij-server/src/logging_pipe.rs +++ b/zellij-server/src/logging_pipe.rs @@ -91,7 +91,7 @@ impl Write for LoggingPipe { while let Some(msg) = split_converted_buffer.next() { if split_converted_buffer.peek().is_none() { // Log last chunk iff the last char is endline. Otherwise do not do it. - if converted_buffer.chars().last().unwrap() == '\n' && !msg.is_empty() { + if converted_buffer.ends_with('\n') && !msg.is_empty() { self.log_message(msg); consumed_bytes += msg.len() + 1; } @@ -239,4 +239,20 @@ mod logging_pipe_test { println!("len: {}, buf: {:?}", test_buffer.len(), test_buffer); } + + #[test] + fn write_with_many_endls_consumes_everything_after_flush() { + let mut pipe = LoggingPipe::new("TestPipe", 0); + let test_buffer = "Testing write \n".as_bytes(); + + pipe.write( + [test_buffer, test_buffer, b"\n", b"\n", b"\n"] + .concat() + .as_slice(), + ) + .expect("Err write"); + pipe.flush().expect("Err flush"); + + assert_eq!(pipe.buffer.len(), 0); + } } From 27634423d90df538070e052ba4cbd8b9811fae51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Sat, 17 Jul 2021 23:50:24 -0700 Subject: [PATCH 15/18] Minor fixes --- src/main.rs | 2 -- zellij-client/src/lib.rs | 1 + zellij-server/src/lib.rs | 2 +- zellij-server/src/logging_pipe.rs | 18 ++++++------------ zellij-utils/src/logging.rs | 4 +--- 5 files changed, 9 insertions(+), 18 deletions(-) diff --git a/src/main.rs b/src/main.rs index 1fa3343b3..612e130ec 100644 --- a/src/main.rs +++ b/src/main.rs @@ -4,7 +4,6 @@ mod sessions; mod tests; use crate::install::populate_data_dir; -use log::info; use sessions::{assert_session, assert_session_ne, get_active_session, list_sessions}; use std::convert::TryFrom; use std::process; @@ -21,7 +20,6 @@ use zellij_utils::{ pub fn main() { configure_logger(); - info!("Starting Zellij!"); let opts = CliArgs::from_args(); if let Some(Command::Sessions(Sessions::ListSessions)) = opts.command { diff --git a/zellij-client/src/lib.rs b/zellij-client/src/lib.rs index d456103aa..d9dda42ca 100644 --- a/zellij-client/src/lib.rs +++ b/zellij-client/src/lib.rs @@ -89,6 +89,7 @@ pub fn start_client( info: ClientInfo, layout: Option, ) { + info!("Starting Zellij client!"); let clear_client_terminal_attributes = "\u{1b}[?1l\u{1b}=\u{1b}[r\u{1b}12l\u{1b}[?1000l\u{1b}[?1002l\u{1b}[?1003l\u{1b}[?1005l\u{1b}[?1006l\u{1b}[?12l"; let take_snapshot = "\u{1b}[?1049h"; let bracketed_paste = "\u{1b}[?2004h"; diff --git a/zellij-server/src/lib.rs b/zellij-server/src/lib.rs index b8cbbc5dc..690304bb5 100644 --- a/zellij-server/src/lib.rs +++ b/zellij-server/src/lib.rs @@ -116,7 +116,7 @@ pub(crate) enum SessionState { } pub fn start_server(os_input: Box, socket_path: PathBuf) { - info!("starts server"); + info!("Starting Zellij server!"); daemonize::Daemonize::new() .working_directory(std::env::current_dir().unwrap()) .umask(0o077) diff --git a/zellij-server/src/logging_pipe.rs b/zellij-server/src/logging_pipe.rs index eecfa2d3c..a2658cf9b 100644 --- a/zellij-server/src/logging_pipe.rs +++ b/zellij-server/src/logging_pipe.rs @@ -3,7 +3,7 @@ use std::{ io::{Read, Seek, Write}, }; -use log::{debug, error, info}; +use log::{debug, error}; use wasmer_wasi::{WasiFile, WasiFsError}; use zellij_utils::serde; @@ -22,13 +22,6 @@ pub struct LoggingPipe { impl LoggingPipe { pub fn new(plugin_name: &str, plugin_id: u32) -> LoggingPipe { - info!( - "|{:<25.25}| {} [{:<10.15}] Creating decorating pipe for plugin: {}!", - plugin_name, - Local::now().format("%Y-%m-%d %H:%M:%S.%3f"), - format!("id: {}", plugin_id), - plugin_name - ); LoggingPipe { buffer: VecDeque::new(), plugin_name: String::from(plugin_name), @@ -49,11 +42,12 @@ impl LoggingPipe { impl Read for LoggingPipe { fn read(&mut self, buf: &mut [u8]) -> std::io::Result { + // NOTE: should we do this? I think if anyone were to chain LoggingPipe and read from it, + // they would see very weird behavior because we drain self.buffer in `flush`. Also, logs would be screwed up. + // Consider removing this code. let amt = std::cmp::min(buf.len(), self.buffer.len()); - for (i, byte) in self.buffer.drain(..amt).enumerate() { - buf[i] = byte; - } - Ok(amt) + let data: Vec<_> = self.buffer.drain(..amt).collect(); + buf.as_mut().write(&data) } } diff --git a/zellij-utils/src/logging.rs b/zellij-utils/src/logging.rs index d7f35344d..7e57eebda 100644 --- a/zellij-utils/src/logging.rs +++ b/zellij-utils/src/logging.rs @@ -7,7 +7,7 @@ use std::{ path::{Path, PathBuf}, }; -use log::{info, LevelFilter}; +use log::LevelFilter; use log4rs::append::file::FileAppender; use log4rs::config::{Appender, Config, Logger, Root}; @@ -59,8 +59,6 @@ pub fn configure_logger() { .unwrap(); let _ = log4rs::init_config(config).unwrap(); - - info!("Zellij logger initialized"); } pub fn atomic_create_file(file_name: &Path) -> io::Result<()> { From 0cabc5f11291da1814abbf4ce68676b4d338f43a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Palenica?= Date: Tue, 20 Jul 2021 22:17:26 -0700 Subject: [PATCH 16/18] Read from LoggingPipe returns error --- zellij-server/src/logging_pipe.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/zellij-server/src/logging_pipe.rs b/zellij-server/src/logging_pipe.rs index a2658cf9b..f1fae6b83 100644 --- a/zellij-server/src/logging_pipe.rs +++ b/zellij-server/src/logging_pipe.rs @@ -41,13 +41,11 @@ impl LoggingPipe { } impl Read for LoggingPipe { - fn read(&mut self, buf: &mut [u8]) -> std::io::Result { - // NOTE: should we do this? I think if anyone were to chain LoggingPipe and read from it, - // they would see very weird behavior because we drain self.buffer in `flush`. Also, logs would be screwed up. - // Consider removing this code. - let amt = std::cmp::min(buf.len(), self.buffer.len()); - let data: Vec<_> = self.buffer.drain(..amt).collect(); - buf.as_mut().write(&data) + fn read(&mut self, _: &mut [u8]) -> std::io::Result { + Err(std::io::Error::new( + std::io::ErrorKind::Other, + "Can not reed from a LoggingPipe", + )) } } From 56b7cbf58cd9aae162a5037ee536c64818b0dd11 Mon Sep 17 00:00:00 2001 From: qepasa Date: Wed, 21 Jul 2021 07:19:39 +0200 Subject: [PATCH 17/18] Cleanup Cargo.toml --- zellij-client/Cargo.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/zellij-client/Cargo.toml b/zellij-client/Cargo.toml index 731c0d452..b9edb0ad1 100644 --- a/zellij-client/Cargo.toml +++ b/zellij-client/Cargo.toml @@ -14,7 +14,6 @@ termbg = "0.2.3" zellij-utils = { path = "../zellij-utils/", version = "0.16.0" } log = "0.4.14" - [dev-dependencies] insta = "1.6.0" From 290704a0568a831eb2b7e77c3f0f1f5ee69edf4b Mon Sep 17 00:00:00 2001 From: qepasa Date: Wed, 21 Jul 2021 07:20:07 +0200 Subject: [PATCH 18/18] Cleanup Cargo.toml --- zellij-server/Cargo.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/zellij-server/Cargo.toml b/zellij-server/Cargo.toml index e3015aaad..c9c6491ed 100644 --- a/zellij-server/Cargo.toml +++ b/zellij-server/Cargo.toml @@ -23,7 +23,6 @@ log = "0.4.14" typetag = "0.1.7" chrono = "0.4.19" - [dev-dependencies] insta = "1.6.0"