mirror of
https://github.com/zellij-org/zellij.git
synced 2024-11-22 13:02:12 +03:00
8031d6bf64
* xtask/pipeline: Fix publish task which was previously stuck in an infinite loop after successfully publishing a crate. The error originated in the code only checking for error conditions but not breaking out of the inner infinite loop in case of success. * xtask: Improve publish failure UX by offering the user more actions to choose from when an error occured. * utils/assets: Add generated prost files to assets to make sure they're available at build time and are picked up by all components. It seems we hit some strange bug with the build script where, when running `cargo publish --dry-run` the build script **is not** run before regularly compiling zellij-utils. This shouldn't happen according to the docs, but I cannot explain what's causing it. So we're using this as a workaround for now to make a smooth release. * xtask: Prevent accidental git commit deletion when dry-running a publish. * utils: Add comments to protobuf-related code to explain why these changes were performed. The comments all include a link to an issue comment explaining the situation in greater detail. * xtask: Build protobuf definitions when building any part of the project, similar to how we build the plugins when required. This should ensure that all crates built through `cargo xtask` (which is the officially supported build method) will receive up-to-date protobuf definitions.
34 lines
1.2 KiB
Rust
34 lines
1.2 KiB
Rust
// NOTE: This build script is currently out of order.
|
|
// Refer to [the PR introducing this change][1] to learn more about the reasons.
|
|
// TL;DR: The build script doesn't work during a `cargo publish --dry-run` and to ensure we can
|
|
// make a release, we decided to temporarily disable it.
|
|
//
|
|
// [1]: https://github.com/zellij-org/zellij/pull/2711#issuecomment-1695015818
|
|
|
|
//use prost_build;
|
|
//use std::fs;
|
|
|
|
fn main() {
|
|
//let mut prost_build = prost_build::Config::new();
|
|
//let out_dir = concat!(env!("CARGO_MANIFEST_DIR"), "/assets/prost");
|
|
//let out_dir = std::path::Path::new(out_dir);
|
|
|
|
//std::fs::create_dir_all(out_dir).unwrap();
|
|
//prost_build.out_dir(out_dir);
|
|
//prost_build.include_file("generated_plugin_api.rs");
|
|
//let mut proto_files = vec![];
|
|
//for entry in fs::read_dir("src/plugin_api").unwrap() {
|
|
// let entry_path = entry.unwrap().path();
|
|
// if entry_path.is_file() {
|
|
// if let Some(extension) = entry_path.extension() {
|
|
// if extension == "proto" {
|
|
// proto_files.push(entry_path.display().to_string())
|
|
// }
|
|
// }
|
|
// }
|
|
//}
|
|
//prost_build
|
|
// .compile_protos(&proto_files, &["src/plugin_api"])
|
|
// .unwrap();
|
|
}
|