LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-16 08:50:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "LibWeb: Use memcpy() in CanvasRenderingContext2D.getImageData()"

Browse Source 
This reverts commit 59cb7994c6.

This change caused a bug where getImageData returned the image in
BGRA8888 format instead of RGBA8888.
This commit is contained in:
circl 2024-06-14 15:04:14 +02:00 committed by Andreas Kling
parent c14369e2e3
commit d2f9ba7db1
Notes: sideshowbarker 2024-07-17 09:48:50 +09:00 
Author: https://github.com/circl-lastname
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d2f9ba7db1
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/166
Issue: https://github.com/LadybirdBrowser/ladybird/issues/120
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp
View File

@ -360,9 +360,10 @@ WebIDL::ExceptionOr<JS::GCPtr<ImageData>> CanvasRenderingContext2D::get_image_da
// 6. Set the pixel values of imageData to be the pixels of this's output bitmap in the area specified by the source rectangle in the bitmap's coordinate space units, converted from this's color space to imageData's colorSpace using 'relative-colorimetric' rendering intent.
// FIXME: Can't use a Gfx::Painter + blit() here as it doesn't support ImageData bitmap's RGBA8888 format.
for (int target_y = 0; target_y < source_rect_intersected.height(); ++target_y) {
auto* dst = image_data->bitmap().scanline(target_y);
auto const* src = bitmap.scanline(target_y + y) + x;
memcpy(dst, src, source_rect_intersected.width() * sizeof(Gfx::ARGB32));
for (int target_x = 0; target_x < source_rect_intersected.width(); ++target_x) {
auto pixel = bitmap.get_pixel(target_x + x, target_y + y);
image_data->bitmap().set_pixel(target_x, target_y, pixel);
}
}
// 7. Set the pixels values of imageData for areas of the source rectangle that are outside of the output bitmap to transparent black.