Commit Graph

1976 Commits

Author SHA1 Message Date
Michael Muré
45f5f852b7
core: generalized resolvers to resolve any entity time when unmarshalling an operation 2022-08-18 15:55:48 +02:00
Michael Muré
cd52872475
Merge pull request #835 from MichaelMure/op-base
entity/dag: proper base operation for simplified implementation
2022-08-01 17:16:45 +02:00
Michael Muré
56966fec55
build: go 1.18 minimum 2022-07-31 14:47:07 +02:00
Michael Muré
d179b8b7ec
bug: fix an issue where Id would be used, then changed due to metadata 2022-07-31 14:38:32 +02:00
Michael Muré
3d454d9dc8
entity/dag: proper base operation for simplified implementation
- reduce boilerplace necessary to implement an operation
- consolidate what an operation is in the core, which in turn pave the way for a generic cache layer mechanism
- avoid the previously complex unmarshalling process
- support operation metadata from the core
- simplified testing
2022-07-25 13:27:17 +02:00
Michael Muré
2ade8fb1d5
doc: more tiny fixes 2022-06-25 12:49:50 +02:00
Michael Muré
c6be058871
doc: more tiny fixes 2022-06-25 12:44:42 +02:00
Michael Muré
b43a447ab6
doc: tiny tweaks 2022-06-25 12:20:32 +02:00
Steve Moyer
00b9e1a602
Merge pull request #817 from MichaelMure/refactor/guarantee-test-cleanup
refactor(809): guarantee test cleanup
2022-06-24 09:52:58 -04:00
Steve Moyer
fd248de1eb
Merge branch 'master' into refactor/guarantee-test-cleanup 2022-06-22 11:08:20 -04:00
Steve Moyer
323dd0e293
test(809): do not export function that returns GoGit filesystem 2022-06-22 10:46:52 -04:00
Steve Moyer
6fc6a0f0ab
test(809): remove reliance on repo's filesystem 2022-06-22 10:38:09 -04:00
Steve Moyer
52c724a033
test: use testing.TB as common interface 2022-06-21 06:48:28 -04:00
Michael Muré
b694052c46
Merge pull request #807 from MichaelMure/default-repo-name
cache: ensure that the default repo has a non-empty name to make js/apollo happy
2022-06-18 22:44:28 +02:00
Steve Moyer
f3d316d16c
test(809): remove remaining calls to InitGoRepo in tests
Note that examples still need to shown how a developer would use the library.
2022-06-16 19:45:51 -04:00
Steve Moyer
97ae544878
Merge branch 'master' into refactor/guarantee-test-cleanup 2022-06-16 09:04:18 -04:00
Steve Moyer
1d4667c825
refactor(809): eliminate need to defer CleanupTestRepos() 2022-06-16 09:02:52 -04:00
Steve Moyer
f80910891e
Merge pull request #808 from selesy/fix/778-git-bug-rm-broken
fix(778): git bug rm broken
2022-06-15 10:47:16 -04:00
Steve Moyer
d853a6fbc9
test(778): simplify and guarantee backend cleanup 2022-06-15 10:23:33 -04:00
Steve Moyer
0a9aaa9442
refactor(778): test only command implementations 2022-06-15 09:07:00 -04:00
Michael Muré
b33c1d42fc
Merge pull request #795 from MichaelMure/dependabot/go_modules/github.com/xanzy/go-gitlab-0.68.0
build(deps): bump github.com/xanzy/go-gitlab from 0.64.0 to 0.68.0
2022-06-12 21:54:16 +02:00
Michael Muré
7e9c1b230c
Merge pull request #814 from MichaelMure/dependabot/go_modules/github.com/stretchr/testify-1.7.2
build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2
2022-06-12 21:53:55 +02:00
Steve Moyer
941f5b3fc3
chore(808): rearrange imports to git-bug convention 2022-06-07 08:01:19 -04:00
Steve Moyer
6ec7d67ea1
test(808): document getCWD() and clean-up arguments 2022-06-07 07:45:30 -04:00
Steve Moyer
f0f52472dc
test(808): skip root help test that uses a golden file 2022-06-07 07:34:04 -04:00
dependabot[bot]
3b77af72ec
build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.1...v1.7.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-07 04:09:38 +00:00
Steve Moyer
848f72537d
fix(808): remove duplication stderr/stdout set-up 2022-06-06 10:13:42 -04:00
Steve Moyer
54306a8f0a
test(808): make build tag compatible with Go 1.16 2022-06-06 09:49:13 -04:00
Steve Moyer
99669d77b1
test(808): do not run golden file tests on Windows 2022-06-06 09:38:15 -04:00
Steve Moyer
1a504e0522
fix(808): simplify handling of Windows line terminations 2022-06-06 09:01:02 -04:00
Steve Moyer
5982e8fb3c
chore(808): merge in LocalStorage namespace configuration 2022-06-06 08:39:40 -04:00
Steve Moyer
8fc93d8824
Merge branch 'master' into fix/778-git-bug-rm-broken 2022-06-06 08:31:42 -04:00
Steve Moyer
cd1099aac8
fix(808): replace Windows line terminators 2022-06-06 08:25:36 -04:00
Michael Muré
dd8134b638
Merge pull request #803 from MichaelMure/feat/configurable-local-storage
Feat/configurable local storage
2022-06-06 13:26:29 +02:00
Michael Muré
ee0bac6b54
Merge pull request #813 from MichaelMure/fix-data-race2
Github: fix data race
2022-06-06 12:54:20 +02:00
Michael Muré
c2d7b1271f
Merge pull request #811 from MichaelMure/fix-data-race
graphql: fix two invalid mutex lock leading to data races
2022-06-06 12:53:23 +02:00
Michael Muré
7348fb9edb
github: fix data race when closing event channel
I believe the issue was twofold:

When done importing, the calling context is likely still valid, so if the output channel is not read enough and reach capacity, some event producer down the line can be blocked trying to send in that channel. When closing it, this send is still trying to proceed, which is illegal in go.

In rateLimitHandlerClient, there was a need to 2 different type of output channel: core.ExportResult and ImportEvent. To do so, the previous code was using a single channel type RateLimitingEvent and a series of goroutines to read/cast/send to the final channel. This could result in more async goroutine being stuck trying to send in an at-capacity channel. Instead, the code now use a simple synchronous callback to directly push to the final output channel. No concurrency needed anymore and the code is simpler.

Any of those fixes could have resolved the data race, but both fixes is more correct.
2022-06-05 15:13:49 +02:00
Michael Muré
fe231231c6
graphql: fix two invalid mutex lock leading to data races 2022-06-05 13:23:02 +02:00
Steve Moyer
eda312f9b1
fix(778): remove extra mutex lock when resolving bug prefix 2022-05-31 21:25:23 -04:00
Michael Muré
295da9c70f cache: ensure that the default repo has a non-empty name to make js/apollo happy 2022-05-31 21:47:57 +02:00
Michael Muré
96327c3371
Merge pull request #806 from MichaelMure/docs
doc: more discoverable docs
2022-05-31 20:20:25 +02:00
Michael Muré
1c219f6769 doc: more discoverable docs 2022-05-31 20:18:18 +02:00
Michael Muré
d94df63466
Merge pull request #805 from MichaelMure/completion-cleanup
misc: move all completions in a dedicated folder
2022-05-31 20:16:15 +02:00
Michael Muré
c732a18ac2 misc: move all completions in a dedicated folder 2022-05-31 19:44:53 +02:00
Steve Moyer
ccc342e814
refactor: simplify creation of temp dir - after 1.15 2022-05-31 07:47:56 -04:00
Steve Moyer
da9f95e495
fix: remove only t.Parallel() 2022-05-31 07:22:55 -04:00
Michael Muré
50de0306df
gogit: close index before deleting it on disk 2022-05-31 12:24:58 +02:00
Steve Moyer
86dd450aaf
test: clean up temp dir and repo correctly 2022-05-31 12:04:26 +02:00
Steve Moyer
90208b5f6d
test(778): execute rm bug in testEnv (hangs) 2022-05-28 10:38:04 -04:00
Steve Moyer
ecfffe3902
test(778): execute add user in testEnv and return userID 2022-05-28 10:30:44 -04:00