This ensures that, for implementation details, bits that use stage-0 as
a synonym for stage-1 when it is not supported gets the same exact eval
than the one for stage-1.
Without this change, some `fdt-forward` and changes made under that
`mkIf` would end-up included. `fdt-forward` was found to be in the
stage-1 image even though it was irrelevant.
... this way, the framebuffer content is not evicted by a needless mode
change.
AFAIK none of our targets will be affected by this change. The
framebuffer should already be setup with the correct mode. This was
holdover from early early cargo-culting about the framebuffer.
I have verified on a few devices, it does not worsen their behaviour.
Technically this is an issue from 5.1, but the patch won't apply on 5.1,
so let's target the following stable release.
It serves no purpose to force on 5.1~5.3 which are EOL and should not
have been used as a base by vendors.
By using a square aspect ratio logo as the source material, we can
"fill" the area, which will not go outside of the bounds, which implies
that the image is scaled to the smaller dimension.
This image is then trimmed, meaning that it is cut to remove any
redundant colour at the outside edge.
There is no `override` that will work given the number of `callPackage`
calls between this and the actual derivation.
I guess `overrideAttrs` could be used instead, if we used an attribute
of the derivation instead. I'm not sure if it's better since it would
entail using `apply` to `overrideAttrs` the final `kernel.package`
value.
It is generally awkward to deal with the console kernel parameters, and
just as awkward to deal with lists in the modules system.
Internally to Mobile NixOS, we'll use these values that should always be
prefixed to any other values. This means that those consoles will likely
to be less preferred than any the end-users sets (e.g. `console=tty1` in
their own config).
The option for `defaultConsole` is not really meant to be
user-controlled, but there is actually no issue if they use it, as long
as their configuration does not set another console later in the
cmdline.
A NixOS change for systemd-stage-1 added an `x-` mount option, which is
not handled well by busybox mount.
- 1b39491326
The same option was not an issue for the shell-script stage-1 as it
already stripped `x-` mount options
- 8be838254b/nixos/modules/system/boot/stage-1-init.sh (L365-L366)
Thus it's assumed safe to strip the options the same way.
