Commit Graph

150 Commits

Author SHA1 Message Date
Jasper Woudenberg
07076cea55
Merge pull request #14 from NoRedInk/segmented-control-styling-fixes
Segmented control styling fixes
2018-03-27 13:47:56 +02:00
Hardy Jones
349e9760a3
Use V2 of the segmented control in the style guide 2018-03-26 19:56:20 -07:00
Hardy Jones
a00262c3aa
Set the backround color directly
The `initial` `background-color` is `transparent`.
We got away with not setting the background color before
as we were always using segmented controls on top of white backgrounds.

We now want to use a segmented control atop a non-white background,
so we have to explicitly set the `background-color`.
2018-03-26 19:53:33 -07:00
Hardy Jones
7ebb488786
Style the tabs directly
tl;dr; Use a class for each variant instead of overriding one variant.

Before, we relied on CSS specificity in an unclear way.
The `Focused` class was applying properly because it was ordered later
than the `Tab` class in the stylesheet.
The ordering that is important is the ordering in `styles` value.
Since `elm-css` generates the stylesheet in the order of the lists,
the `Focused` rule would be generated after the `Tab` rule.
Meaning the `Focused` rule would take precedence over the `Tab` rule
if an element had both classes as it was defined later in the stylesheet.

There are some concerns with this approach:
1. It's not readily apparent that the ordering in `styles` is important.
    It is pretty easy to change the ordering of the list
    and have it break the styling.
2. We rely on `elm-css` to generate the stylesheet in a specific order.
    If it changes the order of rules it generates,
    we're almost surely going to break the styling.
3. Altering styles for tabs that are not focused is even less intuitive.
    Since the specificity is the same,
    you might not know why a given rule applies (or doesn't apply).

Rather, we can eschew the specificity/precedence issues
by applying a different class to each tab.
The stuff that is the same can stay on the `Tab` class,
and the stuff that differs can be on different classes.
2018-03-26 19:53:19 -07:00
Hardy Jones
dd164e3e57
Bump version to 3.4.0 2018-03-26 16:26:36 -07:00
Hardy Jones
c838f4f322
Merge pull request #11 from NoRedInk/add-segmented-control
Add `SegmentedControl`
2018-03-26 16:23:10 -07:00
Richard Feldman
6b71b4378a
Merge pull request #13 from NoRedInk/add-forgotten-module
Add forgotten module
2018-03-26 17:49:22 -04:00
Brooke
25ddfb8e8e bump elm-package to 3.3.0 2018-03-26 14:24:16 -07:00
Brooke
e86fd17d2f add forgotten module to exposed-modules 2018-03-26 14:23:24 -07:00
Brooke
dad9d3e62f
Merge pull request #12 from NoRedInk/add-nri-styled
Add Nri.Ui.styled
2018-03-26 13:59:47 -07:00
Brooke
0297d2fda6 bump elm-package version 2018-03-26 12:39:36 -07:00
Brooke
5147e5c056 add Nri.Ui.styled 2018-03-26 12:08:16 -07:00
Jasper Woudenberg
af6fb30993 Add box-sizing attribute to segmented control
On the monolith we have a base css file somewhere that adds this
property by default. In this package we don't (and even if we did, we
couldn't bundle it with the elm code), so this commit adds the property
manually on a div that needs it.
2018-03-26 10:21:23 +02:00
Hardy Jones
3b99ba56a7
Add SegmentedControl 2018-03-23 19:05:34 -07:00
Tessa
ecf4de663c
Merge pull request #9 from NoRedInk/butteroala__condense-with-nri-elm-css
Butteroala  condense with nri elm css
2018-03-20 10:37:37 -07:00
Tessa Kelly
b4853feb69 MINOR version bump 2018-03-19 15:56:52 -07:00
Tessa Kelly
157d7d8a49 Adds the unused bool back into the Checkbox.V1 2018-03-19 15:56:12 -07:00
Tessa Kelly
e869f064ff Adds new version of the checkbox 2018-03-19 15:55:04 -07:00
Tessa Kelly
8766a17f4d Revert "MAJOR package bump"
This reverts commit b938cfc527.
2018-03-19 15:51:59 -07:00
Tessa Kelly
b938cfc527 MAJOR package bump 2018-03-16 17:33:43 -07:00
Tessa Kelly
af3feeed83 Expose the new modules 2018-03-16 17:33:25 -07:00
Tessa Kelly
98a8a5458c Remove dependency on nri-elm-css 2018-03-16 17:33:24 -07:00
Tessa Kelly
63d7178b32 🐛 fix duplicated package install (not sure how this every worked 😬:) 2018-03-16 17:33:24 -07:00
Tessa Kelly
e7b5d0e878 Nri.Colors -> Nri.Ui.Colors.V1 2018-03-16 17:33:24 -07:00
Tessa Kelly
ef390c606c Nri.Fonts -> Nri.Ui.Fonts.V1 2018-03-16 17:15:03 -07:00
Tessa Kelly
231911b013 Remove Nri.UI.Text dependency on Nri.Stylers 2018-03-16 17:12:55 -07:00
Tessa Kelly
f60277cc8b Remove dependence on Nri.Stylers for the outline 2018-03-16 17:09:37 -07:00
Tessa Kelly
bba1269d5f Remove checkbox dependence on nri stylers 2018-03-16 17:07:07 -07:00
Tessa Kelly
b72b362547 Remove dependency on NRi.Styelrs 2018-03-16 17:04:56 -07:00
Tessa Kelly
319c37caf4 Remove final dependence on Nri.Accessibility
Note: breaking API change. Better to keep the useless bool around..?
2018-03-16 16:53:43 -07:00
Tessa Kelly
ccb873e9be 💀 kill unused attribute 2018-03-16 16:47:31 -07:00
Tessa Kelly
ca240968f0 🎨 clean up uses of TextIntput.view_ 2018-03-16 16:45:24 -07:00
Tessa Kelly
15a3cb407f Replace the invisible label class with accessible html use 2018-03-16 16:44:23 -07:00
Tessa Kelly
e05c353980 Remove dependency on Nri.Accessibility from the inputs 2018-03-16 16:41:34 -07:00
Tessa Kelly
4ca27fc05c 🎨 clean up example code styles 2018-03-16 16:24:29 -07:00
Tessa Kelly
f9c3884e6a Adds Colors 2018-03-16 16:24:29 -07:00
Tessa Kelly
38eaee2eb2 Adds colors modules 2018-03-16 16:24:09 -07:00
Tessa Kelly
186a19e7f4 Adds user generated font style 2018-03-16 16:24:09 -07:00
Tessa Kelly
c406c5353d Adds Fonts as a category 2018-03-16 16:24:09 -07:00
Tessa Kelly
7f7826bcae Display the Fonts 2018-03-16 16:24:09 -07:00
Tessa Kelly
f87f3ae482 Copy over fonts from nri-elm-css 2018-03-16 16:18:18 -07:00
Jasper Woudenberg
d9067dee09 3.1.1 2018-03-13 10:22:35 +01:00
Jasper Woudenberg
d0129fc514
Merge pull request #8 from NoRedInk/tweak-ccs-textarea-styles
Tweak styles for the CCS textarea
2018-03-13 10:20:19 +01:00
Jasper Woudenberg
614eb87070 Tweak styles for the CCS textarea 2018-03-13 10:18:44 +01:00
Jasper Woudenberg
41930416e0 Bump version to 3.1.0 2018-03-13 10:11:34 +01:00
Jasper Woudenberg
7c3f6f4f6c
Merge pull request #7 from NoRedInk/textarea-for-content-creation
Add text area for content creation
2018-03-13 10:11:12 +01:00
Jasper Woudenberg
cf2dec09fd Add text area for content creation
The styling used for this textarea is not quite the same as the one of
the default or writing textareas currently in use.
2018-03-13 10:08:07 +01:00
Jasper Woudenberg
01518a444f Bump version to 3.0.0
This is a major release, but really only for projects depending on the
TextArea module. That, at the moment, does not include the monolith.
2018-03-12 20:25:06 +01:00
Jasper Woudenberg
f19903e3d3
Merge pull request #5 from NoRedInk/update-textarea
Update textarea
2018-03-12 20:04:18 +01:00
Tessa Kelly
6e7bb28f6f Bump version 2018-03-08 11:53:32 -08:00