Commit Graph

286 Commits

Author SHA1 Message Date
Jasper Woudenberg
5d5ef7f5d4 Add note on upgrading from Nri.Ui.Table.V1 2018-05-03 09:36:57 +02:00
Jasper Woudenberg
243cae984a 💀 Remove dead code 2018-05-03 09:24:42 +02:00
Jasper Woudenberg
181697d8bb Reinstitute padding for loading styles
The table loading styles require the paddings that are removed for the
general table case. That's okay: the table loading styles do not support
putting custom content in cells, and so the option of setting custom
paddings for content will not be missed.
2018-04-30 15:07:22 +02:00
Jasper Woudenberg
66c079f3cc Vertically align content in table cells by default
The previous removal of default table cell padding makes the default
alignment in content look weird. Adding a vertical alignment property
fixes this.

We previously removed the default padding because it did not play nice
with designs requiring less padding. Does the addition of vertical
alignment create a similar problem? I'd argue now. Padding cannot be
easily countered. Vertical alignment can easily be countered by
embedding div's in the cells with custom styling.
2018-04-30 14:08:04 +02:00
Jasper Woudenberg
6b9e35071b Remove default cell padding
We've run into a situation in CCS where the default padding added to
cells are to large. Considering it is much harder to remove a padding
from the outside then it is to add one, this commit removes the default
cell padding for tables.
2018-04-30 13:58:54 +02:00
Jasper Woudenberg
81fa1b0bc6 Update classnames for V2 2018-04-30 13:56:56 +02:00
Jasper Woudenberg
dc87a14925
Merge branch 'master' into table-v2 2018-04-30 10:19:11 +02:00
Juan Edi
9fe7b3ed81 Bump to 4.10.0 2018-04-25 17:49:26 -03:00
Juan Edi
a1ded12682
Merge pull request #43 from NoRedInk/gw--add-icon
Add guidedWrite icon
2018-04-25 17:44:33 -03:00
Jasper Woudenberg
72a4a1c5e6 elm-format 2018-04-25 19:29:22 +02:00
Jasper Woudenberg
8f344774c3 Switch Table.V2 over to Html.Styled
This is probably better then relying on more deprecated elm css
functionality, like we were before.
2018-04-25 19:25:34 +02:00
Jasper Woudenberg
de10ffb43e New table version that takes any css width
This way you're not limited to creating tables with fixed-width columns.
This also makes the table take up the maximum available width space by
default.
2018-04-25 19:10:34 +02:00
Juan Edi
88ed81cfc0 Add guidedWrite icon 2018-04-25 13:54:14 -03:00
Jasper Woudenberg
021e91d505
Merge pull request #42 from NoRedInk/make-table-styles-explicit
Make table styles explicit
2018-04-25 14:25:00 +02:00
Jasper Woudenberg
e0e22c9e09 Bump 4.9.1 2018-04-25 14:20:42 +02:00
Jasper Woudenberg
540b5b4e71 Make some styles of the table explicit
The table styles are currently depending on some browser styles. If
those are disabled (for instance using a reset.css file), then tables do
not look correct. This makes explicit styles that are currently coming
from the browser.
2018-04-25 14:19:28 +02:00
Jasper Woudenberg
f9ed6530bc
Merge pull request #41 from NoRedInk/bump-4.9.0
Bump version to 4.9.0
2018-04-25 09:38:50 +02:00
Jasper Woudenberg
cb930b6205 Bump version to 4.9.0 2018-04-25 09:34:01 +02:00
Hardy Jones
9bdc888923
Merge pull request #40 from NoRedInk/extract-nri-table
Extract `Nri.Table`
2018-04-24 17:11:48 -07:00
Jasper Woudenberg
979a49002f Expose Nri.Ui.Table.V1 2018-04-24 18:45:53 +02:00
Jasper Woudenberg
4c8f2cae89 Add keyframe animations to styleguide example
Also provide a function for easily embedding said keyframes into a page.
2018-04-24 18:36:37 +02:00
Jasper Woudenberg
5580edaa7d Collapse border tables
In the monolith we seem to inherit this bit of styling from somewhere.
For `noredink-ui` we need to make it explicit.
2018-04-24 17:56:43 +02:00
Jasper Woudenberg
e950661c8b Add Table to the styleguide application 2018-04-24 17:49:29 +02:00
Jasper Woudenberg
4920316a54 Extract Nri.Table into noredink-ui 2018-04-24 17:43:26 +02:00
Hardy Jones
caa429d013
Merge pull request #39 from NoRedInk/bump-version-to-4.8.0
Bump version to 4.8.0
2018-04-18 08:12:59 -07:00
Hardy Jones
4a366154b0
Merge branch 'master' into bump-version-to-4.8.0 2018-04-18 08:10:56 -07:00
Hardy Jones
64635bdc74
Bump version to 4.8.0 2018-04-18 08:09:51 -07:00
Hardy Jones
71cd1653e7
Merge pull request #38 from NoRedInk/expand-select
Expand select
2018-04-18 08:07:27 -07:00
Hardy Jones
df328ec686
Expose select v2 2018-04-18 08:01:31 -07:00
Hardy Jones
cbb7c34225
Test the new select version
We make a suite that checks the behavior of both versions.
Assuming they have the same API, this should work.

If we add another version and it changes the API,
we might want to rethink this approach.
2018-04-18 07:59:26 -07:00
Hardy Jones
1647b2f358
Make selects expand to the full width of parent
There are places where we need the select to be as wide as possible.
Since it seems like a sensible default to have all the selects expand,
we take that approach.

If we find out that this is harder, we can release use the old version.
2018-04-18 07:58:19 -07:00
Hardy Jones
537425f94c
Merge pull request #37 from NoRedInk/extract-select-tests
Extract tests for select from the monolith
2018-04-18 07:36:49 -07:00
Hardy Jones
276d20c3ef
Extract tests for select from the monolith
This was forgotten in the extraction PR.
Just moves the tests over verbatim.
2018-04-17 11:25:29 -07:00
Hardy Jones
2e7701d34b
Merge pull request #36 from NoRedInk/bump-version-to-4.7.0
Bump version to 4.7.0
2018-04-17 08:20:08 -07:00
Hardy Jones
b0203cdffc
Bump version to 4.7.0 2018-04-17 08:15:44 -07:00
Ian Davies
3ed8d7d327
Merge pull request #35 from NoRedInk/extract-select
Extract `Nri.Select`
2018-04-17 16:09:48 +01:00
Hardy Jones
5036c63e28
Merge branch 'master' into extract-select 2018-04-17 07:56:22 -07:00
Ian Davies
058a3cd2db
Merge pull request #34 from NoRedInk/extract-dropdown
Extract `Nri.Dropdown`
2018-04-17 15:54:21 +01:00
Hardy Jones
d5567b6f3d
Expose Nri.Ui.Select.V1 2018-04-16 15:51:17 -07:00
Hardy Jones
4977d00361
Style the selector
We need some styling that was implicit in the monolith.
2018-04-16 15:50:28 -07:00
Hardy Jones
144eff1af7
Un-pipeline niceId
It's a bit clearer what we're doing in `niceId`
if we remove the indirection of the pipeline.
2018-04-16 15:43:06 -07:00
Hardy Jones
bffaae0e3f
Extract Nri.Select from the monolith 2018-04-16 15:43:01 -07:00
Hardy Jones
51ab788083
Expose dropdown module 2018-04-16 13:13:31 -07:00
Hardy Jones
199689abd0
Style the dropdown 2018-04-16 13:12:17 -07:00
Hardy Jones
1b86ec442f
Extract Nri.Dropdown to noredink-ui
There are a couple of minor differences here.
Some of the dependencies we had were inlined.
_Should_ be no behavioral changes though.
2018-04-16 12:19:43 -07:00
James Gary
115819c2a3
Merge pull request #33 from NoRedInk/james__add_skip_icon
Add skip icon
2018-04-04 16:25:48 -07:00
James Gary
8ba5bfec44 Minor version bump 2018-04-04 09:35:34 -07:00
James Gary
a4d3448b47 Add skip icon 2018-04-04 09:34:42 -07:00
Jasper Woudenberg
1d1085ce68
Merge pull request #32 from NoRedInk/butteroala__add-icons
Butteroala  add icons
2018-04-03 08:52:04 +02:00
Tessa Kelly
cb6f0fcfc3 MINOR version bump 2018-04-02 17:20:02 -07:00