Ary Borenszweig
98b348325a
Fix autoresize not working well in Firefox on page load
2024-04-11 16:24:18 -03:00
nora-dingbot[bot]
a61ed6a1de
Merge #1665
...
1665: Visual highlighter overlap tests r=micahhahn a=omnibs
Adds new tests for `Nri.Ui.Highlighter.V5`'s `selectShortest` function, making scenarios easier to inspect and craft visually.
No API changes anywhere.
Co-authored-by: Juliano Solanho <juliano.solanho@gmail.com>
2024-04-03 19:59:12 +00:00
Juliano Solanho
9cf767a786
Remove redundant tests from spec/Highlighter.elm
2024-04-03 10:18:51 -03:00
Juliano Solanho
9b6c3767e8
Add more scenarios
2024-04-03 09:20:51 -03:00
Juliano Solanho
6d875f851e
Try out making a visual highlighter overlap test
2024-04-03 09:09:26 -03:00
Juan Edi
89848322ec
Merge pull request #1664 from NoRedInk/bump-to-28.3.1
...
Bump version to 28.3.1 - Highlighter performance improvements
2024-04-02 10:20:59 -03:00
Juan Edi
8d1232d735
bump version to 28.3.1
2024-04-02 10:05:15 -03:00
Juliano Solanho
77e4243b27
Merge pull request #1663 from NoRedInk/compute-overlaps-data-once
...
Compute overlaps data once
2024-04-01 17:07:53 -03:00
Juan Edi
9ae0605eca
reduce 1 more loop just because i can
2024-03-30 13:56:14 -03:00
Juan Edi
444b803618
do it all in a single fold
2024-03-30 13:38:41 -03:00
Juan Edi
fc5645659a
🎨 simplify
2024-03-30 13:29:36 -03:00
Juan Edi
691f560628
filter markers earlier on when calculating lengths
2024-03-30 13:25:41 -03:00
Juan Edi
14f06f3575
inline highlightlengths
2024-03-30 13:23:06 -03:00
Juan Edi
726f78f090
store the shortest hovered highlight directly
...
no need to differentiate between "single hovered highlight" and
"multiple hovered highlight" for so long if all we want is to calculate
the shortest.
2024-03-30 13:21:30 -03:00
Juan Edi
b481756377
try to make more information explicit in the types
2024-03-30 12:52:39 -03:00
Juan Edi
6fba9d1830
🎨 rename constructors
2024-03-30 12:40:37 -03:00
Juan Edi
e3072bd51a
view_ doesn't need the sorter anymore
2024-03-29 18:44:27 -03:00
Juan Edi
be2b6ed6cc
only compute the data for the overlaps case when we'll actually use it
2024-03-29 18:23:10 -03:00
Juan Edi
97777cdb5e
highlightLenghts won't compute anything if there's a single candidate
2024-03-29 18:13:58 -03:00
Juan Edi
e970dc00df
compute highlightLengths once, at the top
...
TODO: we are currently computing it unnecessarily some times. i'll fix that!
2024-03-29 18:10:40 -03:00
Juan Edi
b98e7a09c8
🎨 flip param order
2024-03-29 18:01:58 -03:00
Juan Edi
189f2cca28
isHovered: don't re-compute the currently hovered highlightable for every highlightable being tested
2024-03-29 18:00:50 -03:00
Juliano Solanho
229018babb
Merge pull request #1661 from NoRedInk/phx-1464-speed-up-highlighter-by-optimizing-select-shortest
...
Speed up highlighter by special casing `selectShortest` for non-overlapping case
2024-03-29 12:27:08 -03:00
Juliano Solanho
6a1fed094e
Merge remote-tracking branch 'origin/master' into phx-1464-speed-up-highlighter-by-optimizing-select-shortest
2024-03-29 11:54:01 -03:00
Juliano Solanho
fb3f1428c7
Merge pull request #1662 from NoRedInk/lazy-highlighter
...
Make Highlighter views lazy
2024-03-29 11:23:25 -03:00
Juan Edi
e827e33ba5
Take note of the change in the top level comment
2024-03-29 08:35:58 -03:00
Juan Edi
1d66f16140
make other highlighter views lazy by default
2024-03-29 08:30:07 -03:00
Juan Edi
d57a704190
make Highlighter.viewWithOverlappingHighlights lazy by default
2024-03-29 08:25:32 -03:00
Micah Hahn
9c26540f7d
Add Patch changes note
2024-03-28 16:51:49 -05:00
Micah Hahn
16d7451c23
🤖 elm-format
2024-03-28 16:50:34 -05:00
Micah Hahn
bc9aeea755
If there are 0 or 1 highlight kinds, we happen to know which one is shortest :)
2024-03-28 16:43:49 -05:00
Casey Webb
d2da6f11ec
Merge pull request #1660 from NoRedInk/bump-28.3.0
2024-03-21 08:10:02 -05:00
Erik Feeley
d49d4a0e03
bump version
2024-03-20 18:41:18 -04:00
Erik
ebd5f64952
Merge pull request #1657 from NoRedInk/kra-1441-add-caption-option-to-nriuimenu-groups
...
Add Menu.captionedGroup, text+menu css helpers, example
2024-03-20 10:47:17 -04:00
Casey Webb
0d055d0d07
Don't include aria-describedby when caption is not present
2024-03-19 16:24:56 -05:00
Erik
ab3fa49aa1
Merge pull request #1658 from NoRedInk/kraken/genres-icons
...
Kraken/genres icons
2024-03-19 09:06:32 -04:00
Erik Feeley
752bcff1a0
let circles live together
2024-03-18 16:47:19 -04:00
Casey Webb
4f31324bfc
Apply group caption css
2024-03-18 15:26:32 -05:00
Erik Feeley
4423b2daf6
adds examples for new genres icons
2024-03-18 16:25:17 -04:00
Erik Feeley
f32f0bb625
adds genres and genresCircled assignment icons
2024-03-18 16:25:05 -04:00
Casey Webb
1eb92abeec
Add Menu.captionedGroup, text+menu css helpers, example
2024-03-18 11:30:04 -05:00
Casey Webb
2a73e7b939
Merge pull request #1656 from NoRedInk/bump-28.2.0
2024-02-28 16:51:50 -06:00
Casey Webb
6c0fa964a6
Bump version 28.2.0
2024-02-28 15:07:41 -06:00
Casey Webb
ab2d5ab859
Merge pull request #1655 from NoRedInk/kraken/deep-sidenav-alignment
...
Fix indentation for deeply nested menu groups
2024-02-28 14:56:29 -06:00
Erik
f32dfef6e6
Merge pull request #1654 from NoRedInk/kraken/menu-container-stylin
...
Kraken/menu container stylin
2024-02-28 15:52:07 -05:00
Casey Webb
769e063568
elm-format, subtitle elm-lsp how could you do this to me
2024-02-28 14:30:55 -06:00
Casey Webb
2e95f4b99a
Use separate example for deeply nested menu
2024-02-28 14:28:26 -06:00
Casey Webb
91929e7ce5
Revert "Add deeply nested entry to SideNav examples"
...
This reverts commit 589fc9120a
2024-02-28 14:25:38 -06:00
Casey Webb
589fc9120a
Add deeply nested entry to SideNav examples
2024-02-28 14:22:35 -06:00
Casey Webb
af24384c59
Don't use extra styles on ul container'
2024-02-28 14:07:12 -06:00
