Commit Graph

4142 Commits

Author SHA1 Message Date
Tessa Kelly
a9fa26a023 Only show the premium pennant when the content is not free 2021-11-22 11:54:10 -08:00
Tessa Kelly
42a805f446 Replace intermediary InternalConfig structure 2021-11-22 11:39:11 -08:00
Tessa Kelly
ac119b6dd1 replace with containerCss helper 2021-11-22 11:19:10 -08:00
Tessa Kelly
2a4799cf4c Adds labelVisibility setting 2021-11-22 11:08:40 -08:00
Tessa Kelly
5600383d5d Move name into list of controlled attribtues 2021-11-22 11:06:08 -08:00
Tessa Kelly
bf8988f345 Move the premium level into the list
i think this exposes a weakness of the API -- the teacher premium level won't vary across the inputs, but we're still requiring the user to pass it in for every input
2021-11-22 11:04:28 -08:00
Tessa Kelly
df89d0597c Move pennant into example list 2021-11-22 10:47:58 -08:00
Tessa Kelly
ad0116ac2c Adds disabled/enabled helper 2021-11-22 10:42:39 -08:00
Tessa Kelly
d38d18f1f8 Adds debug controls settings 2021-11-22 10:31:17 -08:00
Tessa Kelly
ac12759931 make the premium behavior more clear 2021-11-22 10:06:38 -08:00
Alex Perkins
50a3ee8c16 wire in button controlling the input 2021-11-22 10:21:58 -05:00
Alex Perkins
f5865855f3 hide label on inline. No one is asking for this and it looks awful 2021-11-21 12:23:24 -05:00
Alex Perkins
3bfb389c9b Allow hiding the label. Why? See below
Explained in greater detail with a diagram in [this comment on the
work-in-progress pull
request](https://github.com/NoRedInk/noredink-ui/pull/787#issuecomment-974838245)
2021-11-21 09:57:38 -05:00
Alex Perkins
5d86a5fa31 wrap grey block with a button, not a div
This is so we can select the radio button when clicking anywhere in the
grey. So why not a <label>? Then the full contents of the disclosure
would be read out as the label content when picking options. That
content *describes* the radio button but it does not *label* it, and
should not be read out before "selected, n of m" and the rest of the
radio helper voiceover content.
2021-11-21 09:16:34 -05:00
Alex Perkins
e0ef0ccc73 and finally clean up the names of internalConfig and config all over 2021-11-19 17:15:49 -05:00
Alex Perkins
2db0f5a6af lift eventsAndValues into internalConfig 2021-11-19 17:10:16 -05:00
Alex Perkins
647967d1b2 lift config into internalConfig 2021-11-19 17:03:27 -05:00
Alex Perkins
6d095c0f6d move computed values from let blocks into internal config 2021-11-19 16:46:42 -05:00
Alex Perkins
6d2085a27d internal config helper 2021-11-19 16:32:24 -05:00
Alex Perkins
0d47f37ab9 make an explicit choice to display inline or in a block thing. use view helpers for those since branching inside of view was very unwieldy 2021-11-19 16:22:32 -05:00
Alex Perkins
1578dea074 add doc for none 2021-11-19 13:39:52 -05:00
Alex Perkins
7a5cfbc300 add describedBy and a no-op attribute 2021-11-19 12:36:45 -05:00
Alex Perkins
64409702ac remove obviated exteranl/internal view distinction; clarify when view does not render in doc comment 2021-11-19 10:13:18 -05:00
Alex Perkins
9abfa3bc68 add bullet to changelog about disclosure function 2021-11-19 10:12:22 -05:00
Alex Perkins
480e46c37c unstyled but functional disclosure content 2021-11-19 10:05:16 -05:00
Alex Perkins
598daf604f add doc messages 2021-11-19 08:58:22 -05:00
Alex Perkins
f4d74032d4 add back in showPennant 2021-11-18 19:07:21 -05:00
Alex Perkins
e18a25154b add back in premiumm as an attribute, requiring all the premium locking info at once 2021-11-18 18:44:58 -05:00
Alex Perkins
710576115b required label attribute at the begininning, in keeping with other APIs 2021-11-18 18:18:50 -05:00
Alex Perkins
83486fbf2f move valueToString into the list API 2021-11-18 18:14:44 -05:00
Alex Perkins
b73a135939 intermezzo to make actual use of my don't-render-nonsense-radios pattern 2021-11-18 17:54:29 -05:00
Alex Perkins
7460c4700b move onSelect into list API 2021-11-18 17:48:49 -05:00
Alex Perkins
aaa1d0f2f7 move selectedValue into the list api 2021-11-18 17:10:29 -05:00
Alex Perkins
e30a968088 premium is becoming a hassle so I will remove it for now and maybe add it back later 2021-11-18 17:01:48 -05:00
Alex Perkins
a7efe81cb1 move name into list api 2021-11-18 16:43:48 -05:00
Alex Perkins
6a298e82b6 move value into list api 2021-11-18 16:42:02 -05:00
Alex Perkins
a750666b2e add disable/enabled attributes to the list based api 2021-11-17 12:01:25 -05:00
Alex Perkins
9ae32aaf02 expose list based API from view 2021-11-17 11:39:42 -05:00
Alex Perkins
ac2ff7d59f expose radiobutton v3 2021-11-17 11:39:41 -05:00
Alex Perkins
fc7c4b916f boilerplate to have list API for radio config/events 2021-11-17 11:39:41 -05:00
Alex Perkins
5d4b58a852 copy v2 to v3 2021-11-16 14:05:59 -05:00
Alex Perkins
7daf70d201
Merge pull request #781 from NoRedInk/kraken/change-margin
Adjust inputs' margin top
2021-11-16 13:21:36 -05:00
Tessa
5b883a1e43
Merge pull request #786 from NoRedInk/new-major-version
Periodic cleanup release - 15.0.0
2021-11-15 17:52:47 -08:00
Tessa Kelly
517b662880 Bump 2021-11-15 17:49:38 -08:00
Tessa
689d373430
Merge pull request #732 from NoRedInk/tessa/kill-old-components
Tessa/kill old components
2021-11-15 17:48:25 -08:00
Tessa
5a83071054
Merge pull request #760 from NoRedInk/dansby/put-litter-in-its-place
Dansby/put litter in its place
2021-11-15 11:54:54 -08:00
Tessa
f61a5c8f51
Merge pull request #782 from NoRedInk/tessa/re-org-examples-slightly
Tessa/re org examples slightly
2021-11-15 09:30:17 -08:00
Tessa
9bdc97b7c6
Merge pull request #785 from NoRedInk/dansby/slide-away
Remove slide example
2021-11-12 13:07:06 -08:00
Ben Dansby
11bfc9fcea remove slide example 2021-11-12 11:51:09 -08:00
Mariano Coca
290cf1a15e
Merge pull request #784 from NoRedInk/macoca/bump
Bump version
2021-11-12 15:49:49 -03:00