Arthur Bernardi Jordão
f67f40300f
Add test for the aria labels on carousel container
2023-09-05 11:59:05 -03:00
Arthur Bernardi Jordão
e7effdb8d4
Use findPreviousAndNextSlide on viewWithCombinedControls
2023-09-05 11:37:45 -03:00
Juan Edi
f192973511
fix tests
2023-09-05 11:29:51 -03:00
Juan Edi
a3fc5e1bc6
make tabs test helpers types more generic
...
needed to be used in carousel which requires other additional types of interactions
2023-09-05 10:41:58 -03:00
Juan Edi
35efdcadeb
make tabbed use cases consistent with new API
...
TO-DO: tests are broken -- we'll need some refactoring to move away from
the tab helpers as we now need to change the message type being used.
2023-09-05 10:34:05 -03:00
Juan Edi
c0d51483af
selectAndAnnounce -> announceAndSelect
...
for consistency with Tabs' focusAndSelect
2023-09-05 10:07:27 -03:00
Juan Edi
0cd20a611c
simplify helpers a little bit
2023-09-05 10:04:03 -03:00
Juan Edi
e5ef6fa5fe
standarize on "slide" over "panel"
...
still using "panel" internally when calling TabsInternal, though!
2023-09-05 09:47:38 -03:00
Arthur Bernardi Jordão
d2f639f222
Fix catalog
2023-09-02 11:03:02 -03:00
Juan Edi
7a7eeb7fbf
test announcements, as much as we can
2023-09-01 17:58:04 -03:00
Juan Edi
b104fbe8bb
simplify slide selection logic a little bit
...
NOTE: still need to avoid duplication with the combined case. coming next!
2023-09-01 17:50:37 -03:00
Juan Edi
ba6740b7b6
change API from focusAndSelect to selectAndAnnounce
...
we are now building a brief message for the ATAC. this should provide a
nicer UX for screen reader users and also for keyboard users as focus
isn't changed to the slide content after they press the buttongs.
2023-09-01 17:18:30 -03:00
Juan Edi
09ffe59cf7
decouple prev/next tests from TabsInternal helpers
2023-09-01 17:15:17 -03:00
Juan Edi
234a936597
organize tests by Carousel use case
2023-09-01 17:02:06 -03:00
Juan Edi
5dc122ca9c
qualify calls to Spec.TabsInternalHelpers
...
we'll make it so that the non tabbed use case doesn't rely on that
2023-09-01 16:55:50 -03:00
Juan Edi
954951c4db
make order of button params consistent with ClickableSvg.button
2023-09-01 16:29:45 -03:00
Juan Edi
d4a2609a42
rename config fields that are not view functions anymore
...
viewPreviousButton -> previousButton
viewNextButton -> nextButton
2023-09-01 16:27:12 -03:00
Arthur Bernardi Jordão
8216793ae9
Remove live polite and use tabbable on slide container
2023-09-01 14:22:52 -03:00
Arthur Bernardi Jordão
77a3545852
Remove unneeded import
2023-09-01 14:12:51 -03:00
Arthur Bernardi Jordão
1be3815769
Add tests for carousel with combined controls
2023-09-01 12:54:07 -03:00
Arthur Bernardi Jordão
3627ca16a7
Add test for carousel with prev/next controls
2023-09-01 12:23:10 -03:00
Arthur Bernardi Jordão
565115df6b
Adapt existing tests to v2
2023-08-31 22:59:23 -03:00
Tessa Kelly
717dd58677
Remove bad example code
2023-08-31 18:07:22 -06:00
Arthur Bernardi Jordão
5bff2ada75
Remove unneeded imports
2023-08-31 14:27:29 -03:00
Arthur Bernardi Jordão
7d74924a27
Apply same prev/next logic to combined carousel
2023-08-31 14:25:56 -03:00
Arthur Bernardi Jordão
94e56177b2
Make carousel component with previous and next control the prev/next buttons
2023-08-31 14:22:27 -03:00
Arthur Bernardi Jordão
65a64c663a
Elm format
2023-08-30 15:27:27 -03:00
Arthur Bernardi Jordão
4c831e5fe6
Merge branch 'wr-244-add-new-nriuicarousel-components' of github.com:NoRedInk/noredink-ui into wr-244-add-new-nriuicarousel-components
2023-08-30 15:18:46 -03:00
Tessa Kelly
e3a6fbf0e8
Merge remote-tracking branch 'origin/wr-244-add-new-nriuicarousel-components' into wr-244-add-new-nriuicarousel-components
2023-08-30 12:02:55 -06:00
Arthur Bernardi Jordão
27887c5178
Remove unneeded code
2023-08-30 15:02:20 -03:00
Tessa Kelly
958a883afa
Use Code helpers
2023-08-30 12:00:25 -06:00
Arthur Bernardi Jordão
dfeaf899ab
Rename some doc
2023-08-30 14:53:51 -03:00
Arthur Bernardi Jordão
723925dde6
Change api to use clickable svg on prev/next button
2023-08-30 14:51:00 -03:00
Arthur Bernardi Jordão
dba6c6fbb7
Formater
2023-08-25 18:39:25 -03:00
Arthur Bernardi Jordão
66e1219798
Add docs for roles
2023-08-25 18:36:27 -03:00
Arthur Bernardi Jordão
457f42b95a
Remove unneeded paramter
2023-08-25 18:24:05 -03:00
Arthur Bernardi Jordão
be8a75b6f3
Return previous/next button separally
2023-08-25 18:22:49 -03:00
Arthur Bernardi Jordão
93b810dff4
Return container attributes for all functions
2023-08-25 18:09:26 -03:00
Arthur Bernardi Jordão
c35b633baa
Make role be a parameter
2023-08-25 17:40:08 -03:00
Arthur Bernardi Jordão
1d737b589d
Fix api examples
2023-08-25 17:30:01 -03:00
Arthur Bernardi Jordão
41591274d9
Rename aria label -> Labbelled by
2023-08-25 17:29:20 -03:00
Arthur Bernardi Jordão
ecf3f6c714
Refactor example code
2023-08-24 19:47:16 -03:00
Arthur Bernardi Jordão
c1d44b5009
Format file
2023-08-24 19:24:58 -03:00
Arthur Bernardi Jordão
72fcb8aede
Add docs for AriaLabel type
2023-08-24 19:15:27 -03:00
Arthur Bernardi Jordão
71afc6923a
Add docs for carousel v2 api
2023-08-24 19:11:06 -03:00
Arthur Bernardi Jordão
2b2a38e719
Add mixed example
2023-08-24 18:57:50 -03:00
Arthur Bernardi Jordão
5b07b79eac
Implement mixed carousel
2023-08-24 17:44:51 -03:00
Arthur Bernardi Jordão
35e99e4549
Add carousel example
2023-08-24 13:52:16 -03:00
Arthur Bernardi Jordão
8b869b6254
Add prev/next carousel example
2023-08-23 20:23:00 -03:00
Arthur Bernardi Jordão
b8e7bb83f7
Fix indentation
2023-08-23 17:40:15 -03:00
