Commit Graph

3160 Commits

Author SHA1 Message Date
freak4pc
2b58d5370a for_where: Use for/where instead of internal if where possible 2019-01-30 20:19:57 +01:00
freak4pc
98ed335d60 control_statement: Remove parantheses around conditionals 2019-01-30 20:19:57 +01:00
freak4pc
3bb2d489f2 empty_enum_arguments: remove unused arguments for enum cases 2019-01-30 20:19:57 +01:00
freak4pc
fd2457b3c1 empty_parentheses_with_trailing_closure: Remove unneeded parantheses for trailing closure 2019-01-30 20:19:57 +01:00
freak4pc
181cc9fca3 unneded_break_in_switch: Remove redundant breaks in switch statements 2019-01-30 20:19:57 +01:00
freak4pc
d8f42bb984 redundant_discardable_let: Remove instances of let _ = where needed 2019-01-30 20:19:57 +01:00
freak4pc
6748801a87 redundant_optional_initialization: Remove redundant initialization with nil 2019-01-30 20:19:57 +01:00
freak4pc
40d6fd94e8 unused_closure_parameter: Remove unused closure parameters 2019-01-30 20:19:57 +01:00
freak4pc
b45ee2143b shorthand_operator: prefer using shorthand operator 2019-01-30 20:19:57 +01:00
freak4pc
36dd486921 private_over_fileprivate: Prferer private over fileprivate where applicable 2019-01-30 20:19:57 +01:00
freak4pc
2e645681e1 Add Swiftlint basic YAML 2019-01-30 20:19:57 +01:00
Keith Smiley
bc30215913 Remove unnecessary returns 2019-01-25 22:52:09 +01:00
Keith Smiley
8fc9f7492f Fix warnings from the Swift 5 compiler
This makes some backwards compatible warnings fixes for the Swift 5
compiler in Swift 4.2 mode. There are 3 warnings being fixed here.

1. Functions inside public extensions don't need to be marked public.
For this case I opted to remove the public from the extension instead so
that no method that is meant to be internal in one of these extensions
accidentally becomes public API.
2. Members inside of a fileprivate extension don't need to be marked
fileprivate. Here I removed it from the member so that new members will
also be fileprivate unless decided otherwise.
3. private(set) is redundant on a private property. I assume this was
left over from some changes.
2019-01-25 22:52:09 +01:00
Krunoslav Zaher
5f073a59f6 Include AtomicInt tests in all targets. 2019-01-25 15:36:41 +01:00
liugang
8292759f9f Delete unused code in GroupBy.swift 2019-01-19 19:40:16 +01:00
mykoma
c8b376e6c7 Refactor the Sample.swift
There are some duplicate code, it's better to refactor these code.
2019-01-19 19:39:24 +01:00
Romain Bertozzi
161e0f6361 Readme: remove mention of Variable (#1854) 2019-01-16 09:17:55 +02:00
mykoma
f607fd9985 Delete unused typealias in SkipWhile.swift (#1852)
`typealias PredicateWithIndex` is no need anymore
2019-01-12 02:13:00 +02:00
freak4pc
68b61f1d44 Add behavior argument to takeUntil predicate variation 2019-01-05 14:37:32 +01:00
freak4pc
fac400a85a Update SPM tests 2019-01-05 14:37:32 +01:00
freak4pc
25b57d39c6 Add CHANGELOG entry. 2019-01-05 14:37:32 +01:00
freak4pc
bb01480bd5 Add takeUntil(_ predicate:) tests 2019-01-05 14:37:32 +01:00
freak4pc
0edf8f5823 Add takeUntil(_ predicate:) operator. 2019-01-05 14:37:32 +01:00
Cruz
16cb628ce1 Put self where it doesn’t exist for consistency for asObservable()
code review by @kzaher
2019-01-04 20:03:25 +01:00
Dave Goldman
833378b691 Fix typo(?): ValidationResult -> Availability (#1845) 2019-01-03 09:55:56 +02:00
Luciano Almeida
fb37967f93 Reverting #1823 2018-12-30 14:23:55 +01:00
Bernardo Ferrari
e75b803e4e Fix "Pod" thumbnail redirecting to image instead of a site.
It was opening a svg image when clicking. Now it should direct to RxSwift on cocoapods.
2018-12-30 14:22:17 +01:00
Zev Eisenberg
cee8b2150e Remove warn_unused_result. (#1836) 2018-12-26 23:05:21 +02:00
mykoma
c1a4eafea4 Using Cancelable instead of Disposable
BehaviorSubject has implemented `var isDisposed: Bool`, so it would be better for using Cancelable.
2018-12-23 16:13:02 +01:00
Luciano Almeida
b51493faba Removing swift3 compile checks. 2018-12-21 16:08:10 +01:00
wstompearson
1195554adf Uses accept instead of value in docs (#1826) 2018-12-18 11:29:44 +02:00
Krunoslav Zaher
5f5790de91
Fix. #1800 2018-12-16 17:44:48 +01:00
Krunoslav Zaher
aaa2a90a86
Move compilation timing flags to Release-Tests. 2018-12-14 22:38:22 +01:00
Martin Conte Mac Donell
52d99673cf Fix DISABLE_SWIZZLING compilation
Some methods under the compiler flag are being used by RxCocoa's proxy
delegate. So this commit is moving these outside the conditional.
2018-12-14 22:34:47 +01:00
Tony Arnold
67ae8066c1 Remove type checking performance debugging flags 2018-12-14 22:32:17 +01:00
Luciano Almeida
cf346cbe0c Formatting. 2018-12-12 20:03:26 +01:00
Luciano Almeida
2bcfeb2d4c Revomoving extra line. 2018-12-12 20:03:26 +01:00
Luciano Almeida
39df536450 Back to form. 2018-12-12 20:03:26 +01:00
Luciano Almeida
8f86799fe3 Removing duplicated import and some commented code on scripts. 2018-12-12 20:03:26 +01:00
freak4pc
262e9eae6c Remove Code Signing 2018-12-12 20:02:34 +01:00
Noah Gilmore
774276961d Update a deprecated example in GettingStarted.md 2018-12-12 11:25:58 +02:00
Luciano Almeida
c8a1420ef2 Adding build trigger only for master and develop (#1823) 2018-12-12 11:22:15 +02:00
Quico Moya
e74a67951f Syntax fixes 2018-11-28 22:12:28 +01:00
Krunoslav Zaher
cba79fa0cc
Merge branch 'master' into develop 2018-11-28 21:17:05 +01:00
Victor Sigler
cf781b6eed Fix RxAtomic typo in the CHANGELOG 2018-11-27 08:50:15 +02:00
polonez
0ef20bf0e2 Fix typo in comment: didDeselectItemAtIndexPath (#1812) 2018-11-24 11:49:15 +02:00
Josip Ćavar
bf83288eef Fix typo in error message (#1810) 2018-11-22 17:36:44 +02:00
Josip Ćavar
1c3383218d Fix documentation typo 2018-11-21 15:59:33 +02:00
GeorgeWu
e5b5850480 Remove duplicated subscription in example 2018-11-14 13:17:19 +01:00
Carlos García
b1a882ab91
Fix logo URL for Cocoapods Page 2018-11-05 13:21:32 +01:00