Commit Graph

5960 Commits

Author SHA1 Message Date
Sanne de Vries
0ab0100567 Fixed bottom padding for card menu in Firefox 2020-10-23 11:55:41 +02:00
Kevin Ansfield
5d97c1710f Update dependency eslint-plugin-ghost to v2.0.0
no issue

- bumps eslint and eslint-plugin-ember versions
- octane rules are enabled by default
  - disabled them in our eslintrc.json so we can switch to warn/error whilst migrating to octane
- fixed a couple of linting errors from new/updated rules
2020-10-23 09:59:09 +01:00
Sanne de Vries
36dbb35eb5 Styled new row layout of the cardmenu
No issue

- Adjusted menu width and height
- Improved spacing cards
- Changed font styling
- Added snippet icons
2020-10-23 10:36:31 +02:00
Peter Zimon
6ecba355eb Moved members settings to new page (#1736)
no refs

Moves members related settings in Labs to its own page to improve the overall UX and make it more consistent with the rest of the Admin.
2020-10-22 16:09:00 +05:30
Kevin Ansfield
f1bab33296 Fixed member's location sometimes showing as ", US"
no issue

- geolocation.region is not always available but we had assumed it was. Adjusted the logic to only show "region, US" if region is available
2020-10-22 09:15:03 +01:00
Kevin Ansfield
5ae27247f7 Prevented card toolbar showing for embed/bookmark cards in input state
no issue

- it doesn't make sense to create snippets of bookmark/embed cards before they contain any content so we avoid passing the save snippet function through until content exists and the card has left it's input state
2020-10-21 18:27:26 +01:00
Kevin Ansfield
09368c2966 Changed card/plus menu layout from grid to rows
no issue

- with the addition of snippets the card menu contents height and potential label width are both growing considerably making the grid layout unworkable
2020-10-21 12:34:05 +01:00
Kevin Ansfield
489f45155d Added "Create snippet" toolbar icon when cards are selected
no issue

- show the toolbar icon for any `<KoenigCard>` instance that has the `saveAsSnippet` action passed to it
  - currently that's all cards except the HR card because that's a primitive element rather than containing any user-defined content
- add `koenigUi.inputHasFocus` so that card toolbars can be hidden when the snippet input is displayed
2020-10-21 12:16:04 +01:00
Kevin Ansfield
14755425c2 Fixed error when clicking on snippets in card menu
no issue

- click event was clearing the editor range so it's necessary to reposition the cursor before replacing with the post
2020-10-20 18:10:25 +01:00
Daniel Lockyer
bc342029d1 v3.36.0 2020-10-20 09:38:09 +01:00
Renovate Bot
c298bc7db3 Update dependency @tryghost/kg-clean-basic-html to v1.0.9 2020-10-20 08:41:19 +01:00
Renovate Bot
62d429be42 Update dependency @tryghost/kg-parser-plugins to v1.0.9 2020-10-20 08:38:06 +01:00
Renovate Bot
24f3366544 Update dependency @tryghost/timezone-data to v0.2.30 2020-10-20 08:36:57 +01:00
Renovate Bot
26a79e0edf Update dependency @tryghost/helpers to v1.1.33 2020-10-20 08:36:08 +01:00
Kevin Ansfield
3efeeac6a1 Swapped toolbar snippet icon for the new design 2020-10-19 09:55:26 +01:00
Kevin Ansfield
96bcf99332 Added Ctrl/Cmd+P shortcut in editor to open preview in new tab
no issue

- allows quick access to the preview without having to open post settings menu and click the preview link or hit Ctrl/Cmd+S and click the link in the success notification
2020-10-19 08:25:26 +01:00
Kevin Ansfield
11c16b8b4b Disabled mocked snippets API in development 2020-10-16 19:22:09 +01:00
Kevin Ansfield
95aa341468 Added max length validation to snippet's name field 2020-10-16 19:22:09 +01:00
Kevin Ansfield
3d48ce6bc4 Fixed snippets not loading in background when accessing editor
no issue

- add the missing snippets API query to the editor's background loaded
2020-10-16 19:22:09 +01:00
Renovate Bot
45bee39739 Update dependency @tryghost/helpers to v1.1.32 2020-10-16 14:35:51 +01:00
Renovate Bot
4b220ebd17 Update dependency @tryghost/string to v0.1.13 2020-10-16 14:35:34 +01:00
Peter Zimon
94077449b3 Update portal settings (#1731)
* Added auto focusing preview on the signup page while being on links and clicking on any setting in the sidebar

* Refine upload custom portal icon button

* Updated copy for sidebar and links screen

* Added grouping to links list
2020-10-16 15:34:22 +02:00
Kevin Ansfield
7e169a2a86 Renamed snippet.title to snippet.name for consistency
no issue

- all of our models which allow users to name something use `name` as the field descriptor rather than `title` so `snippet.title` was renamed for consistency
- also fixes typo in the plus-menu component that stopped clicking on snippets from working
2020-10-16 10:15:07 +01:00
Kevin Ansfield
b590ce1b95 Implemented first iteration of content snippets
closes https://github.com/TryGhost/Team/issues/411

- adds "Create snippet" icon to the editor toolbar
- uses the same link input component design for specifying snippet titles
- snippets are loaded in the background when the editor is accessed
- snippets are listed at the bottom of the card menus of the + and / menus
- clicking a snippet inserts the snippet's contents in place of the current blank section
2020-10-15 18:03:35 +01:00
Peter Zimon
bc779bb3e7 Fixed 'null' portal button text
no refs.
- fixing portal button displaying 'null' if the portal button text input field is empty
2020-10-14 14:47:08 +02:00
Kevin Ansfield
9fe752d86d Lock file maintenance 2020-10-14 12:55:06 +01:00
renovate[bot]
6c3195db93 Update dependency ember-cli-app-version to v4 (#1724)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-14 10:21:20 +01:00
renovate[bot]
4778128e63 Update dependency ember-truth-helpers to v3 (#1723)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-14 10:20:56 +01:00
Renovate Bot
2d285e7498 Update dependency ember-exam to v6 2020-10-12 21:55:26 +00:00
Peter Zimon
eede9e1141 Updated Portal links design
no refs.
- in Portal settings domain and the path are separated visually so that it conveys the concept of using the relative URL instead of absolute
- for similar reasons, copy link copies only the path part
2020-10-12 13:56:37 +02:00
Renovate Bot
69bcb90c43 Update dependency eslint to v7.11.0 2020-10-09 21:05:56 +00:00
Peter Zimon
33e1ceb010 Fixed test for scheduling copy change
no refs.
2020-10-09 17:15:21 +02:00
Peter Zimon
d567e975d2 Removed full stop from scheduling text in editor
no refs.
2020-10-09 16:56:37 +02:00
Peter Zimon
a7c0dc7469 Fixed account menu margin
no refs.
- fixes account menu dropdown button margins disappearing on Firefox for smaller screensizes
2020-10-09 16:56:13 +02:00
Kevin Ansfield
a8f63f9343 Fixed usage of {{enable-developer-experiments}} without sub-expression syntax 2020-10-09 15:52:23 +01:00
Kevin Ansfield
a3d3632e97 Added developer experiments indication to about page
no issue

- without this there's no indication the config flag is set when you have no access to the config file or you don't know which features are currently behind the flag
2020-10-09 11:38:47 +01:00
Kevin Ansfield
235d5f1b8b Added {{enable-developer-experiments}} helper
no issue

- removes the need to have component backing classes with the `config` service injected
2020-10-09 11:10:39 +01:00
Daniel Lockyer
508b7734fe v3.35.5 2020-10-08 11:00:35 +01:00
Daniel Lockyer
7ff4557e3c v3.35.4 2020-10-06 09:55:49 +01:00
Kevin Ansfield
44b9b0fc94 Resolved "already declared in upper scope" linting warnings
no issue

- fixed all `no-shadow` linter warnings
- changed `no-shadow` eslint rule from `warn` to `error` so we don't re-introduce shadowed variables in the future
2020-10-05 09:56:21 +01:00
renovate[bot]
c51990c3ae Update dependency ember-power-select to v4.0.5 (#1721)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-05 09:09:39 +01:00
renovate[bot]
7ea3a46ff3 Update dependency @tryghost/timezone-data to v0.2.28 (#1719)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-05 09:09:26 +01:00
Sam Lord
52e85451ec v3.35.3 2020-10-02 14:38:32 +01:00
Peter Zimon
47a045a935 Updated scheduling copy
no refs.
- updated moment locale to display '1 minute' instead of 'a minute' to be more explicit about scheduled time
- removed full stop from the scheduler message in editor header
2020-10-02 10:45:49 +02:00
Sam Lord
a60a28822d v3.35.2 2020-10-01 19:57:13 +01:00
Sam Lord
6090245ccb v3.35.1 2020-10-01 19:21:26 +01:00
Kevin Ansfield
fa240cae53 Fixed content jiggle when selecting cards and card code background position
no issue

- borders are necessary on selected cards to keep consistent spacing between selected/non-selected cards
  - use transparent borders in dark mode rather than eliminating borders
- moved transparent card background style to `_koenig-dark.css` so it only affects dark mode - we want to keep the background colour for light mode so that we don't get mis-aligned backgrounds in certain cards
2020-10-01 16:56:30 +01:00
Kevin Ansfield
171cec2b4e 🐛 Fixed first set of members appearing twice in members list
closes https://github.com/TryGhost/Ghost/issues/12241

- `ella-sparse` exposes a `range.page` property which we can use instead of trying to calculate the page number ourselves
2020-10-01 11:21:34 +01:00
Kevin Ansfield
db68f0248b Update dependency ember-in-viewport to v3.8.0
no issue

- now that we no longer have the `ember-sticky-element` dependency we're free to upgrade `ember-in-viewport`
- remove package.json resolution so latest version gets installed
- remove ember-in-viewport from renovate ignore config
- update `<GhScrollTrigger>` to match latest `ember-in-viewport` usage and convert to a glimmer component
  - ensure `scrollableArea` is always set so that the trigger doesn't stop working after the first trigger
2020-10-01 10:06:53 +01:00
Kevin Ansfield
c0149ee997 Removed ember-sticky-element in favour of native position: sticky
no issue

- native `position: sticky` support is now good enough across the board of our supported browser versions to use in place of a JS version for our use cases
- `ember-sticky-element` is preventing the dependency update of `ember-in-viewport` so removing it will allow a lot of our sub-dependencies to be updated
2020-10-01 10:02:27 +01:00