Commit Graph

3930 Commits

Author SHA1 Message Date
Kevin Ansfield
1b02a63848 Koenig - Expand -- to en dash and --- to em dash
refs https://github.com/TryGhost/Ghost/issues/9623
- match `--` and `---` and convert if followed by a space or any character respectively
- include guards to ensure that expansion doesn't occur inside code blocks
2018-05-14 17:29:49 +01:00
Kevin Ansfield
d760e5633c Koenig - Fixed text deselection when toggling section formatting via toolbar
refs https://github.com/TryGhost/Ghost/issues/9623
- maintains easy reversibility by keeping text selected and toolbar shown in the same position to avoid jumping buttons when font size or other formatting changes
2018-05-14 15:53:34 +01:00
Kevin Ansfield
e9ead57da5 Koenig - Fixed deletion of / not closing the /-menu
refs https://github.com/TryGhost/Ghost/issues/9623
2018-05-14 15:48:29 +01:00
Kevin Ansfield
505aee4dac Koenig - Fix triple-click select adding formatting to following paragraph
refs https://github.com/TryGhost/Ghost/issues/9623
- triple-click select will by default end the selection at position 0 of the following paragraph which means section-level formatting such as headers or quotes will affect the apparently unselected following paragraph
- add a guard to check for that selection situation and ensure the selection is constrained to the visibly selected text
2018-05-14 15:13:47 +01:00
Kevin Ansfield
f03954679e Koenig - Fixed double-tap to select not immediately showing toolbar
refs https://github.com/TryGhost/Ghost/issues/9623
- keep a truthy "skip mouse move" flag around across re-triggers within the 50ms restart window to cater for slightly different mouse/selection event orders
- add a couple of guards to avoid triggering the toggle task unnecessarily
2018-05-14 14:52:40 +01:00
Kevin Ansfield
5c948a264e Bump dependencies 2018-05-14 13:56:09 +01:00
Kevin Ansfield
5b43350112 Add {{background-image-style}} helper
no issue
- cleans up multiple CPs that were only outputting a background image style
- moves URL decoding/encoding and `htmlSafe` output into one place
2018-05-14 13:04:53 +01:00
Kevin Ansfield
5ce5dd04ab 🐛 Fixed low-resolution gravatar images on Team/User screens
closes https://github.com/TryGhost/Ghost/issues/9563
- fixes incorrect gravatar URLs by removing incorrect HTML encoding of the URL and enforcing URL encoding
- centralise image URL generation in the User model so that default image logic isn't spread across the app
- remove unnecessary proxy mixin from `ghost-paths` service (allows property access without `.get()`)
2018-05-14 12:15:08 +01:00
Kevin Ansfield
9d388aecc1 Bump ember-in-viewport dependency
no issue
- includes perf improvements for Koenig when many sticky elements can be present on a single screen
- requires bump to `ember-sticky-element`
2018-05-10 17:10:33 +01:00
Kevin Ansfield
e545161ed3 Koenig - Extract key commands out of {{koenig-editor}}
refs https://github.com/TryGhost/Ghost/issues/9505
- standardises on a single place for key command handlers
- mark re-used methods as public API rather than private
2018-05-09 18:11:22 +01:00
Zimo
f079ed15af Koenig - Refine card menu and fix toolbar tick color
refs https://github.com/TryGhost/Ghost/issues/9505
- card menu style refinements
- fix tick color and adding appear animation to toolbar
- bump Spirit dependency
2018-05-09 16:48:13 +01:00
Kevin Ansfield
4753f92fe1 Koenig - Fix error on backspace with heading as first section 2018-05-09 10:23:30 +01:00
Kevin Ansfield
8b75b37c7b Version bump to 1.22.7 2018-05-09 09:21:17 +01:00
Kevin Ansfield
6c4d125cd6 🐛 Fixed tag creation via the Post Settings Menu
closes https://github.com/TryGhost/Ghost/issues/9619
- e28a960970 changed `availableTags` to be the direct result of `store.peekAll()` rather than a promise that resolved to the peekAll result but other code was not updated and still expected a promise object
2018-05-09 09:12:31 +01:00
Kevin Ansfield
e8fdc4ca6f Koenig - Handle deletion of last card with no other sections
refs https://github.com/TryGhost/Ghost/issues/9505
- if there is only a single card in a document and no other text then deleting it would throw an error because we assumed there's another section to move the cursor to
- handle the situation of not having a position to move to by creating a new blank paragraph and placing the cursor inside
2018-05-08 18:17:30 +01:00
Zimo
b4b85fba99 Koenig - Style refinements for card menu, toolbar, and link input
refs https://github.com/TryGhost/Ghost/issues/9505
- Card menu style refinements
- Toolbar style refinements
- Unifying toolbar, link tooltip and link toolbar size and position
- Making link input the same size as text toolbar
- Fix single element position in toolbar
- Making toolbars darker
2018-05-08 18:04:56 +01:00
Kevin Ansfield
e56337a2f4 Bump Spirit dependency 2018-05-08 17:38:20 +01:00
Kevin Ansfield
e23e068e13 Version bump to 1.22.6 2018-05-08 15:58:04 +01:00
Kevin Ansfield
8d9ef6d5be Fixed tests
no issue
- after the ember bump the `signin` route's `deactivate` hook started throwing errors - `Property set failed: object in path "signin" could not be found or was destroyed.`
2018-05-08 12:35:42 +01:00
Kevin Ansfield
ab20d24c41 Bump dependencies
no issue
- bump dependencies with non-breaking changes
- no bump of yarn.lock sub-dependencies because that bumps the version of `ember-in-viewport` to 3.0.3 that does not currently work with `ember-sticky-element`
2018-05-08 10:46:24 +01:00
Peter Zimon
26aa2770ed Koenig - Made full width images work with closed sidebar (#1014)
refs https://github.com/TryGhost/Ghost/issues/9505
- use `ui` service to adjust full-width image styles then the side nav is open
2018-05-08 10:26:46 +01:00
Kevin Ansfield
011b016582 Bump Spirit dependencies 2018-05-08 10:23:54 +01:00
Kevin Ansfield
5adbb9b665 Koenig - Fixed HTML card init error
no issue
- `payload.set` is not always a method because mobiledoc-kit can give us POJOs
2018-05-07 15:40:11 +01:00
Peter Zimon
70ee42a51a UI Fixes (#1015)
no issue
* Fixing 'Suspended' label on user screen
* Replace default avatar on users screen
* Remove shadow of 'Publish' button to work better on top of full width images
2018-05-07 12:15:44 +01:00
Kevin Ansfield
06d7f6d67c 🐛 Fixed invalid character and 'define' is undefined errors in IE11
closes https://github.com/TryGhost/Ghost/issues/9617
- bumped `ghost-spirit` to a version that doesn't use ES2015 on files that are directly included without transpilation (see related `ember-cli-cjs-transform` issue here https://github.com/rwjblue/ember-cli-cjs-transform/issues/14)
- bumped `ember-cli-ghost-spirit` to fix the `ghost-spirit` dependency version range that resulted in yarn pulling in two different versions
2018-05-04 14:51:15 +01:00
Kevin Ansfield
9a68dca80e Remove more import Ember via module imports
refs https://github.com/TryGhost/Ghost/issues/8927
- removes usage of `Ember.testing`
- removes usage of `Ember.uuid`
- removes usage of `Ember.Debug.registerWarnHandler`
2018-05-03 17:52:39 +01:00
Kevin Ansfield
1096e8c3d2 Koenig - Remove reliance on CSS class selectors
no issue
- switch to using data attributes instead of class names to target elements to avoid problems if CSS class names change or are removed
2018-05-02 17:31:17 +01:00
Zimo
4c05d618bd Koenig - Replace custom CSS classes with Spirit
no issue
- Koenig container styles for Spirit
- Applying Spirit styles to card menu
- Applying Spirit styles to generic cards
- Replacing icon styles with Spirit
- Fix slash menu selected state
- Cleanup of unused files + fix empty HTML
2018-05-02 15:54:22 +01:00
Kevin Ansfield
d1b3237780 Bump Spirit dependencies 2018-05-02 15:51:53 +01:00
Kevin Ansfield
ac72b89164 Koenig - Fixed incorrect sticky card icon positioning
refs https://github.com/TryGhost/Ghost/issues/9505
- sticky positioning was correct on the first post load but leaving the editor then coming back never took the editor header height into account
- store a reference to the header element in `{{gh-editor}}` so that we can more reliably grab the height to pass through
2018-05-02 12:50:53 +01:00
Kevin Ansfield
135d550c8a Koenig - Switch this.get for ES5 getters
no issue
- Ember 3.1 adds support for ES5 getters to replace (mostly) the need for `this.get` - https://www.emberjs.com/blog/2018/04/13/ember-3-1-released.html#toc_es5-getters-for-computed-properties-2-of-4
- updating Koenig now because it's a fairly isolated part of Ghost-Admin and a good playground for new standards that we can migrate to in the main codebase
2018-05-01 17:13:53 +01:00
Kevin Ansfield
26e70e86ea Koenig - Sticky card icons (#1013)
refs https://github.com/TryGhost/Ghost/issues/9505
- use `ember-sticky-element` to stick card icons in top left when scrolling
- pass an `headerOffset` down from the `{{gh-editor}}` component through Koenig and the card components so that it can be used for adjustments where necessary
    - calculate `headerHeight` in `{{gh-editor}}` any time we change the header class
2018-05-01 15:55:51 +01:00
Kevin Ansfield
39cddf0da5 Fixed error in text-input mixin when using auto-fill
no issue
- `event.keyCode` can be `undefined` when using Chrome or Safari's login auto-fill
2018-05-01 14:55:03 +01:00
kirrg001
83d2f70792 Version bump to 1.22.5 2018-05-01 14:44:24 +02:00
Kevin Ansfield
a0d3a25f98 Revert "Bump ember-power-select/datepicker & ember-basic-dropdown deps"
no issue
- test helpers are broken when not using the latest ember-test-helpers which we aren't because ember-cli-mocha hasn't been upgraded yet
2018-05-01 13:13:25 +01:00
Kevin Ansfield
1e5ec43c5a Bump simplemde dep to use latest Codemirror 2018-05-01 11:48:22 +01:00
Kevin Ansfield
a2e39c3ed5 Fixed incorrect search icon colour
no issue
- search icon colour was being overridden and appearing too dark
2018-05-01 11:41:38 +01:00
Kevin Ansfield
14f40c2d18 Bump ember-power-select/datepicker & ember-basic-dropdown deps
no issue
- latest 2.0.0 release no longer breaks anything
2018-05-01 11:40:45 +01:00
Kevin Ansfield
c3f450cc5a Remove ember application template wrapper
no issue
- Ember will not output the application template wrapper div in the future but it's possible to optionally enable that feature now
- fixes test harness render so that all elements are constrained to the application wrapper rather than breaking out with `position: fixed` and covering the test results
2018-05-01 10:57:20 +01:00
Kevin Ansfield
0317dca2be Revert current-device dependency to 0.7.2
no issue
- `0.7.7` throws an exception on mobile safari which crashes Ember and blocks rendering
- https://github.com/matthewhudson/current-device/issues/164
2018-05-01 10:29:57 +01:00
Kevin Ansfield
c1bb3dd47c Bump ember-drag-drop dependency
no issue
- removes another babel 5 deprecation notice
2018-05-01 09:23:33 +01:00
Kevin Ansfield
d95105b3a5 Remove usage of ember-element-resize-detector
no issue
- fixes babel deprecation warning coming from `ember-element-resize-detector`
- re-created basic `resize-detector` service to wrap `element-resize-detector`
    - import `element-resize-detector` directly from `npm` (includes bump to latest version)
    - drop usage of jQuery selectors
2018-04-30 17:03:29 +01:00
Kevin Ansfield
9cd28eebf2 Remove unused ember-cli-active-link-wrapper dependency 2018-04-30 15:58:53 +01:00
Kevin Ansfield
220b6c6969 Drop Node.js 4 support 2018-04-30 15:13:37 +01:00
Kevin Ansfield
cd30fd6725 Bump dependencies
no issue
- bump dependencies with no breaking changes
- bump yarn.lock sub-dependencies
2018-04-30 14:25:12 +01:00
Kevin Ansfield
e28a960970 Removed used of ember-data-filter
closes https://github.com/TryGhost/Ghost/issues/9591
- swapped use of `store.filter` for a combination `store.peekAll` and CPs to filter the result set
2018-04-30 13:54:09 +01:00
Kevin Ansfield
7d95d42eda Fixed "Route#router intimate API" deprecation notices
closes https://github.com/TryGhost/Ghost/issues/9603
- don't add a `setTitle` method on the router and instead call `window.document.title` directly so that we don't have to access  `Route#router` (throws deprecation) or `Route#_router` (private and may break without notice)
2018-04-30 13:07:37 +01:00
Kevin Ansfield
072a561be1 Fixed duplicate tokens in app titles
no issue
- the `Settings - Apps` part of the title is already set via the `settings` route
2018-04-30 12:49:14 +01:00
Kevin Ansfield
86c75aed72 🐛 Fixed admin URL not updating when changing tag slug
closes https://github.com/TryGhost/Ghost/issues/9571
- uses `window.replaceState` to update the URL when a tag is saved with a new URL
    - ensures back button doesn't result in 404
    - use `windowProxy` util so that behaviour can be tested
2018-04-30 12:29:43 +01:00
Kevin Ansfield
8ed92dec71 🐛 Fixed 404 handling in admin
refs https://github.com/TryGhost/Ghost/issues/9571
- use `replaceWith` rather than `transitionTo` so that the back button still works and doesn't immediately throw you back to the 404 page
- use the new `router` service to avoid deprecation notices
- update the regex replacements to work with `#` urls
2018-04-30 12:09:30 +01:00