TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-22 10:21:36 +03:00
Code Issues Projects Releases Wiki Activity
34,870 Commits 250 Branches 1,686 Tags 392 MiB
2568c5898a
Commit Graph

17959 Commits

Author SHA1 Message Date
Rishabh
eaf5aaade2 Updated site preview to handle theme settings 
refs https://github.com/TryGhost/Team/issues/3354

- wires theme settings to site preview frame, dynamically updating the preview when theme settings change
 2023-06-09 20:06:06 +05:30
Naz
f7e2f82089 Enabled collections permissions in controller 
refs https://github.com/TryGhost/Team/issues/3220

- With permissions in place in the database, they can be enabled on controller level.
 2023-06-09 21:13:06 +07:00
Naz
05bb82cf1a Added collections CRUD permissions 
refs https://github.com/TryGhost/Team/issues/3220

- Added permissions for collection resources
 2023-06-09 21:13:06 +07:00
Simon Backx
2a263c1024 Updated Signup Form to v0.1 
no issue
 2023-06-09 14:32:17 +02:00
Simon Backx
c3abd3a021 Released Signup Form v0.1.0 2023-06-09 14:31:32 +02:00
Peter Zimon
2d3ab08724 Experimenting with sticky footers in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:29:39 +02:00
Peter Zimon
4e5523674c Updated twitter and FB settings tests in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:16:56 +02:00
Peter Zimon
33ea5486df Updated user detail modal buttons in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:16:56 +02:00
Simon Backx
6d6da2492c Fixed showing errors when non 2XX response in signup form 
no issue
 2023-06-09 14:12:09 +02:00
Rishabh
c26f77586a Added dynamic site preview iframe 
refs https://github.com/TryGhost/Team/issues/3354

- adds dynamically loading iframe with site preview based on preview data in Admin
 2023-06-09 17:39:53 +05:30
Simon Backx
a4b24b1c7a Filled in signup form translation contexts 2023-06-09 13:54:23 +02:00
Simon Backx
08b37395cf Added translated placeholder in signup form embed 
no issue
 2023-06-09 13:48:43 +02:00
Simon Backx
381149e45b Added signup form button animation (minimal) 
no issue
 2023-06-09 12:07:57 +02:00
Sanne de Vries
afe18d54de Added email icon to signup form success page 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#de29f9cc1a364a12a4a0eeebef68f3a4
 2023-06-09 11:35:36 +02:00
Simon Backx
5e7edb9da5 ✨ Added embeddable signup form 
refs https://github.com/TryGhost/Team/issues/3274

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
 2023-06-09 11:30:03 +02:00
Peter Zimon
90b9959afc Set up showing images in brand settings (AdminX) 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 11:26:56 +02:00
Simon Backx
ffa6c9c5f8 Added width:100% to minimal signup form CSS 
no issue

Otherwise the auto margin would cause issues in a grid or flex container.
 2023-06-09 11:08:14 +02:00
Simon Backx
66840cda0a Fixed minimal form padding 
no issue

Previous change made the viewport always maximum 440px, so it always triggered the `sm` breakpoint
 2023-06-09 11:06:50 +02:00
Sanne de Vries
6cdaf04fcd Updated NL translations for Portal and Signup Form 
No ref
 2023-06-09 10:53:22 +02:00
Simon Backx
12f7fd0153 Updated minimal signup form to be centered by default 
no issue

Added `margin: 0 auto;` css by default.
 2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055 Moved maximum width and centering outside minimal signup form 
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999

- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
 2023-06-09 10:42:24 +02:00
Simon Backx
f4a822e7e0 Removed success page for minimal signup form 
no issue

Shows the success state in the button now.
 2023-06-09 10:26:05 +02:00
Naz
c507ea9600 Improved oversized batch correction logic 
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- After analyzing data dumps, the data revealed that we have extra data from a stray batch. The filtering logic manually filters out the data to the recipients that belong to a "current batch".
- Hunting down the root cause of the data mixup proved to be too expensive of an investigation, so this is a "good enough patch" to deal with the problem.
- Most likely cause is the concurrent batch sending, but reducing the concurrency would be too expensive of a performance price to pay instead of filtering the data rarely.
 2023-06-09 14:40:12 +07:00
Fabien "egg" O'Carroll
643fbbbb1f Removed collections from stable list in Admin API 
We had to add these so that they could be played with programatically
but now we have a god_mode flag, we can remove them.
 2023-06-09 09:31:44 +02:00
Fabien "egg" O'Carroll
29a403cc68 Supported a god_mode param in the Admin API 
This currently skips the not-implemented middleware and can be used to
access experimental endpoints whilst in development.
 2023-06-09 09:31:44 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal (#16971) 
Refs https://github.com/TryGhost/Team/issues/3407

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f Updated signup form embed settings copy 
No ref
 2023-06-09 08:26:21 +02:00
renovate[bot]
58f48d2e0a Update dependency @playwright/test to v1.35.0 2023-06-09 08:25:51 +02:00
Naz
efac36c36c
Removed data dump during email batching 
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- Having a data dumped in production was a one-off trick to allow us debug the error. Now that we have data it's no longer needed.
 2023-06-09 10:44:13 +07:00
Simon Backx
7e47bff92f Released Signup Form v0.0.3 2023-06-08 16:35:54 +02:00
Simon Backx
c5fbd8bae6 Added Plausible events when copying the signup form embed code 
fixes https://github.com/TryGhost/Team/issues/3389
 2023-06-08 15:51:32 +02:00
Sanne de Vries
9d93d21a2d Fixed signup form modal height 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
- Previous commit broke the height as the negative margin should've only been applied horizontally
 2023-06-08 14:18:16 +02:00
Sanne de Vries
7a74563e21 Fixed scrollbar position in signup form modal 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
 2023-06-08 14:06:31 +02:00
Simon Backx
5949d6a8d4 🐛 Fixed closing modals in admin UI when releasing mouse outside modal 
no issue

When selecting text, and releasing your mouse outside the modal, the modal would close.
 2023-06-08 13:50:44 +02:00
Simon Backx
5658f4b627 Fixed admin failing tests 
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
 2023-06-08 13:38:13 +02:00
Zabriskije
f3b60e6c6f
Updated Italian translations (#16966) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-08 13:33:18 +02:00
Markus Härnvi
bd679e0a81
Updated Swedish translations (#16964) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-08 13:32:11 +02:00
Simon Backx
a68ac4b688 Renamed data-logo to data-icon in signup embed attributes 
fixes https://github.com/TryGhost/Team/issues/3401
 2023-06-08 13:23:38 +02:00
Simon Backx
a1e632abe0 Removed page color in signup form Storybook preview component 
no issue

The Storybook did set the color, but that shouldn't be set because normally the components are always rendered in an iframe, with a default black, unchangeable color.
 2023-06-08 13:17:54 +02:00
Simon Backx
887f7385e1 Fixed label picker overflow hidde in modal in signup form modal 
no issue
 2023-06-08 13:17:54 +02:00
Sanne de Vries
a8b9be38f8 Added max width to success message in signup form 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#419cf40167784a5c85bd38ea3a2006ed
 2023-06-08 13:13:32 +02:00
Sanne de Vries
5346fb430c Updated loading state for embeddable signup form 
Closes https://github.com/TryGhost/Team/issues/3390
 2023-06-08 12:28:45 +02:00
Simon Backx
0b6cae09e9 Fixed Storybook missing context 
no issue

Storybook didn't have access to the `t` method needed for translations. This change adds a Storybook decorator to all stories.
 2023-06-08 11:20:16 +02:00
Elena Baidakova
4f1a92fb17
Fixed the ability to return to the main post page after scheduling a post in lexical (#16970) 
refs TryGhost/Team#3405
- BackgroundSave option sets post status as Draft. Don't need such
behaviour as a post already can have a different status when a user
leaves the page.
 2023-06-08 12:20:07 +04:00
Peter Zimon
cacd54b8c6 Remove traffic lights when in mobile view (AdminX) 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 08:33:01 +02:00
Peter Zimon
207651e2b0 Rename design modal cancel button in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 08:27:37 +02:00
Peter Zimon
949df42000 Added temporary preview content 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 08:14:12 +02:00
Peter Zimon
0d1d4dc365 Removed custom view switch functions 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 08:03:53 +02:00
Peter Zimon
2eda7c3287 Added mobile view to preview modal in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 07:59:32 +02:00
Peter Zimon
d87994d210 Renamed chrome header component in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 07:28:16 +02:00
Peter Zimon
011db27650 Moved preview toolbar to global preview component 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 07:11:12 +02:00
Peter Zimon
859e052810 Updated unstyled option to select input in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 06:32:03 +02:00
Peter Zimon
f28829b24e Updated multiselect styles in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 06:32:03 +02:00
Peter Zimon
d1c32e47bb Updated default input field styles in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 06:32:03 +02:00
Peter Zimon
c67d6fd11b Added dynamic heading color to inputs in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-08 06:32:03 +02:00
Jono Mingard
c1628f46e0 Updated api services to be memoized in case of re-renders 
no issue
 2023-06-08 11:08:00 +12:00
Jono Mingard
446841ce9c Updated design settings to be editable and show theme settings 
refs https://github.com/TryGhost/Team/issues/3354
 2023-06-08 10:30:25 +12:00
Peter Zimon
567422174d Fixed select input size bug in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 22:58:47 +02:00
Peter Zimon
1cd341d9e6 Fixed type error 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 22:53:42 +02:00
Peter Zimon
812b83a66e Fixed type error 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 22:50:56 +02:00
Peter Zimon
1bfade4891 Added preview selection toolbar in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 22:48:58 +02:00
Ghost CI
a173a31736 Merged v5.50.4 into main 2023-06-07 18:43:27 +00:00
Ghost CI
e7eba9f4d7 v5.50.4 2023-06-07 18:43:25 +00:00
Kevin Ansfield
2a32187ad4
🐛 Fixed converter bug that stopped some snippets being migrated for the editor beta 
no issue

- if the converted mobiledoc started with a card and contained any text content we would hit a "can not read .length of undefined" error which could prevent snippets from being migrated when opening the beta editor and result in copy/paste from old editor to new not working
- bumped `@tryghost/kg-converters` to a fixed version
 2023-06-07 18:51:02 +01:00
Steve Larson
f6457569c6
Added koenig lexical package version to sentry report 
closes TryGhost/Team#3381
 2023-06-07 18:50:58 +01:00
Kevin Ansfield
0c24c009d2
🐛 Fixed converter bug that stopped some snippets being migrated for the editor beta 
no issue

- if the converted mobiledoc started with a card and contained any text content we would hit a "can not read .length of undefined" error which could prevent snippets from being migrated when opening the beta editor and result in copy/paste from old editor to new not working
- bumped `@tryghost/kg-converters` to a fixed version
 2023-06-07 18:48:19 +01:00
Steve Larson
85896287e3 Added koenig lexical package version to sentry report 
closes TryGhost/Team#3381
 2023-06-07 11:05:35 -05:00
Ghost CI
e1b1af38e9 Merged v5.50.3 into main 2023-06-07 16:01:00 +00:00
Ghost CI
887155938a v5.50.3 2023-06-07 16:00:59 +00:00
Peter Zimon
ed43ebaee6
Fixed editor feature image overlay bug 
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
 2023-06-07 17:52:55 +02:00
Peter Zimon
5960fdeb53 Fixed editor feature image overlay bug 
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
 2023-06-07 17:30:07 +02:00
Peter Zimon
f48dc5a847 Added inner scrolling for Design sidebar in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 17:30:07 +02:00
Nick Moreton
c4629e0118
Added transparency grid and event tracking to Image Editor (#16959) 2023-06-07 16:05:38 +01:00
Michael Barrett
9da246ac84
Enforce explicit cacheInvalidate header (#16826) 
refs https://github.com/TryGhost/Team/issues/3005
 2023-06-07 15:13:45 +01:00
Fabien "egg" O'Carroll
e0da095c76 Allowed integrations to use Collections API 2023-06-07 15:40:24 +02:00
Fabien 'egg' O'Carroll
92172aca8e
Wired up collections to posts endpoint (#16945) 
- Added support for `include=collections` to the Posts Admin API behind a flag
- Refactored some of the collections work to support it
 2023-06-07 15:06:15 +02:00
Daniel Lockyer
d127b975af
Disabled autoRefresh when inserting fixtures 
refs https://github.com/TryGhost/Toolbox/issues/592

- we don't need to receive the refreshed model back afterwards so we can
  save an SQL select per insert by disabling auto-refresh
- this saves about 18000 DB queries for the MySQL tests, which should
  help reduce test time due to the overhead
 2023-06-07 15:03:12 +02:00
Aileen Booker
9372124d61 Decouple sentry from analytics events handlers by expecting general exception handler 
no issue

- The class should not rely on being passed a specific dependency, but rather needs to communicate with types what structure and method it needs to function correctly.
- Replaced the specific dependency to `sentry` with a generic definition of what is expected.
 2023-06-07 09:00:49 -04:00
Aileen Booker
5db1950090 Added tests ModelEventsAnalytics 
no issue

- Added full unit tests for `ModelEventsAnalytics` class
 2023-06-07 09:00:49 -04:00
Aileen Booker
6efc1cce82 Added JSDoc types and inject more deps for DomainEventsAnalytics 
no issue
 2023-06-07 09:00:49 -04:00
Aileen Booker
591ca2c9bf Added first test structure for ModelEventsAnalytics 
no issue

- The added `ModelEventsAnalytics` class didn't have tests before the refactor. Added unit tests to verify functionality.
 2023-06-07 09:00:49 -04:00
Aileen Booker
9b27804276 Added tests for DomainEventsAnalytics 
no issue

- Added unit tests for newly added `DomainEventsAnalytics` class to verify intended functionality
 2023-06-07 09:00:49 -04:00
Aileen Booker
2c4d9e2776 First pass on adding domainevents to segment service 
no issue

- In order to listen to `DomainEvents` for `MilestoneCreatedEvents` we need to add a `DomainEvents` listener and handler to the Segment analytics service.
- For better readability and to be more consistent with how code is currently written in Ghost, I refactored the service index file and split the two types of event listener into separate classes which is much cleaner and easier to test.
 2023-06-07 09:00:49 -04:00
Peter Zimon
20eaff9e5c Updated sticky footer component in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 13:06:26 +02:00
Sanne de Vries
6b444dabdc Added max width to signup card form in split layout 
Refs https://www.notion.so/ghost/Sign-up-card-feedback-doc-6b9aa746ed654a1a87b759dc5f5bb031?pvs=4#693bad1f085a430aa6da2a9659ac3f27
 2023-06-07 13:00:18 +02:00
Fabien "egg" O'Carroll
7667d6d589 Removed coverage checks from regression tests 
Regression tests are not written to ensure coverage of code, in fact they are
barely written at all anymore, instead we write unit and e2e tests. Because of
this the coverage is constantly dropping as the codebase grows. This causes
significant pain and suffering for developers and slows down development.
 2023-06-07 12:46:39 +02:00
Peter Zimon
76704d05c6 Added global sticky footer component in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 11:53:51 +02:00
Kevin Ansfield
abc169329c
Added error logging to lexical snippet fix try/catch 
no issue

- we had a `catch` with no error logging, it shouldn't be hit but it will be useful to know if it does fail
 2023-06-07 09:56:18 +01:00
Peter Zimon
ef096d9c87 Cleaned up classname properties in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 10:48:33 +02:00
Peter Zimon
f05b6a6037 Added unstyled property to image uploads AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 10:29:03 +02:00
Peter Zimon
9faf2cafbe Got rid of modal folders in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 09:53:20 +02:00
Peter Zimon
a3cba13381 Broke down design settings in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 09:40:56 +02:00
Peter Zimon
d7e5661a35 Fixed preview modal size bug in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-07 09:10:16 +02:00
Sodbileg Gansukh
dfd4ab0f0f
Fixed search input focus on iOS (#16950) 
closes https://github.com/TryGhost/Ghost/issues/16825

- iOS is very restrictive on input focus which doesn't allow without any
user interaction
- The only workaround was creating a temporary input, focus it, and
remove it after moving the focus to the actual searfch input
- It also moves the inputRef to the parent component, so that it can be
used in the click event handler, because the focus event only works when
it's inside a function that's triggered after user interaction
 2023-06-07 15:01:28 +08:00
Duberly, Guarnizo Fuentes Rivera
28bef37d02
Updated Spanish translations (#16940) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-07 08:57:30 +02:00
EchoBilisim
095a262b14
Updated Turkish translations (#16937) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-07 08:52:20 +02:00
Daniel Lockyer
5d7d56198c
Released Portal v2.33.1 2023-06-07 08:38:25 +02:00
Daniel Lockyer
5f860c6e31
Fixed encoded characters appearing for Offers in Portal 
fixes https://github.com/TryGhost/Team/issues/3392

- the "price" here can contain a slash, which is encoded/escaped by default by
  i18next
- this disables the escaping to fix the text that is shown to the user
 2023-06-07 08:35:40 +02:00
Rishabh
71e5d708d4 Reverted "Disabled image editor setting check" 
This reverts commit 9d9e296148.

This commit was a temporary fix to load the image editor if the setting was disabled.
 2023-06-07 02:10:02 +05:30
Ghost CI
80ed948bb9 Merged v5.50.2 into main 2023-06-06 19:05:20 +00:00
Ghost CI
924d73e02e v5.50.2 2023-06-06 19:05:19 +00:00
Rishabh
9d9e296148 Disabled image editor setting check 
refs https://github.com/TryGhost/Team/issues/3034

Temporarily disables image editor setting check to allow it load by default
 2023-06-06 23:59:43 +05:30
Rishabh
6806b88139 Fixed pintura link in image editor integration 
refs https://github.com/TryGhost/Team/issues/3034
 2023-06-06 23:35:56 +05:30
Steve Larson
75458cd7be Added koenig lexical version to feedback submission 
refs TryGhost/Team#3381
 2023-06-06 12:55:51 -05:00
Naz
fab5b1845c
Made builtin collections un-deletable 
closes https://github.com/TryGhost/Team/issues/3376

- It should not be possible to delete a built-in collection.
 2023-06-06 22:04:16 +07:00
Ghost CI
c8b713a679 Merged v5.50.1 into main 2023-06-06 14:40:58 +00:00
Ghost CI
6a07d63f38 v5.50.1 2023-06-06 14:40:57 +00:00
Kevin Ansfield
076c2be9aa
🐛 Fixed copy/paste of HR cards between editor and beta editor 
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
 2023-06-06 15:20:35 +01:00
Kevin Ansfield
d5a547b6ad
Added double-encoded fix to mobiledoc->lexical snippets sync 
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
 2023-06-06 15:20:22 +01:00
Kevin Ansfield
ed24899fa5
🐛 Fixed existing snippets not being available in beta editor 
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
 2023-06-06 15:20:14 +01:00
Kevin Ansfield
dddd2a4111
🐛 Fixed copy/paste of HR cards between editor and beta editor 
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
 2023-06-06 15:14:22 +01:00
Michael Barrett
a1b08f15b2
Fixed flaky frontend members test (#16947) 
closes https://github.com/TryGhost/Team/issues/3325

Awaited `DomainEvents.allSettled()` to ensure domain event is fully
processed before asserting member was successfully updated
 2023-06-06 14:57:46 +01:00
Sanne de Vries
d9a20b0e00 Fixed form embed settings overflowing in x direction 
Closes https://github.com/TryGhost/Team/issues/3384
 2023-06-06 15:24:08 +02:00
Peter Zimon
2e2a96c741 User modal refinements in AdminX 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-06 15:17:05 +02:00
Peter Zimon
2fc3336dd2 Fixed modal padding bug 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-06 15:08:04 +02:00
Sanne de Vries
c08723b7aa
Fixed error message position to be visible on minimal form (#16946) 
Closes https://github.com/TryGhost/Team/issues/3386
 2023-06-06 15:05:24 +02:00
Peter Zimon
19dfd28946 Added sticky footer option to modals in AdminX 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-06 14:58:55 +02:00
Peter Zimon
f5415a25ad Added backDropClick param. to modals in AdminX 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-06 14:58:55 +02:00
Rishabh Garg
5c209abdc0
Updated default value for image editor integration setting (#16897) 
refs https://github.com/TryGhost/Team/issues/3145

Updates pintura integration to be switched on by default for all sites by adding a migration to update the default value for the setting.
 2023-06-06 18:15:01 +05:30
Kevin Ansfield
c11c842b1e
Added double-encoded fix to mobiledoc->lexical snippets sync 
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
 2023-06-06 13:35:07 +01:00
Kevin Ansfield
48defc4000
🐛 Fixed existing snippets not being available in beta editor 
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
 2023-06-06 12:56:33 +01:00
Sanne de Vries
9c9eae1c11 Updated signup embed modal responsiveness 
Refs https://github.com/TryGhost/Team/issues/3340
 2023-06-06 12:21:11 +02:00
Daniel Lockyer
73ba799d17
Fixed generating sodo-search CSS in dev mode 
refs https://ghost.slack.com/archives/CFH10N79S/p1686042479311309?thread_ts=1679079897.164069&cid=CFH10N79S

- the current build workflow wasn't generating the Tailwind compiled CSS
  so we needed to amend the commands to do so
 2023-06-06 12:19:40 +02:00
Rishabh
695857ae96 Wired save and error handling for user details modal 
refs https://github.com/TryGhost/Team/issues/3351

- updates user state on suspend/delete actions to show the latest
- shows errors for email and url on user detail screen
 2023-06-06 15:08:44 +05:30
Simon Backx
31549933a1 Removed 200% width in signup form minimal preview 
no issue

This change wasn't needed after all
 2023-06-06 10:43:32 +02:00
Simon Backx
0ae1dad2d2 Removed signup form preview flickering in Safari and improved responsiveness 
no issue

- In Safari, we'll poll longer before animating to the new iframe
- Update the iframe immediately if the last change was a while ago, to improve responsiveness
 2023-06-06 10:43:06 +02:00
Sodbileg Gansukh
feac482859 Fixed loading screen flash issue in dark mode 
closes https://github.com/TryGhost/Team/issues/3344
 2023-06-06 16:21:15 +08:00
Simon Backx
f0518bc76a Increased signup form embed icon resolution to 192px 
no issue

Optimal resolution for @3x devices
 2023-06-06 09:42:42 +02:00
Simon Backx
fc89ad22fc Prevented setting signup form embed locale when feature flag is disabled 
fixes https://github.com/TryGhost/Team/issues/3385
 2023-06-06 09:40:47 +02:00
Naz
5a8eec402f
Restricted built-in collection init to run once 
refs https://github.com/TryGhost/Team/issues/3376
fixes b4a97d084f

- The in-memory stores are not cleaned up when the Ghost instance is "shallow restarted" between test suite runs, causing the initialization of built-in collections to run multiple times. The initialization should ever add the collections once.
 2023-06-06 13:35:06 +07:00
Naz
b4a97d084f
Fixed snapshot for failing collections test 
refs bdbd9327d9

- The "build" command was not run for the @tryghost/collecitons package and caused outdated response
 2023-06-06 12:50:55 +07:00
Naz
bdbd9327d9
Added built-in automatic featured collection 
refs https://github.com/TryGhost/Team/issues/3376

- When the Ghost instance is initialized it has to have a set of built-in collections. With these changes Ghost starts with a "featured posts" collection - available to be used right away.
 2023-06-06 12:41:37 +07:00
Rishabh
fbfb1d0008 Fixed user cover and profile image upload issues 
refs https://github.com/TryGhost/Team/issues/3351

Uploading cover and profile images for user was having a weird behavior where one was getting removed when the other was uploaded or deleted. This was due to how the state was being updated on image change, which ended up using the old user state while setting the new one. This change uses react's setState method that uses the latest state to set the new one so the changes don't get overridden.
 2023-06-06 09:43:36 +05:30
Rishabh
c243b48629 Wired user invite actions on adminX 
refs https://github.com/TryGhost/Team/issues/3351

- wires resend and revoke actions for a user invite in staff settings
 2023-06-06 09:20:45 +05:30
Rishabh
c88a073a5c Wired delete and owner actions for staff users in adminX 
refs https://github.com/TryGhost/Team/issues/3351

- allows owners/admins to delete users based on their permission level
- allows admins to be made owner users only if owner is logged in
 2023-06-06 09:20:45 +05:30
Jono Mingard
885531b345 Added e2e tests for most simple AdminX settings 2023-06-06 15:50:07 +12:00
Jono M
089a3f7aaf
Added playwright config to admin-x-settings (#16941) 
no issue
 2023-06-06 11:29:28 +12:00
Simon Backx
ab0c33346d Fixed signup form minimal width in preview 
no issue
 2023-06-05 18:10:19 +02:00
Simon Backx
1e7b658148 Updated sign up form to use resized version of icon 
fixes https://github.com/TryGhost/Team/issues/3345

The icon is now served as a 128x128px version
 2023-06-05 17:59:18 +02:00
Peter Zimon
ae6a2ba0cc Added notification to user invitations 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-05 17:54:53 +02:00
Simon Backx
9aef897936 Increased virtual iframe width of minimal signup form preview 
no issue

Because the signup form is responsive, it is displayed too small in the preview. To counteract this, the width of the iframe is increased to 200%, and clipped to make it larger.
 2023-06-05 17:37:43 +02:00
Peter Zimon
e0dca2e0c7 Cleanup test code from AdminX 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-05 17:33:20 +02:00
Peter Zimon
5ad8e71cba Added toasters to AdminX Design System 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-05 17:31:25 +02:00
Daniel Lockyer
6c3517f67a
Removed unused top-gh-contribs dependency 
- this is currently unused so we can clean it up
 2023-06-05 15:58:51 +02:00
Simon Backx
b641859242 Released Signup Form v0.0.2 2023-06-05 15:30:05 +02:00
Daniel Lockyer
2b488945da
Fixed missing newline 2023-06-05 15:25:54 +02:00
Simon Backx
22f4d55f75 Added throttling and animation when updating signup form preview 
fixes https://github.com/TryGhost/Team/issues/3378
 2023-06-05 15:24:59 +02:00
Daniel Lockyer
c2c6e54578
Fixed line endings in Croatian translation files 
- these should be LF and not CRLF
 2023-06-05 15:22:39 +02:00
May Kittens Devour Your Soul
dbac82dd36
Added Croatian translations (#16928) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-05 14:40:46 +02:00
renovate[bot]
4834f77f0f Update dependency mailgun.js to v9 2023-06-05 14:34:16 +02:00
Ronald Langeveld
acb309679d Updated Afrikaans translations for Portal 
no issue
 2023-06-05 14:01:47 +02:00
Ronald Langeveld
b3c270e7ed Updated Afrikaans translations for ghost 2023-06-05 14:00:56 +02:00
Ronald Langeveld
3984dc2b11 Updated Afrikaans translations for Signup-form 
no issue
 2023-06-05 14:00:56 +02:00
Mysterious_Dev
7720ac6b10
Updated French translations for signup-form 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-05 13:51:18 +02:00
Naz
2390afc6f1
Added automatic collection recalculation 
closes https://github.com/TryGhost/Team/issues/3170

- When resources that are related to automatic collection filter are updated the posts in collections should be updated as well.
- This change adds a super-basic way to track changes in post/tag/author resources and updated all automatic collections when any of those resources change. In the future we can optimize the update process to be more performant, but it's good enough for current needs
 2023-06-05 18:33:39 +07:00
Keegan Sand
4d3c7d3177
Updated Spanish Portal translations 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-05 13:18:23 +02:00
Raka Afp
793ab34c81
Updated Bahasa Indonesia translations for signup-form (#16932) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-05 13:09:41 +02:00
EchoBilisim
8133360020
Updated Turkish translations for signup-form 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-05 13:04:07 +02:00
Gary Lai
04e76eced4
Added traditional Chinese translatinos for signup-form (#16926) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-05 13:01:45 +02:00
Sodbileg Gansukh
f4c109cfb2 Added small improvements to the image editor UI 
refs https://github.com/TryGhost/Team/issues/3208

- added maximum width limit to the editor stage, so the image doesn't get under the editor controls
- made the crop indicator a bit bigger
- fixed image alignment for the vertical layout
 2023-06-05 18:27:31 +08:00
Ronald Langeveld
52150d5ffb
Fixed Signup Embed iFrame not loading in Safari (#16935) 
refs https://github.com/TryGhost/Team/issues/3375

- Fixed a safari bug that caused the signup embed iframe to be in the
`onLoad` state perpetually, causing it not to render.
 2023-06-05 12:01:55 +02:00
Peter Zimon
ffe5cd765a Updated user role in AdminX settings 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-05 11:53:06 +02:00
Peter Zimon
c6a5ada5cc Updated user cover and profile image position 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-05 11:48:56 +02:00
Peter Zimon
2fe6ccbc22 Wired up user cover and profile image actions 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-05 11:45:47 +02:00
Naz
c86859d0a7
Added test coverage to automatic collections 
refs https://github.com/TryGhost/Team/issues/3170

- The test confirms relational filters like `tag:kitchen-sink` filtering works for automatic collections
 2023-06-05 16:37:17 +07:00
Naz
3599cfdd7a
Added test coverage for collection updates 
refs https://github.com/TryGhost/Team/issues/3170

- When the collection filter is updated the collection's posts should be updated automatically.
 2023-06-05 16:23:02 +07:00
Ghost CI
67fdff479b Merged v5.50.0 into main 2023-06-05 08:58:32 +00:00
Ghost CI
7170b2489e v5.50.0 2023-06-05 08:58:31 +00:00
Kevin Ansfield
bbd511b752
✨ Added beta of the new Ghost editor (#16923) 
no issue

Keep an eye on Ghost's changelog (https://ghost.org/changelog/) for the full feature announcement.
 2023-06-05 09:46:31 +01:00
Kevin Ansfield
8167e7dc5e
Fixed lexical rendering bugs 
closes https://github.com/TryGhost/Team/issues/3373
closes https://github.com/TryGhost/Team/issues/3374

- fixes rendering of contiguous linebreaks
- fixes rendering of multiple nested formats when using latest jsdom release
 2023-06-05 10:42:15 +02:00
Naz
1968296410
Added type:post enforcement when fetching posts for collections 
refs https://github.com/TryGhost/Team/issues/3148

- Collections should never ever operate on pages, so limiting them at the fetch stage is the bes possible place, so they don't enter the system when an automatic collection is created.
 2023-06-05 15:04:57 +07:00
Naz
260ca0548a
Added test coverage to automatic collections 
refs https://github.com/TryGhost/Team/issues/3170

- The test confirms `published_at` filtering works for automatic collections
 2023-06-05 14:59:49 +07:00
Naz
bfefcfd4df
Added automatic collection creation based on filter 
refs https://github.com/TryGhost/Team/issues/3170

- This implementation allows to create an automatic collection with a filter defining automatically populated posts that belong to a collection
- To populate collection using a filter the API client can send a `filter` property along with a collection request
- Filter values are compatible with the filters used in Content API (https://ghost.org/docs/content-api/#filter)
 2023-06-05 13:39:52 +07:00
Naz
6e224f3702
Added automatic collection validation 
refs https://github.com/TryGhost/Team/issues/3170

- When an automatic collection is created it should always have a valid filter assigned
 2023-06-05 13:39:52 +07:00
Naz
f64276b26e
Added basic test an automatic collection 
refs https://github.com/TryGhost/Team/issues/3170

- This test confirms we can create a collection with "automatic" type and assign a "filter" value to it
 2023-06-05 13:39:49 +07:00
Rishabh
c2371b4841 Wired suspend user action on user detail modal in adminX 
refs https://github.com/TryGhost/Team/issues/3351

- wires Suspend/Un-suspend user action on user detail modal
- adds running state for task buttons in modal
- adds api to delete and suspend/un-suspend users
 2023-06-05 10:09:37 +05:30
Rishabh
2b0a6bc454 Wired user invite modal in admin-x 
refs https://github.com/TryGhost/Team/issues/3351

Allows logged in user to send invites to new users, with allowed roles that can be invited restricted based on the role of logged in user.
 2023-06-04 15:49:34 +05:30
Kevin Ansfield
2fb68ada83
Fixed lexical rendering bugs 
closes https://github.com/TryGhost/Team/issues/3373
closes https://github.com/TryGhost/Team/issues/3374

- fixes rendering of contiguous linebreaks
- fixes rendering of multiple nested formats when using latest jsdom release
 2023-06-02 16:33:14 +01:00
Ghost CI
6ac848195c v5.49.3 2023-06-02 15:02:42 +00:00
Simon Backx
d4f82f8b88 Added copy on click to textarea in signup form embed modal 
no issue
 2023-06-02 16:31:30 +02:00
Simon Backx
fc5af7e7f8 Removed notification when copying signup form embed code 2023-06-02 16:21:20 +02:00
Djordje Vlaisavljevic
187c62145c Updated Twitter and FB card edit mode spacing 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 15:15:47 +01:00
Simon Backx
ff28e1c94f Added fixed order in data attributes for signup form embed script 
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685711310532969
 2023-06-02 16:13:42 +02:00
Sanne de Vries
8833ec03de
Updated signup form modal (#16925) 
Refs https://github.com/TryGhost/Team/issues/3340

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-06-02 16:07:30 +02:00
Elena Baidakova
af2e069cbe Bumped @tryghost/kg-lexical-html-renderer 
no issue
 2023-06-02 17:59:55 +04:00
Peter Zimon
2c0b5e61c5 Refined invites user list in AdminX Settings 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-02 15:49:09 +02:00
Djordje Vlaisavljevic
f5e81c9b16 Removed className prop from ImageUpload 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:56 +01:00
Djordje Vlaisavljevic
e9caf73175 Fixed lint error 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
d7ecc4b33e Moved CSS for ImageUpload to prop 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
449ce994f4 Moved ImageUpload labels from props to children 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
091b3acd61 Updated Twitter and FB card edit mode design 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
bbb09523ce Added bg-transparent to clearBg variants of TextField and TextArea 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
10f987ad24 Added className prop to ImageUpload 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
8a8561fc94 Added FB and Twitter social icons 
refs https://github.com/TryGhost/Team/issues/3318
 2023-06-02 14:47:09 +01:00
Rishabh
b307c59d54 Wired invites list in admin-x settings 
refs https://github.com/TryGhost/Team/issues/3351

- adds api to get list of all invites on the site
- wires invite list with Revoke/Resend option on the User settings group
 2023-06-02 18:41:09 +05:30
Peter Zimon
1a0c1c0cd2 Minor UX fix on password change 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-02 15:09:48 +02:00
Elena Baidakova
97c3434c3d Bumped @tryghost/kg-lexical-html-renderer 
no issue
 2023-06-02 17:06:08 +04:00
Peter Zimon
d1c0ea6c57 Added avatar image uploader in AdminX 
refs. https://github.com/TryGhost/Team/issues/3351
 2023-06-02 15:00:36 +02:00
Simon Backx
498629d9a9 Fixed encoded html character in signup form success message translation 
no issue
 2023-06-02 14:38:54 +02:00
Simon Backx
258dc2f8f2 Added locale data option to signup form script 
refs https://github.com/TryGhost/Team/issues/3307
 2023-06-02 14:36:17 +02:00