TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-22 10:21:36 +03:00
Code Issues Projects Releases Wiki Activity
29,889 Commits 250 Branches 1,686 Tags 392 MiB
35bc5fa08a
Commit Graph

5344 Commits

Author SHA1 Message Date
Simon Backx
1caa8f5b9a Hidden analytics page button for published post when attribution is disabled 
fixes https://github.com/TryGhost/Team/issues/1998

- Should not show analytics button when post is not sent via email and attribution is disabled
- Improved checks for the analytics button
 2022-09-28 16:15:03 +02:00
James Morris
dc9ef69547 Better matching up the pages table with the posts table 
refs https://github.com/TryGhost/Team/issues/1995
 2022-09-28 14:17:12 +01:00
James Morris
cd97341ed6 Fixed up the edit and stats buttons based on feedback 
refs https://github.com/TryGhost/Team/issues/1994
 2022-09-28 13:44:58 +01:00
Djordje Vlaisavljevic
b72b51b542 Made the attribution widget look better on smaller screens 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 14:20:40 +02:00
Rishabh
d63f4548c0 Removed attribution sources from UI if site is invite-only 
refs https://github.com/TryGhost/Team/issues/1986

- removes attribution section from dashboard and post analytics if site is invite only
 2022-09-28 17:26:38 +05:30
Rishabh
8c225ee9d0 Fixed lint 
- updates `index` for susbcription detail box
 2022-09-28 17:22:24 +05:30
Djordje Vlaisavljevic
9209a39c29 Added new attribution widget design 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 13:44:28 +02:00
Rishabh
79248cdde9 Fixed dropdown blink for subscription detail box 
refs https://github.com/TryGhost/Team/issues/1986

- creates new component for subscription detail box that avoids re-render of whole block causing flicker
 2022-09-28 17:08:28 +05:30
Rishabh
cf1f41d61c Updated attribution table design to show single column data 
- adds new dropdown that allows switching between signups vs paid conversions
- updates chart data based on dropdown value, keeps the sort column till the design for this is polished
 2022-09-28 16:27:44 +05:30
James Morris
994f0eea64 Tiny padding adjustment for boxes 
refs https://github.com/TryGhost/Team/issues/1968
 2022-09-28 11:11:15 +01:00
Rishabh
8b2db5c017 Refined attribution table on dashboard for list of sources 
- updates table to always show top 5 sources, including the empty sources
- only adds `Other` to list on table if more than 5 sources exist
- updates mock to include `Unavailable` data
 2022-09-28 15:31:41 +05:30
Simon Backx
160469d787 Improved analytics page loading states 
refs https://github.com/TryGhost/Team/issues/1976

- Wait to show any module until everything has been loaded
 2022-09-28 11:58:51 +02:00
Djordje Vlaisavljevic
49a922fbd5 Updated attribution widget empty state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 11:05:28 +02:00
Simon Backx
03bfe2504e Fixed ref instead of rel when stripping querystring from tracked url 
no issue
 2022-09-28 11:03:00 +02:00
Simon Backx
e0965a6262 Readded hash to cleaned tracked links in admin 
fixes https://github.com/TryGhost/Team/issues/1980
 2022-09-28 10:31:18 +02:00
Sanne de Vries
08656ea569 Updated lexical sandbox page structure 
Refs https://github.com/TryGhost/Team/issues/1991
 2022-09-28 11:06:32 +07:00
Djordje Vlaisavljevic
2c2fd20a17 Removed inline styles 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 21:36:59 +02:00
Djordje Vlaisavljevic
ca7937d100 Removed inline styles 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 21:36:59 +02:00
Djordje Vlaisavljevic
b64e7b6da0 Fixed dashboard dark mode issues 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 20:47:10 +02:00
Djordje Vlaisavljevic
8a3c696f9d Fixed subscription box dark mode issues 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 20:34:59 +02:00
James Morris
81605f7f2a Added a basic loading state to modules in post analytics 
refs https://github.com/TryGhost/Team/issues/1956
 2022-09-27 18:02:20 +01:00
James Morris
c266971e04 Fixed the broken source attributiont table design in post analytics 
refs https://github.com/TryGhost/Team/issues/1959
 2022-09-27 18:02:20 +01:00
Rishabh
2be3452c76 Refined attribution data on member details screen 
refs https://github.com/TryGhost/Team/issues/1986

- hides attribution section if attribution data is null
- hides referrer section if referrer source is empty
 2022-09-27 21:59:42 +05:30
Djordje Vlaisavljevic
f3f6e87378 Updated chart container size 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
535624d511 Updated chart size 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
cb25817581 Fixed chart title 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
94009a2612 Removed old empty state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
cbd76f3437 Updated dot color 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Kevin Ansfield
a67cb265fc 🐛 Fixed error preventing publish for non-Admin staff users 
refs e3db911108

Contributors/Authors/Editors do not have permissions to fetch members so the request to fetch a member count when checking member host limits fails and blocked publishing because it was treated like a failed limit check.

- prevented the up-front limit check from running for non-Admin staff users. Publishing will still fail for other users if the site is over the hosting plan members limit but the error will be shown later in the flow when the actual publish request is made.
 2022-09-27 13:19:02 +01:00
Kevin Ansfield
e2d02131aa Added lexical editor design sandbox route 
closes https://github.com/TryGhost/Team/issues/1985

- adds `/#/lexicalsandbox` route that renders the `<DesignSandbox />` component from the `@tryghost/koenig-lexical` library
 2022-09-27 13:00:16 +01:00
Djordje Vlaisavljevic
a6bf772195 Added dynamic border color 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
45b3772ddc Made the dashes lighter 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
3960384a25 Removed fixed height from the table body 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
970eef761c Removed dots from modal sources table 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
49786c8ca4 Made the modal wider 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
baede872ea Updated the copy 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
James Morris
ec9e61dc2f Tweaks to how click events are handled based on feedback 
refs https://github.com/TryGhost/Team/issues/1981
 2022-09-27 12:29:08 +01:00
Djordje Vlaisavljevic
e98dda15f9 Removed subscription source when it's unknown 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-27 11:32:31 +02:00
Djordje Vlaisavljevic
4858baf2df Added doughnut chart titles 
refs https://github.com/TryGhost/Team/issues/1905
 2022-09-27 10:55:27 +02:00
Djordje Vlaisavljevic
87ad7d1df3 Updated font weight for source 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-27 10:51:51 +02:00
Djordje Vlaisavljevic
83f88e1586 Added pointer cursor to column names 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-27 10:02:27 +02:00
Djordje Vlaisavljevic
5d5fc33d2c Updated MRR widget design 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-27 09:53:41 +02:00
Sanne de Vries
ac7d7427e9 Fixed padding on member-limit notification box on publish page 
Refs https://github.com/TryGhost/Team/issues/1885
 2022-09-27 11:27:58 +07:00
Daniel Lockyer
9818634b63
Merged v5.16.1 into main 
v5.16.1
 2022-09-27 11:21:48 +07:00
Rishabh Garg
b1b3c72642
Added sorting for attribution data on dashboard (#15474) 
refs https://github.com/TryGhost/Team/issues/1941

- sorts attribution table and chart on signups or paid conversions
 2022-09-26 23:29:30 +05:30
James Morris
83e608c25b Changed link clicks to newsletter links for analytics page 
refs https://github.com/TryGhost/Team/issues/1968
 2022-09-26 18:12:06 +01:00
James Morris
8bef3b9e34 The new post list rows match the edit or analytics button 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 18:09:52 +01:00
Kevin Ansfield
e3db911108
🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473) 
closes https://github.com/TryGhost/Team/issues/1885

- adds limit check for members to the `PublishOptions` class when it's constructed to set a `publishDisabledError` property if the limit check fails
  - if `publishOptions.publishDisabledCheck` is present, all publish options in the publish flow are disabled, the underlying error message is shown, and the continue button is removed to prevent filling in everything only to find at the end of the process that publishing fails
- added handling for a `HostLimitError` error from the API when confirming publishing so the proper underlying message is displayed instead of the confusing "Host limit error, cannot edit post" error
  - this is a backup measure for any instances where you're under the max members limit when starting the publish flow but are over the limit when you reach the end of the publish flow
 2022-09-26 17:37:35 +01:00
James Morris
ad2cb3ae11 Lots of visual tweaks to the post list table 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 17:30:39 +01:00
Djordje Vlaisavljevic
ac661c19b7 Updated copy 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-26 17:26:01 +02:00
Djordje Vlaisavljevic
74873c7e48 Updated the heading text 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:25:27 +02:00
Djordje Vlaisavljevic
3a9143cacc Removed the medium info from the subscription box 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:20:14 +02:00
Djordje Vlaisavljevic
f9ce3239ee Updated the heading text 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:19:12 +02:00
Djordje Vlaisavljevic
bb0b9c4261 Added rotation to the details toggle arrow 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:12:56 +02:00
Djordje Vlaisavljevic
bdc43d8f66 Updated table design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 17:12:25 +02:00
Djordje Vlaisavljevic
752cf1a607 Added static sort indicator to the table 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 15:53:26 +02:00
Djordje Vlaisavljevic
64d4ddbaca Updated logic for showing member profile attribution 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-26 15:52:39 +02:00
Djordje Vlaisavljevic
81e15f823b Updated logic for showing member profile attribution 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-26 15:44:53 +02:00
Djordje Vlaisavljevic
6461e814db Updated font weight 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 15:32:18 +02:00
Djordje Vlaisavljevic
d024bd60fc Updated attribution widget design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 15:30:20 +02:00
Simon Backx
281cd2e7a3
Renamed count.conversions to count.paid_conversions in posts (#15460) 
fixes https://github.com/TryGhost/Team/issues/1943
 2022-09-26 14:25:27 +02:00
Djordje Vlaisavljevic
acd1de3983 Removed chart border on hover 
refs https://github.com/TryGhost/Team/issues/1905
 2022-09-26 13:38:56 +02:00
James Morris
97af5c3731 Added a small tweak to the percentages on post list 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 12:30:54 +01:00
James Morris
7e780681d9 Looking to improve the post list rows again for email clicks 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 12:30:54 +01:00
James Morris
c92267c900 Realignement of the post list items for email clicks 
no issue
 2022-09-26 12:30:54 +01:00
Djordje Vlaisavljevic
ceadb2634f Updated MRR widget design 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-26 13:21:05 +02:00
Djordje Vlaisavljevic
4941627128 Added show/hide behaviour to subscription box details 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 13:20:31 +02:00
Djordje Vlaisavljevic
b9c7fe316b Updated attribution widget design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 12:14:06 +02:00
Rishabh
190031f38c Added modal for showing all attribution sources 
refs https://github.com/TryGhost/Team/issues/1941

- limits the source attribution list to top 5 on dashboard, and shows all sources on clicking on `Other` link

Fixed lint
 2022-09-26 10:43:05 +05:30
Rishabh
baaf64405a Refined details toggle on member subscription box 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Rishabh
f4e6f00077 Refined attribution chart to show custom tooltips 
refs https://github.com/TryGhost/Team/issues/1905
 2022-09-26 10:43:05 +05:30
Rishabh
e76f082884 Moved mrr data to dashboard anchor chart 
refs https://github.com/TryGhost/Team/issues/1932

- moves MRR data to main dashboard anchor chart behind source attribution flag
 2022-09-26 10:43:05 +05:30
Rishabh
6137f9d3d5 Refined attribution chart legends to match table 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 10:43:05 +05:30
Rishabh
ec5f09edeb Refined member subscription detail box design 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
50100a7c8d Capitalized subscription page 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
bdce8f21cc Updated font weights 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
4a8c9a530b Updated embedded MRR metric design 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
0be2191726 Updated attribution dashboard widget design 
refs https://github.com/TryGhost/Team/issues/1941

Updated attribution dashboard widget design

refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
7c23e721f1 Updated attribution sources table design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
5785f2b9bd Reorganized dashboard layout 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-26 10:43:05 +05:30
Sanne de Vries
663b9ffe02 Updated post list stats 
Refs https://github.com/TryGhost/Team/issues/1895
 2022-09-26 10:39:37 +07:00
Kevin Ansfield
508119244c
Switched delete snippet modal to new modal pattern (#15468) 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-25 10:54:07 +01:00
Kevin Ansfield
ac67475605
Switched delete member modal to new modal pattern (#15467) 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-24 18:18:34 +02:00
Kevin Ansfield
63b1e4e8ad
Resolved power-select related deprecation warnings for loading components by string (#15466) 
no issue

- in many places we were passing a string as an argument to a `<PowerSelect>` related component that referred to a component name, that was throwing deprecation warnings because those strings were used dynamically with `{{component}}` later on which isn't statically analyzable
- switched to passing a component explicitly with `{{component}}`
- https://github.com/embroider-build/embroider/blob/main/REPLACING-COMPONENT-HELPER.md#when-youre-passing-a-component-to-someone-else
 2022-09-24 17:00:05 +02:00
renovate[bot]
65a74f41c8
Update dependency ember-power-select to v4.1.7 (#15157) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
 2022-09-24 15:08:42 +02:00
Rishabh
e5fb7b805f Wired referrer information on member detail page 
refs https://github.com/TryGhost/Ghost/pull/15463
 2022-09-24 17:46:57 +05:30
Kevin Ansfield
a934481f45 Fixed @sentry/browser imports 
no issue

- needed for embroider compatibility
- the package we have installed is `@sentry/ember` not `@sentry/browser` so the imports fail when built by webpack
 2022-09-24 13:28:35 +02:00
Kevin Ansfield
bfd7ace721 Fixed invalid shortcuts imports 
no issue

- `utils/shortcuts.js` does not have a default export but we were using it as if it did, this isn't valid and breaks when transpiled via webpack via embroider
- switched to the valid `import * as shortcuts` import syntax
 2022-09-24 13:28:30 +02:00
Kevin Ansfield
fa84808048 Dropped ember-cli-moment-shim dependency 
no issue

Since `ember-moment@10.0` it's not been necessary to use the `ember-cli-moment-shim` package, with `moment` instead being usable directly via `ember-auto-import`. Getting rid of the shim package is necessary for compatibility with `embroider`, Ember's new build tooling.

- dropped `ember-cli-moment-shim` dependency
- added `moment-timezone` dependency and updated all imports to reflect the different package
- worked around `ember-power-calendar` having `ember-cli-moment-shim` as a sub-dependency
  - added empty in-repo-addon `ember-power-calendar-moment` to avoid `ember-power-calendar` complaining about a missing package
  - added `ember-power-calendar-utils` in-repo-addon that is a copy of `ember-power-calendar-moment` but without the build-time renaming of the tree for better compatibility with embroider
 2022-09-24 13:28:23 +02:00
Kevin Ansfield
9bbafc3ccf Deleted unused files 
no issue

- files were left over from earlier development and not being used anywhere
 2022-09-24 13:27:54 +02:00
Simon Backx
bba6a4dc84 Fixed cleaned URLs in link table on analytics page 
fixes https://github.com/TryGhost/Team/issues/1963
 2022-09-23 17:42:51 +02:00
James Morris
87a242bada Removed the full width for posts with the member attribution flag 
- Full width was  part of the member attribution flag
- It's messing with email clicks flag
- Removing for both to make things easier

refs https://github.com/TryGhost/Team/issues/1960
 2022-09-23 16:19:35 +01:00
James Morris
6c527cfe78 Made the margins event between elements in the new post rows 
refs https://github.com/TryGhost/Team/issues/1957
 2022-09-23 15:55:20 +01:00
James Morris
80eaa567b5 Added target blank to links in the link table on post analytics 
refs https://github.com/TryGhost/Team/issues/1955
 2022-09-23 15:23:59 +01:00
James Morris
eb7547ea3c Added a new click icon for the member attribution flag 
- Adds a new SVG icon when the members attribution flag is on only
- Fixes up some dark mode issues for the URL scrollable in events

refs https://github.com/TryGhost/Team/issues/1951
 2022-09-22 18:00:48 +01:00
James Morris
729935eca7 Tidied up the page a bit more with the source attribution included 
- Has the source attribution chart and table with some basic styles
- Added in a edit button to the analytics page

refs https://github.com/TryGhost/Team/issues/1920
 2022-09-22 17:20:15 +01:00
James Morris
0541dbc79b Moved the empty links into it's own box in the post analytics page 
- Not ideal, yet, but this is better than what it was before
- Now links empty state is inside it's box rather than just plain text

refs https://github.com/TryGhost/Team/issues/1920
 2022-09-22 17:18:51 +01:00
Djordje Vlaisavljevic
a0c6fafba1
Refined source attribution dashboard design (#15457) 
refs https://github.com/TryGhost/Team/issues/1932
refs https://github.com/TryGhost/Team/issues/1941
refs https://github.com/TryGhost/Team/issues/1904
refs https://github.com/TryGhost/Team/issues/1932

- updates attribution sources table design
- updates member profile page design
 2022-09-22 21:46:42 +05:30
Rishabh
e93f6071cd Handled null sources for attribution chart and table 
refs https://github.com/TryGhost/Team/issues/1932

- removes null sources from attribution chart
- moves null sources count to bottom of attribution table
 2022-09-22 21:04:46 +05:30
Simon Backx
7581b8726e Added basic post table and analytics page conditionals 
refs https://github.com/TryGhost/Team/issues/1947
 2022-09-22 15:40:37 +02:00