Commit Graph

9449 Commits

Author SHA1 Message Date
Simon Backx
3f95a5e00f Removed unnecessary and helper 2022-05-24 16:55:50 +02:00
Simon Backx
bc1aa493fa 🐛 Fixed unreliable paid members enabled checks (#2405)
refs https://github.com/TryGhost/Team/issues/1650

- Some places only checked for Stripe being connected via the 'connect' method and ignored the 'direct' method
- Updated (where possible) admin to use the new calculated `paid_members_enabled` setting
2022-05-24 16:53:03 +02:00
Kevin Ansfield
94c192041d Added guards for missing codemirror elements when destroying markdown cards
no issue

- if a markdown card is created and destroyed before the simplemde+codemirror instance is fully initialised we could throw errors due to simplemde calling methods on objects that don't yet exist during teardown
- we also had issues with the `_applyToolbarStyles()` method being called async by event handlers after the component was destroyed
2022-05-24 13:12:22 +01:00
Hannah Wolfe
1ca5b43fcb Fixed link to redirect documentation
closes: https://github.com/TryGhost/Ghost/issues/14888

- tutorials no longer lives under docs
2022-05-24 12:31:33 +01:00
Sanne de Vries
70f82896cd Added break-all to email addresses on member details page 2022-05-24 13:25:53 +02:00
Kevin Ansfield
7dd32423b6 🐛 Fixed inability to select a date in future months when scheduling
no issue

- selecting a date in a future month always selected the same day number in the current month, if that was in the past it would also reset to "in 5 minutes"
- we were grabbing the day/month/year from the moment object provided by the calendar picker but we weren't using the correct property names, moment.js uses `months` and `years` instead of `month` and `year`
2022-05-24 10:41:50 +01:00
Sanne de Vries
446ab3a9d8 Fixed subscriber count formatting on publish confirmation page
No ref
2022-05-24 10:57:56 +02:00
Kevin Ansfield
2502639a86 🐛 Fixed timezone related issues when scheduling posts
no issue

- fixed incorrect conversion of time when converting between site tz and utc when setting scheduled hour/minute in publish flow
  - we initially created a UTC `newDate` moment from `publishOptions.scheduledAtUTC` but then used `newDate.tz(siteTimezone).format()` to get the time which was the source of the bug, it was assumed that was a non-destructive action returning a new date but it actually changed the underlying date resulting in the later calculations causing timezone adjustments to be applied twice
  - simplified by not converting to UTC inside the publish-at component as that's already handled inside PublishOptions
- fixed time not resetting to minimum schedule time when set to earlier date than allowed
2022-05-23 22:12:37 +01:00
Daniel Lockyer
a559f4c686 v5.0.0 2022-05-23 13:20:52 +01:00
Djordje Vlaisavljevic
61a459ac2e Fixed linting error 2022-05-20 12:26:01 +02:00
Djordje Vlaisavljevic
f3b56d092a Fixed text overflow in the input field 2022-05-20 12:09:41 +02:00
Djordje Vlaisavljevic
80a9a664a7 Fixed mobile preview border-radius issue in Safari 2022-05-20 10:13:03 +02:00
Simon Backx
552800bde7 Fixed dashboard recent posts not showing email only posts
refs https://ghost.slack.com/archives/C02G9E68C/p1652982196273769
2022-05-20 09:34:25 +02:00
Kevin Ansfield
7a5f15414b Fixed scheduled publishedAt validation being triggered unexpectedly
no issue

Problem:
- the server stores time with second-level precision but we send milliseconds
- when scheduling a post we were storing the selected publish-at time in the PublishOptions instance with non-zero milliseconds as the initial date was based on now+5mins
- when we were saving after the initial schedule that millisecond-containing time was still being used resulting in a perceived time difference in our client-side and server-side validations indicating that the published_at value should be updated, but when that time was <2 mins in the future the published_at change validation was triggered resulting in errors

Solution:
- ensure we only set times on PublishOptions with 0 milliseconds
- update client-side validations so we only trigger published_at validation when it's dirty

Also fixed:
- client-side validation errors were not shown on the confirm step due to a missing `.args`
2022-05-19 23:11:01 +01:00
Simon Backx
bafbe9b6b0 Fixed paid subscribers graph not counting all items
refs https://ghost.slack.com/archives/C02G9E68C/p1652971697862399?thread_ts=1652893154.768669&cid=C02G9E68C

mergeDates skips a value when the date of the next item is different than the currently aggregating entry
2022-05-19 17:20:03 +02:00
Djordje Vlaisavljevic
d2db9c6a7f Fixed dropdown flicker in dark mode 2022-05-19 16:44:16 +02:00
Sanne de Vries
20b797d2e4 Updated subscriber count in newsletter selection dropdown in publish flow
No ref
2022-05-19 15:17:55 +02:00
Kevin Ansfield
802a3c6187 Skipped animation when switching between preview modal tabs
refs 2c9998be69

- animation should only show when opening the preview modal directly from the editor
2022-05-19 13:33:23 +01:00
Sanne de Vries
2c9998be69 Added animation to post preview modes and publish button
No ref
2022-05-19 14:13:12 +02:00
Sanne de Vries
2941065eb7 Added back button to completed publishing flow
No ref
2022-05-19 13:39:40 +02:00
Kevin Ansfield
b03aa5f255 Added reverse animation to publish/preview modal contents when closing modal
refs 2fb62708a8

- use modal's own `.epm-out` class that's added when closing to trigger the reverse of the fade-in animation
- added `.publish-modal` class to the three publish modals so we can alter the default modal animations/timing if required
2022-05-19 12:19:55 +01:00
Simon Backx
e7a703ee73 Removed commented css code 2022-05-19 13:19:21 +02:00
Simon Backx
195733af2c Fixed icon and button colours in dark mode
refs https://ghost.slack.com/archives/C02G9E68C/p1652957053084759

- Activiy feed filters label colours
- Activiy feed member email address text colour
- . (i) icon when editing newsletters
- colour of edit pencil when editing free tier
- paid tiers 'active' dropdown button colour
2022-05-19 13:15:30 +02:00
Kevin Ansfield
08aa2d91ba Skipped publish flow modal animations when swapping between publish/preview
no issue

- updated the publish/preview toggle action to pass a `skipAnimation` data attribute to the modals when opening if they are being swapped rather than initially opened
2022-05-19 12:02:23 +01:00
Djordje Vlaisavljevic
5d0e3d2536 Fixed icon color in dark mode 2022-05-19 13:01:26 +02:00
Kevin Ansfield
dce531cf1c Standardized on "subscriber" for default & multiple newsletters in publish flow
no issue

- "subscriber" makes more sense than "member" in the default-only newsletter state because members still need to be subscribed to the default newsletter
- removed all subscriber/member conditionals and cleaned up template logic where possible
2022-05-19 11:37:01 +01:00
Sanne de Vries
2fb62708a8 Added fade-in effect when opening publish and preview modals in editor
No ref
2022-05-19 11:58:51 +02:00
Simon Backx
f9cd8b1f66 Removed zero tiers from paid mix charts (unless all zero)
no issue

When the last tier in the paid mix chart is zero, the border radius is broken.
2022-05-19 11:41:54 +02:00
Simon Backx
1ce02660aa Fixed recent posts open rate bars width
refs https://ghost.slack.com/archives/C02G9E68C/p1652951577111489
2022-05-19 11:28:37 +02:00
Kevin Ansfield
0549ffd4b5 Removed unused component argument with typo
no issue

- spotted the typo and thought there was a bug somewhere but post count isn't used in the complete-with-email-error state of the publish flow
2022-05-19 10:25:05 +01:00
Sanne de Vries
e09f41716b Fixed subscriber count not showing for scheduled email-only posts
No ref
2022-05-19 11:23:50 +02:00
Simon Backx
0cddb3ccb9 Fixed archived paid tiers causing dashboard errors 2022-05-19 11:19:28 +02:00
Sanne de Vries
df15dcb8d5 Added confirmation message to email-only post being sent
No ref
2022-05-19 10:54:44 +02:00
Djordje Vlaisavljevic
635dc3ce56 Fixed icon color 2022-05-18 23:31:27 +02:00
Sanne de Vries
435f5189aa Hid "Back to settings" when publish button is running
No ref
2022-05-18 20:56:49 +02:00
Sanne de Vries
8468994014 Added spinner icon to running publish button
No ref
2022-05-18 20:48:36 +02:00
Sanne de Vries
2835d0a6a4 Fixed publish button pulsating when running
No ref
2022-05-18 20:32:10 +02:00
Kevin Ansfield
473831ac2b Added image fallback and site icon/title to <GhPostBookmark> (#2401)
no issue

- adds `{{get-setting "key"}}` helper to make settings available in templates without needing a backing class
- updated `<GhPostBookmark>` component
  - if post feature image isn't present, fall back to site cover image
  - add site icon (if present) and title to the details line
  - removed author image

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
2022-05-18 19:05:27 +01:00
Kevin Ansfield
f2b9fa544f Fixed published post count shown on publish complete step
no issue

- API query was using `?status=published` instead of `?filter=status:published` so was counting all posts rather than just published ones
2022-05-18 18:01:28 +01:00
James Morris
9019ae783c Fixed up the borders for dark mode on Dashboard
refs: https://github.com/TryGhost/Team/issues/1531
2022-05-18 17:06:41 +01:00
Simon Backx
fdece55480 Added auto save to newsletters toggle
refs https://github.com/TryGhost/Team/issues/1639

- When enabling/disabling newsletters, the change is saved automatically
2022-05-18 17:26:03 +02:00
Rishabh Garg
1dc3026aba Fixed subscribe count on adding new newsletter (#2402)
refs https://github.com/TryGhost/Team/issues/1634

- member count on newsletter may not be immediately updated on saving newsletter
- api returns `opted_in_member_count` in response to adding newsletter which admin cannot use atm
- re-fetches newsletters on save so all newsletters get updated member and post counts
2022-05-18 20:44:42 +05:30
Simon Backx
857a8e5ae0 Added tests for unsaved newsletter changes
refs https://github.com/TryGhost/Team/issues/1477
2022-05-18 15:57:02 +02:00
Sanne de Vries
02a3f4d784 Changed running and success copy for publish button when scheduled
No ref
2022-05-18 15:14:43 +02:00
Simon Backx
d87aef7e0a Removed some multipleNewslettersUI feature checks 2022-05-18 15:00:29 +02:00
Kevin Ansfield
6c960704b9 Hid total member counts in newsletter selection for authors/editors
no issue

- authors/editors don't yet have a way to fetch member counts for specific filters so the final member count is hidden in the publish options text, however we were still showing the total subscribed members for each newsletter in the dropdown which could lead to incorrect assumptions for how many members would receive the newsletter
2022-05-18 13:58:25 +01:00
Simon Backx
6ba9f6a3be Fixed tiers without members not shown in paid mix chart 2022-05-18 14:17:59 +02:00
Simon Backx
59a1b8a31f Added tests for editing newsletters
refs https://github.com/TryGhost/Team/issues/1477

- Added default test fixture
- Added tests for validation of newsletter when editing
- Added tests for opening and closing tabs
2022-05-18 13:14:38 +02:00
Kevin Ansfield
93c9035c49 Fixed "memberssubscribers" text in editor status for scheduled posts
refs d11cf9e1c7

- "free subscribers" worked but "paid" and "all" states still had "members" in the fixed string along with the new "members/subscribers" plural variable resulting in text like "all memberssusbcribers of My Newsletter"
2022-05-18 10:55:31 +01:00
Kevin Ansfield
a6dcd936bc Hooked up "revert to draft" button on complete step after scheduling
refs a19d5c7df3

- added handling of the `afterTask` return value provided when closing the publish flow modal via the revert-to-draft button
2022-05-18 10:49:08 +01:00