TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-28 21:33:24 +03:00
Code Issues Projects Releases Wiki Activity
31,728 Commits 250 Branches 1,686 Tags 400 MiB
498bec08cf
Commit Graph

5520 Commits

Author SHA1 Message Date
Djordje Vlaisavljevic
37dd97b5c5 Updated default mock state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-06 22:26:54 +02:00
Ozan Uslan
220af3b276
🐛 Fixed timezone issue with min/max dates in datetime picker 
fixes #15497

`'now'` option for min/max date used `moment()` function and did not consider the timezone of the site.
 2022-10-06 20:09:36 +02:00
Kevin Ansfield
fc5f0f7c79 Refactored stripe settings form component with Octane patterns 
refs https://github.com/TryGhost/Ghost/issues/14101

- migrated to native class syntax and Glimmer component patterns
 2022-10-06 16:22:32 +01:00
Kevin Ansfield
c2d8950bd5 Moved and renamed stripe settings form component 
no issue

- moved screen-specific component into the `settings/members` folder
- renamed to better reflect the component's purpose
 2022-10-06 16:22:32 +01:00
James Morris
4e3380190b Improving the member filters 
- Closes dropdown when removing labels
- Larger width to handle multiple labels better
- Subtle focuses when using tabs only
- Bigger close button hitpoints on labels
- Added text ellipis for larger labels in dropdown
- Added some event propagation stops

no issue
 2022-10-06 12:21:55 +01:00
Sanne de Vries
a2bfdc7534 Updated error status in post list and the editor 
Refs https://github.com/TryGhost/Team/issues/2009
 2022-10-06 17:37:08 +07:00
Sanne de Vries
08da18e324 Fixed breadcrumbs responsive issues 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- New breadcrumb style broke posts list on smaller screens
- Updated copy to reflect the action taken on the page (e.g. Edit tag)
 2022-10-06 16:25:57 +07:00
Simon Backx
aaabf4b103
🎨 Improved email failure handling and retrying (#15504) 
fixes https://github.com/TryGhost/Team/issues/2009

- When an email is sent, but it failed there was no way to retry once you left the retry screen
- There was no indication that the email failed to send in the post list and editor
 2022-10-06 11:12:11 +02:00
Djordje Vlaisavljevic
94aaa168cd Added disabled state with CTA for Zapier integration 
refs https://github.com/TryGhost/Team/issues/1157
 2022-10-05 15:36:52 +02:00
Kevin Ansfield
524b23c182
Migrated staff user screen to Ember Octane patterns (#15532) 
refs https://github.com/TryGhost/Ghost/issues/14101

- migrated staff user controller to native class syntax
- removed use of `{{action}}` helper
- moved from custom components to native `<input>` and `<textarea>` for form fields
  - added `{{select-on-click}}` modifier to cover the `<GhTextingInput @selectOnClick>` option behaviour for any input element
- added `submitForm()` test helper that finds closest `form` element and trigger's a `submit` event on it simulating <kbd>Enter</kbd> being pressed whilst a field has focus
 2022-10-05 12:05:31 +01:00
Sanne de Vries
b7fd0c04b6 Updated tag and history breadcrumbs 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Updated the copy to follow the common breadcrumb pattern
 2022-10-05 12:40:51 +07:00
Kevin Ansfield
e0430b4efc 🐛 Fixed ctrl/cmd+s not saving focused fields on general/staff settings screens 
no issue

- swapped from route actions triggered by shortcuts mixin to explicit `{{on-key}}` actions
- when saved via keyboard, blur any focused element to trigger it's on-blur action and schedule the save to run after those actions
 2022-10-04 17:55:24 +01:00
Kevin Ansfield
c77c150745 Refactored facebook/twitter URL inputs 
refs https://github.com/TryGhost/Ghost/issues/14101

Twitter/facebook URL validation doesn't follow our typical validation and was duplicated across multiple screens making the controllers unnecessarily complex.

- extracted url input fields and their validation into separate components
- uses tracked scratch values so that the input field values can reset to the saved value on save
  - twitter/facebook URL inputs are different to our other inputs because invalid values won't prevent saving, instead they are reset to their previous value on save
- added `this.validate()` call after a successful save in `settings` service so the service and underlying model validations are both in sync (fixes validation error sticking around after saving with invalid twitter/facebook values that have been reset)
 2022-10-04 17:55:24 +01:00
Djordje Vlaisavljevic
b15451dfa6 Deemphasized unavailable sources and added an explainer 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-04 13:29:25 +02:00
Kevin Ansfield
d8193da005 Revert "Fixed errors thrown from blank twitter/facebook URL fields" 
This reverts commit a523fedccb.

- caused input value to be cleared on focus+blur with no changes
- reverting in favor of an incoming refactor
 2022-10-04 10:30:13 +01:00
Kevin Ansfield
a523fedccb Fixed errors thrown from blank twitter/facebook URL fields 
no issue

- reset logic was incorrect meaning that if you focused a twitter/facebook URL field then moved to a different field without inputting anything an error would be thrown from trying to use `.match()` on `null`
 2022-10-04 10:09:36 +01:00
Sanne de Vries
0124c2f28a Updated member activity page with new breadcrumb styles 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Filtering on specific member activity now uses new breadcrumb pattern
- Fixed double scrollbar issue on member activity and history page
 2022-10-04 13:51:01 +07:00
Sanne de Vries
2c498ab193 Updated breadcrumb and title style across admin 
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Separating out the breadcrumbs and the title makes it easier to navigate back on multiple levels for nested pages.
- Avoids very long titles, as it doesn't include breadcrumbs anymore
 2022-10-04 12:35:29 +07:00
Rishabh
09fbe19a31 Fixed anchor chart load for site without paid tiers 
refs https://github.com/TryGhost/Team/issues/2019

- the anchor chart keeps showing the loading spinner for a site that has no paid tiers and the source attribution flag switched on.
- this was because it tries to load the the MRR chart by default, which doesn't has any data when paid tiers are disabled.
- updated the chart to use `total members` data when paid tiers is disabled
 2022-10-04 10:34:44 +05:30
Ronald Langeveld
226794e201
🐛 Fixed broken close buttons on modals (#15514) 
* 🐛 Fixed broken `close` button on modals
no issue

Some modals' close elements containing `{{on "click" @close}}` and `href=""` would not take the 'on cl
ick' function into account, meaning the whole page would get redirected to "/" (back to the root of the dashboard) instead of just closing the modal.
 2022-10-04 06:33:49 +04:00
Kevin Ansfield
cd9a50841e Fixed tests 
refs 85cce39af7

- removed out of date transfer owner modal integration test
- fixed missing `?` in optional chaining in `<GhImageUploader>` error handling
 2022-10-03 22:05:02 +01:00
Kevin Ansfield
bdc5984cdc Fixed linter error 
refs 85cce39af7
 2022-10-03 21:20:37 +01:00
Kevin Ansfield
85cce39af7 Refactored staff user modals 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
- cleaned up the `upload-image` modal which had multiple areas of code that were no longer being used
- disabled `no-duplicate-landmark-elements` template lint rule as it's buggy and mostly gives false positives
 2022-10-03 21:15:34 +01:00
Kevin Ansfield
74d66ca9be Renamed incorrect test selectors on limit modals 
no issue

- selectors hadn't been updated when copy/pasting modal contents
 2022-10-03 21:15:34 +01:00
Stephen Sauceda
eb585f9c02
🐛 Fixed active state bug in sidebar nav (#15511) 
closes: https://github.com/TryGhost/Ghost/issues/15506

- The sidebar items that don't open the editor were missing some relative current-when attributes so the nested views weren't considered "active".
 2022-10-03 19:49:21 +01:00
Djordje Vlaisavljevic
02369ee852 Switched the dash character 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 17:29:07 +02:00
Kevin Ansfield
353cad7ed2 Fixed mirage members route permissions checks 
refs 568e4183e3
refs 258f56ded9

- when in test environment add a `X-Test-User` header to API requests that allows the mirage endpoints to check the logged in user without having to cross boundaries into the application or test contexts
 2022-10-03 14:59:16 +01:00
Rishabh
01249926d5 Refined attribution data on member details page 
refs https://github.com/TryGhost/Team/issues/1986

- hides referrer source on member details page if its `Created manually` as its not useful
 2022-10-03 18:58:48 +05:30
Djordje Vlaisavljevic
c48df76d9b Updated formatting of the signup info 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 14:25:32 +02:00
Djordje Vlaisavljevic
f351064726 Commented out the Learn more link 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 14:20:03 +02:00
Djordje Vlaisavljevic
7fea370faf Fixed all sources modal gradient in dark mode 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 12:24:54 +02:00
Djordje Vlaisavljevic
ee40c92758 Updated cursor for disabled dropdown 
refs https://github.com/TryGhost/Team/issues/1986
 2022-10-03 11:42:50 +02:00
Rishabh
e57502e02f Handled empty attribution section on member detail page 
refs https://github.com/TryGhost/Team/issues/1986

- hides attribution section if there is no source and page/post attribution
 2022-10-03 14:58:14 +05:30
Rishabh
6dc5f7ebb0 Added empty state mock option for attribution data 
- allows mimicking empty state on dashboard for attribution data
 2022-10-03 14:56:37 +05:30
Peter Zimon
349ef4926c Update engagement copy in Post Analytics 
closes https://github.com/TryGhost/Team/issues/2016

- the absolute value and percentage for Opened and Clicked metrics in the engagement section of the post analytics page were inconsistent
 2022-10-03 08:42:19 +02:00
Rishabh
30efab8401 Fixed lint 2022-09-30 09:38:15 +05:30
Rishabh
579ca615f9 Refined member attribution wording 2022-09-30 01:27:26 +05:30
Djordje Vlaisavljevic
198e43daec Updated disabled state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 20:49:53 +02:00
Djordje Vlaisavljevic
fb2f0b3d3b Updated the all sources modal grid 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 20:33:00 +02:00
Rishabh
fa2292806a Refined all sources list on dashboard 
refs https://github.com/orgs/TryGhost/projects/77

- shows single selected column on the all referrer sources list in dashboard
 2022-09-29 23:47:43 +05:30
Rishabh
5eae093b3c Cleaned up attribution widget on analytics page 
- updates attribution widget on analytics page to work same as dashboard with data
 2022-09-29 23:33:17 +05:30
Djordje Vlaisavljevic
40c66dae6a Made the attribution widget show if you don't have paid tiers 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 19:37:09 +02:00
James Morris
8a6f082b14 Moving opened stats in row over if there are no clickes in post rows 
- When there are no clicks, we are moving over the opened stats in it's place
- There shouldn't be too many times these mix so design should be ok

refs https://github.com/TryGhost/Team/issues/2000
 2022-09-29 18:01:01 +01:00
James Morris
fd977479ee Tweaked up the analytics resources sections 
refs https://github.com/TryGhost/Team/issues/1987
 2022-09-29 17:38:50 +01:00
Simon Backx
648811690a ✨ Added email click tracking 
no issue

Bumped flag to GA.
 2022-09-29 18:14:15 +02:00
Simon Backx
58cabc68ec Fixed analytics button not working 
no issue
 2022-09-29 17:43:06 +02:00
James Morris
c44e7d1536 Improving the newsletter clicks table in post analytics 
refs https://github.com/TryGhost/Team/issues/1984
 2022-09-29 16:15:27 +01:00
Djordje Vlaisavljevic
aea7820487 Renamed files 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:45:56 +02:00
Simon Backx
0cd0fc838d
Added email track clicks column and cleaned up frontend checks (#15501) 
fixes https://github.com/TryGhost/Team/issues/2008

- New column that stores email click tracking at the time it was created
- Improved frontend side checks for when to show analytics
 2022-09-29 16:42:45 +02:00
Djordje Vlaisavljevic
22a75ba144 Updated dashboard mocks 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:23:50 +02:00
Djordje Vlaisavljevic
d2d34b1418 Updated all sources modal width 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:23:01 +02:00
Djordje Vlaisavljevic
d811bd512f Fixed modal footer 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:20:21 +02:00
Djordje Vlaisavljevic
9fa48613de Updated hover state for the anchor dropdown 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 16:14:58 +02:00
James Morris
9e51ba0c31 Removed the button labels from the post rows 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-29 15:07:37 +01:00
Djordje Vlaisavljevic
3fe51c8e9a Set max height for All sources modal 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 15:59:12 +02:00
James Morris
a9308e6394 Adding in new code to bring source attribution more in line 
refs https://github.com/TryGhost/Team/issues/2001
 2022-09-29 14:52:36 +01:00
Simon Backx
1a5ff8d53d
Added back button from editor to analytics (#15493) 
fixes https://github.com/TryGhost/Team/issues/1992

When you edit a post via the editor, the back button on the top of the editor should go back to the analytics page and the status at the top should be removed.
 2022-09-29 14:34:01 +02:00
Simon Backx
0c20950512 Cleaned up indentation in links-table.hbs 2022-09-29 13:05:55 +02:00
Simon Backx
061ae9c018 Added pagination to the links table on analytics page 
refs https://github.com/TryGhost/Team/issues/1984
 2022-09-29 13:02:49 +02:00
Simon Backx
99e6f8ddda Moved analytics page to separate component 
refs https://github.com/TryGhost/Team/issues/1976
refs https://ghost.slack.com/archives/C02G9E68C/p1664446234131629

- @tracked properties in controllers are persisted, should use components instead
 2022-09-29 12:41:16 +02:00
James Morris
9be863cc82 Tiny tweaks to styles for post analytics 
- Made the source attribution table half and half
- Adjust the button hover for post rows

no issue
 2022-09-29 11:06:29 +01:00
Djordje Vlaisavljevic
0d6946685e Updated design for multiple subs in sub box edge case 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 10:22:59 +02:00
Djordje Vlaisavljevic
d1c269b2e7 Updated the tooltip offset 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 09:25:59 +02:00
Rishabh
aa6f65ac22 Fixed disabled attribution category selector dropdown 
- removes hardcoded disable on attribution category selector and uses calculated value instead
 2022-09-29 12:17:45 +05:30
Rishabh
b3adaf26c5 Handled attribution table empty data on dashboard 
- updates default dropdown based on availability of paid conversions or signups
- disables dropdown if data is missing for type of attribution
 2022-09-29 11:17:02 +05:30
Rishabh
7e68bc172a Added empty state UI for attribution charts on dashboard 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-29 11:17:02 +05:30
Rishabh
f9215cbbe4 Refined attribution table unavailable source style 
- updates legend color for Unavailable to match Others as a white transparent dot
 2022-09-29 11:17:02 +05:30
James Morris
5299905851 Added in the static front-end of the pagination 
refs https://github.com/TryGhost/Team/issues/1984
 2022-09-28 18:18:45 +01:00
James Morris
4cf5380724 Added in member filtering to rest of stats in analytics 
- This adds member filtering for signups and conversions in analytics
- This also makes all events in rows clickable

refs https://github.com/TryGhost/Team/issues/1969
 2022-09-28 17:10:15 +01:00
Djordje Vlaisavljevic
901708b299 Updated design of Other sources field 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 17:25:51 +02:00
Djordje Vlaisavljevic
e843df75b4 Added commented out footnote 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 17:25:51 +02:00
Simon Backx
b905085d6f
Added opened, clicked and received email filtering to members (#15492) 
fixes https://github.com/TryGhost/Team/issues/1993

- Allows filtering members by opened, clicked and received email
- Adds clicked_links filter relation to Member model.
- Adds emails filter relation to Member model.
- Adds opened_emails filter expansion to Member model.
- Updated GhResourceSelect to be able to only show list posts by setting the `type` attribute to `email`.
- Improved code reuse in `filter-value` component.
 2022-09-28 17:14:32 +02:00
James Morris
59b5cd59b2 Better matching posts and pages and fixing when no members 
refs https://github.com/TryGhost/Team/issues/1995
 2022-09-28 15:56:22 +01:00
Djordje Vlaisavljevic
584546cf1d Updated other sources button 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 16:47:29 +02:00
Djordje Vlaisavljevic
52af7c687d Added attribution help docs link placeholder 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 16:31:52 +02:00
Rishabh
f2430c34cc Updated attribution chart on post analytics page 
refs https://github.com/TryGhost/Team/issues/1986

- added dropdown for paid vs signups selection on attribution chart
 2022-09-28 19:50:29 +05:30
Simon Backx
1caa8f5b9a Hidden analytics page button for published post when attribution is disabled 
fixes https://github.com/TryGhost/Team/issues/1998

- Should not show analytics button when post is not sent via email and attribution is disabled
- Improved checks for the analytics button
 2022-09-28 16:15:03 +02:00
James Morris
dc9ef69547 Better matching up the pages table with the posts table 
refs https://github.com/TryGhost/Team/issues/1995
 2022-09-28 14:17:12 +01:00
James Morris
cd97341ed6 Fixed up the edit and stats buttons based on feedback 
refs https://github.com/TryGhost/Team/issues/1994
 2022-09-28 13:44:58 +01:00
Djordje Vlaisavljevic
b72b51b542 Made the attribution widget look better on smaller screens 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 14:20:40 +02:00
Rishabh
d63f4548c0 Removed attribution sources from UI if site is invite-only 
refs https://github.com/TryGhost/Team/issues/1986

- removes attribution section from dashboard and post analytics if site is invite only
 2022-09-28 17:26:38 +05:30
Rishabh
8c225ee9d0 Fixed lint 
- updates `index` for susbcription detail box
 2022-09-28 17:22:24 +05:30
Djordje Vlaisavljevic
9209a39c29 Added new attribution widget design 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 13:44:28 +02:00
Rishabh
79248cdde9 Fixed dropdown blink for subscription detail box 
refs https://github.com/TryGhost/Team/issues/1986

- creates new component for subscription detail box that avoids re-render of whole block causing flicker
 2022-09-28 17:08:28 +05:30
Rishabh
cf1f41d61c Updated attribution table design to show single column data 
- adds new dropdown that allows switching between signups vs paid conversions
- updates chart data based on dropdown value, keeps the sort column till the design for this is polished
 2022-09-28 16:27:44 +05:30
James Morris
994f0eea64 Tiny padding adjustment for boxes 
refs https://github.com/TryGhost/Team/issues/1968
 2022-09-28 11:11:15 +01:00
Rishabh
8b2db5c017 Refined attribution table on dashboard for list of sources 
- updates table to always show top 5 sources, including the empty sources
- only adds `Other` to list on table if more than 5 sources exist
- updates mock to include `Unavailable` data
 2022-09-28 15:31:41 +05:30
Simon Backx
160469d787 Improved analytics page loading states 
refs https://github.com/TryGhost/Team/issues/1976

- Wait to show any module until everything has been loaded
 2022-09-28 11:58:51 +02:00
Djordje Vlaisavljevic
49a922fbd5 Updated attribution widget empty state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-28 11:05:28 +02:00
Simon Backx
03bfe2504e Fixed ref instead of rel when stripping querystring from tracked url 
no issue
 2022-09-28 11:03:00 +02:00
Simon Backx
e0965a6262 Readded hash to cleaned tracked links in admin 
fixes https://github.com/TryGhost/Team/issues/1980
 2022-09-28 10:31:18 +02:00
Sanne de Vries
08656ea569 Updated lexical sandbox page structure 
Refs https://github.com/TryGhost/Team/issues/1991
 2022-09-28 11:06:32 +07:00
Djordje Vlaisavljevic
2c2fd20a17 Removed inline styles 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 21:36:59 +02:00
Djordje Vlaisavljevic
ca7937d100 Removed inline styles 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 21:36:59 +02:00
Djordje Vlaisavljevic
b64e7b6da0 Fixed dashboard dark mode issues 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 20:47:10 +02:00
Djordje Vlaisavljevic
8a3c696f9d Fixed subscription box dark mode issues 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 20:34:59 +02:00
James Morris
81605f7f2a Added a basic loading state to modules in post analytics 
refs https://github.com/TryGhost/Team/issues/1956
 2022-09-27 18:02:20 +01:00
James Morris
c266971e04 Fixed the broken source attributiont table design in post analytics 
refs https://github.com/TryGhost/Team/issues/1959
 2022-09-27 18:02:20 +01:00
Rishabh
2be3452c76 Refined attribution data on member details screen 
refs https://github.com/TryGhost/Team/issues/1986

- hides attribution section if attribution data is null
- hides referrer section if referrer source is empty
 2022-09-27 21:59:42 +05:30
Djordje Vlaisavljevic
f3f6e87378 Updated chart container size 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
535624d511 Updated chart size 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
cb25817581 Fixed chart title 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
94009a2612 Removed old empty state 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Djordje Vlaisavljevic
cbd76f3437 Updated dot color 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 16:52:21 +02:00
Kevin Ansfield
a67cb265fc 🐛 Fixed error preventing publish for non-Admin staff users 
refs e3db911108

Contributors/Authors/Editors do not have permissions to fetch members so the request to fetch a member count when checking member host limits fails and blocked publishing because it was treated like a failed limit check.

- prevented the up-front limit check from running for non-Admin staff users. Publishing will still fail for other users if the site is over the hosting plan members limit but the error will be shown later in the flow when the actual publish request is made.
 2022-09-27 13:19:02 +01:00
Kevin Ansfield
e2d02131aa Added lexical editor design sandbox route 
closes https://github.com/TryGhost/Team/issues/1985

- adds `/#/lexicalsandbox` route that renders the `<DesignSandbox />` component from the `@tryghost/koenig-lexical` library
 2022-09-27 13:00:16 +01:00
Djordje Vlaisavljevic
a6bf772195 Added dynamic border color 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
45b3772ddc Made the dashes lighter 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
3960384a25 Removed fixed height from the table body 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
970eef761c Removed dots from modal sources table 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
49786c8ca4 Made the modal wider 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
Djordje Vlaisavljevic
baede872ea Updated the copy 
refs https://github.com/TryGhost/Team/issues/1986
 2022-09-27 13:54:27 +02:00
James Morris
ec9e61dc2f Tweaks to how click events are handled based on feedback 
refs https://github.com/TryGhost/Team/issues/1981
 2022-09-27 12:29:08 +01:00
Djordje Vlaisavljevic
e98dda15f9 Removed subscription source when it's unknown 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-27 11:32:31 +02:00
Djordje Vlaisavljevic
4858baf2df Added doughnut chart titles 
refs https://github.com/TryGhost/Team/issues/1905
 2022-09-27 10:55:27 +02:00
Djordje Vlaisavljevic
87ad7d1df3 Updated font weight for source 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-27 10:51:51 +02:00
Djordje Vlaisavljevic
83f88e1586 Added pointer cursor to column names 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-27 10:02:27 +02:00
Djordje Vlaisavljevic
5d5fc33d2c Updated MRR widget design 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-27 09:53:41 +02:00
Sanne de Vries
ac7d7427e9 Fixed padding on member-limit notification box on publish page 
Refs https://github.com/TryGhost/Team/issues/1885
 2022-09-27 11:27:58 +07:00
Daniel Lockyer
9818634b63
Merged v5.16.1 into main 
v5.16.1
 2022-09-27 11:21:48 +07:00
Rishabh Garg
b1b3c72642
Added sorting for attribution data on dashboard (#15474) 
refs https://github.com/TryGhost/Team/issues/1941

- sorts attribution table and chart on signups or paid conversions
 2022-09-26 23:29:30 +05:30
James Morris
83e608c25b Changed link clicks to newsletter links for analytics page 
refs https://github.com/TryGhost/Team/issues/1968
 2022-09-26 18:12:06 +01:00
James Morris
8bef3b9e34 The new post list rows match the edit or analytics button 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 18:09:52 +01:00
Kevin Ansfield
e3db911108
🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473) 
closes https://github.com/TryGhost/Team/issues/1885

- adds limit check for members to the `PublishOptions` class when it's constructed to set a `publishDisabledError` property if the limit check fails
  - if `publishOptions.publishDisabledCheck` is present, all publish options in the publish flow are disabled, the underlying error message is shown, and the continue button is removed to prevent filling in everything only to find at the end of the process that publishing fails
- added handling for a `HostLimitError` error from the API when confirming publishing so the proper underlying message is displayed instead of the confusing "Host limit error, cannot edit post" error
  - this is a backup measure for any instances where you're under the max members limit when starting the publish flow but are over the limit when you reach the end of the publish flow
 2022-09-26 17:37:35 +01:00
James Morris
ad2cb3ae11 Lots of visual tweaks to the post list table 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 17:30:39 +01:00
Djordje Vlaisavljevic
ac661c19b7 Updated copy 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-26 17:26:01 +02:00
Djordje Vlaisavljevic
74873c7e48 Updated the heading text 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:25:27 +02:00
Djordje Vlaisavljevic
3a9143cacc Removed the medium info from the subscription box 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:20:14 +02:00
Djordje Vlaisavljevic
f9ce3239ee Updated the heading text 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:19:12 +02:00
Djordje Vlaisavljevic
bb0b9c4261 Added rotation to the details toggle arrow 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 17:12:56 +02:00
Djordje Vlaisavljevic
bdc43d8f66 Updated table design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 17:12:25 +02:00
Djordje Vlaisavljevic
752cf1a607 Added static sort indicator to the table 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 15:53:26 +02:00
Djordje Vlaisavljevic
64d4ddbaca Updated logic for showing member profile attribution 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-26 15:52:39 +02:00
Djordje Vlaisavljevic
81e15f823b Updated logic for showing member profile attribution 
refs https://github.com/TryGhost/Team/issues/1953
 2022-09-26 15:44:53 +02:00
Djordje Vlaisavljevic
6461e814db Updated font weight 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 15:32:18 +02:00
Djordje Vlaisavljevic
d024bd60fc Updated attribution widget design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 15:30:20 +02:00
Simon Backx
281cd2e7a3
Renamed count.conversions to count.paid_conversions in posts (#15460) 
fixes https://github.com/TryGhost/Team/issues/1943
 2022-09-26 14:25:27 +02:00
Djordje Vlaisavljevic
acd1de3983 Removed chart border on hover 
refs https://github.com/TryGhost/Team/issues/1905
 2022-09-26 13:38:56 +02:00
James Morris
97af5c3731 Added a small tweak to the percentages on post list 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 12:30:54 +01:00
James Morris
7e780681d9 Looking to improve the post list rows again for email clicks 
refs https://github.com/TryGhost/Team/issues/1965
 2022-09-26 12:30:54 +01:00
James Morris
c92267c900 Realignement of the post list items for email clicks 
no issue
 2022-09-26 12:30:54 +01:00
Djordje Vlaisavljevic
ceadb2634f Updated MRR widget design 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-26 13:21:05 +02:00
Djordje Vlaisavljevic
4941627128 Added show/hide behaviour to subscription box details 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 13:20:31 +02:00
Djordje Vlaisavljevic
b9c7fe316b Updated attribution widget design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 12:14:06 +02:00
Rishabh
190031f38c Added modal for showing all attribution sources 
refs https://github.com/TryGhost/Team/issues/1941

- limits the source attribution list to top 5 on dashboard, and shows all sources on clicking on `Other` link

Fixed lint
 2022-09-26 10:43:05 +05:30
Rishabh
baaf64405a Refined details toggle on member subscription box 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Rishabh
f4e6f00077 Refined attribution chart to show custom tooltips 
refs https://github.com/TryGhost/Team/issues/1905
 2022-09-26 10:43:05 +05:30
Rishabh
e76f082884 Moved mrr data to dashboard anchor chart 
refs https://github.com/TryGhost/Team/issues/1932

- moves MRR data to main dashboard anchor chart behind source attribution flag
 2022-09-26 10:43:05 +05:30
Rishabh
6137f9d3d5 Refined attribution chart legends to match table 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 10:43:05 +05:30
Rishabh
ec5f09edeb Refined member subscription detail box design 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
50100a7c8d Capitalized subscription page 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
bdce8f21cc Updated font weights 
refs https://github.com/TryGhost/Team/issues/1904
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
4a8c9a530b Updated embedded MRR metric design 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
0be2191726 Updated attribution dashboard widget design 
refs https://github.com/TryGhost/Team/issues/1941

Updated attribution dashboard widget design

refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
7c23e721f1 Updated attribution sources table design 
refs https://github.com/TryGhost/Team/issues/1941
 2022-09-26 10:43:05 +05:30
Djordje Vlaisavljevic
5785f2b9bd Reorganized dashboard layout 
refs https://github.com/TryGhost/Team/issues/1932
 2022-09-26 10:43:05 +05:30
Sanne de Vries
663b9ffe02 Updated post list stats 
Refs https://github.com/TryGhost/Team/issues/1895
 2022-09-26 10:39:37 +07:00
Kevin Ansfield
508119244c
Switched delete snippet modal to new modal pattern (#15468) 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-25 10:54:07 +01:00
Kevin Ansfield
ac67475605
Switched delete member modal to new modal pattern (#15467) 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-24 18:18:34 +02:00
Kevin Ansfield
63b1e4e8ad
Resolved power-select related deprecation warnings for loading components by string (#15466) 
no issue

- in many places we were passing a string as an argument to a `<PowerSelect>` related component that referred to a component name, that was throwing deprecation warnings because those strings were used dynamically with `{{component}}` later on which isn't statically analyzable
- switched to passing a component explicitly with `{{component}}`
- https://github.com/embroider-build/embroider/blob/main/REPLACING-COMPONENT-HELPER.md#when-youre-passing-a-component-to-someone-else
 2022-09-24 17:00:05 +02:00
renovate[bot]
65a74f41c8
Update dependency ember-power-select to v4.1.7 (#15157) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
 2022-09-24 15:08:42 +02:00
Rishabh
e5fb7b805f Wired referrer information on member detail page 
refs https://github.com/TryGhost/Ghost/pull/15463
 2022-09-24 17:46:57 +05:30
Kevin Ansfield
a934481f45 Fixed @sentry/browser imports 
no issue

- needed for embroider compatibility
- the package we have installed is `@sentry/ember` not `@sentry/browser` so the imports fail when built by webpack
 2022-09-24 13:28:35 +02:00
Kevin Ansfield
bfd7ace721 Fixed invalid shortcuts imports 
no issue

- `utils/shortcuts.js` does not have a default export but we were using it as if it did, this isn't valid and breaks when transpiled via webpack via embroider
- switched to the valid `import * as shortcuts` import syntax
 2022-09-24 13:28:30 +02:00
Kevin Ansfield
fa84808048 Dropped ember-cli-moment-shim dependency 
no issue

Since `ember-moment@10.0` it's not been necessary to use the `ember-cli-moment-shim` package, with `moment` instead being usable directly via `ember-auto-import`. Getting rid of the shim package is necessary for compatibility with `embroider`, Ember's new build tooling.

- dropped `ember-cli-moment-shim` dependency
- added `moment-timezone` dependency and updated all imports to reflect the different package
- worked around `ember-power-calendar` having `ember-cli-moment-shim` as a sub-dependency
  - added empty in-repo-addon `ember-power-calendar-moment` to avoid `ember-power-calendar` complaining about a missing package
  - added `ember-power-calendar-utils` in-repo-addon that is a copy of `ember-power-calendar-moment` but without the build-time renaming of the tree for better compatibility with embroider
 2022-09-24 13:28:23 +02:00
Kevin Ansfield
9bbafc3ccf Deleted unused files 
no issue

- files were left over from earlier development and not being used anywhere
 2022-09-24 13:27:54 +02:00
Simon Backx
bba6a4dc84 Fixed cleaned URLs in link table on analytics page 
fixes https://github.com/TryGhost/Team/issues/1963
 2022-09-23 17:42:51 +02:00
James Morris
87a242bada Removed the full width for posts with the member attribution flag 
- Full width was  part of the member attribution flag
- It's messing with email clicks flag
- Removing for both to make things easier

refs https://github.com/TryGhost/Team/issues/1960
 2022-09-23 16:19:35 +01:00
James Morris
6c527cfe78 Made the margins event between elements in the new post rows 
refs https://github.com/TryGhost/Team/issues/1957
 2022-09-23 15:55:20 +01:00
James Morris
80eaa567b5 Added target blank to links in the link table on post analytics 
refs https://github.com/TryGhost/Team/issues/1955
 2022-09-23 15:23:59 +01:00
James Morris
eb7547ea3c Added a new click icon for the member attribution flag 
- Adds a new SVG icon when the members attribution flag is on only
- Fixes up some dark mode issues for the URL scrollable in events

refs https://github.com/TryGhost/Team/issues/1951
 2022-09-22 18:00:48 +01:00
James Morris
729935eca7 Tidied up the page a bit more with the source attribution included 
- Has the source attribution chart and table with some basic styles
- Added in a edit button to the analytics page

refs https://github.com/TryGhost/Team/issues/1920
 2022-09-22 17:20:15 +01:00
James Morris
0541dbc79b Moved the empty links into it's own box in the post analytics page 
- Not ideal, yet, but this is better than what it was before
- Now links empty state is inside it's box rather than just plain text

refs https://github.com/TryGhost/Team/issues/1920
 2022-09-22 17:18:51 +01:00
Djordje Vlaisavljevic
a0c6fafba1
Refined source attribution dashboard design (#15457) 
refs https://github.com/TryGhost/Team/issues/1932
refs https://github.com/TryGhost/Team/issues/1941
refs https://github.com/TryGhost/Team/issues/1904
refs https://github.com/TryGhost/Team/issues/1932

- updates attribution sources table design
- updates member profile page design
 2022-09-22 21:46:42 +05:30
Rishabh
e93f6071cd Handled null sources for attribution chart and table 
refs https://github.com/TryGhost/Team/issues/1932

- removes null sources from attribution chart
- moves null sources count to bottom of attribution table
 2022-09-22 21:04:46 +05:30
Simon Backx
7581b8726e Added basic post table and analytics page conditionals 
refs https://github.com/TryGhost/Team/issues/1947
 2022-09-22 15:40:37 +02:00
James Morris
99332dae21 Added the new URL design for events over in the members activity page too 
- Brought over the new URL events design
- Tested to make sure it worked as expected
- Had to add a new JS component file

refs https://github.com/TryGhost/Team/issues/1922
 2022-09-22 13:44:45 +01:00
Simon Backx
e18ba2bb4d Removed hardcoded subscribers count from list-item-clicks 
fixes https://github.com/TryGhost/Team/issues/1948
 2022-09-22 14:23:06 +02:00
Rishabh
6dbc42bf55 Updated api endpoint for referrer stats in admin 
refs https://github.com/TryGhost/Team/issues/1939
 2022-09-22 17:48:46 +05:30
Simon Backx
2d583cef43 Removed free from analytics page count header 2022-09-22 13:44:51 +02:00
Simon Backx
1ab6ff8ada Renamed free signups to signups on analytics page and source chart 2022-09-22 13:43:46 +02:00
Fabien 'egg' O'Carroll
5fcf5098a8
Added links API (#15446) 
closes https://github.com/TryGhost/Team/issues/1927

This expose the /links endpoint on the Admin API, which is filterable by Post ID.

Co-authored-by: Simon Backx <simon@ghost.org>
 2022-09-22 13:39:52 +02:00
James Morris
433842b2f2 Fixed up the post analytics page so it didn't break at narrower viewports 
- Some layout problems at narrower viewports
- Followed dashboard convention with stacking metrics when narrow
- Stacking resources too

refs https://github.com/TryGhost/Team/issues/1937
 2022-09-22 12:24:28 +01:00
Rishabh Garg
98fc808e6e
Wired referrers API data to admin dashboard (#15454) 
closes https://github.com/TryGhost/Team/issues/1939

- adds real source data counts to attribution table and chart on dashboard
 2022-09-22 16:51:41 +05:30
Daniel Lockyer
c4c39fe3c4
Added pipe into History log date formatting 
- this should help with readability when scanning the list
 2022-09-21 19:57:39 +01:00
Simon Backx
7cadaa6378 Implemented referrers stats API on posts' analytics page 
refs https://github.com/TryGhost/Team/issues/1921
 2022-09-21 18:20:03 +02:00
James Morris
16acdad985 Improved the post table at narrower viewports 
- Fixed up the broken table for Email Clicks flag
- Double checked other flags and when flag is off and fixed those
- Tested to smallest width

refs https://github.com/TryGhost/Team/issues/1937
 2022-09-21 15:20:11 +01:00
James Morris
fe46bd05fb Added in email clicks icon and better handling of URLs 
- Now has a new email click icon
- Handles long URLs better in the events list
- Fixed narrow viewports bug with events

refs https://github.com/TryGhost/Team/issues/1936
 2022-09-21 14:05:37 +01:00
Simon Backx
ad79d45926 Added source attribution table to posts' analytics page 
refs https://github.com/TryGhost/Team/issues/1921
 2022-09-21 15:01:31 +02:00
Simon Backx
cd4e4d7003 Added format option to gh-format-post-time helper 
fixes https://github.com/TryGhost/Team/issues/1940

The passed format was not used by the helper. This is fixed now.
 2022-09-21 12:15:53 +02:00
Simon Backx
383edc293f Added protection for missing count in clickRate 
refs https://ghost.slack.com/archives/C02G9E68C/p1663751415397159?thread_ts=1663748981.221509&cid=C02G9E68C
 2022-09-21 11:11:06 +02:00
Simon Backx
b8041f0a60
Added clicks to activity feed (#15439) 
closes https://github.com/TryGhost/Team/issues/1933

- Added click_events to activity feed
- Added support for parsing click_events in the frontend
- Moved url parsing (transform ready) to model layer of LinkRedirect
- Moved `getEventTimeline` method to the top of the event repository
- Added description field to parsed events in the frontend (because we need a second line)
- Fixed: member email not returned in comment_event
 2022-09-21 10:25:51 +02:00
Hannah Wolfe
f31a50270d Removed search labs flag 
- the search helper was promoted to GA and we no longer need the feature flag
 2022-09-20 15:22:06 +01:00
Simon Backx
ae6761c08b Updated filledSubscriptionCountStats implementation in dashboard stats 
refs https://ghost.slack.com/archives/C02G9E68C/p1663674928386639
 2022-09-20 15:06:09 +02:00
Simon Backx
1a0f366cf8 Fixed linting errors 
refs fe0071496c
 2022-09-20 15:05:54 +02:00
Simon Backx
fe0071496c Added real count data to analytics page 
closes https://github.com/TryGhost/Team/issues/1934
 2022-09-20 14:53:50 +02:00
Rishabh Garg
41bf5f1530
Fixed empty paid subscriptions chart for fake data (#15440) 
- the paid subscribers chart was empty when using with fake data due to missing values of `signups` and `cancellations`
 2022-09-20 17:36:31 +05:30
Simon Backx
63103c2251
Added click counts to posts admin API (#15435) 
closes https://github.com/TryGhost/Team/issues/1928
 2022-09-20 10:05:41 +02:00
Sanne de Vries
b2d449fecf Added Lexical indicator to post list 
Closes https://github.com/TryGhost/Team/issues/1926
 2022-09-19 15:40:19 +01:00
Sanne de Vries
242850b7da Added external link to lexical indicator pointing to koenig-lexical repo 
Refs https://github.com/TryGhost/Team/issues/1926
 2022-09-19 14:55:00 +01:00