Fabien 'egg' O'Carroll
50e99e013c
Added migrations to drop and recreate the suppressions table ( #16070 )
...
There are currently two issues with the suppressions table:
- We have some incorrect rows
- We have missing UNIQUE constraints
We want to completely wipe the tables and start fresh, as well as make
sure that the UNIQUE constraints are added, so we drop the table
completely, and then re-add it, which should result in an empty
suppressions table with all expected constraints.
We've also renamed the `email_address` column to `email` to match our
`users` & `members` tables
2023-01-04 17:26:57 +07:00
Simon Backx
819d0d884c
Improved email verification required checks ( #16060 )
...
fixes https://github.com/TryGhost/Team/issues/2366
refs https://ghost.slack.com/archives/C02G9E68C/p1670232405014209
Probem described in issue.
In the old MEGA flow:
- The `email_verification_required` check is now repeated inside the job
In the new email service flow:
- The `email_verification_required` is now checked (didn't happen
before)
- When generating the email batch recipients, we only include members
that were created before the email was created. That way it is
impossible to avoid limit checks by inserting new members between
creating an email and sending an email.
- We don't need to repeat the check inside the job because of the above
changes
Improved handling of large imports:
- When checking `email_verification_required`, we now also check if the
import threshold is reached (a new method is introduced in
vertificationTrigger specifically for this usage). If it is, we start
the verification progress. This is required for long running imports
that only check the verification threshold at the very end.
- This change increases the concurrency of fastq to 3 (refs
https://ghost.slack.com/archives/C02G9E68C/p1670232405014209 ). So when
running a long import, it is now possible to send emails without having
to wait for the import. Above change makes sure it is not possible to
get around the verification limits.
Refactoring:
- Removed the need to use `updateVerificationTrigger` by making
thresholds getters instead of fixed variables.
- Improved awaiting of members import job in regression test
2023-01-04 11:22:12 +01:00
renovate[bot]
c9221525bc
Update dependency gscan to v4.35.1
2023-01-04 11:13:01 +01:00
Fabien 'egg' O'Carroll
e78612bb66
Fixed MailgunEmailSuppressionList adding non-5xx failures to the list
...
The MailgunEmailSuppression list was incorrectly adding emails
to the suppression list for permanent failure events which have
an error code outside of the 5xx range.
2023-01-04 17:03:52 +07:00
Kevin Ansfield
ea9c8c03fe
Update dependency ember-template-lint to v5.3.0 ( #16062 )
...
refs https://github.com/TryGhost/Ghost/pull/15550
Pulled out of the rolled up node+ember-js+ember-template rollup linter update PR as it required fairly extensive changes.
- bumped package
- renamed `no-down-event-binding` to `no-pointer-down-event-binding`
- disabled `no-pointer-down-event-binding` rule
- disabled `no-triple-curlies` rule
- ran `yarn lint:hbs --fix`
- updated integration tests to match Octane syntax
- fixed various one-off errors
- updated .lint-todo
2023-01-04 09:39:32 +00:00
Simon Backx
789e2c96c0
🐛 Fixed SingleUseTokens being cleared on boot ( #15999 )
...
fixes https://github.com/TryGhost/Team/issues/1996
**Issue**
Our Magic links are valid for 24 hours. After first usage, the token
lives for a further 10 minutes, so that in the case of email servers or
clients that "visit" links, the token can still be used.
The implementation of the 10 minute window uses setTimeout, meaning if
the process is interrupted, the 10 minute window is ignored completely,
and the token will continue to live for the remainder of it's 24 hour
validity period. To prevent that, the tokens are cleared on boot at the
moment.
**Solution**
To remove the boot clearing logic, we need to make sure the tokens are
only valid for 10 minutes after first use even during restarts.
This commit adds 3 new fields to the SingleUseToken model:
- updated_at: for storing the last time the token was changed/used). Not
really used atm.
- first_used_at: for storing the first time the token was used
- used_count: for storing the number of times the token has been used
Using these fields:
- A token can only be used 3 times
- A token is only valid for 10 minutes after first use, even if the
server restarts in between
- A token is only valid for 24 hours after creation (not changed)
We now also delete expired tokens in a separate job instead of on boot /
in a timeout.
2023-01-04 09:49:39 +01:00
renovate[bot]
497491fbef
Update metascraper to v5.33.3
2023-01-04 01:46:54 +00:00
renovate[bot]
640b4accd6
Update dependency knex-migrator to v5.1.0
2023-01-03 22:35:38 +00:00
Paul Davis
8db947cd24
Trim generated post slug length in Revue importer ( #16065 )
...
refs: 5f90baf6fe
2023-01-03 20:15:32 +00:00
renovate[bot]
1c9ad00d6d
Update dependency bookshelf-relations to v2.5.1
2023-01-03 19:09:30 +00:00
renovate[bot]
854c90f324
Update dependency fastq to v1.15.0
2023-01-03 19:06:34 +00:00
renovate[bot]
f6db0640a6
Update dependency @ember/test-helpers to v2.9.3 ( #16011 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@ember/test-helpers](https://togithub.com/emberjs/ember-test-helpers )
| [`2.8.1` ->
`2.9.3`](https://renovatebot.com/diffs/npm/@ember%2ftest-helpers/2.8.1/2.9.3 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>emberjs/ember-test-helpers</summary>
###
[`v2.9.3`](https://togithub.com/emberjs/ember-test-helpers/releases/tag/v2.9.3 ):
Release 2.9.3
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.2...v2.9.3 )
##### 🐛 Bug Fix
-
[#​1305](https://togithub.com/emberjs/ember-test-helpers/pull/1305 )
\[backport] Avoid unnecessary dependencies on `@glimmer` types
([@​dfreeman](https://togithub.com/dfreeman ))
##### Committers: 1
- Dan Freeman ([@​dfreeman](https://togithub.com/dfreeman ))
###
[`v2.9.2`](https://togithub.com/emberjs/ember-test-helpers/releases/tag/v2.9.2 ):
Release 2.9.2
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.1...v2.9.2 )
##### 🐛 Bug Fix
-
[#​1302](https://togithub.com/emberjs/ember-test-helpers/pull/1302 )
\[backport] Remove the index signature from `TestContext`
([@​chriskrycho](https://togithub.com/chriskrycho ))
- Backporting
[#​1301](https://togithub.com/emberjs/ember-test-helpers/pull/1301 )
Remove the index signature from `TestContext`
([@​dfreeman](https://togithub.com/dfreeman ))
-
[#​1303](https://togithub.com/emberjs/ember-test-helpers/pull/1303 )
`TestContext.resumeTest()` returns `void`, not `Promise<void>`
([@​chriskrycho](https://togithub.com/chriskrycho ))
##### Committers: 1
- Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho ))
- Dan Freeman ([@​dfreeman](https://togithub.com/dfreeman ))
###
[`v2.9.1`](https://togithub.com/emberjs/ember-test-helpers/blob/HEAD/CHANGELOG.md#v291-2022-12-16 )
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.9.0...v2.9.1 )
***Note:** these were all back-ported from master since they could go
out on 2.9. This will be the last 2.9 release unless there are critical
bug fixes here!*
##### 🐛 Bug Fix
- Let ESLint have its way about docstring location
([`a8fac83`](https://togithub.com/emberjs/ember-test-helpers/commit/a8fac83 ))
- DOC: API: add render helper examples
([`f476a20`](https://togithub.com/emberjs/ember-test-helpers/commit/f476a20 ))
- Tweak TS style for indexing multiple types (for getElement)
([`f01ad9f`](https://togithub.com/emberjs/ember-test-helpers/commit/f01ad9f ))
- Use export type for RenderingTestContext
([`2dc5077`](https://togithub.com/emberjs/ember-test-helpers/commit/2dc5077 ))
- Tweak TS style for indexing multiple types
([`3214483`](https://togithub.com/emberjs/ember-test-helpers/commit/3214483 ))
- Address PR feedback
([`5e87a54`](https://togithub.com/emberjs/ember-test-helpers/commit/5e87a54 ))
- DOC: API: add DOM query helper examples
([`83b7f5f`](https://togithub.com/emberjs/ember-test-helpers/commit/83b7f5f ))
- Export type for Target
([`335019d`](https://togithub.com/emberjs/ember-test-helpers/commit/335019d ))
- Upgrade expect-type and fix issues the new version reveals
([`bae5e33`](https://togithub.com/emberjs/ember-test-helpers/commit/bae5e33 ))
- Correctly handle special char keyCodes with Shift
([`d537923`](https://togithub.com/emberjs/ember-test-helpers/commit/d537923 ))
- Add tab type test
([`64f40d5`](https://togithub.com/emberjs/ember-test-helpers/commit/64f40d5 ))
- Generate documentation
([`939f29f`](https://togithub.com/emberjs/ember-test-helpers/commit/939f29f ))
- Ensure types reflect optional-ness of tab options
([`95285cc`](https://togithub.com/emberjs/ember-test-helpers/commit/95285cc ))
- Fix typesVersions config again
([`53fa899`](https://togithub.com/emberjs/ember-test-helpers/commit/53fa899 ))
- Clean up public-types after pack
([`b9dcbca`](https://togithub.com/emberjs/ember-test-helpers/commit/b9dcbca ))
###
[`v2.9.0`](https://togithub.com/emberjs/ember-test-helpers/blob/HEAD/CHANGELOG.md#v290-2022-12-14 )
[Compare
Source](https://togithub.com/emberjs/ember-test-helpers/compare/v2.8.1...v2.9.0 )
##### 🚀 Enhancement
-
[#​1269](https://togithub.com/emberjs/ember-test-helpers/pull/1269 )
Re-export hasEmberVersion (and its type) from
[@​ember/test-helpers](https://togithub.com/ember/test-helpers )
([@​gitKrystan](https://togithub.com/gitKrystan ))
-
[#​1278](https://togithub.com/emberjs/ember-test-helpers/pull/1278 )
perf: Remove excessive destroy call
([@​runspired](https://togithub.com/runspired ))
-
[#​1234](https://togithub.com/emberjs/ember-test-helpers/pull/1234 )
Introduce public TypeScript support
([@​chriskrycho](https://togithub.com/chriskrycho ))
##### 🐛 Bug Fix
-
[#​1277](https://togithub.com/emberjs/ember-test-helpers/pull/1277 )
Actually publish .d.ts
([@​gitKrystan](https://togithub.com/gitKrystan ))
-
[#​1270](https://togithub.com/emberjs/ember-test-helpers/pull/1270 )
Fix typesVersions path
([@​gitKrystan](https://togithub.com/gitKrystan ))
-
[#​1233](https://togithub.com/emberjs/ember-test-helpers/pull/1233 )
Add more keyCode mappings ([@​CvX](https://togithub.com/CvX ))
##### 📝 Documentation
-
[#​1259](https://togithub.com/emberjs/ember-test-helpers/pull/1259 )
DOCS: API: publish docs for tab
([@​geneukum](https://togithub.com/geneukum ))
##### Committers: 5
- Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho ))
- Chris Thoburn ([@​runspired](https://togithub.com/runspired ))
- Geordan Neukum ([@​geneukum](https://togithub.com/geneukum ))
- Jarek Radosz ([@​CvX](https://togithub.com/CvX ))
- Krystan HuffMenne
([@​gitKrystan](https://togithub.com/gitKrystan ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 18:04:35 +00:00
Kevin Ansfield
0b80a7f9eb
Fixed new tier creation browser tests ( #16066 )
...
refs https://github.com/TryGhost/Ghost/pull/16013
- ordering of tiers changed so newly added tiers are no longer always at the end of the list in Admin
2023-01-03 17:59:33 +00:00
Daniel Lockyer
99c775be23
ℹ️ Bumped minimum Node version to 14.18.0
...
refs https://github.com/TryGhost/Toolbox/issues/488
- this is needed so we can bump some dependencies
- given how old these versions are, users should probably update past
this anyway
2023-01-03 18:54:39 +01:00
renovate[bot]
9d577a2d5a
Update peter-evans/create-or-update-comment digest to 66af805
2023-01-03 18:48:48 +01:00
renovate[bot]
9e4b882889
Update dependency @sinonjs/fake-timers to v10.0.2
2023-01-03 18:47:15 +01:00
renovate[bot]
dcf8c55e9c
Update dependency @types/nodemailer to v6.4.7
2023-01-03 18:46:57 +01:00
renovate[bot]
470cdbb681
Update dependency html-validate to v7.12.0
2023-01-03 18:46:27 +01:00
renovate[bot]
55b73b9049
Update dependency @playwright/test to v1.29.1
2023-01-03 18:46:13 +01:00
renovate[bot]
cd1cdd869f
Update dependency ember-in-viewport to v4.1.0 ( #15795 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-in-viewport](https://togithub.com/dockyard/ember-in-viewport ) |
[`4.0.2` ->
`4.1.0`](https://renovatebot.com/diffs/npm/ember-in-viewport/4.0.2/4.1.0 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>dockyard/ember-in-viewport</summary>
###
[`v4.1.0`](https://togithub.com/dockyard/ember-in-viewport/compare/v4.0.2...v4.1.0 )
[Compare
Source](https://togithub.com/dockyard/ember-in-viewport/compare/v4.0.2...v4.1.0 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:23:51 +00:00
renovate[bot]
6f6f816077
Update dependency ember-css-transitions to v4.3.2 ( #15846 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[ember-css-transitions](https://miguelcobain.github.io/ember-css-transitions )
([source](https://togithub.com/miguelcobain/ember-css-transitions )) |
[`4.2.0` ->
`4.3.2`](https://renovatebot.com/diffs/npm/ember-css-transitions/4.2.0/4.3.2 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>miguelcobain/ember-css-transitions</summary>
###
[`v4.3.2`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v432-2022-11-18 )
[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.3.1...v4.3.2 )
##### 🐛 Bug Fix
-
[#​117](https://togithub.com/miguelcobain/ember-css-transitions/pull/117 )
Handle no ownConfig scenario (for real)
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### Committers: 1
- Sergey Astapov
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
###
[`v4.3.1`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v431-2022-11-18 )
[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.3.0...v4.3.1 )
##### 🐛 Bug Fix
-
[#​116](https://togithub.com/miguelcobain/ember-css-transitions/pull/116 )
Handle no ownConfig scenario
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### Committers: 1
- Sergey Astapov
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
###
[`v4.3.0`](https://togithub.com/miguelcobain/ember-css-transitions/blob/HEAD/CHANGELOG.md#v430-2022-11-18 )
[Compare
Source](https://togithub.com/miguelcobain/ember-css-transitions/compare/v4.2.0...v4.3.0 )
##### 🚀 Enhancement
-
[#​113](https://togithub.com/miguelcobain/ember-css-transitions/pull/113 )
Add opt-in integration with
[@​ember/test-waiters](https://togithub.com/ember/test-waiters )
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​109](https://togithub.com/miguelcobain/ember-css-transitions/pull/109 )
Update glint import path to template-registry
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### 📝 Documentation
-
[#​115](https://togithub.com/miguelcobain/ember-css-transitions/pull/115 )
Add Glint support page to docs
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### 🏠 Internal
-
[#​114](https://togithub.com/miguelcobain/ember-css-transitions/pull/114 )
Fix flaky tests
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​112](https://togithub.com/miguelcobain/ember-css-transitions/pull/112 )
Rename addon folder to ember-css-transitions
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
-
[#​111](https://togithub.com/miguelcobain/ember-css-transitions/pull/111 )
update v2 addon setup
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
##### Committers: 1
- Sergey Astapov
([@​SergeAstapov](https://togithub.com/SergeAstapov ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNi40IiwidXBkYXRlZEluVmVyIjoiMzQuMjYuNCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:23:23 +00:00
renovate[bot]
5ff142bd49
Update dependency liquid-wormhole to v3 ( #16003 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [liquid-wormhole](https://togithub.com/pzuraq/liquid-wormhole ) |
[`2.1.5` ->
`3.0.0`](https://renovatebot.com/diffs/npm/liquid-wormhole/2.1.5/3.0.0 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>pzuraq/liquid-wormhole</summary>
###
[`v3.0.0`](https://togithub.com/pzuraq/liquid-wormhole/blob/HEAD/CHANGELOG.md#v300-2022-12-13 )
[Compare
Source](https://togithub.com/pzuraq/liquid-wormhole/compare/v2.1.5...v3.0.0 )
##### 💥 Breaking Change
- [#​75](https://togithub.com/pzuraq/liquid-wormhole/pull/75 )
Ember >= 3.24, node >= 14
([@​rwwagner90](https://togithub.com/rwwagner90 ))
- [#​72](https://togithub.com/pzuraq/liquid-wormhole/pull/72 )
Update liquid-fire, remove getowner polyfill
([@​rwwagner90](https://togithub.com/rwwagner90 ))
- [#​67](https://togithub.com/pzuraq/liquid-wormhole/pull/67 ) ci:
drop support for node 4.x and node 6.x
([@​alexdiliberto](https://togithub.com/alexdiliberto ))
##### 🚀 Enhancement
- [#​74](https://togithub.com/pzuraq/liquid-wormhole/pull/74 ) Add
Embroider support
([@​rwwagner90](https://togithub.com/rwwagner90 ))
- [#​73](https://togithub.com/pzuraq/liquid-wormhole/pull/73 )
Various Ember updates
([@​rwwagner90](https://togithub.com/rwwagner90 ))
##### Committers: 2
- Alex DiLiberto
([@​alexdiliberto](https://togithub.com/alexdiliberto ))
- Robert Wagner ([@​rwwagner90](https://togithub.com/rwwagner90 ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNTQuMiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 17:21:58 +00:00
Daniel Lockyer
8d18530f60
Revert "Bumped GHA Runners to larger machines"
...
- this reverts commit 921e9f4069
2023-01-03 17:56:03 +01:00
Simon Backx
803bb18b8d
Improved unit test coverage for the output mappers
...
no issue
Increases the unit test coverage to a bit above 60% to increase margin
2023-01-03 15:58:31 +01:00
renovate[bot]
fe454d8a33
Update dependency @babel/plugin-proposal-decorators to v7.20.7 ( #16043 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@babel/plugin-proposal-decorators](https://babel.dev/docs/en/next/babel-plugin-proposal-decorators )
([source](https://togithub.com/babel/babel )) | [`7.20.5` ->
`7.20.7`](https://renovatebot.com/diffs/npm/@babel%2fplugin-proposal-decorators/7.20.5/7.20.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>babel/babel</summary>
###
[`v7.20.7`](https://togithub.com/babel/babel/blob/HEAD/CHANGELOG.md#v7207-2022-12-22 )
[Compare
Source](https://togithub.com/babel/babel/compare/v7.20.5...v7.20.7 )
##### 👓 Spec Compliance
- `babel-helper-member-expression-to-functions`,
`babel-helper-replace-supers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`
- [#​15223](https://togithub.com/babel/babel/pull/15223 ) fix:
Deleting super property should throw
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
- `babel-helpers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`, `babel-plugin-transform-object-super`
- [#​15241](https://togithub.com/babel/babel/pull/15241 ) fix:
Throw correct error types from sed ant class TDZ helpers
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
##### 🐛 Bug Fix
- `babel-parser`, `babel-plugin-transform-typescript`
- [#​15209](https://togithub.com/babel/babel/pull/15209 ) fix:
Support auto accessors with TypeScript annotations
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-traverse`
- [#​15287](https://togithub.com/babel/babel/pull/15287 ) Fix
`.parentPath` after rename in `SwitchCase`
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
- `babel-plugin-transform-typescript`, `babel-traverse`
- [#​15284](https://togithub.com/babel/babel/pull/15284 ) fix: Ts
import type and func with duplicate name
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-plugin-transform-block-scoping`
- [#​15278](https://togithub.com/babel/babel/pull/15278 ) Fix tdz
analysis for reassigned captured for bindings
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
- `babel-plugin-proposal-async-generator-functions`, `babel-preset-env`
- [#​15235](https://togithub.com/babel/babel/pull/15235 ) fix:
Transform `for await` with shadowed variables
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-generator`, `babel-plugin-proposal-optional-chaining`
- [#​15258](https://togithub.com/babel/babel/pull/15258 ) fix:
Correctly generate `(a ?? b) as T`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-plugin-transform-react-jsx`, `babel-types`
- [#​15233](https://togithub.com/babel/babel/pull/15233 ) fix: Emit
correct sourcemap ranges for `JSXText`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
- `babel-core`, `babel-helpers`,
`babel-plugin-transform-computed-properties`, `babel-runtime-corejs2`,
`babel-runtime-corejs3`, `babel-runtime`
- [#​15232](https://togithub.com/babel/babel/pull/15232 ) fix:
Computed properties should keep original definition order
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
- `babel-helper-member-expression-to-functions`,
`babel-helper-replace-supers`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-classes`
- [#​15223](https://togithub.com/babel/babel/pull/15223 ) fix:
Deleting super property should throw
([@​SuperSodaSea](https://togithub.com/SuperSodaSea ))
- `babel-generator`
- [#​15216](https://togithub.com/babel/babel/pull/15216 ) fix:
Print newlines for leading Comments of `TSEnumMember`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
##### 💅 Polish
- `babel-plugin-transform-block-scoping`, `babel-traverse`
- [#​15275](https://togithub.com/babel/babel/pull/15275 ) Improve
relative execution tracking in fn exprs
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
##### 🏠 Internal
- `babel-helper-define-map`, `babel-plugin-transform-property-mutators`
- [#​15274](https://togithub.com/babel/babel/pull/15274 ) Inline &
simplify `@babel/helper-define-map`
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
- `babel-core`, `babel-plugin-proposal-class-properties`,
`babel-plugin-transform-block-scoping`,
`babel-plugin-transform-classes`,
`babel-plugin-transform-destructuring`,
`babel-plugin-transform-parameters`,
`babel-plugin-transform-regenerator`, `babel-plugin-transform-runtime`,
`babel-preset-env`, `babel-traverse`
- [#​15200](https://togithub.com/babel/babel/pull/15200 ) Rewrite
`transform-block-scoping` plugin
([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo ))
##### 🏃♀️ Performance
- `babel-helper-compilation-targets`
- [#​15228](https://togithub.com/babel/babel/pull/15228 ) perf:
Speed up `getTargets`
([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:45:34 +00:00
renovate[bot]
e264616808
Update dependency ember-resolver to v8.1.0 ( #16035 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-resolver](https://togithub.com/ember-cli/ember-resolver ) |
[`8.0.3` ->
`8.1.0`](https://renovatebot.com/diffs/npm/ember-resolver/8.0.3/8.1.0 ) |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>ember-cli/ember-resolver</summary>
###
[`v8.1.0`](https://togithub.com/ember-cli/ember-resolver/blob/HEAD/CHANGELOG.md#v810-2022-12-20 )
[Compare
Source](https://togithub.com/ember-cli/ember-resolver/compare/v8.0.3...v8.1.0 )
Back-ports built-in TypeScript support from 9.0.0 (see below) to
decouple that from the Ember 4.x upgrade.
##### 🚀 Enhancement
- [#​839](https://togithub.com/ember-cli/ember-resolver/pull/839 )
Backport types to 8.x
([@​chriskrycho](https://togithub.com/chriskrycho ))
##### Committers: 1
- Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMSJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:44:38 +00:00
renovate[bot]
9955cdc3ba
Update dependency testem to v3.10.1 ( #16034 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [testem](https://togithub.com/testem/testem ) | [`3.10.0` ->
`3.10.1`](https://renovatebot.com/diffs/npm/testem/3.10.0/3.10.1 ) |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>testem/testem</summary>
### [`v3.10.1`](https://togithub.com/testem/testem/releases/tag/v3.10.1 )
[Compare
Source](https://togithub.com/testem/testem/compare/v3.10.0...v3.10.1 )
#### What's Changed
- build(deps): bump socket.io from 4.5.3 to 4.5.4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1609 ](https://togithub.com/testem/testem/pull/1609 )
- build(deps-dev): bump sinon from 14.0.2 to 15.0.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1611 ](https://togithub.com/testem/testem/pull/1611 )
- build(deps-dev): bump socket.io-client from 4.5.3 to 4.5.4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1610 ](https://togithub.com/testem/testem/pull/1610 )
- build(deps-dev): bump eslint from 8.28.0 to 8.30.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1616 ](https://togithub.com/testem/testem/pull/1616 )
- build(deps-dev): bump sinon from 15.0.0 to 15.0.1 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/testem/testem/pull/1617 ](https://togithub.com/testem/testem/pull/1617 )
- Scope testem assets with a prefix by
[@​stepankuzmin](https://togithub.com/stepankuzmin ) in
[https://github.com/testem/testem/pull/1615 ](https://togithub.com/testem/testem/pull/1615 )
#### New Contributors
- [@​stepankuzmin](https://togithub.com/stepankuzmin ) made their
first contribution in
[https://github.com/testem/testem/pull/1615 ](https://togithub.com/testem/testem/pull/1615 )
**Full Changelog**:
https://github.com/testem/testem/compare/v3.10.0...v3.10.1
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42Ni4wIiwidXBkYXRlZEluVmVyIjoiMzQuNjYuMCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:44:07 +00:00
renovate[bot]
bde3dc8087
Update dependency ember-basic-dropdown to v6.0.2 ( #15809 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-basic-dropdown](http://ember-basic-dropdown.com )
([source](https://togithub.com/cibernox/ember-basic-dropdown )) |
[`6.0.1` ->
`6.0.2`](https://renovatebot.com/diffs/npm/ember-basic-dropdown/6.0.1/6.0.2 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>cibernox/ember-basic-dropdown</summary>
###
[`v6.0.2`](https://togithub.com/cibernox/ember-basic-dropdown/blob/HEAD/CHANGELOG.md#​602 )
[Compare
Source](https://togithub.com/cibernox/ember-basic-dropdown/compare/v6.0.1...d6395e07adfa13037617fd2b051623d2f9bfde58 )
- Relax dependency on ember-style-modifier so version 1.0 is also
allowed
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yMS42IiwidXBkYXRlZEluVmVyIjoiMzQuMjEuNiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:39:21 +00:00
renovate[bot]
be31f8e9fe
Update dependency @embroider/macros to v1.10.0 ( #15874 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@embroider/macros](https://togithub.com/embroider-build/embroider ) |
[`1.9.0` ->
`1.10.0`](https://renovatebot.com/diffs/npm/@embroider%2fmacros/1.9.0/1.10.0 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>embroider-build/embroider</summary>
###
[`v1.10.0`](https://togithub.com/embroider-build/embroider/blob/HEAD/CHANGELOG.md#embroidermacros-190---1100 )
- BUGFIX: template macros could have pre-moved appRoot in their
packageCache
- ENHANCEMENT: expose simplified transforms API for use with
babel-plugin-ember-template-compilation
Previously, we used MacrosConfig.astTransforms() which gave you
transforms in
the reverse order they were expected to run, for compatibility with the
wacky
ordering in class ember-cli-htmlbars. Now we also offer
`MacrosConfig.transforms()` which provides them in a format compatible
directly with babel-plugin-ember-template-compilation 2.0, which uses
the more natural order and which supports
plugins-as-strings-to-be-loaded in addition to just plain functions.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuMzAuNCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-03 14:38:47 +00:00
Daniel Lockyer
f512bd8eff
Bumped CI Node version to 16
...
refs https://github.com/TryGhost/Toolbox/issues/488
- Node 16 is our recommended version so we should run tests using that
2023-01-03 14:39:31 +01:00
renovate[bot]
435d5da3ff
Update sentry-javascript monorepo to v7.28.1
2023-01-03 14:27:06 +01:00
renovate[bot]
c908ccc721
Update dependency husky to v8.0.3
2023-01-03 14:06:21 +01:00
Daniel Lockyer
921e9f4069
Bumped GHA Runners to larger machines
...
- this switches the testing CI over to larger 16 core machines we now
have access to
2023-01-03 10:53:13 +01:00
Kevin Ansfield
581f0b34b4
🐛 Fixed missing validation of offer amounts in the admin panel ( #16022 )
...
closes https://github.com/TryGhost/Team/issues/2380
- improved offer validation for `amount` field to cover all type/amount cases
- added validate-on-blur to the amount field to match our standard validation behaviour
- added re-validation of the amount field when the type is changed and the amount gets reset
- removed the internal parsing of a decimal trial days entry to an integer so the field value matches what is set internally and we let the user know that partial trial days are not supported
Non-user-facing refactors:
- renamed `_saveOfferProperty` to `_updateOfferProperty` to better reflect what it does
- fixed missing indentation for conditional blocks in the offer template
2023-01-03 09:23:11 +00:00
Elena Baidakova
235446b034
🐛 Fixed tiers order by monthly_price ( #16013 )
...
refs TryGhost/Team#2273
- According to documentation (https://ghost.org/docs/content-api/#order )
tiers should be ordered from lowest to highest monthly price.
2023-01-03 12:59:18 +04:00
Simon Backx
211de82a8d
Fixed random test failure due to member newsletter ordering ( #16024 )
...
fixes https://github.com/TryGhost/Team/issues/2365
The newsletters relation of a member was not sorted. This is fixed now,
so we have consistent results in the test snapshots.
2023-01-03 09:43:41 +01:00
renovate[bot]
c0b700147e
Update dependency eslint to v8.31.0
2023-01-03 07:22:01 +00:00
renovate[bot]
af91df561c
Update metascraper to v5.32.4
2023-01-03 04:07:06 +00:00
renovate[bot]
694e02d7ba
Update dependency sanitize-html to v2.8.1
2023-01-03 00:17:13 +00:00
Daniel Lockyer
4867b7fb3d
Updated @tryghost/logging resolutions
...
refs 08b786af3b
2023-01-02 21:01:45 +01:00
Daniel Lockyer
08b786af3b
Bumped TryGhost-owned dependencies and lockfile
...
- this was all getting terribly behind so I've done several things:
- majority of `@tryghost/*` except Lexical packages
- gscan + knex-migrator to remove old `@tryghost/errors` usage
- bumped lockfile
2023-01-02 20:55:22 +01:00
renovate[bot]
24274fec0b
Update actions/stale action to v7
2023-01-02 18:03:54 +01:00
Sam Lord
994e546787
Prevented posts meta table from breaking data generator script
...
refs: https://github.com/TryGhost/Toolbox/issues/453
2023-01-02 16:45:45 +00:00
Simon Backx
f568b35f26
Fixed 2023 snapshot tests
...
no issue
Updated the snapshot files for the email preview test snapshots that contain 2023 in the email footer.
2023-01-02 11:18:07 +01:00
Ghost CI
65252c361a
v5.26.4
2022-12-30 16:00:45 +00:00
Ghost CI
85db1838d9
v5.26.3
2022-12-23 16:01:11 +00:00
Ghost CI
42f5743e86
v5.26.2
2022-12-20 12:15:51 +00:00
Hannah Wolfe
1b5aa390f1
🐛 Fixed meta is missing error with revue imports ( #16033 )
...
refs:
5f90baf6fe
2022-12-20 11:56:07 +00:00
Ghost CI
1f5a752b71
v5.26.1
2022-12-16 16:01:00 +00:00
Ghost CI
26be3b9ccd
v5.26.0
2022-12-16 12:49:22 +00:00
