Commit Graph

9594 Commits

Author SHA1 Message Date
Sanne de Vries
a4d5d14ba6 Updated internal tag style in user deletion modal 2022-07-14 15:11:43 +01:00
Sanne de Vries
09794a7c05 Updated theme upload modal in Casper error state
No ref

- Updated modal default state to make it look more clickable
- Updated the Casper upload error state design
- Changed the 'try again' button to directly open the finder rather than only resetting the modal
2022-07-14 15:07:08 +01:00
jp
214ad1d57c 🎨 Added link to GitHub release for current version (#2349) 2022-07-14 15:07:24 +02:00
James Morris
415dfa97b3 Refactored and cleared out some unneeded Dashboard CSS
no issue
2022-07-14 10:37:10 +01:00
James Morris
551db84966 Small fix for email newsletter setting arrow placement
no issue
2022-07-14 09:52:26 +01:00
Djordje Vlaisavljevic
048b0470da Updated lint-todo 2022-07-13 18:25:54 +02:00
Djordje Vlaisavljevic
5ad99f79a9 Added unique aria-labels to form elements 2022-07-13 18:25:46 +02:00
Djordje Vlaisavljevic
a710dd3c06 Removed option to close the modal by clicking behind it 2022-07-13 17:28:29 +02:00
Djordje Vlaisavljevic
82808d69f5 Made the "back" buttons have unique aria-label attributes 2022-07-13 17:27:24 +02:00
Djordje Vlaisavljevic
6e0bd66063 Updated lint-todo 2022-07-13 17:26:35 +02:00
Kevin Ansfield
cb6e1679e9 Fixed modalOptions.ignoreBackdropClick not always being picked up
no issue

- the modal instance on `this.top` inside the background click handler is not always a direct instance so we need to check both `.options` and `._options` when looking for the desired click ignore behaviour
2022-07-13 16:02:34 +01:00
Djordje Vlaisavljevic
1158555084 Set canonical post placeholder value to post URL 2022-07-13 16:59:28 +02:00
Daniel Lockyer
a644cc14c1 Merged v5.3.1 into main
v5.3.1
2022-07-13 12:56:50 +01:00
Daniel Lockyer
3f380e266d v5.3.1 2022-07-13 12:55:34 +01:00
Simon Backx
5f63060f78 🐛 Excluded plan changes from paid subscribers graph in dashboard
refs https://github.com/TryGhost/Team/issues/1673

When a user switches plan, the paid subscribers delta chart on the dashboard displays the change as a cancellation plus a new subscription. This display is misleading and confusing - instead, plan changes should be excluded from the paid subscribers delta chart.
2022-07-13 13:46:45 +02:00
Daniel Lockyer
3c63a01eec v5.3.0 2022-07-12 16:24:01 +01:00
Sanne de Vries
be2744c27f Updated activity feed empty state icon 2022-07-12 14:03:40 +01:00
Sanne de Vries
18102f309b Fixed empty state icons in dark mode 2022-07-12 13:49:24 +01:00
Sanne de Vries
be0fb41636 Updated webhook actions to dotdotdot menu 2022-07-12 13:38:51 +01:00
Naz
c7de8d3358 Updated copy for user deletion modal
refs https://github.com/TryGhost/Ghost/issues/15008

- When the user is removed the new flow adds a special tag and reassignes all the user-owned posts to the owner user. Updated copy to inform about this behavior clearly
2022-07-13 00:26:13 +12:00
Sanne de Vries
abc11a8028 Fixed broken activity filter empty state 2022-07-12 12:47:48 +01:00
Sanne de Vries
ea2bbef4c1 Fixed broken icon for activity empty state 2022-07-12 12:28:57 +01:00
Sanne de Vries
ea92f89c1d Removed unused contributors code and images 2022-07-12 11:38:08 +01:00
Rishabh
0ec3e2274f Removed sodo search alpha feature flag
refs https://github.com/TryGhost/Team/issues/1665

- removes feature flag for sodo search as its now bumped to GA
2022-07-12 13:22:26 +05:30
renovate[bot]
9cde5db860 Lock file maintenance 2022-07-11 00:04:38 +00:00
Kevin Ansfield
c06692a2fb 🐛 Fixed "Published" date for recent posts in dashboard always showing current time
no issue

- switched to the actual published at property name
- wrapped date in `{{moment-site-tz}}` so the site-local time is shown
2022-07-08 12:34:58 +02:00
Naz
04d27fac5f Stopped downloading site backup when deleting a user
refs https://github.com/TryGhost/Ghost/issues/15008

- Backup process had a slim benefit to keep around. Without it the removal process is much smoother.
- The backup still happens on the server side if it's absolutely needed at some point in the future
2022-07-08 20:56:52 +12:00
Kevin Ansfield
87eafc1ae4 Wired up user comment notifications toggle 2022-07-06 18:32:13 +02:00
Peter Zimon
27212475f3 Added basic email notification for comment in staff 2022-07-06 17:55:44 +02:00
Peter Zimon
385000d4ce Fixed lint error 2022-07-06 11:09:25 +02:00
Peter Zimon
ff7bb48b7e Added Comment access dropdown to membership settings 2022-07-06 11:01:57 +02:00
Kevin Ansfield
79f0c04828 Added commentsEnabled setting
refs https://github.com/TryGhost/Team/issues/1664

- used to change native comments system availability
2022-07-06 09:53:21 +02:00
Kevin Ansfield
b98b6aa805 🐛 Fixed dashboard member activity feed always showing current time for timestamp
no issue

- `event.timestamp` was used instead of `parsedEvent.timestamp` meaning it was undefined and `{{moment-format}}` created a new date object instead of using the real event date
2022-07-06 09:22:05 +02:00
Daniel Lockyer
a7c34b7a7e Merged v5.2.4 into main
v5.2.4
2022-07-05 10:52:15 +02:00
Daniel Lockyer
862ace7945 v5.2.4 2022-07-05 09:50:40 +01:00
Kevin Ansfield
fa92a62cd3 🐛 Fixed scheduled post datepicker sometimes picking day before selected date
no issue

- in sites with a timezone that is negatively offset from UTC at certain times of day when the equivalent UTC date would be the next day, selecting a date when scheduling a post would select a day before the selected date
- fixed the date adjustment when applying the selected date to properly take timezones into account
2022-07-05 10:44:38 +02:00
Kevin Ansfield
a1457a0b8c 🐛 Fixed schedule post date picker sometimes not allowing "today" to be selected
no issue

- with large site timezone UTC offsets it could happen that "today" in the site timezone is not selectable in the date picker when scheduling posts
- the problem occurred because we were passing a minimum date to the date picker in UTC which was then converted to a local date using just the "YYYY-MM-DD" data but that would not always be correct because the UTC date could be "tomorrow" compared to the site timezone. Passing in the minimum date in the site timezone rather than UTC ensures the minimum date always matches "today" in the site timezone
2022-07-05 10:44:30 +02:00
Kevin Ansfield
8ff94df1c8 Added comments toggle to labs feature list
no issue
2022-07-04 14:15:53 +02:00
Naz
2857e46d7c Added sodoSearch flag to Admin Labs
refs 911ce4f29e
2022-07-04 18:10:42 +08:00
renovate[bot]
a70ffd32d7 Lock file maintenance 2022-07-01 14:32:42 +00:00
renovate[bot]
a99f836b83 Update dependency miragejs to v0.1.45 (#2379)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-07-01 13:00:39 +01:00
Kevin Ansfield
f03041929f 🐛 Fixed schedule post date picker sometimes not allowing "today" to be selected
no issue

- with large site timezone UTC offsets it could happen that "today" in the site timezone is not selectable in the date picker when scheduling posts
- the problem occurred because we were passing a minimum date to the date picker in UTC which was then converted to a local date using just the "YYYY-MM-DD" data but that would not always be correct because the UTC date could be "tomorrow" compared to the site timezone. Passing in the minimum date in the site timezone rather than UTC ensures the minimum date always matches "today" in the site timezone
2022-07-01 11:20:26 +01:00
Kevin Ansfield
100dea6d98 🐛 Fixed scheduled post datepicker sometimes picking day before selected date
no issue

- in sites with a timezone that is negatively offset from UTC at certain times of day when the equivalent UTC date would be the next day, selecting a date when scheduling a post would select a day before the selected date
- fixed the date adjustment when applying the selected date to properly take timezones into account
2022-07-01 11:20:26 +01:00
Daniel Lockyer
cc570d23b0 v5.2.3 2022-06-15 03:59:46 +01:00
Daniel Lockyer
9551e57a00 v5.2.2 2022-06-03 17:50:37 +01:00
Daniel Lockyer
802cf2457f v5.2.1 2022-06-02 12:34:53 +01:00
Simon Backx
bd1f11f147 Added test timeout hint to README 2022-06-02 13:20:05 +02:00
Simon Backx
549e8c526f Added newsletter slug generation to mirage 2022-06-02 13:19:52 +02:00
Simon Backx
7c04c2c472 Added test to see if newsletter is saved 2022-06-02 12:58:10 +02:00
Simon Backx
d5887c6ac0 Added tests for newsletter limits
refs https://github.com/TryGhost/Team/issues/1477
2022-06-02 11:21:29 +02:00
Simon Backx
557e268445 Added newsletter archiving tests
refs https://github.com/TryGhost/Team/issues/1477
2022-06-02 10:39:17 +02:00
Simon Backx
fb1b9b5f1f Added test documentation to README
no issue
2022-06-02 10:38:51 +02:00
Sanne de Vries
1e76022a28 Fixed post bookmark shifting layout bug 2022-06-01 18:26:20 -04:00
Sanne de Vries
5e7678b239 Fixed empty states spacing regression 2022-06-01 17:31:23 -04:00
Daniel Lockyer
facf16becc v5.2.0 2022-06-01 16:28:51 +01:00
Kevin Ansfield
e1dfe3edb0 🎨 Improved save/update button copy in editor (#2413)
no issue

- renamed "Update" to "Unpublish" or "Unschedule" to match the available actions
- renamed "Save" to "Update" and made it always visible but disabled when there are no unsaved changes
- switched <Editor::PublishManagement> to a provider component and extracted `<Editor::PublishButtons>`
  - allows for the management flow to wrap other UI elements and have the yielded actions passed down so the publish/update flow can be opened from more than just the publish/unschedule/unpublish buttons
- added link to "Sent" in editor status that opens the update flow for email-only posts

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2022-06-01 13:48:33 +01:00
Kevin Ansfield
ed235b374d Increased publish flow acceptance tests
refs https://github.com/TryGhost/Team/issues/1586

- updated `?newsletter_id=id` handling in posts API mock to match the real `?newsletter=slug` behaviour
- added additional publish flow acceptance tests for single/multiple newsletter behaviour, scheduling, and sending
2022-05-31 22:59:20 +01:00
Peter Zimon
4d89ddf5bf Added 2 digit pad to fraction prices 2022-05-31 17:38:43 +02:00
Sodbileg Gansukh
ce37e969ce Updated Casper screenshot 2022-05-31 16:47:30 +08:00
Kevin Ansfield
99f05e14b2 🐛 Fixed default publish type being "Publish and email" when default recipients set to "Usually nobody"
no issue

The default recipients setting "Usually nobody" was being respected with the email recipient list defaulting to no members selected. However the UI for that state was confusing because the default publish options ended up being "Publish and email" and "Not sent as a newsletter" but it was expected to be "Publish" with the newsletter option being disabled.

- updated the `PublishOptions` setup to reflect the desired outcome for "Usually nobody"
  - default publish type is set to "Publish"
  - default email recipients are set to match post visibility - this means there are fewer clicks required when switching from "Publish" to "Publish and send"
- updated mirage data setup so any members created are automatically assigned to any newsletter instance with `subscribeOnSignup` set
  - ensures we get proper member counts in the publish flow
2022-05-30 20:04:04 +01:00
Kevin Ansfield
3f0e46c7b0 Added initial tests for new publish flow
refs https://github.com/TryGhost/Team/issues/1586

- added test helper for enabling/disabling members and helpers for disabling mailgun and newsletters
- added `loginAsRole` helper that alleviates duplication of user+role creation and also handles log-out before log-in so it's easier to mix different role tests within a block that has a default role setup in `beforeEach()`
- cleaned up editor tests that were skipped due to using the old publish flow
- added `Publish flow` acceptance test suite with an initial batch of tests
2022-05-30 19:12:16 +01:00
Kevin Ansfield
b123b297b6 Improved test settings fixtures
no issue

- the settings fixtures file was becoming hard to use because settings have been appended to it on an as-used basis which meant it was difficult to reason about the base-state in acceptance tests and was never really in sync with the default settings state for a Ghost site
- added a utility function to create a settings object with the `id` defined to avoid problems with manually updating the ids in the list
- updated to include all default settings with their default values if not already set to a specific testing value in the old fixtures
2022-05-30 14:09:29 +01:00
Daniel Lockyer
3d0e4c9380 v5.1.1 2022-05-30 13:54:28 +01:00
Kevin Ansfield
e4b402c603 Sped up tests that use {{liquid-if}}
no issue

- some tests were unnecessarily slowed down by waiting repeatedly for animations to complete
- added override for `<LiquidContainer>` component that `<LiquidIf>` uses internally with the only change being to set the default growth animation duration to 5ms when running tests
2022-05-30 12:10:37 +01:00
Djordje Vlaisavljevic
ac52e01977 Put less emphasis on the "Send test email" button 2022-05-30 12:42:13 +02:00
Kevin Ansfield
09400a1ef8 🐛 Fixed broken file selectors in labs, general, and portal settings screens
refs 8fee5f155b

- the conversion from jQuery to native was incomplete in a few places and still used `.find()` in place of `.querySelector()`
2022-05-29 11:18:55 +01:00
Daniel Lockyer
f9736d2437 v5.1.0 2022-05-27 16:10:19 +01:00
Kevin Ansfield
508af14460 Fixed linting
refs 3f9c019bc0
2022-05-27 15:24:30 +01:00
Kevin Ansfield
3f9c019bc0 Fixed editor error when using blockquote text expansion in product/toggle card content
no issue

- `<KoenigBasicHtmlTextarea>` has no UI or keyboard shortcut support for blockquotes but the markdown text expansion for quotes was left in despite the code required for it not existing, this meant any time `> text` was typed the editor would throw errors due to missing actions
2022-05-27 15:21:54 +01:00
Simon Backx
191c7e312b 🎨 Reduced favicon requirements (#2408)
refs TryGhost/Team#1652

- Support picking new image types in the favicon image uploader.
- Added support for non-square and not resizable files (e.g., svg files) as favicon (cover background image).
2022-05-27 16:20:40 +02:00
Kevin Ansfield
cab7f2cd74 🐛 Fixed paste into product card descriptions not stripping header formatting
closes https://github.com/TryGhost/Ghost/issues/14018

- product card descriptions and toggle card content both use `<KoeingBasicHtmlTextarea>` which is a stripped down Koenig editor with basic formatting support where heading sections are not expected
- when pasting into or updating the content in `<KoeingBasicHtmlTextarea>`, convert any headings, blockquotes, or other markerable section types to standard paragraphs so the content formatting matches what is possible through the editing interface
2022-05-27 15:11:08 +01:00
Hannah Wolfe
8ac5bb5b48 🐛 Fixed word count for RTL languages
closes: https://github.com/TryGhost/Ghost/issues/14365
closes: https://github.com/TryGhost/SDK/issues/366
closes: https://github.com/TryGhost/SDK/issues/389
refs: https://github.com/TryGhost/SDK/pull/431

- our word count helper has been updated to handle RTL languages

Co-authored-by: Emmanuel-Melon <emmanuelgatwech@gmail.com>
2022-05-27 13:58:48 +01:00
Kevin Ansfield
8e9582d632 Migrated signup screen to Octane patterns
refs https://github.com/TryGhost/Ghost/issues/14101

- dropped usage of `<GhTrimFocusInput>` and `<GhTextInput>` in favor of native input elements for more explicit behaviour
- switched `SignupController` to native class syntax
  - migrated to `@action` decorators and swapped all template action triggers to `{{on}}` and `{{fn}}`
2022-05-27 13:28:29 +01:00
Kevin Ansfield
33d724527c Fixed linter error
refs 817bc3453d
2022-05-27 13:07:36 +01:00
Kevin Ansfield
817bc3453d Cleaned up unused profile image upload in signup controller
refs https://github.com/TryGhost/Admin/pull/2286

- the UI to upload a profile image during setup/signup was removed as part of the auth screens redesign but the related code was left behind
2022-05-27 13:04:33 +01:00
Peter Zimon
1b682696cc Fixed publish end screen bookmark text overflow bug 2022-05-27 13:28:42 +02:00
Kevin Ansfield
67d87e8756 Fixed flash of failure state when submitting site setup and staff signup forms
no issue

- ensure tasks return `true` or `false` so the button states reflect reality
- added `@showSuccess={{false}}` to both forms because they automatically switch to a new screen on success so there's no point showing a flash of the success state
- removed unnecessary and not-recommended tabindex properties on form elements
2022-05-27 12:13:54 +01:00
Kevin Ansfield
c24ea5d0bc Fixed raw JS error messages appearing in alerts (#2407)
refs https://github.com/TryGhost/Team/issues/1613

We use `notifications.showAPIError()` in many of our try/catch routines but those can also pick up standard JS errors which can result in ugly and useless messages showing in alerts.

- added a list of known built-in JS error type names to check against and a generic error message to be used in place of ones we know shouldn't be displayed
- in `showAPIError(obj)` check `obj.name` against the known list and swap the message for a generic one
  - only the message is swapped, we still log the full/original error to Sentry
- in `handleNotification(msg)` which is the final method used when displaying any alert/notification, extract all words in the supplied message and check that against the known list and swap the message on a match. This handles situations where the API might give us a raw JS error message in the message string
2022-05-27 11:52:39 +01:00
Kevin Ansfield
b9707a2b4a Moved logic for publish confirm button text states into backing class (#2397)
refs a021553203

- keeps text and logic together, avoids duplication of button code just for changing the running/success text
- added a `buttonTextMap` to keep the high-level text states in one place
- added `publishType` getter for easier switching between states in other getters and to have one place for the logic
- updated `confirmButtonText` getter and added `confirmRunningText` and `confirmSuccessText` getters that read from the button text map so the pattern used for getting text to pass as arguments in the template is consistent
2022-05-27 11:45:40 +01:00
Matt Hanley
a8acd63aff Merged v5.0.2 into main
v5.0.2
2022-05-26 15:23:32 +01:00
Daniel Lockyer
bcde7970fb v5.0.2 2022-05-26 15:17:24 +01:00
Kevin Ansfield
ffdbde8eed 🐛 Fixed editor cards sometimes being removed as soon as they are added
no issue

When adding cards to the editor, especially image cards, we were seeing the cards removed instantaneously or whilst the file dialog was open making it appear that nothing had happened after selecting the card in the menu or selecting a file.

- as part of the publish flow workflow we extracted the pre-save routine into a separate task so that it could be triggered from external components
- one of the pre-save routine actions was to trigger an editor cleanup that removes empty cards and trailing paragraphs _but_ it should only do that when not performing a background save that occurs on any change to the post contents for drafts
- the problem arose from the background saves because the `options` argument was never passed through to the `beforeSaveTask` call meaning every save looked like a full save and performed editor cleanup resulting in unexpected removal of empty cards that had just been created
2022-05-26 15:09:58 +01:00
James Morris
2f85bd6ea4 Fixed the button positions and spacings for the Publish, Save and Sidebar icons in the editor
no issue
2022-05-26 13:47:38 +01:00
Kevin Ansfield
a4df422249 🐛 Fixed editor cards sometimes being removed as soon as they are added
no issue

When adding cards to the editor, especially image cards, we were seeing the cards removed instantaneously or whilst the file dialog was open making it appear that nothing had happened after selecting the card in the menu or selecting a file.

- as part of the publish flow workflow we extracted the pre-save routine into a separate task so that it could be triggered from external components
- one of the pre-save routine actions was to trigger an editor cleanup that removes empty cards and trailing paragraphs _but_ it should only do that when not performing a background save that occurs on any change to the post contents for drafts
- the problem arose from the background saves because the `options` argument was never passed through to the `beforeSaveTask` call meaning every save looked like a full save and performed editor cleanup resulting in unexpected removal of empty cards that had just been created
2022-05-26 12:39:15 +01:00
Kevin Ansfield
8fee5f155b Standardized on non-jQuery file dialog triggers
no issue

- we had a mix of legacy jQuery triggers and native triggers for file input clicks and jQuery hasn't been required to do this in our target browsers for quite a long time now so it made sense to update all click triggers to avoid old patterns being replicated
- cleaned up some conditionals with optional-chaining
- removed use of `run.bind(this)` for methods that use `@action` because the binding is already handled for us
2022-05-26 11:05:14 +01:00
Kevin Ansfield
aaef8f7d44 Deleted unused <GhProfileImage> component
no issue

- the component became unused when the staff user page design was updated but was never cleaned up
2022-05-26 10:42:10 +01:00
Kevin Ansfield
1130b609c3 Fixed linter errors in <KoenigCardProduct> template
refs https://github.com/TryGhost/Ghost/issues/14101
2022-05-26 10:09:00 +01:00
Renovate Bot
f4f519ed90 Update dependency grunt to v1.5.3 [SECURITY] 2022-05-25 22:23:31 +00:00
Kevin Ansfield
d23b7525a4 Removed post.email from serialization when saving posts
closes https://github.com/TryGhost/Team/issues/1647

- sending the embedded `email` record back to the API when saving could trigger "Request entity too large" errors for very large posts that were sent as email because it doubles up on the request size
- `post.email` is a read-only property and is ignored by the API so there's no point serializing it and making request bodies larger than they need to be
2022-05-25 14:27:05 +01:00
Simon Backx
741d00baf6 Removed tweetGridCard feature flag 2022-05-25 13:52:57 +02:00
Kevin Ansfield
7356bfbcd9 Migrated notifications tests to Octane patterns
refs e021843e3f

- fixed closing of alerts due to missing `.args` after migrating to glimmer syntax
- updated related tests for glimmer component syntax
2022-05-25 12:45:26 +01:00
Kevin Ansfield
e021843e3f Migrated notifications to Octane patterns
no issue

- migrated `notifications` service from EmberObject to true native class
  - switched to tracked properties and use of `TrackedArray`
  - swapped computed properties to getters
  - dropped unnecessary usage of `get` and `set`
- migrated alert/notification related components to Glimmer components
2022-05-25 12:16:37 +01:00
renovate[bot]
0c07e26cc4 Update babel monorepo to v7.18.2 (#2406)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 11:24:38 +01:00
Kevin Ansfield
36564a984f Deleted email-recipient model file missed in relationship cleanup
refs 1ade40d697
2022-05-25 11:22:09 +01:00
Kevin Ansfield
1ade40d697 Removed unneeded member.emailRecipients relationship setup
no issue

- the relationship is no longer used (it was a temporary solution whilst we built full member events) and was never fully set up resulting in warning output in test runs
- dropped remaining vestiges of the relationship
2022-05-25 11:18:37 +01:00
Kevin Ansfield
5544389b80 Fixed "The routes only function has been deprecated" output in test runs
no issue

`ember-cli-mirage` replaced the use of a default function export with a `createServer` function that applies config and deprecated the older mirage config export style. It will also soon drop support of the separate `testConfig` export we used for defining our test routes.

- switched to the newer `return createServer(config);` server configuration approach
- extracted dev and test routes into separate files for a cleaner base config
2022-05-25 11:03:05 +01:00
Simon Backx
7f6de77cee Removed selectablePortalLinks feature flag
refs https://github.com/TryGhost/Team/issues/1616
2022-05-25 11:36:30 +02:00
renovate[bot]
8115a4b6d2 Update dependency @tryghost/timezone-data to v0.2.68 (#2369)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 10:14:05 +01:00
Kevin Ansfield
c69509ee1b Updated .lint-todo
refs 99bfde4417
2022-05-25 10:12:27 +01:00
Kevin Ansfield
99bfde4417 Converted <GhCanvasHeader> to glimmer component
no issue

- added `{{on-scroll}}` modifier to replace custom setup and teardown of event handlers inside the component
2022-05-25 10:07:11 +01:00
Sanne de Vries
96a2e016b1 Fixed truncation of publication title in post bookmark 2022-05-25 10:39:00 +02:00
Sanne de Vries
7263d74c15 Truncated publication and author names in post bookmark 2022-05-25 10:33:19 +02:00
Peter Zimon
90dfe9f0df Fixed button type from membership settings link 2022-05-25 10:27:44 +02:00
Sanne de Vries
5edc95d96d Fixed dark mode issues in publishing flow 2022-05-25 10:23:11 +02:00
Kevin Ansfield
a09a1939c7 Fixed linter errors in editor preview templates 2022-05-25 09:13:08 +01:00
Kevin Ansfield
f76d7e9cd2 Renamed editor-labs component directory to editor
no issue

- cleanup now the old publish flow is no more
2022-05-25 09:13:08 +01:00
Simon Backx
49c0a64184 Cleaned up removed feature flags
refs https://github.com/TryGhost/Team/issues/1616
2022-05-25 10:11:24 +02:00
Sanne de Vries
edbdcb410d Fixed spacing bug on filtered posts empty state 2022-05-25 10:08:47 +02:00
renovate[bot]
db09ec7b01 Update dependency glob to v8.0.3 (#2383)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:48:24 +01:00
renovate[bot]
e915ca6892 Update dependency @tryghost/color-utils to v0.1.17 (#2385)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:48:11 +01:00
renovate[bot]
7125f2cddd Update dependency @tryghost/helpers to v1.1.69 (#2386)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:47:58 +01:00
renovate[bot]
c3a48193c6 Update dependency @ember/test-helpers to v2.8.1 (#2399)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:47:43 +01:00
renovate[bot]
d3ee4fd4c8 Update dependency @tryghost/members-csv to v1.2.16 (#2393)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:47:29 +01:00
renovate[bot]
c3acdb6c0d Update dependency @tryghost/string to v0.1.26 (#2394)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:47:15 +01:00
renovate[bot]
4d7526bcbd Update babel monorepo to v7.17.12 (#2395)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:47:00 +01:00
renovate[bot]
7c320cd707 Update dependency testem to v3.7.0 (#2400)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:45:55 +01:00
renovate[bot]
4c421a5ab3 Update dependency ember-auto-import to v1.12.2 (#2404)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-25 08:45:41 +01:00
Daniel Lockyer
15b06fce2a v5.0.1 2022-05-24 18:21:40 +01:00
Kevin Ansfield
90be535eb8 Fixed linter error
refs a90f9d275c
2022-05-24 17:56:12 +01:00
Kevin Ansfield
a90f9d275c Fixed "Update support address" button showing error on success
no issue

- the API response is now empty so returning the parsed response is null/undefined resulting in `<GhTaskButton>` showing a failure state
- switched to returning an enforced `true` value, if there was an error that's handled by the try/catch
2022-05-24 17:52:31 +01:00
Simon Backx
3f95a5e00f Removed unnecessary and helper 2022-05-24 16:55:50 +02:00
Simon Backx
bc1aa493fa 🐛 Fixed unreliable paid members enabled checks (#2405)
refs https://github.com/TryGhost/Team/issues/1650

- Some places only checked for Stripe being connected via the 'connect' method and ignored the 'direct' method
- Updated (where possible) admin to use the new calculated `paid_members_enabled` setting
2022-05-24 16:53:03 +02:00
Kevin Ansfield
94c192041d Added guards for missing codemirror elements when destroying markdown cards
no issue

- if a markdown card is created and destroyed before the simplemde+codemirror instance is fully initialised we could throw errors due to simplemde calling methods on objects that don't yet exist during teardown
- we also had issues with the `_applyToolbarStyles()` method being called async by event handlers after the component was destroyed
2022-05-24 13:12:22 +01:00
Hannah Wolfe
1ca5b43fcb Fixed link to redirect documentation
closes: https://github.com/TryGhost/Ghost/issues/14888

- tutorials no longer lives under docs
2022-05-24 12:31:33 +01:00
Sanne de Vries
70f82896cd Added break-all to email addresses on member details page 2022-05-24 13:25:53 +02:00
Kevin Ansfield
7dd32423b6 🐛 Fixed inability to select a date in future months when scheduling
no issue

- selecting a date in a future month always selected the same day number in the current month, if that was in the past it would also reset to "in 5 minutes"
- we were grabbing the day/month/year from the moment object provided by the calendar picker but we weren't using the correct property names, moment.js uses `months` and `years` instead of `month` and `year`
2022-05-24 10:41:50 +01:00
Sanne de Vries
446ab3a9d8 Fixed subscriber count formatting on publish confirmation page
No ref
2022-05-24 10:57:56 +02:00
Kevin Ansfield
2502639a86 🐛 Fixed timezone related issues when scheduling posts
no issue

- fixed incorrect conversion of time when converting between site tz and utc when setting scheduled hour/minute in publish flow
  - we initially created a UTC `newDate` moment from `publishOptions.scheduledAtUTC` but then used `newDate.tz(siteTimezone).format()` to get the time which was the source of the bug, it was assumed that was a non-destructive action returning a new date but it actually changed the underlying date resulting in the later calculations causing timezone adjustments to be applied twice
  - simplified by not converting to UTC inside the publish-at component as that's already handled inside PublishOptions
- fixed time not resetting to minimum schedule time when set to earlier date than allowed
2022-05-23 22:12:37 +01:00
Daniel Lockyer
a559f4c686 v5.0.0 2022-05-23 13:20:52 +01:00
Djordje Vlaisavljevic
61a459ac2e Fixed linting error 2022-05-20 12:26:01 +02:00
Djordje Vlaisavljevic
f3b56d092a Fixed text overflow in the input field 2022-05-20 12:09:41 +02:00
Djordje Vlaisavljevic
80a9a664a7 Fixed mobile preview border-radius issue in Safari 2022-05-20 10:13:03 +02:00
Simon Backx
552800bde7 Fixed dashboard recent posts not showing email only posts
refs https://ghost.slack.com/archives/C02G9E68C/p1652982196273769
2022-05-20 09:34:25 +02:00
Kevin Ansfield
7a5f15414b Fixed scheduled publishedAt validation being triggered unexpectedly
no issue

Problem:
- the server stores time with second-level precision but we send milliseconds
- when scheduling a post we were storing the selected publish-at time in the PublishOptions instance with non-zero milliseconds as the initial date was based on now+5mins
- when we were saving after the initial schedule that millisecond-containing time was still being used resulting in a perceived time difference in our client-side and server-side validations indicating that the published_at value should be updated, but when that time was <2 mins in the future the published_at change validation was triggered resulting in errors

Solution:
- ensure we only set times on PublishOptions with 0 milliseconds
- update client-side validations so we only trigger published_at validation when it's dirty

Also fixed:
- client-side validation errors were not shown on the confirm step due to a missing `.args`
2022-05-19 23:11:01 +01:00
Simon Backx
bafbe9b6b0 Fixed paid subscribers graph not counting all items
refs https://ghost.slack.com/archives/C02G9E68C/p1652971697862399?thread_ts=1652893154.768669&cid=C02G9E68C

mergeDates skips a value when the date of the next item is different than the currently aggregating entry
2022-05-19 17:20:03 +02:00
Djordje Vlaisavljevic
d2db9c6a7f Fixed dropdown flicker in dark mode 2022-05-19 16:44:16 +02:00
Sanne de Vries
20b797d2e4 Updated subscriber count in newsletter selection dropdown in publish flow
No ref
2022-05-19 15:17:55 +02:00
Kevin Ansfield
802a3c6187 Skipped animation when switching between preview modal tabs
refs 2c9998be69

- animation should only show when opening the preview modal directly from the editor
2022-05-19 13:33:23 +01:00
Sanne de Vries
2c9998be69 Added animation to post preview modes and publish button
No ref
2022-05-19 14:13:12 +02:00
Sanne de Vries
2941065eb7 Added back button to completed publishing flow
No ref
2022-05-19 13:39:40 +02:00
Kevin Ansfield
b03aa5f255 Added reverse animation to publish/preview modal contents when closing modal
refs 2fb62708a8

- use modal's own `.epm-out` class that's added when closing to trigger the reverse of the fade-in animation
- added `.publish-modal` class to the three publish modals so we can alter the default modal animations/timing if required
2022-05-19 12:19:55 +01:00
Simon Backx
e7a703ee73 Removed commented css code 2022-05-19 13:19:21 +02:00
Simon Backx
195733af2c Fixed icon and button colours in dark mode
refs https://ghost.slack.com/archives/C02G9E68C/p1652957053084759

- Activiy feed filters label colours
- Activiy feed member email address text colour
- . (i) icon when editing newsletters
- colour of edit pencil when editing free tier
- paid tiers 'active' dropdown button colour
2022-05-19 13:15:30 +02:00
Kevin Ansfield
08aa2d91ba Skipped publish flow modal animations when swapping between publish/preview
no issue

- updated the publish/preview toggle action to pass a `skipAnimation` data attribute to the modals when opening if they are being swapped rather than initially opened
2022-05-19 12:02:23 +01:00
Djordje Vlaisavljevic
5d0e3d2536 Fixed icon color in dark mode 2022-05-19 13:01:26 +02:00
Kevin Ansfield
dce531cf1c Standardized on "subscriber" for default & multiple newsletters in publish flow
no issue

- "subscriber" makes more sense than "member" in the default-only newsletter state because members still need to be subscribed to the default newsletter
- removed all subscriber/member conditionals and cleaned up template logic where possible
2022-05-19 11:37:01 +01:00
Sanne de Vries
2fb62708a8 Added fade-in effect when opening publish and preview modals in editor
No ref
2022-05-19 11:58:51 +02:00
Simon Backx
f9cd8b1f66 Removed zero tiers from paid mix charts (unless all zero)
no issue

When the last tier in the paid mix chart is zero, the border radius is broken.
2022-05-19 11:41:54 +02:00
Simon Backx
1ce02660aa Fixed recent posts open rate bars width
refs https://ghost.slack.com/archives/C02G9E68C/p1652951577111489
2022-05-19 11:28:37 +02:00
Kevin Ansfield
0549ffd4b5 Removed unused component argument with typo
no issue

- spotted the typo and thought there was a bug somewhere but post count isn't used in the complete-with-email-error state of the publish flow
2022-05-19 10:25:05 +01:00