Simon Backx
06e4eb0c77
Created separate table templates for posts with emailClicks enabled
...
refs https://github.com/TryGhost/Team/issues/1892
2022-09-13 11:57:05 +02:00
Simon Backx
e8f4e106dd
Added basic analytics page for posts
...
refs https://github.com/TryGhost/Team/issues/1892
2022-09-13 11:00:45 +02:00
renovate[bot]
1b8dbb132f
Update Test & linting packages ( #15338 )
...
* Update Test & linting packages
* Fixed new `no-quoteless-attributes` template lint errors
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2022-09-13 09:19:14 +01:00
Kevin Ansfield
512a434738
Cleaned up .lint-todo file
...
no issue
- rebuilt the lint-todo file to clean up fixed todos and reset the warning countdown
2022-09-09 18:05:22 +01:00
Kevin Ansfield
8fde9a05d2
Switched User settings unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:12 +01:00
Kevin Ansfield
6e11a24002
Switched Unsplash integration unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:12 +01:00
Kevin Ansfield
5d5e77af85
Switched Slack integration unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:12 +01:00
Kevin Ansfield
f1c4f880a6
Switched FirstPromoter unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:12 +01:00
Kevin Ansfield
2c10e53774
Switched AMP unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:12 +01:00
Kevin Ansfield
a6f19ca807
Switched navigation unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:12 +01:00
Kevin Ansfield
2396c6d615
Switched general settings unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:11 +01:00
Kevin Ansfield
1cbf310a7d
Switched code injection unsaved changes modal to new modal pattern
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-09 17:44:11 +01:00
Kevin Ansfield
d208cc881a
Cleaned up unused code in settings controller
...
no issue
- removed old/unused unsaved-changes code
- cleaned up unused service injections
2022-09-09 17:44:11 +01:00
Kevin Ansfield
08b099e527
Refactored tags screens
...
refs https://github.com/TryGhost/Ghost/issues/14101
- migrated to full native class and octane syntax
- cleaned up unnecessary use of "scratchTag"
2022-09-09 13:27:13 +01:00
Kevin Ansfield
5bbdad38a5
Refactored delete all content modal
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-08 09:18:46 +01:00
Kevin Ansfield
556a2a8ee9
Refactored tag delete modal
...
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101
- switches to newer modal patterns ready for later Ember upgrades
2022-09-08 09:18:43 +01:00
Kevin Ansfield
eca3cd7110
Moved tag screen components
...
no issue
- relocated screen-specific components into a separate `tags/` directory as part of the move to keep the top-level `components/` directory for re-usable components
2022-09-08 09:18:36 +01:00
James Morris
4373369a51
Updated lint todo file
2022-09-02 19:05:13 +01:00
Sanne de Vries
f765b019c5
Updated lint todo file
2022-09-02 17:08:13 +01:00
Sanne de Vries
a2fc31aa0a
Cleaned up icon styles
...
Refs https://www.notion.so/ghost/Unify-icons-across-Admin-7e3d124d5db34c63beccca029af595e7
- Reduced duplicate plus icons
- Replaced fill trash, info and pen icons by stroke icons
- Removed fill styles from default button classes
- Removed launch-wizard css
2022-09-02 16:56:02 +01:00
Sanne de Vries
989c3ddd77
Fixed linting error
2022-08-31 16:57:13 +01:00
Kevin Ansfield
bc185665a4
Removed use of ember-route-action-helper
...
refs https://github.com/TryGhost/Ghost/issues/14101
refs https://github.com/TryGhost/Team/issues/1734
- use of the helper was generating deprecation warnings when building Admin
- removed the single usage in favor of using `{{perform}}` directly on a controller task property as there was no need to go via the route
- changed naming of task properties to include a `...Task` suffix so it's clear when dealing with a task object
2022-08-30 16:44:50 +01:00
Kevin Ansfield
5bd66fd8b7
Migrated users.index
controller to Octane patterns
...
refs https://github.com/TryGhost/Ghost/issues/14101
- dropped use of `{{action}}`
- dropped use of computed properties in favor of getters
2022-08-30 16:44:50 +01:00
Simon Backx
977aba928c
Updated admin lint todo
2022-08-25 18:13:48 +02:00
Georg Grauberger
36d9ae36ae
Added secret handling for webhooks ( #13980 )
...
closes: https://github.com/TryGhost/Team/issues/1203
refs: https://github.com/TryGhost/Ghost/issues/9942
- Ensures that the webhook secret is validated and saved in Ghost admin
- Then makes use of this value by optionally adding an X-Ghost-Signature header that effectively signs the webhooks
- This allows for verifying the source of a webhook coming from Ghost is truly Ghost.
- Uses the same pattern as GitHub uses: https://docs.github.com/en/developers/webhooks-and-events/webhooks/securing-your-webhooks
Co-authored-by: Hannah Wolfe <github.erisds@gmail.com>
2022-08-23 16:34:32 +01:00
Peter Zimon
3b13c03af2
Fixed Admin lint error
2022-08-22 18:40:49 +02:00
Djordje Vlaisavljevic
17de478a86
Updated .lint-todo
2022-08-16 17:21:52 +02:00
Djordje Vlaisavljevic
577b30c4f6
Updated .lint-todo
2022-08-15 09:36:47 +02:00
Rishabh
c51edc19d9
Fixed lint
2022-08-11 12:03:38 +05:30
Kevin Ansfield
38a12f4e18
Update dependency ember-template-lint to v4.10.1
2022-08-03 11:40:12 +01:00
Kevin Ansfield
81f3718867
Duplicated <GhKoenigEditor>
to <GhKoenigEditorReact>
...
no issue
- the component wraps the title and editor canvas components, we only want to replace the canvas component with a react experiment so we need a duplicate for use in the `react-editor` experiment templates
2022-07-18 11:11:19 +01:00
Kevin Ansfield
a76132bda3
Re-generated .lint-todo file
...
refs https://github.com/TryGhost/Ghost/issues/14101
- compacted file and reset warning/error times
2022-07-18 10:54:10 +01:00
Kevin Ansfield
8d65303268
Fixed linter error for use of {{action}}
in editor-loading controller
...
refs https://github.com/TryGhost/Ghost/issues/14101
- `{{action}}` is deprecated and should be replaced with `{{on}}` and `{{fn}}` with direct use of methods
- switched to calling `ui.setMainClass` action directly
2022-07-18 10:50:03 +01:00
Kevin Ansfield
242106d596
Migrated code card to Octane syntax
...
refs https://github.com/TryGhost/Ghost/issues/14101
- applying boyscout rule and upgrading/cleaning up when touching files
- nothing out of the ordinary to report with this migration
2022-07-14 17:32:44 +01:00
Sanne de Vries
8aeb5c181e
Updated .lint-todo
2022-07-14 15:32:21 +01:00
Djordje Vlaisavljevic
048b0470da
Updated lint-todo
2022-07-13 18:25:54 +02:00
Djordje Vlaisavljevic
6e0bd66063
Updated lint-todo
2022-07-13 17:26:35 +02:00
Kevin Ansfield
8e9582d632
Migrated signup screen to Octane patterns
...
refs https://github.com/TryGhost/Ghost/issues/14101
- dropped usage of `<GhTrimFocusInput>` and `<GhTextInput>` in favor of native input elements for more explicit behaviour
- switched `SignupController` to native class syntax
- migrated to `@action` decorators and swapped all template action triggers to `{{on}}` and `{{fn}}`
2022-05-27 13:28:29 +01:00
Kevin Ansfield
aaef8f7d44
Deleted unused <GhProfileImage> component
...
no issue
- the component became unused when the staff user page design was updated but was never cleaned up
2022-05-26 10:42:10 +01:00
Kevin Ansfield
1130b609c3
Fixed linter errors in <KoenigCardProduct> template
...
refs https://github.com/TryGhost/Ghost/issues/14101
2022-05-26 10:09:00 +01:00
Kevin Ansfield
e021843e3f
Migrated notifications to Octane patterns
...
no issue
- migrated `notifications` service from EmberObject to true native class
- switched to tracked properties and use of `TrackedArray`
- swapped computed properties to getters
- dropped unnecessary usage of `get` and `set`
- migrated alert/notification related components to Glimmer components
2022-05-25 12:16:37 +01:00
Kevin Ansfield
c69509ee1b
Updated .lint-todo
...
refs 99bfde4417
2022-05-25 10:12:27 +01:00
Simon Backx
bc1aa493fa
🐛 Fixed unreliable paid members enabled checks ( #2405 )
...
refs https://github.com/TryGhost/Team/issues/1650
- Some places only checked for Stripe being connected via the 'connect' method and ignored the 'direct' method
- Updated (where possible) admin to use the new calculated `paid_members_enabled` setting
2022-05-24 16:53:03 +02:00
Djordje Vlaisavljevic
61a459ac2e
Fixed linting error
2022-05-20 12:26:01 +02:00
Kevin Ansfield
78418e3708
Resolved "no-action" lint errors in editor.hbs
...
refs https://github.com/TryGhost/Ghost/issues/14101
- backing class already updated to use `@action` so the use of `{{action}}` in the template could be removed
2022-05-18 09:27:43 +01:00
Rishabh Garg
8b5b3aa734
Updated usage of the Tiers API ( #2388 )
...
refs https://github.com/TryGhost/Team/issues/1575
- Update usage of Tier to read monthly & yearly price & currency from top level
- Updated usage of Tier to read benefit name from benefits[n], not from benefits[n].name
Co-authored-by: Fabien "egg" O'Carroll <fabien@allou.is>
2022-05-16 19:51:49 +01:00
Hannah Wolfe
7521d69405
Removed oauth experiment ( #2390 )
...
refs: https://github.com/TryGhost/Team/issues/1625
- this didn't work the way we wanted to
- removing this will free up the namespaces to start over
2022-05-16 17:37:00 +01:00
Simon Backx
8ba1cabc1e
Cleaned lint todo
2022-05-16 17:45:25 +02:00
Kevin Ansfield
3b088cbd77
Removed usage of old publish menu for contributors
...
no issue
- updated `<PublishManagement>` and sub-components to handle contributors by replacing publish button with save button in main view and in preview
- removed feature flag gating and usage of `<GhPublishmenu>` in editor template
- updated tests that indirectly used the old publish menu so they work with the new design/behaviour
- skipped editor tests that used the old publish menu
2022-05-16 14:18:04 +01:00
Hannah Wolfe
385240e03d
Refactored to use individual slack settings ( #2384 )
...
refs: TryGhost/Team#1625
- we want to remove backwards compatibility code for slack being a single setting
Co-authored-by: Rishabh <zrishabhgarg@gmail.com>
2022-05-16 11:38:32 +01:00