Elena Baidakova
9f1279b58e
🐛 Fixed snippet insertion in the new editor ( #17003 )
...
refs TryGhost/Team#3445
- The snippet model always expects an object as it gets serialized when
saving - if we give it a string, it gets doubly serialized. It breaks
snippet replacement and insertion in the new editor.
2023-06-13 15:51:23 +04:00
Daniel Lockyer
6a9d01c6ad
Removed superfluous GHA workflow
...
- this was left here when we moved Sodo-Search into the monorepo but
isn't needed now
2023-06-13 13:44:49 +02:00
Peter Zimon
6023bddafc
Replaced tab component in themes (AdminX)
...
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 13:11:44 +02:00
Peter Zimon
1071d4437c
Updated 'upload theme' component in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 13:11:44 +02:00
Daniel Lockyer
264773ccd1
Reset URL service between test boots
...
refs https://github.com/TryGhost/Toolbox/issues/592
- we should reset the URL service to avoid event listeners piling up and
slowing down CI due to the number of events it has to process
2023-06-13 12:52:03 +02:00
Daniel Lockyer
cedfb14924
Fixed random timeouts with mysql2 library during tests
...
refs https://github.com/TryGhost/Toolbox/issues/592
- heads up, I'm not really sure about this fix
- when we're wrapping `setTimeout`, time stops and mysql2 starts doing
weird things because we then shift time and it hits timeouts
- apparently `shouldAdvanceTime` should fix this by automatically
incrementing time along with the system clock
- given the problem is quite difficult to hit, I could just be seeing a
lack of this due to some other factor
- also removed unnecessary sinon sandbox creation as this is superfluous
2023-06-13 12:52:03 +02:00
Fabien 'egg' O'Carroll
7e1efd97e8
🐛 Fixed Post History for posts sent as an email ( #16999 )
...
refs https://github.com/TryGhost/Team/issues/3458
From the discussion in slack, for all published/sent posts:
Published only --> view history & restore
Published & sent --> view history & restore
Email only --> history hidden
And for all unpublished/unsent posts:
All states --> view history & restore.
2023-06-13 12:38:39 +02:00
Naz
7717021331
Added GET /collections/:id/posts
endpoint
...
refs https://github.com/TryGhost/Team/issues/3423
- The Admin API endpoint allows to browse collection posts and paginate over them
2023-06-13 17:23:09 +07:00
Naz
ddc23b3467
Added collection's posts fetching to collections lib
...
refs https://github.com/TryGhost/Team/issues/3423
- This is a building block to allow paging, querying etc. of the posts belonging to a collection
2023-06-13 17:23:09 +07:00
Peter Zimon
db1c4e6381
Restructured components for theme mngmt in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 12:20:29 +02:00
Peter Zimon
09b404acd2
Fixed modal footer bug in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 12:16:19 +02:00
Peter Zimon
58f51a1838
Updated theme setting copy in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 12:05:52 +02:00
Hannah Wolfe
b80b90229f
Added consistent linting pattern to all packages
...
refs: https://github.com/TryGhost/Toolbox/issues/188
- some of our older packages used a pattern for linting which missed using test config for linting tests
- we need this to be consistent so that we can add more eslint rules for testing
- two packages also didn't use the lib pattern, which made the lint pattern error - so this was fixed as well
2023-06-13 10:43:29 +01:00
Rishabh Garg
b697ca2768
Added basic theme settings design in AdminX ( #17000 )
...
refs https://github.com/TryGhost/Team/issues/3432
- adds basic design structure for theme settings/management in adminX
---------
Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2023-06-13 14:27:29 +05:30
Rishabh
5cc1c43257
Added theme management apis in adminX
...
refs https://github.com/TryGhost/Team/issues/3432
2023-06-13 13:24:47 +05:30
Jono Mingard
778e9a5f96
Added offers support in default recipients
2023-06-13 18:48:45 +12:00
Jono Mingard
731858e9e0
Added tier and label selection in default recipients
...
refs https://github.com/TryGhost/Team/issues/3151
2023-06-13 18:48:45 +12:00
Ronald Langeveld
c0e638fecd
Added membersEnabled config to lexical editor
...
refs https://github.com/TryGhost/Team/issues/3456
- adds a boolean config whether members signup is enabled so that we can
hide the signup card option from the editor if it's not enabled.
2023-06-13 08:47:16 +02:00
Jesús
a98f25b37a
Updated Catalan translations ( #16992 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-13 08:33:15 +02:00
Yin Guobing
8bc04e9e6e
Updated Chinese translations ( #16995 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-13 08:31:23 +02:00
Ghost CI
6c25f4cb08
Merged v5.51.1 into main
2023-06-13 05:52:58 +00:00
Ghost CI
e990bf5a94
v5.51.1
2023-06-13 05:52:56 +00:00
Steve Larson
d857e0ef15
Upgraded koenig lexical dependencies
...
no refs
2023-06-12 16:49:21 -05:00
Steve Larson
e742283ec8
Bumped koenig lexical dependencies
...
no refs
-added a couple more fixes: callout card rendering, code editor wrapping
2023-06-12 16:48:18 -05:00
Steve Larson
fd7b30fac0
Updated koenig lexical dependencies
...
no refs
-various fixes, including renderer for embed cards
2023-06-12 12:17:46 -05:00
Steve Larson
1345afdd71
Updated koenig lexical dependencies
...
no refs
-updated to fix embed card rendering
2023-06-12 12:08:19 -05:00
Daniel Lockyer
af8c0dc7a5
Prevented registering multiple Slack event listeners
...
refs https://github.com/TryGhost/Toolbox/issues/592
- in tests, we boot Ghost over and over
- this inits all the services each time
- it turns out that the Slack event listener is registered 80+ times
- to prevent this, we can check if it has already been registered, like
we do with webhooks: 4639396c3a/ghost/core/core/server/services/webhooks/listen.js (L67-L69)
- not sure about this pattern in general, but it's something we can
review in coming weeks
2023-06-12 15:04:11 +02:00
Daniel Lockyer
4639396c3a
Collected Ghost boot timing in test framework
...
refs https://github.com/TryGhost/Toolbox/issues/592
- this should help us track and calculate how much time is being spent
in the boot/DB reset process during tests
2023-06-12 12:07:04 +02:00
Daniel Lockyer
3ac28c7a95
Fixed snapshot for settings
...
- this deviated somewhere, which I am investigating
2023-06-12 10:04:50 +02:00
Raka Afp
078aa72a2d
Updated Bahasa Indonesia translations ( #16981 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-12 09:47:07 +02:00
EchoBilisim
eca84d61c4
Updated Turkish translation ( #16979 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-12 09:45:13 +02:00
EchoBilisim
9d8c9cda09
Updated Turkish translation ( #16982 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-12 09:44:18 +02:00
Naz
bb4e2fcadb
Added "index" built in collection
...
closes https://github.com/TryGhost/Team/issues/3425
- Index collection is needed to support one of the usecases we have in the near future where we'd hold all posts that would be displayed on the "index" page.
2023-06-12 12:57:52 +07:00
Naz
6421e202e5
Removed API endpoints adding posts to collections
...
closes https://github.com/TryGhost/Team/issues/3431
- We don't currently have a clear usecase to use the new pattern of updating posts as nested resource (of a collection). To simplify the API we are sticking with the approach of controlling where the post belongs to only through the Posts Admin API.
2023-06-12 12:08:37 +07:00
Jono Mingard
345d90bbba
Added homepage/post URL selection in AdminX design settings
...
refs https://github.com/TryGhost/Team/issues/3354
2023-06-12 13:46:14 +12:00
Jono Mingard
ba2436e834
Fixed type errors in storybook
2023-06-12 11:10:53 +12:00
Jono Mingard
c3f6d77fd9
Added simple tests for design modal
...
refs https://github.com/TryGhost/Team/issues/3354
2023-06-12 11:04:19 +12:00
Jono Mingard
90c269275e
Factored out useForm from useSettingGroup to be useful in more places
...
refs https://github.com/TryGhost/Team/issues/3151
2023-06-12 10:01:13 +12:00
Steve Larson
d1b5bf0a80
Updated koenig lexical dependencies
...
no refs
2023-06-09 12:22:01 -05:00
Steve Larson
88c3412cd4
Updated koenig lexical dependencies
...
no refs
2023-06-09 12:11:37 -05:00
renovate[bot]
ae3e38a14d
Update dependency concurrently to v8.2.0
2023-06-09 17:39:51 +02:00
Ghost CI
2744d9a58b
v5.51.0
2023-06-09 15:03:06 +00:00
Rishabh
eaf5aaade2
Updated site preview to handle theme settings
...
refs https://github.com/TryGhost/Team/issues/3354
- wires theme settings to site preview frame, dynamically updating the preview when theme settings change
2023-06-09 20:06:06 +05:30
Naz
f7e2f82089
Enabled collections permissions in controller
...
refs https://github.com/TryGhost/Team/issues/3220
- With permissions in place in the database, they can be enabled on controller level.
2023-06-09 21:13:06 +07:00
Naz
05bb82cf1a
Added collections CRUD permissions
...
refs https://github.com/TryGhost/Team/issues/3220
- Added permissions for collection resources
2023-06-09 21:13:06 +07:00
Simon Backx
2a263c1024
Updated Signup Form to v0.1
...
no issue
2023-06-09 14:32:17 +02:00
Simon Backx
c3abd3a021
Released Signup Form v0.1.0
2023-06-09 14:31:32 +02:00
Peter Zimon
2d3ab08724
Experimenting with sticky footers in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 14:29:39 +02:00
Peter Zimon
4e5523674c
Updated twitter and FB settings tests in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 14:16:56 +02:00
Peter Zimon
33ea5486df
Updated user detail modal buttons in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 14:16:56 +02:00
Simon Backx
6d6da2492c
Fixed showing errors when non 2XX response in signup form
...
no issue
2023-06-09 14:12:09 +02:00
Rishabh
c26f77586a
Added dynamic site preview iframe
...
refs https://github.com/TryGhost/Team/issues/3354
- adds dynamically loading iframe with site preview based on preview data in Admin
2023-06-09 17:39:53 +05:30
Simon Backx
a4b24b1c7a
Filled in signup form translation contexts
2023-06-09 13:54:23 +02:00
Simon Backx
08b37395cf
Added translated placeholder in signup form embed
...
no issue
2023-06-09 13:48:43 +02:00
Simon Backx
381149e45b
Added signup form button animation (minimal)
...
no issue
2023-06-09 12:07:57 +02:00
Sanne de Vries
afe18d54de
Added email icon to signup form success page
...
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#de29f9cc1a364a12a4a0eeebef68f3a4
2023-06-09 11:35:36 +02:00
Simon Backx
5e7edb9da5
✨ Added embeddable signup form
...
refs https://github.com/TryGhost/Team/issues/3274
Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
2023-06-09 11:30:03 +02:00
Peter Zimon
90b9959afc
Set up showing images in brand settings (AdminX)
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 11:26:56 +02:00
Simon Backx
ffa6c9c5f8
Added width:100%
to minimal signup form CSS
...
no issue
Otherwise the auto margin would cause issues in a grid or flex container.
2023-06-09 11:08:14 +02:00
Simon Backx
66840cda0a
Fixed minimal form padding
...
no issue
Previous change made the viewport always maximum 440px, so it always triggered the `sm` breakpoint
2023-06-09 11:06:50 +02:00
Sanne de Vries
6cdaf04fcd
Updated NL translations for Portal and Signup Form
...
No ref
2023-06-09 10:53:22 +02:00
Simon Backx
12f7fd0153
Updated minimal signup form to be centered by default
...
no issue
Added `margin: 0 auto;` css by default.
2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055
Moved maximum width and centering outside minimal signup form
...
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999
- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
2023-06-09 10:42:24 +02:00
Simon Backx
f4a822e7e0
Removed success page for minimal signup form
...
no issue
Shows the success state in the button now.
2023-06-09 10:26:05 +02:00
Naz
c507ea9600
Improved oversized batch correction logic
...
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324
- After analyzing data dumps, the data revealed that we have extra data from a stray batch. The filtering logic manually filters out the data to the recipients that belong to a "current batch".
- Hunting down the root cause of the data mixup proved to be too expensive of an investigation, so this is a "good enough patch" to deal with the problem.
- Most likely cause is the concurrent batch sending, but reducing the concurrency would be too expensive of a performance price to pay instead of filtering the data rarely.
2023-06-09 14:40:12 +07:00
Fabien "egg" O'Carroll
643fbbbb1f
Removed collections from stable list in Admin API
...
We had to add these so that they could be played with programatically
but now we have a god_mode flag, we can remove them.
2023-06-09 09:31:44 +02:00
Fabien "egg" O'Carroll
29a403cc68
Supported a god_mode param in the Admin API
...
This currently skips the not-implemented middleware and can be used to
access experimental endpoints whilst in development.
2023-06-09 09:31:44 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal ( #16971 )
...
Refs https://github.com/TryGhost/Team/issues/3407
---------
Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f
Updated signup form embed settings copy
...
No ref
2023-06-09 08:26:21 +02:00
renovate[bot]
58f48d2e0a
Update dependency @playwright/test to v1.35.0
2023-06-09 08:25:51 +02:00
Naz
efac36c36c
Removed data dump during email batching
...
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324
- Having a data dumped in production was a one-off trick to allow us debug the error. Now that we have data it's no longer needed.
2023-06-09 10:44:13 +07:00
Simon Backx
7e47bff92f
Released Signup Form v0.0.3
2023-06-08 16:35:54 +02:00
Simon Backx
c5fbd8bae6
Added Plausible events when copying the signup form embed code
...
fixes https://github.com/TryGhost/Team/issues/3389
2023-06-08 15:51:32 +02:00
Sanne de Vries
9d93d21a2d
Fixed signup form modal height
...
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
- Previous commit broke the height as the negative margin should've only been applied horizontally
2023-06-08 14:18:16 +02:00
Sanne de Vries
7a74563e21
Fixed scrollbar position in signup form modal
...
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
2023-06-08 14:06:31 +02:00
Simon Backx
5949d6a8d4
🐛 Fixed closing modals in admin UI when releasing mouse outside modal
...
no issue
When selecting text, and releasing your mouse outside the modal, the modal would close.
2023-06-08 13:50:44 +02:00
Simon Backx
5658f4b627
Fixed admin failing tests
...
no issue
renderInPlace broke tests because expected dropdown changed place in the DOM
2023-06-08 13:38:13 +02:00
Zabriskije
f3b60e6c6f
Updated Italian translations ( #16966 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-08 13:33:18 +02:00
Markus Härnvi
bd679e0a81
Updated Swedish translations ( #16964 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-08 13:32:11 +02:00
Simon Backx
a68ac4b688
Renamed data-logo to data-icon in signup embed attributes
...
fixes https://github.com/TryGhost/Team/issues/3401
2023-06-08 13:23:38 +02:00
Simon Backx
a1e632abe0
Removed page color in signup form Storybook preview component
...
no issue
The Storybook did set the color, but that shouldn't be set because normally the components are always rendered in an iframe, with a default black, unchangeable color.
2023-06-08 13:17:54 +02:00
Simon Backx
887f7385e1
Fixed label picker overflow hidde in modal in signup form modal
...
no issue
2023-06-08 13:17:54 +02:00
Sanne de Vries
a8b9be38f8
Added max width to success message in signup form
...
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#419cf40167784a5c85bd38ea3a2006ed
2023-06-08 13:13:32 +02:00
Sanne de Vries
5346fb430c
Updated loading state for embeddable signup form
...
Closes https://github.com/TryGhost/Team/issues/3390
2023-06-08 12:28:45 +02:00
Simon Backx
0b6cae09e9
Fixed Storybook missing context
...
no issue
Storybook didn't have access to the `t` method needed for translations. This change adds a Storybook decorator to all stories.
2023-06-08 11:20:16 +02:00
Elena Baidakova
4f1a92fb17
Fixed the ability to return to the main post page after scheduling a post in lexical ( #16970 )
...
refs TryGhost/Team#3405
- BackgroundSave option sets post status as Draft. Don't need such
behaviour as a post already can have a different status when a user
leaves the page.
2023-06-08 12:20:07 +04:00
Peter Zimon
cacd54b8c6
Remove traffic lights when in mobile view (AdminX)
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:33:01 +02:00
Peter Zimon
207651e2b0
Rename design modal cancel button in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:27:37 +02:00
Peter Zimon
949df42000
Added temporary preview content
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:14:12 +02:00
Peter Zimon
0d1d4dc365
Removed custom view switch functions
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:03:53 +02:00
Peter Zimon
2eda7c3287
Added mobile view to preview modal in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 07:59:32 +02:00
Peter Zimon
d87994d210
Renamed chrome header component in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 07:28:16 +02:00
Peter Zimon
011db27650
Moved preview toolbar to global preview component
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 07:11:12 +02:00
Peter Zimon
859e052810
Updated unstyled option to select input in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Peter Zimon
f28829b24e
Updated multiselect styles in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Peter Zimon
d1c32e47bb
Updated default input field styles in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Peter Zimon
c67d6fd11b
Added dynamic heading color to inputs in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Jono Mingard
c1628f46e0
Updated api services to be memoized in case of re-renders
...
no issue
2023-06-08 11:08:00 +12:00
Jono Mingard
446841ce9c
Updated design settings to be editable and show theme settings
...
refs https://github.com/TryGhost/Team/issues/3354
2023-06-08 10:30:25 +12:00
Peter Zimon
567422174d
Fixed select input size bug in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:58:47 +02:00
Peter Zimon
1cd341d9e6
Fixed type error
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:53:42 +02:00
Peter Zimon
812b83a66e
Fixed type error
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:50:56 +02:00
Peter Zimon
1bfade4891
Added preview selection toolbar in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:48:58 +02:00
Ghost CI
a173a31736
Merged v5.50.4 into main
2023-06-07 18:43:27 +00:00
Ghost CI
e7eba9f4d7
v5.50.4
2023-06-07 18:43:25 +00:00
Kevin Ansfield
2a32187ad4
🐛 Fixed converter bug that stopped some snippets being migrated for the editor beta
...
no issue
- if the converted mobiledoc started with a card and contained any text content we would hit a "can not read .length of undefined" error which could prevent snippets from being migrated when opening the beta editor and result in copy/paste from old editor to new not working
- bumped `@tryghost/kg-converters` to a fixed version
2023-06-07 18:51:02 +01:00
Steve Larson
f6457569c6
Added koenig lexical package version to sentry report
...
closes TryGhost/Team#3381
2023-06-07 18:50:58 +01:00
Kevin Ansfield
0c24c009d2
🐛 Fixed converter bug that stopped some snippets being migrated for the editor beta
...
no issue
- if the converted mobiledoc started with a card and contained any text content we would hit a "can not read .length of undefined" error which could prevent snippets from being migrated when opening the beta editor and result in copy/paste from old editor to new not working
- bumped `@tryghost/kg-converters` to a fixed version
2023-06-07 18:48:19 +01:00
Steve Larson
85896287e3
Added koenig lexical package version to sentry report
...
closes TryGhost/Team#3381
2023-06-07 11:05:35 -05:00
Ghost CI
e1b1af38e9
Merged v5.50.3 into main
2023-06-07 16:01:00 +00:00
Ghost CI
887155938a
v5.50.3
2023-06-07 16:00:59 +00:00
Peter Zimon
ed43ebaee6
Fixed editor feature image overlay bug
...
refs. https://github.com/TryGhost/Team/issues/3399
The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:52:55 +02:00
Peter Zimon
5960fdeb53
Fixed editor feature image overlay bug
...
refs. https://github.com/TryGhost/Team/issues/3399
The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:30:07 +02:00
Peter Zimon
f48dc5a847
Added inner scrolling for Design sidebar in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 17:30:07 +02:00
Nick Moreton
c4629e0118
Added transparency grid and event tracking to Image Editor ( #16959 )
2023-06-07 16:05:38 +01:00
Michael Barrett
9da246ac84
Enforce explicit cacheInvalidate header ( #16826 )
...
refs https://github.com/TryGhost/Team/issues/3005
2023-06-07 15:13:45 +01:00
Fabien "egg" O'Carroll
e0da095c76
Allowed integrations to use Collections API
2023-06-07 15:40:24 +02:00
Fabien 'egg' O'Carroll
92172aca8e
Wired up collections to posts endpoint ( #16945 )
...
- Added support for `include=collections` to the Posts Admin API behind a flag
- Refactored some of the collections work to support it
2023-06-07 15:06:15 +02:00
Daniel Lockyer
d127b975af
Disabled autoRefresh
when inserting fixtures
...
refs https://github.com/TryGhost/Toolbox/issues/592
- we don't need to receive the refreshed model back afterwards so we can
save an SQL select per insert by disabling auto-refresh
- this saves about 18000 DB queries for the MySQL tests, which should
help reduce test time due to the overhead
2023-06-07 15:03:12 +02:00
Aileen Booker
9372124d61
Decouple sentry from analytics events handlers by expecting general exception handler
...
no issue
- The class should not rely on being passed a specific dependency, but rather needs to communicate with types what structure and method it needs to function correctly.
- Replaced the specific dependency to `sentry` with a generic definition of what is expected.
2023-06-07 09:00:49 -04:00
Aileen Booker
5db1950090
Added tests ModelEventsAnalytics
...
no issue
- Added full unit tests for `ModelEventsAnalytics` class
2023-06-07 09:00:49 -04:00
Aileen Booker
6efc1cce82
Added JSDoc types and inject more deps for DomainEventsAnalytics
...
no issue
2023-06-07 09:00:49 -04:00
Aileen Booker
591ca2c9bf
Added first test structure for ModelEventsAnalytics
...
no issue
- The added `ModelEventsAnalytics` class didn't have tests before the refactor. Added unit tests to verify functionality.
2023-06-07 09:00:49 -04:00
Aileen Booker
9b27804276
Added tests for DomainEventsAnalytics
...
no issue
- Added unit tests for newly added `DomainEventsAnalytics` class to verify intended functionality
2023-06-07 09:00:49 -04:00
Aileen Booker
2c4d9e2776
First pass on adding domainevents to segment service
...
no issue
- In order to listen to `DomainEvents` for `MilestoneCreatedEvents` we need to add a `DomainEvents` listener and handler to the Segment analytics service.
- For better readability and to be more consistent with how code is currently written in Ghost, I refactored the service index file and split the two types of event listener into separate classes which is much cleaner and easier to test.
2023-06-07 09:00:49 -04:00
Peter Zimon
20eaff9e5c
Updated sticky footer component in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 13:06:26 +02:00
Sanne de Vries
6b444dabdc
Added max width to signup card form in split layout
...
Refs https://www.notion.so/ghost/Sign-up-card-feedback-doc-6b9aa746ed654a1a87b759dc5f5bb031?pvs=4#693bad1f085a430aa6da2a9659ac3f27
2023-06-07 13:00:18 +02:00
Fabien "egg" O'Carroll
7667d6d589
Removed coverage checks from regression tests
...
Regression tests are not written to ensure coverage of code, in fact they are
barely written at all anymore, instead we write unit and e2e tests. Because of
this the coverage is constantly dropping as the codebase grows. This causes
significant pain and suffering for developers and slows down development.
2023-06-07 12:46:39 +02:00
Peter Zimon
76704d05c6
Added global sticky footer component in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 11:53:51 +02:00
Kevin Ansfield
abc169329c
Added error logging to lexical snippet fix try/catch
...
no issue
- we had a `catch` with no error logging, it shouldn't be hit but it will be useful to know if it does fail
2023-06-07 09:56:18 +01:00
Peter Zimon
ef096d9c87
Cleaned up classname properties in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 10:48:33 +02:00
Peter Zimon
f05b6a6037
Added unstyled property to image uploads AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 10:29:03 +02:00
Peter Zimon
9faf2cafbe
Got rid of modal
folders in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 09:53:20 +02:00
Peter Zimon
a3cba13381
Broke down design settings in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 09:40:56 +02:00
Peter Zimon
d7e5661a35
Fixed preview modal size bug in AdminX
...
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 09:10:16 +02:00
Sodbileg Gansukh
dfd4ab0f0f
Fixed search input focus on iOS ( #16950 )
...
closes https://github.com/TryGhost/Ghost/issues/16825
- iOS is very restrictive on input focus which doesn't allow without any
user interaction
- The only workaround was creating a temporary input, focus it, and
remove it after moving the focus to the actual searfch input
- It also moves the inputRef to the parent component, so that it can be
used in the click event handler, because the focus event only works when
it's inside a function that's triggered after user interaction
2023-06-07 15:01:28 +08:00
Duberly, Guarnizo Fuentes Rivera
28bef37d02
Updated Spanish translations ( #16940 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-07 08:57:30 +02:00
EchoBilisim
095a262b14
Updated Turkish translations ( #16937 )
...
refs https://github.com/TryGhost/Team/issues/2795
2023-06-07 08:52:20 +02:00
Daniel Lockyer
5d7d56198c
Released Portal v2.33.1
2023-06-07 08:38:25 +02:00
Daniel Lockyer
5f860c6e31
Fixed encoded characters appearing for Offers in Portal
...
fixes https://github.com/TryGhost/Team/issues/3392
- the "price" here can contain a slash, which is encoded/escaped by default by
i18next
- this disables the escaping to fix the text that is shown to the user
2023-06-07 08:35:40 +02:00
Rishabh
71e5d708d4
Reverted "Disabled image editor setting check"
...
This reverts commit 9d9e296148
.
This commit was a temporary fix to load the image editor if the setting was disabled.
2023-06-07 02:10:02 +05:30
Ghost CI
80ed948bb9
Merged v5.50.2 into main
2023-06-06 19:05:20 +00:00
Ghost CI
924d73e02e
v5.50.2
2023-06-06 19:05:19 +00:00
Rishabh
9d9e296148
Disabled image editor setting check
...
refs https://github.com/TryGhost/Team/issues/3034
Temporarily disables image editor setting check to allow it load by default
2023-06-06 23:59:43 +05:30
Rishabh
6806b88139
Fixed pintura link in image editor integration
...
refs https://github.com/TryGhost/Team/issues/3034
2023-06-06 23:35:56 +05:30
Steve Larson
75458cd7be
Added koenig lexical version to feedback submission
...
refs TryGhost/Team#3381
2023-06-06 12:55:51 -05:00
Naz
fab5b1845c
Made builtin collections un-deletable
...
closes https://github.com/TryGhost/Team/issues/3376
- It should not be possible to delete a built-in collection.
2023-06-06 22:04:16 +07:00
Ghost CI
c8b713a679
Merged v5.50.1 into main
2023-06-06 14:40:58 +00:00
Ghost CI
6a07d63f38
v5.50.1
2023-06-06 14:40:57 +00:00
Kevin Ansfield
076c2be9aa
🐛 Fixed copy/paste of HR cards between editor and beta editor
...
no issue
- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
2023-06-06 15:20:35 +01:00