Commit Graph

4414 Commits

Author SHA1 Message Date
Kevin Ansfield
46662e590f Fixed error thrown by editor caption input when pressing Escape 2018-12-13 15:22:47 +00:00
Kevin Ansfield
165b2efac9 Added auto-scroll when dragging gallery images (#1083)
no issue

Adds auto-scroll if the mouse is placed near the top or bottom of the window whilst dragging an image to re-order it within a gallery. Useful when the position you want to drag to is not currently on screen.

- append drop indicator element to `.koenig-editor` element to account for scrolling (also fixes indicator positioning bug with current implementation if you use mouse-wheel or keyboard to scroll the page whilst dragging)
- generalise `getParent` util to accept a 
  - switch to using selectors rather than dataset for finding parent draggable/droppable/container
- add a `ScrollHandler` class that is used by the `koenigDragDropHandler` service to trigger scrolling whilst dragging
2018-12-13 12:17:43 +00:00
kirrg001
5874a4d041 Version bump to 2.8.0 2018-12-11 14:25:52 +01:00
Kevin Ansfield
00ee6ebedd Fixed drag-n-drop reorder of gallery images not responding to drops
no issue
- https://github.com/TryGhost/Ghost-Admin/pull/1081 introduced a bug where the `insertIndex` was being cleared every time we showed the drop position indicator because we hide the indicator as a reset every time we show the indicator. This meant every drop was missing the required insertIndex.
- added a flag to the `_hideDropIndicator` function so that a reset when showing the indicator doesn't clear the required information
2018-12-11 13:20:05 +00:00
Kevin Ansfield
f743697450 Fixed overlay overflow on left-most images in gallery card
no issue
- margin was applied to the wrong edge
2018-12-11 13:01:22 +00:00
Kevin Ansfield
9ed6ea0f1e Fixed gallery image changing order randomly when dropped on itself (#1081)
no issue
- clear the cached `insertIndex` when hiding the drop position indicator
- update the gallery card's `_isDropAllowed` function to return `false` if the `droppabeIndex` (`insertIndex`) doesn't exist
2018-12-11 12:13:51 +00:00
Kevin Ansfield
a565abf5bb Fixed drop indicator not showing if placed directly between images (#1082)
no issue
- when dragging an image, if you dragged out of the gallery then back in directly over the space between images then no indicator was shown
- switch to using padding around images rather than margin so that the mouse can be detected over the gap. Added classes to the image overlays to account for the change in sizing
2018-12-11 12:13:15 +00:00
Kevin Ansfield
5647459a2b Added drag-n-drop re-ordering of images within gallery cards (#1073)
no issue
- first pass at implementation of drag-and-drop re-ordering of images within a gallery
- adds a `koenig-drag-drop-handler` service that allows consumers (editor and cards) to hook into drag and drop behaviour without interfering with each other and allows for future possibilities such as dragging images between galleries or into/out of galleries
2018-12-11 10:05:59 +00:00
Kevin Ansfield
1946c7f3fa 🐛 Fixed ability to submit invite form with a missing role (#1080)
refs https://github.com/TryGhost/Ghost/issues/10071
- moved roles fetch request into an ember-concurrency task
- use the task's derived state to disable the submit button whilst fetching
- added role presence check to the invite user validator and updated template to display the error
2018-12-10 14:26:05 +00:00
Kevin Ansfield
48854e4812 Bumped editor undo states to 100 2018-12-06 10:08:49 +00:00
John O'Nolan
6fbe4f42d6 More specific docs link
No issue

Nothing wrong with the docs link but in this context makes more sense to deep link to the info specifically about Ghost Handlebars themes
2018-12-06 15:44:21 +07:00
Kevin Ansfield
2639ff62e6 Optimised gallery image upload previews (#1079)
no issue
- use `URL.createObjectURL(file)` to get a blob url rather than using `FileReader.readAsDataURL` which generates a very large data attribute
- speeds up the display of previews and associated browser hangs when an upload finishes, especially noticeable with large images and fast connections where multiple uploads finish around the same time
2018-12-05 20:16:03 +00:00
Fabien O'Carroll
b3b5290a3c Version bump to 2.7.1 2018-12-05 14:28:11 +07:00
John O'Nolan
314ac7c5ac Fix broken docs link
Refs https://github.com/TryGhost/Ghost-Admin/pull/1078
2018-12-05 14:01:25 +07:00
Fabien O'Carroll
d6abc64b9a Version bump to 2.7.0 2018-12-04 21:10:16 +07:00
John O'Nolan
4ab05b5403 I was never here 2018-12-04 21:04:33 +07:00
John O'Nolan
5fde7ea168 SVG fix 2018-12-04 21:02:58 +07:00
John O'Nolan
e36f8ca0c1 Added new theme directory links to Ghost Admin (#1078)
* Add new theme directory links to Ghost Admin

* Dark mode fixes
2018-12-04 18:04:52 +07:00
Sumedh Nimkarde
83aeea7892 🐛 Fixed the link for Markdown guide documentation. (#1076) 2018-12-03 17:40:07 +07:00
Rish
32e04516ce Version bump to 2.6.2 2018-11-27 18:33:56 +05:30
Antonio
d1427c8ba3 Fixed post excerpt fallback in Stories list (#1052)
closes https://github.com/TryGhost/Ghost/issues/9775
- update the `subText` CP to prioritise the custom excerpt over meta description and plain text content
2018-11-26 14:32:49 +00:00
Peter Zimon
8ae47cd0e5 UI refinements (#1075)
no issue
* Update negative margin of card indicators
* Update to Spirit 0.0.49
2018-11-26 14:25:47 +00:00
Ben Jenkinson
238f261ccf Added "Recently updated" sorting option to Stories screen (#1023)
no issue
2018-11-26 12:26:45 +00:00
Peter Zimon
f94f7d52d9 Updating to Spirit 0.0.48 (#1074)
refs. https://github.com/TryGhost/Team/issues/148
- fix vertical rhythm for divs and headings
2018-11-26 10:34:16 +00:00
Rishabh Garg
f3ea465435 Added image validation error message to gallery card (#1048)
closes https://github.com/TryGhost/Ghost/issues/9840
- added error on uploading an invalid image format
  - updated to use overall error method(`onFailed`) to set error message instead of individual upload failures(`onUploadFailure`)
2018-11-26 10:31:02 +00:00
Sumedh Nimkarde
276f9a9c80 Removed outdated Ghost-Desktop client check (#1047)
closes https://github.com/TryGhost/Ghost/issues/9895
2018-11-26 08:28:48 +00:00
Kevin Ansfield
dd8fec7c1f Bump @tryghost/mobiledoc-kit version
no issue
- includes bug fix and improvements to copy/paste from rich-text sources
2018-11-22 10:39:20 +00:00
Nazar Gargol
02633a4b1f Version bump to 2.6.1 2018-11-20 18:21:48 +01:00
Kevin Ansfield
1e1fcb0747 Bump @tryghost/mobiledoc-kit version
no issue
- brings us in-line with upstream mobiledoc-kit master
2018-11-20 11:59:19 +00:00
Zimo
3a26ba018e Fixing negative margins of Koenig embeds 2018-11-20 11:12:15 +01:00
Kevin Ansfield
23ab934db4 Version bump to 2.6.0 2018-11-13 12:51:06 +00:00
John O'Nolan
c287c2b016 Fixed display bug on integration icons (#1071)
no issue
- Resolves error with integration background icon images being tiled
2018-11-13 11:42:44 +00:00
Kevin Ansfield
065182c586 Fixed sticky validation errors when editing webhooks
refs https://github.com/TryGhost/Ghost/issues/10137
- when closing the edit webhook modal we were rolling back the changed attributes of the webhook model but not clearing the errors object which meant a validation error was shown when re-opening the edit webhook modal
- add `reset()` method to the webhook edit controller and call that when leaving the edit route instead of only rolling back the changed attributes
2018-11-13 11:40:24 +00:00
Kevin Ansfield
89440a30be Fixed linting 2018-11-13 09:56:59 +00:00
John O'Nolan
59ce575e69 Highlight new integrations directory (#1070)
no issue
- we have a new integrations directory in our docs so we’ve highlighted the most common directly on the integrations screen
2018-11-13 09:18:31 +00:00
Kevin Ansfield
ef551b6061 Improve handling of non-validation errors in webhook modal
no issue
- display the error message of any API-provided error
2018-11-12 21:27:42 +00:00
Kevin Ansfield
c33edbac08 Fixed webhook modal title showing "New webhook" when editing a webhook
refs https://github.com/TryGhost/Ghost/issues/10137
- adjust modal title depending on `webhook.isNew` state
- add acceptance tests for modal creation
- add missing mirage webhook factory
- mock integrations/api-keys/webhooks in test env rather than development
2018-11-12 16:31:47 +00:00
Rishabh Garg
032fba8f7b Added active navigation state for all integrations related routes (#1069)
closes https://github.com/TryGhost/Ghost/issues/10136
- use a CP and `{{#link-to current-when}}` to add the `.active` class any time the current route name starts with `settings.integration` which covers built-in and custom integration screens
2018-11-12 13:10:33 +00:00
Kevin Ansfield
e802b06b77 Fixed error in stories list if plaintext is not a string
no issue
- `gh-posts-list-item`'s excerpt CP attempts to use `.slice` on whichever value is given to it, if it's `null` or `undefined` (as is the case when using mirage) then it would error with ".slice is not a function"
2018-11-08 14:02:01 +00:00
Kevin Ansfield
9abadd57c4 Automatically update count.posts when serialising tags in mirage
no issue
- add a new mirage serialiser for tags that updates the count.posts for each tag that gets serialised
- better matches real API behaviour
2018-11-08 13:49:00 +00:00
Kevin Ansfield
ae0cb45d8c Fixed saving of posts with tags using mirage
no issue
- similar to the previous fix for authors, tags also need to be converted from POJOs to mirage Model objects when creating/saving records in the mirage route handlers
- refactored the code so that the POJO->Model transform can be shared across post and update requests
2018-11-08 13:43:58 +00:00
Kevin Ansfield
f015eeb430 Fixed mirage not respecting ?limit=all queries
no issue
- the `paginatedResponse` helper util tries to convert strings to integers but had no logic for handling `'all'` so it would always default to 15 in that case
2018-11-07 17:07:55 +00:00
kirrg001
731d2a9a2e Version bump to 2.5.0 2018-11-07 16:19:43 +01:00
Kevin Ansfield
d88e7efd04 🎨 Changed tags list, filter dropdown, and select input to sort alphabetically (#1066)
no issue
- switch tags sorting from ID based to alphabetical
- pre-requisite to nested tags sorting
2018-11-07 15:06:28 +00:00
Kevin Ansfield
0d08c639fe 🐛 Fixed editor undo states for card contents (#1064)
refs https://github.com/TryGhost/Ghost/issues/10049
- update `{{koenig-card}}` component to compare payload values and create a snapshot when exiting edit mode for container cards (markdown, html, code)
- update image card to trigger snapshots on image upload/selection and width change
2018-11-06 14:43:19 +00:00
Kevin Ansfield
ac17053863 Added custom integrations - Content API Keys and "Site rebuild" webhooks (#1063)
closes TryGhost/Ghost#9942
- move custom integrations UI out from behind the developer experiments flag
- put Admin API key and web hook secret fields behind the developer experiments flag
- do not show "unsaved changes" modal when adding/editing a webhook
- fixed all webhooks showing for each custom integration
2018-11-06 10:59:47 +00:00
Fabien O'Carroll
7308fcba79 Version bump to 2.4.0 2018-10-30 19:26:40 +07:00
Rishabh Garg
bd0fb88a52 Fixed sanitization of user invited emails for notification message (#1060)
no issue

- Escaped email ids string sent to notification message during blog setup

Credits: Antony Garand
2018-10-29 12:19:46 +00:00
Peter Zimon
3f7a036905 Integration UI refinements (#1059)
no issue
* Integration detail page design refinements
* Fixing error message layout on integration detail screen
* Heading details
* Margin refinements
* Refine webhooks modal
* Lines and font sizes
* Replace integrations icon
2018-10-24 14:04:17 +01:00
Kevin Ansfield
e7a8be81ef Cleaned up class and :contains based test selectors
no issue
- nav menu had many unused CSS classes that were sometimes used for test selectors
- `:contains` is not a native CSS selector so will cause issues when we switch to native test helpers
2018-10-23 18:11:48 +01:00