Commit Graph

4414 Commits

Author SHA1 Message Date
Kevin Ansfield
98ab4d1d20 Fixed missing margin on subscribers action buttons 2019-03-15 16:27:52 +00:00
Kevin Ansfield
c19f5b9c51 🐛 Fixed unnecessary "Are you sure you want to leave?" modals
no issue
- if a post was saved before the body content was edited you would get stuck with an "Are you sure you want to leave?" modal even though you had already saved
- the editor saw the post as being in a dirty state because the `mobiledoc` and `scratch` value were null but after saving the `mobiledoc` value was set to an blank mobiledoc object as returned by the API
- updated the `post` model save method to reset the `scratch` value if the returned `mobiledoc` no longer matches
2019-03-15 16:18:53 +00:00
Kevin Ansfield
855fd7ae80 🐛 Fixed difficult to cancel webhook modal
closes https://github.com/TryGhost/Ghost/issues/10135
- `focusOut` events are fired before the `click` event is fired when clicking buttons whilst an input has focus, this has the effect of triggering our on-blur validations that can cause UI to jump which then results in the `mouseUp` being outside of the button which means no `click` event is fired
- stops `mouseDown` event from bubbling from modal cancel/close buttons so that `focusOut` validations aren't triggered
2019-03-15 14:38:54 +00:00
Kevin Ansfield
c2a0224543 Removed reliance on run.later in gh-task-button tests
refs https://github.com/TryGhost/Ghost/issues/10308
- switch to using the `waitFor` helper to wait for changes in DOM rather than relying on unreliable timeouts
2019-03-14 17:26:22 +00:00
Kevin Ansfield
d3ac2ee2bc Update Renovate Configuration (#1119)
no issue
- switch scheduling to early monday mornings
2019-03-14 11:33:36 +00:00
kirrg001
eb30a861fd Version bump to 2.18.1 2019-03-13 23:43:48 +01:00
Fabien O'Carroll
13c9631441 Version bump to 2.18.0 2019-03-13 22:06:18 +01:00
renovate[bot]
8efa86f37a Update dependency ember-fetch to v6.5.0 (#1117) 2019-03-13 17:51:45 +00:00
renovate[bot]
491459bda3 Update dependency codemirror to v5.44.0 (#1116) 2019-03-13 17:51:28 +00:00
Kevin Ansfield
9104b73aff Fixed ember resolver warning for ambiguous authorNames access
no issue
- we've added an `{{author-names}}` helper, this generated a warning from `{{gh-posts-list-item}}` which contained `{{authorNames}}` referencing a CP on the component context
- changing the CP access to be explicit using `{{this.authorNames}}` resolves the warning
- updated other references in the template to be explicit in order to differentiate between local context and helpers (this will be enforced in later Ember versions)
2019-03-13 16:16:08 +00:00
Renovate Bot
e3954710d0 Update ember addons 2019-03-13 15:53:24 +00:00
renovate[bot]
a4a3ac7e7f Pin dependency element-resize-detector to 1.1.15 (#1114) 2019-03-13 14:13:22 +00:00
renovate[bot]
aa365f5d8a Configured Renovate (#1111)
no issue
- Add renovate.json
2019-03-13 14:10:28 +00:00
Nazar Gargol
a092659594 Version bump to 2.17.2 2019-03-13 18:52:43 +08:00
Kevin Ansfield
60e9667177 Version bump to 2.17.1 2019-03-12 18:45:54 +00:00
Kevin Ansfield
75245f0d3d Improved duplication checking in notifications service
closes https://github.com/TryGhost/Ghost/issues/10514
- deduplicates alerts based on message content as well as key
2019-03-12 17:50:45 +00:00
Kevin Ansfield
fc6574f0ed Updated editor error handler to work better with new API error messages
no issue
- pass a received API error directly through to the notifications service rather than adding an unnecessary prefix to the error message
2019-03-12 17:49:15 +00:00
Nazar Gargol
9dc093939f Version bump to 2.17.0 2019-03-12 20:39:30 +08:00
Kevin Ansfield
59d7651ef0 🐛 Fixed author names not appearing in Facebook open-graph preview
no issue
- added an `{{author-names}}` helper that takes an array of author-like objects and returns their names separated by a comma
2019-03-12 12:15:02 +00:00
Kevin Ansfield
c28d024fec Fixed error when opening meta/facebook/twitter settings with a new post
no issue
- `post.scratch` does not exist until post contents have been edited which meant that the `seoDescription` CP was erroring trying to access a non-existent `cards` property
2019-03-12 12:15:02 +00:00
Kevin Ansfield
612cbc034f Switched Travis dist to xenial (#1113)
no issue
- matches Ghost's Travis env
- removes custom yarn install
2019-03-12 11:45:51 +00:00
Kevin Ansfield
8ba1c8fb79 Added ability to override the canonical URL of posts/pages
closes https://github.com/TryGhost/Ghost/issues/10593
- adds a "Canonical URL" field to the Meta Data section of the Post Settings Menu
- adds validation for canonical url being a valid absolute or relative URL
2019-03-12 10:40:07 +00:00
Hannah Wolfe
e70dc87626 Update .travis.yml - fix notifications 2019-03-11 21:53:36 +00:00
Kevin Ansfield
30d009ea84 Used ember-exam to split tests and run in parallel on Travis (#1112)
no issue
- improves test run times by splitting the tests into multiple groups and running each in their own browser instance
  - settled on 2 browser instances as that seems to best fit within Travis' memory and CPU constraints
- updated ember-cli-code-coverage config to work with parallel builds
2019-03-11 18:16:01 +00:00
Kevin Ansfield
1c7ce2a0b0 Switched to using built-in Slack notifications for Travis build failure/success 2019-03-11 16:38:38 +00:00
Kevin Ansfield
67815a3c99 Revert "[TEMP] Broke linting"
This reverts commit 8451151596.
2019-03-11 16:26:36 +00:00
Kevin Ansfield
8451151596 [TEMP] Broke linting
no issue
- used for checking nightly Travis build output and early exit on linting failure
2019-03-11 16:16:27 +00:00
Kevin Ansfield
6fb7ebf7a5 Added Slack ping for failed nightly Travis regression test builds
no issue
- added `after_failure` task to post to Slack if the nightly cron build fails
- removed unused GITHUB_OAUTH_KEY env var
2019-03-11 16:14:28 +00:00
Kevin Ansfield
02f73bc44e Fixed Travis to exit early on lint failures and skip duplicate linting in ember tests
no issue
- Travis runs all `script` tasks even if an earlier one fails so moved to using `&&` so ember tests aren't run if linting errors
- Added `ember-cli-eslint` to the addons blacklist when building in Travis so that we aren't running linting twice (also reduces build log output)
2019-03-11 15:45:26 +00:00
Kevin Ansfield
a0e9422699 Disabled FF on Travis outside of cron builds
no issue
- keeps test builds quicker, saving FF tests for nightly regression builds run via cron
2019-03-11 15:31:23 +00:00
Kevin Ansfield
68a98d8e95 Fixed global env variables in Travis config
no issue
- top-level env entries result in a separate build for each env so they need to be listed under the `global` key
2019-03-11 15:14:15 +00:00
Kevin Ansfield
46d3cc9901 Updated Travis config to use Firefox in headless mode 2019-03-11 15:02:32 +00:00
Kevin Ansfield
bad3844ba9 Updated Travis config
no issue
- switched to node 10 to match recommended developer version
- changed `greenkeeper` branch exclusion to `renovate`
- removed the custom cache directories
  - the cache build/upload was timing out after 180s
  - simplifying the config to try and narrow down the exact cause and measure impact
2019-03-11 14:27:55 +00:00
Kevin Ansfield
693c6ba12a Bumped ember-cli-babel version in koenig-editor in-repo addon 2019-03-11 10:19:27 +00:00
Kevin Ansfield
8af0139316 Fixed linting 2019-03-11 10:13:56 +00:00
Rish
4a9ad42478 Fixed member tests
no issue

- Fixes test for members option in sidebar to use value from settings
2019-03-11 13:13:55 +05:30
Zimo
d120440c96 Updated animation of copy buttons in integration
no refs.
"Copy" buttons in the integration detail screen are shown only on hover. Removed animation to make it snappeir.
2019-03-08 09:47:59 +01:00
Kevin Ansfield
856c4000c8 Fixed 500 errors when accessing editor routes without post/page
no issue
2019-03-07 17:31:03 +00:00
Kevin Ansfield
8514372dad Bumped ember core dependencies to 3.8.x
no issue
- bumped ember core reps
- bumped ember-ajax for ember 3.8.0 compatibility
- removed deprecated use of `transition.handlerInfos`
2019-03-07 17:24:35 +00:00
Kevin Ansfield
5696644e2d Bumped ember core dependencies to 3.7.x
no issue
2019-03-07 16:25:43 +00:00
Zimo
134468983f Added random image card placeholder illustrations
no refs.
- three random illustrations loop as image placeholder illustrations
- increased padding of clickable area for better happy-go-clicky
2019-03-07 15:40:08 +01:00
Kevin Ansfield
047f5695b4 🐛 Fixed vague upload error messages on General and Labs setting screens
no issue
- API now returns the "useful" error message in `error.context` rather than `error.message`
- updated `{{gh-uploader}}` to expose `context` on errors
- updated error display to try using `context` with a fallback to `message`
2019-03-07 13:40:38 +00:00
John O'Nolan
01559cf447 Blog => Site 2019-03-07 15:31:15 +02:00
Zimo
99481261b5 Updated image card placeholder illustration
no refs.
2019-03-07 12:44:33 +01:00
Zimo
552449c0a2 Fixing target area of X on tags selector
no refs.
2019-03-07 11:30:49 +01:00
Vikas Potluri
170973eb67 Fixed post/page wording in Page PSM and delete modal (#1109)
closes https://github.com/TryGhost/Ghost/issues/10577
2019-03-07 09:13:31 +00:00
Kevin Ansfield
aed4bed6f3 Removed unused forceI18n attribute from the settings model 2019-03-07 09:10:46 +00:00
Kevin Ansfield
a0dacf5231 Bumped ember core dependencies to 3.6.x 2019-03-06 17:15:44 +00:00
Kevin Ansfield
db7c40b327 Disabled mirage in development
- features that were using mirage are out of the mocking stage so the extra step and logging of each request is just noise
2019-03-06 16:49:53 +00:00
Kevin Ansfield
352c4af1d7 Refactored usage of .get('property') with es5 getters
no issue
- ran [es5-getter-ember-codemod](https://github.com/rondale-sc/es5-getter-ember-codemod)
- [es5 getters RFC](https://github.com/emberjs/rfcs/blob/master/text/0281-es5-getters.md)
- updates the majority of `object.get('property')` with `object.property` with exceptions:
  - `.get('nested.property')` - it's not possible to determine if this is relying on "safe" path chaining for when `nested` doesn't exist
  - `.get('config.x')` and `.get('settings.x')` - both our `config` and `settings` services are proxy objects which do not support es5 getters
- this PR is not exhaustive, there are still a number of places where `.get('service.foo')` and similar could be replaced but it gets us a long way there in a quick and automated fashion
2019-03-06 13:54:14 +00:00